- 29 Apr, 2015 40 commits
-
-
maxbogue authored
This change adds a test class for SyncCustomizationFragment. Common code between this new class and SyncTest has been split out into SyncTestBase. Everything else in this CL is fixing various bugs that popped up when I tried to run the test. BUG=480604 Review URL: https://codereview.chromium.org/1060373004 Cr-Commit-Position: refs/heads/master@{#327510}
-
rdevlin.cronin authored
The current Error Console UI is a little lacking. Most egregiously, there's no way to clear errors. Update the UI by moving more of the error console into its dedicated overlay, which - Minimizes its footprint on the main page. - Makes it easy to switch between errors easily. Additionally, add support for removing specific (or all) errors associated with extensions. Screenshots are up at https://drive.google.com/open?id=0BxjK6_MzZ8UPfndZcElPVGxxdWxXQmN3WkVtSFhNUkN3SlFVYVQtaGlpWTJaOU52YTRfOGs&authuser=0 (Internal only for now; will post externally soon) BUG=482526 Review URL: https://codereview.chromium.org/1016413004 Cr-Commit-Position: refs/heads/master@{#327509}
-
scheib authored
Review URL: https://codereview.chromium.org/1111153002 Cr-Commit-Position: refs/heads/master@{#327508}
-
charliea authored
BUG=478827 Review URL: https://codereview.chromium.org/1108823006 Cr-Commit-Position: refs/heads/master@{#327507}
-
payal.pandey authored
Bescause base/strings/string_split.h defines: typedef std::vector<std::pair<std::string, std::string> > StringPairs; BUG=412250 Review URL: https://codereview.chromium.org/1109353002 Cr-Commit-Position: refs/heads/master@{#327506}
-
glider authored
TBR=danakj@chromium.org BUG=None Review URL: https://codereview.chromium.org/1115693002 Cr-Commit-Position: refs/heads/master@{#327505}
-
dgn authored
The new check warns for new log usages that don't use base.Log The documentation is added in-tree as a markdown file BUG=472152 Review URL: https://codereview.chromium.org/1114593002 Cr-Commit-Position: refs/heads/master@{#327504}
-
bnc authored
Remove HttpNetworkSession::Params::spdy_max_concurrent_streams_limit, SpdySessionPool::max_concurrent_streams_limit_, and SpdySession::max_concurrent_streams_limit_ members. Note that SETTINGS_MAX_CONCURRENT_STREAMS is still limited by kMaxConcurrentStreamLimit, currently 256. BUG=481005 Review URL: https://codereview.chromium.org/1112093002 Cr-Commit-Position: refs/heads/master@{#327503}
-
jbudorick authored
BUG=481960 Review URL: https://codereview.chromium.org/1108053005 Cr-Commit-Position: refs/heads/master@{#327502}
-
jbudorick authored
BUG=267773,482367,482406 Review URL: https://codereview.chromium.org/1112843002 Cr-Commit-Position: refs/heads/master@{#327501}
-
dtapuska authored
Store the gaia logout url request so the URLFetcher object isn't leaked. BUG=482459 TEST=google_api_unittests Review URL: https://codereview.chromium.org/1108053003 Cr-Commit-Position: refs/heads/master@{#327500}
-
dalecurtis authored
We did not end up using this code for video frame rendering. BUG=none TEST=compiles, existing tests pass. Review URL: https://codereview.chromium.org/1111993002 Cr-Commit-Position: refs/heads/master@{#327499}
-
mlerman authored
BUG=481721 Review URL: https://codereview.chromium.org/1106213003 Cr-Commit-Position: refs/heads/master@{#327498}
-
glevin authored
BUG=465607 Sets up logged in user and cellular network for testing, verifies that the Data Saver prompt notification is shown once cellular becomes the connected, default network. Review URL: https://codereview.chromium.org/1108123003 Cr-Commit-Position: refs/heads/master@{#327497}
-
skyostil authored
This makes it possible to later migrate base/ from MessageLoopProxy over to ThreadTaskRunnerHandle, which requires an active task runner on the current thread. TBR=msw@chromium.org BUG=465354 Review URL: https://codereview.chromium.org/1114993002 Cr-Commit-Position: refs/heads/master@{#327496}
-
msarda authored
This CL adds observers Bluetooth device changed and device removed notifications. Each time a device changes, it checks if the device advertises the Smart Lock service UUID. If so and if there is no pending connection to that device, then it tries to connect to it. This CL also forgets the Bluetooth device that advertises Smart Lock. This ensures that the device is disconnected and its entry removed fron the Bluetooth device controller. Note that this strategy is fine as Bluetooth Low Energy device that advertises Smart Lock service UUID is only used by the Proximity Auth component. TEST=On Chrome OS, turn on Smart Lock over Bluetooth Low Energy in settings. Install a Smart Lock app on a BLE device. On Chrome OS, sign in and then lock the screen. Start the Smart Lock app on a BLE device and observe that Chrome OS magically unlocks. BUG=479670 Review URL: https://codereview.chromium.org/1113793002 Cr-Commit-Position: refs/heads/master@{#327495}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/ecb8e3e..385e88c CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=humper@google.com Review URL: https://codereview.chromium.org/1117693002 Cr-Commit-Position: refs/heads/master@{#327494}
-
pdr authored
This patch adds a smoothness benchmark with slimming paint. BUG=464910 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect; Review URL: https://codereview.chromium.org/1114713002 Cr-Commit-Position: refs/heads/master@{#327493}
-
reveman authored
Leave it up to the implementation of this interface to determine if assignment and copy should be disallowed. BUG= Review URL: https://codereview.chromium.org/1107403003 Cr-Commit-Position: refs/heads/master@{#327492}
-
dpranke authored
Roll GN 326666:327383 This includes the following fixes: - "gn help grammar" is included in "gn help all" - phony rules for executables will be correctly generated (previously we would not generate a rule for the unit_tests executable because there were other targets with the 'unit_tests' name) - paths can be resolved in the GN args file R=brettw@chromium.org BUG= Review URL: https://codereview.chromium.org/1111953004 Cr-Commit-Position: refs/heads/master@{#327491}
-
glevin authored
BUG=475194 Collects UMA stats for (i) how many times the Data Saver prompt (notification) is shown, and (ii) how many times the Data Saver prompt is clicked on. Review URL: https://codereview.chromium.org/1106173003 Cr-Commit-Position: refs/heads/master@{#327490}
-
clamy authored
This CL creates a NavigateInternal method in RenderFrameImpl that is used both by OnCommitNavigation and OnNavigate, which creates a unified codepath for navigations in RenderFrameImpl. BUG=376091 Review URL: https://codereview.chromium.org/1112513002 Cr-Commit-Position: refs/heads/master@{#327489}
-
rsorokin authored
BUG=479091 Review URL: https://codereview.chromium.org/1113553002 Cr-Commit-Position: refs/heads/master@{#327488}
-
rahul.g authored
Make GPU bug workaround to disable using GL_RGB format on Mali-400 This CL manages offscreen framebuffer creation based on GL_RGBA format and ignoring GL_RGB format because it is not supported on Mali-400 GPU. BUG=449150 Review URL: https://codereview.chromium.org/996163003 Cr-Commit-Position: refs/heads/master@{#327487}
-
tfarina authored
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/631/steps/compile/logs/stdio This fixes the following kind or warnings: warning(clang): [chromium-style] Complex constructor has an inlined body. warning(clang): [chromium-style] Complex destructor has an inline body. After this, "Complex constructor" warnings will be gone, assuming more does not crap in. BUG=467287 R=thakis@chromium.org,toyoshim@chromium.org Review URL: https://codereview.chromium.org/1117603002 Cr-Commit-Position: refs/heads/master@{#327486}
-
wnwen authored
BUG=481965 Review URL: https://codereview.chromium.org/1116433003 Cr-Commit-Position: refs/heads/master@{#327485}
-
noel authored
Roll in r295003: "Fix libjpeg_turbo svn r64 libjpeg6b compat issue" from https://codereview.appspot.com/229430043/ TBR=fdegans@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel BUG=398235 Review URL: https://codereview.chromium.org/1110113002 Cr-Commit-Position: refs/heads/master@{#327484}
-
anujk.sharma authored
BUG=466848 Review URL: https://codereview.chromium.org/1115583002 Cr-Commit-Position: refs/heads/master@{#327483}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#327482}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/280a9c8..ecb8e3e CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=humper@google.com Review URL: https://codereview.chromium.org/1112833002 Cr-Commit-Position: refs/heads/master@{#327481}
-
petrcermak authored
This patch pulls in recent UI fixes and changes for memory-infra. Summary of changes available at: https://chromium.googlesource.com/external/trace-viewer/+log/eea44df..e2b5374 e2b5374 Handle rows with undefined values in memory dump panes properly 3d85362 Change the main allocator metric from inner_size to outer_size 8b89552 Show generic attributes in memory dump UI df1e6c7 generic_object_view table 1eff1ad Fix table builder column setter 210d769 Add support for string attributes in memory allocator dumps 86ab68f Adjust CSS to center 'Monitoring' label 2ce2802 Fix memory dump event timestamps db25ed4 Handle allocators with undefined values in memory dump panes c39a009 Add precise finding code for slices that obeys nesting rules Size increase for resources.pak: 3566 bytes (16958824 -> 16962390) BUG=458295 Review URL: https://codereview.chromium.org/1117643002 Cr-Commit-Position: refs/heads/master@{#327480}
-
pranay.kumar authored
MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Review URL: https://codereview.chromium.org/1117583003 Cr-Commit-Position: refs/heads/master@{#327479}
-
kjellander authored
Reason: the GYP includes in src/third_party/junit/junit.gyp quickly goes into Android-only terroritory so reusing the target on non-Android would require a lot more work. This reverts the DEPS change in commit 0cb25491. The checklicenses.py change is left in, since it makes sense to have it even if the code is only checked out for Android. BUG=webrtc:4499 TBR=jbudorick@chromium.org, phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/1115643002 Cr-Commit-Position: refs/heads/master@{#327478}
-
anujk.sharma authored
BUG=466848 Review URL: https://codereview.chromium.org/1102353003 Cr-Commit-Position: refs/heads/master@{#327477}
-
vishal.b authored
The FrameTreeNode class has a browser-side and globally unique id. we need id with less bits, for example in extension APIs code exporting those ids to JavaScript. BUG=477770 TBR=sky Review URL: https://codereview.chromium.org/1093923003 Cr-Commit-Position: refs/heads/master@{#327476}
-
kwiberg authored
Review URL: https://codereview.chromium.org/1091353004 Cr-Commit-Position: refs/heads/master@{#327475}
-
tapted authored
Currently when a window that is not main (e.g. the app list) completes a fade-out animation and closes, it will trigger a mainMenu update. We need to ensure the mainMenu says "Chrome" when the last window on the active space is closed. But if that didn't have main status, it won't have been influencing the mainMenu to begin with and also won't trigger a later NSWindowDidBecomeMainNotification. This regressed in r323157, but the bug was always present. It was previously avoided because updates were skipped by anticipating whether AppKit would make a subsequent window main. But that's hard to get right and conflicts with behaviour used when closing panel windows. BUG=481803 TEST=On Mac, open a packaged app window with the app launcher. When launched for the first time, the menubar should say the apps name, rather than "Chrome". Review URL: https://codereview.chromium.org/1114803002 Cr-Commit-Position: refs/heads/master@{#327474}
-
lizeb authored
Prefetching the native library by reading its pages speeds up startup on Android (see the linked bug). When loading the native library from the APK, there is no file to associate with the native library. The most reliable way to prefetch the native library pages is then to look at the pages mapped in the process address space after the native library has been loaded. To minimize disruption, the prefetch is done in a separate forked process. This patch implements the parsing of the address space mappings and the reading of pages from a forked process. Most of the work is done before the fork() to avoid potential nasty issues associated with doing work in a forked process in presence of threads. BUG=460438 Review URL: https://codereview.chromium.org/1001343002 Cr-Commit-Position: refs/heads/master@{#327473}
-
sacomoto authored
Missing return statement in https://codereview.chromium.org/1102093002/. BUG=479673 Review URL: https://codereview.chromium.org/1114843002 Cr-Commit-Position: refs/heads/master@{#327472}
-
lpromero authored
A MemoryWedge is a single chunk of memory allocated. One passes it a size and the wedge is added to the resident memory used by the current app. Furthermore, it adds an experimental flag for iOS based on a variation param, to drive the size of the wedge that could be inserted for a given run. BUG=TBD R=stuartmorgan,asvitkine Review URL: https://codereview.chromium.org/1107963002 Cr-Commit-Position: refs/heads/master@{#327471}
-