- 05 Mar, 2019 40 commits
-
-
Victor Vasiliev authored
Replace connection_id_length in QuicPacketHeader with connection_id_included Historically, QuicPacketHeader has included two fields: destination_connection_id_length and source_connection_id_length, because in older versions of gQUIC (that have since been deleted) there was a way to compress the connection ID by only sending a variable amount of bits. In all currently supported versions of QUIC, there are only two options in a given header: connection ID present and connection ID absent. Therefore this CL replaces these length fields with corresponding destination_connection_id_included and source_connection_id_included. This will allow us to support connection ID lengths that are not 8 in the future. Merge internal change: 236736901 https://chromium-review.googlesource.com/c/1504055/ Stop using AckBundling mode to send ack and replace ack_queued with scheduling ack_alarm to now. No functional change expected, protected by quic_reloadable_flag_quic_deprecate_ack_bundling_mode. With this change, ACKs will be sent in 3 cases: 1) Anytime there is data to send, bundle an ACK if ack_alarm is set. 2) If there is no data to send or packets get received after frames get queued, send an ACK only if ack_alarm expires now. 3) Send an ACK when ack_alarm goes off. Merge internal change: 236725546 https://chromium-review.googlesource.com/c/1504126/ Deprecate quic_keep_ack_decimation_reordering. Merge internal change: 236719336 https://chromium-review.googlesource.com/c/1504004/ Deprecate --quic_restart_flag_quic_check_blocked_writer_for_blockage Merge internal change: 236709014 https://chromium-review.googlesource.com/c/1504125/ Add tests for version negotiation to QuartcEndpointTest. Allows QuicVersionMangers to be injected into both client and server implementations of QuartcEndpoint, in order to control version support in tests. Adds two tests to QuartcEndpointTest for behaviors surrounding version negotiation: - One test actually performs version negotiation: the client picks a version that the server doesn't recognize and the server negotiates for an older one. - One test confirms that the server can accept connections on any supported version: the client picks an older version and starts that. Moves all the fakes from quartc_session_test into a shareable test-only library. Merge internal change: 236677680 https://chromium-review.googlesource.com/c/1504124/ In QUIC, fix connection close's encryption level. Protected by quic_reloadable_flag_quic_fix_termination_packets. Merge internal change: 236663907 https://chromium-review.googlesource.com/c/1504123/ Fix Quartc 0rtt test in chromium. More importantly, this fixes a lifetime issue that occurred in the simulator. Simulator assumes that once an actor is added, it is alive for the entire simulation. Destroying an actor (in this case the client endpoint) may cause runtime failures. (in this case, new object was allocated at the same address, which caused a DCHECK in simulator). Merge internal change: 236660882 https://chromium-review.googlesource.com/c/1504120/ Deprecate quic_reloadable_flag_quic_encryption_driven_header_type Merge internal change: 236650118 https://chromium-review.googlesource.com/c/1504118/ Deprecate gfe2_reloadable_flag_quic_always_reset_ietf_connections. Merge internal change: 236645139 https://chromium-review.googlesource.com/c/1504001/ R=rch@chromium.org Change-Id: I67c2e21e3f23108bb96c1fc1d861fbea5816dfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504233 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#637833}
-
Xiaocheng Hu authored
This reverts commit 6d77a353. Reason for reland: Max recursion depth is reduced to avoid stack overflow. Original change's description: > Revert "Fix caret rendering when at the end of a block after an ineditable inline" > > This reverts commit e9aa20fd. > > Reason for revert: this change breaks tests on win dbg bot > > This is the first failure > https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64%20%28dbg%29/6437 > > Test InsertListCommandTest.CleanupNodeSameAsDestinationNode is definitely fails because of this patch (I've verified it locally on Windows). > The problem with this test that it's very deep recursion in function between functions > AdjustBlockFlowPositionToInline > ComputeInlineAdjustedPositionAlgorithm > > and as a result stack overflow. > > > Original change's description: > > Fix caret rendering when at the end of a block after an ineditable inline > > > > AdjustBlockFlowPositionToInline() has an early-reject branch that avoids > > infinite recursion, introduced in crrev.com/664b6437. > > > > However, the early reject condition is too aggressive that, it also > > rejects some positions that don't enter an infinite recursion, like > > the one used in the new unit test added in this CL. > > > > As now AdjustBlockFlowPositionToInline() has a hard limit on recursion > > depth, this CL safely removes the over-aggressive reject condition, so > > that caret can be correctly rendered for more positions. > > > > Note: Unit test InlineBoxPositionTest.ComputeInlineBoxPositionMixedEditable > > uses another position that doesn't enter the infinite loop but is falsely > > rejected by the condition. This patch allows caret rendering also for that > > position, and therefore changes its test expectation. > > > > Bug: 936988 > > Change-Id: Idef91ffaa412e67cddd5fcf0dd61f54055de7189 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497466 > > Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> > > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#637311} > > TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org > > Change-Id: I6fcff118f27d633e627d5942671b04554fef283b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 936988 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503579 > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637676} TBR=yosin@chromium.org,yoichio@chromium.org,dvadym@chromium.org,xiaochengh@chromium.org Change-Id: Ic959d3d57558995a315269bb938b75307efb6ea8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 936988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504226 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#637832}
-
Matt Menke authored
Previously, socket pools could stack on top of each otherwise, with each socket in one pool owning a socket in the lower pool. When a lower layer pool had no available socket slots and a pending request, it would call into the next layer up and ask it to close a socket. Now that socket pools are no longer layered on top of each other, socket pools no longer have to have the logic to act as the higher layered pool. This leaves the code in place for socket pools to act as a lower layer pool, however. H2 connections can still sit on top of socket pools, and each session is treated as a higher layer "pool" when a socket pool is stalled at its global socket limit. Bug: 472729 Change-Id: I3bbec857166a46a86b07d9ecb96cc77022a7f5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496490Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#637831}
-
Xianzhu Wang authored
- Avoid two comparisons when updating an animatable paint property node - Avoid checking animation status in both PaintPropertyTreeBuilder and XXXPaintPropertyNode. This also makes the checking consistent. Previously we checked style.IsRunningXXXAnimationInCompositor() in PaintPropertyTreeBuilder and CompositingReason::kActiveXXXAnimation in XXXPaintPropertyNode which was incorrect because the latter also includes animations that are updated in the main thread (while we composite the layer to accelerate rendering changes). - BTW, don't ignore transform origin changes during composited animation. Change-Id: I889b0d5155d0744ba3fa9b44621e83402e113900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498030Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637830}
-
Stefan Zager authored
Previously, the dirty flags to IntersectionObservation::Compute were computed by doing a walk up the ancestor tree. This is silly, since the IntersectionObserver algorithm runs in a top-down tree walk. This CL propagates ancestor frame flags down to child frames to avoid the tree walk. R=chrishtr@chromium.org Change-Id: I09f95696ce4d22c15ee76bc0a0ecc4e12778284c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501492 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#637829}
-
Tommy Martino authored
This CL adds an enum describing the type of data contained in a sheet. Bug: 902425 Change-Id: I36a9b06465af839d324ad1d56dc629915d3e597e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1484811 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#637828}
-
Takumi Fujimoto authored
Instead of having a stop button contained in the sink button, make the entire sink button clickable when the sink state is CONNECTED, The stop button worked by activating the entire button, so no extra logic is necessary to make the sink button send the stop request. Focusing on the sink button (tab or mouse hover) changes the status text to "Stop casting". Bug: 900012 Change-Id: I6abce70735bf7920e314063a3326268b54d27b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497632Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#637827}
-
Matt Menke authored
The class is going to be merged into HttpProxyConnectJob, which it used to be part of, and can be part of once more, now that proxy auth is handled entirely while a single ConnectJob is in a socket pool. There are only two tests for QUIC proxies in the file: 1) HttpProxyClientSocketWrapperTest.QuicProxy is redundant, given QuicNetworkTransactionTest.QuicProxy passes. 2) HttpProxyClientSocketWrapperTest.QuicProxySocketTag is much like QuicStreamFactoryTest.Tag, except it also checks the HttpProxyClientSocketWrapperTest passes the the SocketTag to the QuicStreamFactoryTest.Tag. Given the significant setup needed to test QUIC, and the fact that there are no other QUIC tests at this layer, I'm not sure the test is worth the cost of creating a new test fixture just for it. Bug: 938569 Change-Id: I8f2dd83ba2348abfb0a4426c7da9394c6e14013d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504003Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
-
Caitlin Fischer authored
Change-Id: Ieea938de39081ef958fc82d0c971ededd8214b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504117Reviewed-by:
Tommy Martino <tmartino@chromium.org> Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#637825}
-
Yuchen Liu authored
For some web pages, we'd like to use DefaultRendererFactory, so that we can render video on graphics plane. This is mainly used to support playing short video on top of another Cast web page. Bug: internal b/125912333 Test: Playing video on top of YT doesn't break any pages. Merge-With: eureka-internal/247900 Change-Id: Ibbcd3ee13e6642aa4d9ab1548a8f64ce95329fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496008 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#637824}
-
Istiaque Ahmed authored
Bug: None Test: file_manager logs will show spelling correction. Change-Id: I5688ef6b973147adbc55c16a5f2fe49866bb405c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504114Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#637823}
-
Sorin Jianu authored
Bug: 938527 Change-Id: I0814a5078cca8ee25d96a68a64a42fcfcf3be62a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504053 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#637822}
-
Aleks Totic authored
This patch fixes the reported crash. The reproducible case is https://ajuntament.barcelona.cat/widgets/socials/bcn/index.html?lang=es&numRows=1&header&menu&boxColor=aab0b0&buttonColor=aab0b0&buttonRadius=50&fontColor=ffffff&id=3c58a16711f992fee70edcf13ef72da3 Unfortunately, I have been unable to create a minimal reproducible case that causes a crash. The added test case exercises new code path, just without a crash. The bug observed at the crashing URL was: LayoutResult::OOFPositionedDescendants had an invalid descendant that was already removed from the tree. What made this failure extra annoying is that memory occupied by invalid descendant was reused for a different LayoutObject. Removal of the descendant caused LayoutObject::MarkContainerChainForLayout to be called, but the container chain was not fully traversed because ObjectIsRelayoutBoundary returned true and aborted the traversal. My understanding is as following. In 2015, leviw introduced an invalidation optimization. The optimization happens when child needs layout, but can guarantee that it will not affect layout of its parent. In this case, child stops marking parents for relayout, and is instead put on LayoutSubtreeRootList, which gets traversed for layout directly. Method that does this is LocalFrameView::ScheduleRelayoutOfSubtree The method that decides whether child affects parents layout is: ObjectIsRelayoutBoundary(). I've fixed this method for NG, so that cached layout result with oof descendants causes full container chain traversal. Bug: 933054 Change-Id: Ie3daab53937297f1cea75b0974c3fce353c86200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500610 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#637821}
-
Dale Curtis authored
This should work, but is untested beyond a local Android build. BUG=938190 TEST=local Android build passes. R=tguilbert Change-Id: I5588f6b0ce7e347b683aec3daefde33f2b44fadf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503909 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5b3bf586f36d..314a2f06b9ff git log 5b3bf586f36d..314a2f06b9ff --date=short --no-merges --format='%ad %ae %s' 2019-03-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-03-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-03-05 martiniss@chromium.org Revert "Roll recipe dependencies (trivial)." Created with: gclient setdep -r src/third_party/depot_tools@314a2f06b9ff The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Iffe992466674aa09ac8339b2b710e8349a0f7801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503940Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637819}
-
sebsg authored
This removes code from the html and js files. Bug: 930204 Change-Id: Ia3ff2e6f0c85ee2d820edaba8ce63127a3eca984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500055 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#637818}
-
Maxim Kolosovskiy authored
The experiments with PasswordManager.ButtonTitlePerformance.* and PasswordManager.SuccessfulLoginHappened continues. Bug: 930910, 928512 Change-Id: I86c2d2d04ba8b583baf5d701c1009d5347f96b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503593 Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#637817}
-
Johannes Henkel authored
This picks up the BUILD.gn changes. Change-Id: I0a98eff9ff65365cfa9bb790a679a51ea1a94809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504049 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#637816}
-
Christian Fremerey authored
TBR=emircan@chromium.org Bug: 938074 Change-Id: I89f6f85808ffdb15dbb2c9be60adefea5d8f215d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504165Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#637815}
-
Tomasz Wiszkowski authored
This change ensures all our answers are rendered uniformly and correctly. Sport events seem to report only secondary medium text as an answer making the rendering appear like dictionary phonetic representation of a word. To resolve this and potentially other similar issues in the future, we only apply styling to the two answer types that utilize it, that is: - Finance and - Dictionary. Bug: 936731 Change-Id: I2415020e0616720b8e61ac6b7833d6f958e369c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500194Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#637814}
-
Nate Fischer authored
No change to logic, this re-enables a test. testSafeBrowsingWhitelistHardcodedWebUiPages was previously disabled because it was flaking, although this may have been related to a WebUI-related bug which paulmiller@ recently fixed (see http://crrev/c/1432953). This re-enables the test, since it seems reliable now. R=paulmiller@chromium.org Bug: 855732 Test: run_webview_instrumentation_test_apk --num_retries=0 \ Test: --break-on-failure --repeat=1000 \ Test: -f=SafeBrowsingTest.testSafeBrowsingWhitelistHardcodedWebUiPages Change-Id: Idb890f5efdfc8777a679d476351aa421ec507a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504042 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#637813}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6641700a..8fdf9af7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaf5dfd252d6a74c0ceaef3d03ff4d2ee65051d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503338Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637812}
-
Robert Ogden authored
In Chrome Duet, the DataSaver menu footer is moved to the top of the overflow menu, but the IPH anchor view is still set to the footer. This change does several dependant steps to fix the problem: * Use R.id.data_reduction_menu_item for the anchor view * AppMenuHandler.setMenuHighlight requires circle bool instead of equality checking with the footer view * Adds AppMenuHandler.clearMenuHighlight to clean up the API a bit * Move the ViewHighlighter call up in AppMenu Bug: 938022 Change-Id: I97315c588f225b63a35fae69eb72f460194f5c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500840 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
As a preparation for enabling/disabling individual built-in modules, this CL introduces layered_api::Module enum class that identifies each built-in module, and assigns its value in |kLayeredAPIResources|. generate_lapi_grdp.py is modified so that it associates each entry of resource files with a Module value based on the directory name, and layered_api_module.h is generated and added. Bug: 829084 Change-Id: I401c120a49866b249725ddf9e93b3d1dd4e56549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501573Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#637810}
-
Daniel Rubery authored
To make sure the refresh logic works in the AdvancedProtectionStatusManager, add a test that skips the 24 hour timer. Bug: 919708 Change-Id: I3643ea968be58b5dcd9ce30565a6152a10ab5294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495744 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#637809}
-
Erik Jensen authored
This allows the client to request a file from the host. When the host receives a RequestTransfer message, it will display a file chooser for the user to select a file, which will then be sent to the client. Bug: 679313 Change-Id: I137cf2bd93e86514bdf0ec4a9d69277569957d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1484085 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#637808}
-
David Bokan authored
TBR=hanxi@chromium.org Bug: 934941 Change-Id: I287b0239714b2902d3e3016b545c49a103da4175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504169 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#637807}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I5a7600e3aecf0e474f2939831addb53d5caabf19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504172Reviewed-by:
-
Owen Min authored
This reverts commit 976ec7a9. Reason for revert: crbug.com/938591 Original change's description: > innerText setter should not modify an existing Text child > > We have an optimization reusing a Text child, but the standard doesn't > define such behavior, and Edge, Firefox, and Safari don't have it. > > This CL might regress benchmarks. We'll accept it. > > Bug: 573309 > Change-Id: I3aacae5d37e5a7685ce2d310944dfef8d6e4b13a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502338 > Commit-Queue: Kent Tamura <tkent@chromium.org> > Auto-Submit: Kent Tamura <tkent@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637665} TBR=yosin@chromium.org,tkent@chromium.org Change-Id: Ib1884d8b20d9c8d10fc1566498cbdd719cc97b50 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 573309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504128Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637805}
-
Nancy Li authored
Make mojo share files are served by chrome://resources Update all current clients to use that URL instead of registering these separately in every WebUI data source. Bug: 933595 Change-Id: Ie512e3d457329298fed73a70b3c40534968f93e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492752 Commit-Queue: Nancy Li <nancyly@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a1810551f219..2ca31f8de281 git log a1810551f219..2ca31f8de281 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 bsalomon@google.com Use GrSurface::setRelease helper that creates ref-counted wrapper 2019-03-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-03-05 egdaniel@google.com Add unit test to check if we can create a VkDevice using global priority extension. 2019-03-05 scroggo@google.com Fix Android host-side Windows build 2019-03-05 csmartdalton@google.com Make sure to apply the stencil settings for GrDashOp 2019-03-05 benjaminwagner@google.com [infra] Upgrade Debian GCE bots to 9.8. 2019-03-05 herb@google.com Have SkGlyphRunListPainter close over SkStrikeCacheInterface 2019-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e95eeb19a770..e57f10e4041d (1 commits) 2019-03-05 bungeman@google.com Clarify ownership of typefaces in implementation. 2019-03-05 nifong@google.com Initial wasm debugger Created with: gclient setdep -r src/third_party/skia@2ca31f8de281 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126595186,chromium:b/123085931,chromium:b/117921091 TBR=reed@chromium.org Change-Id: Ida4e5c7aa79da36cdc403b11b504a50adbf693ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504173Reviewed-by:
-
Peng Huang authored
Bug: 937060, 938148 Change-Id: I2dfb6cd94fcef434beee3e771f1a0186e0d2b212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503350Reviewed-by:
Brian Salomon <bsalomon@google.com> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#637802}
-
Sean Topping authored
During observer notification, the observer might mutate CWC, which can cause the state DCHECKs to fail. We now check the state before notifying observers. A DCHECK is also added to ensure CWC is not destroyed while notifying observers. Bug: internal b/124794528 Test: CQ, manual test on device with basic media flow: "OKG, play music" Change-Id: Icb0c2f6e9d7dc4e3bad8598ba8ab196253dec900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497299Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#637801}
-
Wei-Yin Chen (陳威尹) authored
ToTLinux bots unexpectedly turned red due to check_gn_headers step. Temporarily remove this step before the root cause is fixed. Bug: 937847 Change-Id: I2e6250f8510bf871ac619b9ecd49234f9855e45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503994 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#637800}
-
Kristi Park authored
Save the is_most_visited state in prefs. Otherwise, custom links initialized from Most Visited would not be deleted by CBD after the browser was restarted/the links were synced. Bug: 931804 Change-Id: Ia033abd9a23bdca49c66ae6c871497f559251aba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495808 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#637799}
-
Abhijeet Kandalkar authored
The primary motivation of CL is that the function names aren't consistent within resource_response.h (e.g."SetHTTPStatusCode" and "HttpStatusCode"). This CL rename function |SetHTTPStatusCode| to |SetHttpStatusCode| and port other dependent files to refer to a new function name. Bug: 937196 Change-Id: I4274ebe73bdf4ae1179d89719f055d678ad6d909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503172 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#637798}
-
Tomasz Wiszkowski authored
Bug: 936733 Change-Id: I1246d9c05fbf386b8679bc15ec9dd8b8830e06d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500193Reviewed-by:
-
Bryan McQuade authored
This does not change the behavior of how existing metrics are associated with sources, but creates source entries for all same-doc navs. Follow up changes can start associating metrics with same doc navs as it makes sense to do so. Change-Id: Ib244c70ab83fde810bcd30c7f1c78169bbf8337a Bug: 917463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489896 Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#637796}
-
Guohui Deng authored
Rename it to overlay_plane_id, which is a better name, and consistent with the name of its counterpart in VideoFrameMetadata. Bug: 925450 Test: None. Change-Id: I965604451b442558dabc65f7e1fcb91315b38881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497612Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Guohui Deng <guohuideng@chromium.org> Cr-Commit-Position: refs/heads/master@{#637795}
-
Alexandre Frechette authored
Match the names and config to the finch studies we're launching server side in ManualTranslateInProductHelp.gcl. Bug: 922216 Change-Id: Iaae80d1172fade2e451c29ddfbb85301244278af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492735Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#637794}
-
