Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 31 Mar, 2020 13 commits
  3. 30 Mar, 2020 27 commits
    • behdad's avatar
      Long main thread work is not blocking Impl work being reported · 65b15787
      behdad authored 
      During submit, if the frame is not activated yet, a copy of reporter at
Begin_Impl stage will be created and reported. This reporter is the
Begin_Impl portion of the existing reporter which is in Begin_main or
Commit stage.

So in the case of:
BI_1 BM_1 S_1 P_1 BI_2 C_1 A_1 S_2 P_2

In addition to:
BI_1 -> BM_1 -> C_1 A_1 S_2 P_2

This set will also be reported:
BI_1 -> S_1 -> P_1

Bug: chromium:1059282
Change-Id: I581088a41cd8ee1247fa18e28e4a24f5d4870103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095350
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754719}
      65b15787
    • Pavel Yatsuk's avatar
      tools/mb/mb.py should handle gn args with different number of spaces · fcbd5218
      Pavel Yatsuk authored 
      Currently GNArgsFromDir expects gn arg to have exactly one space around
assignment operator (target_os = "android"). It removes both spaces so
that later the code could to a check in the form
('target_os="android"' in vals['gn_args']). If an arg doesn't have
spaces or have extra (target_os ="android"), the logic works
incorrectly.

This CL fixes GNArgsFromDir to break name/value line on '=' and strip
spaces around both name and value.

BUG=1066289

Change-Id: I958b2cb400415f33f6b5310da0f127df715bd059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127742
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: default avatarGarrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754718}
      fcbd5218
    • Collin Baker's avatar
      Handle swipes with no preceding scroll events · c275fc57
      Collin Baker authored 
      I incorrectly assumed that any ET_GESTURE_SWIPE would be preceded by an
ET_GESTURE_SCROLL_BEGIN. Sometimes this is not the case, and this caused a
DCHECK.

This change handles swipes that weren't preceded by a scroll event.

Bug: None
Change-Id: I535e43a10e6f6162080af4ba4b85a8fefc8e2cd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128091Reviewed-by: default avatardpapad <dpapad@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754717}
      c275fc57
    • Karandeep Bhatia's avatar
      DNR: Implement indexing of multiple static rulesets. · c99af485
      Karandeep Bhatia authored 
      This CL:
  1. changes the installation code to index all static rulesets provided
  by an extension.
  2. Adds unittests to ensure 1. above works as intended.

Remaining work:
  1. Currently rule limits for static rulesets are only evaluated per
  ruleset. Implement them for the set of enabled rulesets once we
  start supporting the 'enabled' property as part of rulesets specified
  in manifest.
  2. We have limits on the no. of install warnings per ruleset. Also,
  add a limit on the total number of warnings across all rulesets.
  3. Load multiple static rulesets on extension load.
  4. Provide ability to dynamically toggle the set of enabled static
  rulesets.

BUG=754526

Change-Id: I92202ae69724f41ce1645af72dbc88e04fdc9f3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107239
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754716}
      c99af485
    • Mike Frysinger's avatar
      grit: support building/installing as a normal package · 936d24e0
      Mike Frysinger authored 
      This uses standard python setuptools so we can build dedicated source
and wheel distributions, and install them outside in other systems.
We want this for CrOS for example, but it'd also be helpful with some
other projects I've been experimenting with.

The grit_runner change is to support setuptools' console wrapping
logic.  It will invoke our main func, but not pass in argv, so we
need to pull it out of sys.argv ourselves.

The unit change is needed since we don't install the test modules in
the system.  The code still works locally, but no longer blows up the
use of `grit` when installed.

Test: `./setup.py sdist` works, and building a new wheel with that installs/runs fine
Change-Id: Ie929d9370af142bf29e246d543162d974159429b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127847Reviewed-by: default avatarRobbie Iannucci <iannucci@chromium.org>
Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754715}
      936d24e0
    • Jinsuk Kim's avatar
      PreviewTab: Do not handle back button if suppressed · 08f2f6a4
      Jinsuk Kim authored 
      This CL changes the bottom sheet behavior so that Preview Tab in
suppressed state does not consume back button.

Bug: 1065286
Change-Id: I620fc3c74877e5af3096a635d9cb2f9c82def66f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125908Reviewed-by: default avatarMatthew Jones <mdjones@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754714}
      08f2f6a4
    • Sophie Chang's avatar
      Return earlier if we have all information available to make decision · 5cf20ded
      Sophie Chang authored 
      Previously, if the decision was false and we had fetched already or
couldn't fetch, we would wait until DidFinishNavigation to invoke any
registered callbacks.

Change-Id: I0536ff5307d89265863c91845dc3a500a2ecd631
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128526
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: default avatarMichael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754713}
      5cf20ded
    • Alex Moshchuk's avatar
      Deflake the SubframeShowsDialogWhenMainFrameNavigates test. · 0ca2690a
      Alex Moshchuk authored 
      Currently, the test sends two beforeunload IPCs for main frame and
subframe, then waits for the subframe's beforeunload to trigger a
dialog, and then assumes that the main frame's beforeunload has
completed by that point when it checks the number of outstanding
beforeunload requests.  This need not be true -- even though the main
frame does not have a beforeunload handler, we still (currently) send
the beforeunload IPC to it, and it could still reply slower than the
subframe's IPC to put up a dialog.

This CL fixes the test to instead check the number of outstanding
beforeunload requests on the same event loop iteration, before we wait
for a dialog, since at that point we know we couldn't have processed
any beforeunload ACKs yet.  Then, after the beforeunload dialog is
shown, we only check that the subframe has an outstanding beforeunload
request, and don't check anything about the main frame beforeunload
(which may or may not have completed at that point).

Bug: 1044599
Change-Id: I3eb53b3a390a1945cc5e40ca388cb985a60b6d36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128587Reviewed-by: default avatarŁukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754712}
      0ca2690a
    • Jeroen Dhollander's avatar
      Disable suggestion chips after submitting query · 68a5784c
      Jeroen Dhollander authored 
      When an Assistant query has been submitted, you should not be able to
interact with the suggestion chips anymore.
Mouse clicks had always been disabled, but a bug still allowed the
user to submit queries using |TAB| and |ENTER|.

This CL also introduces some extra unittests that were missing.

Bug: b/151800188
Change-Id: I15fe1b946ae92c1f74b7a98656793e4d00b2a12c
Tests: ash_unittests "AssistantPageViewTest.*" and view_unittests
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119388Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Reviewed-by: default avatarXiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/master@{#754711}
      68a5784c
    • Peter Kasting's avatar
      Misc. cleanup for ash/ · 4d66384d
      Peter Kasting authored 
      Found while working on AshTestHelper.

Bug: none
Change-Id: I8d38fbe29fa1db613abf9b3e4447bff18365449f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125231
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754710}
      4d66384d
    • Peter Kasting's avatar
      Call TearDown() from ~AshTestHelper(). · 3b81c72f
      Peter Kasting authored 
      This means callers only need to call TearDown() if they need to do
something between teardown and destruction, which most don't; and they
cannot fail to call TearDown() (and thus leave objects alive).  So it's
both simpler and safer.

Bug: none
Change-Id: Iba7ad30e64dca62d060b8c572253117d7952db3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124979
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: default avatarMitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754709}
      3b81c72f
    • Clark DuVall's avatar
      [WebLayer] Implement CookieSettingsFactory · bac8e1eb
      Clark DuVall authored 
      We need CookieSettings for adding the header necessary for the manage
accounts feature.

Bug: 1054160
Change-Id: I736267acaed75d23362ff96c77bd4a1b1634c707
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127418Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754708}
      bac8e1eb
    • Peter Kasting's avatar
      Split AshTestHelper setup and put some pieces in the constructor. · 9eaedfd9
      Peter Kasting authored 
      This is yet more precursor work for making AshTestHelper an
AuraTestHelper subclass.  It moves into the constructor things that
are more "general-purpose" and don't rely on any state that might be
customized after construction (e.g. reading the ViewsDelegate), and
leaves SetUp() focused more on the ash-specific shell/windowing stuff.

This changes the parameters passed to the constructor vs. setup, since
ultimately some will be relevant to the Aura side and some won't.  For
now, this requires storing the |context_factory_| on the object to
pass it from the constructor to setup, but that will go away later.

This also adds a no-args SetUp() function, which just calls the main
SetUp() function.  This is a precursor to making SetUp() and TearDown()
be virtual method overrides.

A few other trivial changes:
* Explicitly resets |session_controller_client_| during TearDown(),
  since I forgot that previously.  (Should have no effect)
* Puts GetLocalStatePrefService() into the same order in the .cc file
  as the .h file.

Should be no functional effects.

Bug: none
Change-Id: Ida64c3fc0779f3bb38a032cf8d3f490104fe88ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124934
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754707}
      9eaedfd9
    • Kyle Milka's avatar
      [SharingHub] Add padding to end of bottom row · a257b4e6
      Kyle Milka authored 
      Bug: 1009124
Change-Id: Id35faff3cc3f0caa0a4200c40d803a07a32cf01f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128460
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Auto-Submit: Kyle Milka <kmilka@chromium.org>
Reviewed-by: default avatarMatthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754706}
      a257b4e6
    • dpapad's avatar
      Settings: Preparing remaining privacy_page/ tests for Polymer3. · aa00a9e1
      dpapad authored 
      Removing register*() wrapper functions, using runMochaSuite()
instead.

Bug: 1026426
Change-Id: I802eb09bb4640dc673c213dc53796a219ce71f99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127417
Auto-Submit: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: default avatarRebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754705}
      aa00a9e1
    • rbpotter's avatar
      Disable NewTabPageLogoTest.All · 666b3431
      rbpotter authored 
      The test is flaky. This CL fixes the typo in the test rename to ensure
the test is actually disabled.

TBR=miersh@google.com,tiborg@chromium.org

Bug: 1065812
Change-Id: Ib6adf89dbe8bfa35034114f86cc892cdd5252f2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127988
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: default avatarRebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754704}
      666b3431
    • Nick Harper's avatar
      Update bulk entries in HSTS preload list · 8cb7a34d
      Nick Harper authored 
      TBR=rsleevi@chromium.org

Change-Id: Ic6b261d11baa5c6b4999c975266ad8d8b6e3eede
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127726Reviewed-by: default avatarNick Harper <nharper@chromium.org>
Reviewed-by: default avatarRyan Sleevi <rsleevi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754703}
      8cb7a34d
    • Steven Bingler's avatar
      Calculate cross-schemeness for CROSS_SITE · 1a1835f1
      Steven Bingler authored 
      Expand the computation of cross schemeness of same-site contexts to
include CROSS_SITE.

Change-Id: I397fcbc79d62977069e2ec20bcdda027fdd35f9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124546
Commit-Queue: Steven Bingler <bingler@chromium.org>
Reviewed-by: default avatarMaksim Orlovich <morlovich@chromium.org>
Reviewed-by: default avatarLily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754702}
      1a1835f1
    • David Tseng's avatar
      Reland: remove async apis in SpeechMonitor · 63d71e50
      David Tseng authored 
      Fixed by adding a WeakPtrFactory to SpeechMonitor so all posted task callbacks don't run if we destroy SpeechMonitor previously.

Failure in asan:
READ of size 8 at 0x7f8dc614c068 thread T0 (browser_tests)
    #0 0x559e511d3be4 in time_since_epoch ./../../buildtools/third_party/libc++/trunk/include/chrono:1383:103
    #1 0x559e511d3be4 in operator-<std::__1::chrono::steady_clock, std::__1::chrono::duration<long long, std::__1::ratio<1, 1000000000> >, std::__1::chrono::duration<long long, std::__1::ratio<1, 1000000000> > > ./../../buildtools/third_party/libc++/trunk/include/chrono:1564:45
    #2 0x559e511d3be4 in CalculateUtteranceDelayMS ./../../chrome/browser/chromeos/accessibility/speech_monitor.cc:93:15
    #3 0x559e511d3be4 in chromeos::SpeechMonitor::MaybePrintExpectations() ./../../chrome/browser/chromeos/accessibility/speech_monitor.cc:230:7
    #4 0x559e5edf6c45 in Run ./../../base/callback.h:98:12
    #5 0x559e5edf6c45 in base::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/task/common/task_annotator.cc:142:33
    #6 0x559e5ee2dfe8 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*, bool*) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:324:23
    #7 0x559e5ee2d93a in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:248:7
    #8 0x559e5ef7c9d6 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:208:55
    #9 0x559e5ee2f188 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:429:12
    #10 0x559e5eda978d in base::RunLoop::Run() ./../../base/run_loop.cc:124:14
    #11 0x559e5ecac5eb in RunUntilBrowserProcessQuits ./../../chrome/test/base/in_process_browser_test.cc:362:38
    #12 0x559e5ecac5eb in InProcessBrowserTest::QuitBrowsers() ./../../chrome/test/base/in_process_browser_test.cc:584:3
    #13 0x559e5ecac2f7 in InProcessBrowserTest::PostRunTestOnMainThread() ./../../chrome/test/base/in_process_browser_test.cc:559:3
    #14 0x559e601dc870 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:699:3
    #15 0x559e5f0c5e8f in Run ./../../base/callback.h:98:12
    #16 0x559e5f0c5e8f in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1640:38
    #17 0x559e5f0c3bdb in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18
    #18 0x559e5324fc2f in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:597:32
    #19 0x559e57b9c078 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:1020:13
    #20 0x559e58ab7d34 in Run ./../../base/callback.h:98:12
    #21 0x559e58ab7d34 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29
    #22 0x559e57b993a4 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:929:25
    #23 0x559e57ba10ce in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:129:15
    #24 0x559e57b94ae5 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32
    #25 0x559e5d885212 in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10
    #26 0x559e5d885212 in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10
    #27 0x559e5d8844d8 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12
    #28 0x559e667f3da4 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:457:29
    #29 0x559e5ab9eec2 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
    #30 0x559e601da293 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3
    #31 0x559e5eca7ca9 in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:303:20
    #32 0x559e5220cb97 in HotseatShelfAppBrowserTest::SetUp() ./../../chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc:2274:26
    #33 0x559e540b8f08 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #34 0x559e540b8f08 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2663:3
    #35 0x559e540bb736 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2845:11
    #36 0x559e540bcc76 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2977:28
    #37 0x559e540e3716 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5518:44
    #38 0x559e540e23f3 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #39 0x559e540e23f3 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5105:10
    #40 0x559e5efb6539 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2472:46
    #41 0x559e5efb6539 in base::TestSuite::Run() ./../../base/test/test_suite.cc:458:16
    #42 0x559e5ec63f38 in BrowserTestSuiteRunnerChromeOS::RunTestSuite(int, char**) ./../../chrome/test/base/browser_tests_main_chromeos.cc:37:23
    #43 0x559e6029ce29 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:375:31
    #44 0x559e5ec651cb in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:247:10
    #45 0x559e5ec63d69 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:52:10
    #46 0x7f8dc93aabba in __libc_start_main /build/glibc-QG9qOO/glibc-2.29/csu/../csu/libc-start.c:308:16

Address 0x7f8dc614c068 is located in stack of thread T0 (browser_tests) at offset 104 in frame
    #0 0x559e625d8a0f in base::circular_deque<mojo::Message>::DestructRange(unsigned long, unsigned long) ./../../base/containers/circular_deque.h:998:0

Original change
https://chromium-review.googlesource.com/c/chromium/src/+/2124701

TBR=nancylingwang@chromium.org, dmazzoni@chromium.org

Fixed: 1065746
Test: ran tests against asan, debug, and release
Change-Id: Ie3b245933969ffe182962e017515e4cf656ef05b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128027Reviewed-by: default avatarDavid Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754701}
      63d71e50
    • Rebekah Potter's avatar
      Revert "[iOS] Hook up chrome://interstitials page." · 6d752d3e
      Rebekah Potter authored 
      This reverts commit ddc36acb.

Reason for revert: 
The added tests fail consistently on ios-simulator-noncq, see e.g. https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/3424

Original change's description:
> [iOS] Hook up chrome://interstitials page.
> 
> This CL adds support for the chrome://interstitials WebUI, which
> contains links for dummy interstitials.  Currently only a subset of the
> available links are implemented for iOS.
> 
> Bug: 1064803
> Change-Id: I8577b92cdebf5110847ca835d952953171f2d172
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121134
> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
> Reviewed-by: Livvie Lin <livvielin@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754581}

TBR=eugenebut@chromium.org,kkhorimoto@chromium.org,livvielin@chromium.org,livvielin@google.com

Change-Id: I44f5e7a818e581331d7278956ce5588df5dc705b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1064803
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128931Reviewed-by: default avatarRebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754700}
      6d752d3e
    • Regan Hsu's avatar
      [OsSettingsSearch] Connect Search Mojo API to Settings Search UI. · 0eeb729f
      Regan Hsu authored 
      * Replaces search results that were type String to mojom.SearchResult.
* Modifies elements and tests to account for type change.
* Does not remove fakeSettingsSearchHandlerSearch() yet as it will still
  be used to test a variety of cases and enable faster dev.

Bug: 1056909
Change-Id: I4ec246fa50a5076eea6f1d99efa4116d82d43e6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122617
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754699}
      0eeb729f
    • Sergey Ulanov's avatar
      [Fuchsia] Redirect fuchsia.media.Audio to the agent · bed1d89d
      Sergey Ulanov authored 
      Previously CastRunner was implementing Audio protocol to redirect
CreateAudioCapturer() message to the agent that created the component.
The agent also needs to be able to intercept CreateAudioRenderer()
requests, particularly to set stream usage (WebEngine doesn't set
usage for AudioRenderer ATM).

This CL updates the runner to redirect fuchsia.media.Audio protocol,
so then the agent can handle AudioRenderer and AudioCapturer requests
as appropriate.

This affects WebRTC audio output, but not regular media playback which
is handled by the fuchsia.media.AudioConsumer protocol.

Bug: 1059836
Change-Id: If68efdd2e1e4f0cbe84051e22ebaf90c2877b08e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125610
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: default avatarDavid Dorwin <ddorwin@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754698}
      bed1d89d
    • Peter Kasting's avatar
      Misc. cleanup · d77621f1
      Peter Kasting authored 
      Found while working on AshTestHelper.

Bug: none
Change-Id: Ia942c7662dea4b3194a31930efe9ce244286effe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125396Reviewed-by: default avatarMike West <mkwst@chromium.org>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Reviewed-by: default avatarMitsuru Oshima <oshima@chromium.org>
Reviewed-by: default avatarMichael Wasserman <msw@chromium.org>
Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarYuchen Liu <yucliu@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754697}
      d77621f1
    • chromium-autoroll's avatar
      Roll src/third_party/swiftshader 45755df21024..5cf1e9a31c90 (1 commits) · e5bfd81a
      chromium-autoroll authored 
      https://swiftshader.googlesource.com/SwiftShader.git/+log/45755df21024..5cf1e9a31c90

git log 45755df21024..5cf1e9a31c90 --date=short --first-parent --format='%ad %ae %s'
2020-03-30 capn@google.com Fix implicit narrowing cast

Created with:
  gclient setdep -r src/third_party/swiftshader@5cf1e9a31c90

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I7d769239f440d43c0929a07888cec009759f7feb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128381Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754696}
      e5bfd81a
    • chromium-autoroll's avatar
      Roll src/third_party/shaderc/src f085b9745fc1..aface10e934e (1 commits) · 04dff0a3
      chromium-autoroll authored 
      https://chromium.googlesource.com/external/github.com/google/shaderc/+log/f085b9745fc1..aface10e934e

git log f085b9745fc1..aface10e934e --date=short --first-parent --format='%ad %ae %s'
2020-03-30 rharrison@google.com Rolling 5 dependencies and updated exceptions (#1026)

Created with:
  gclient setdep -r src/third_party/shaderc/src@aface10e934e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com
Change-Id: I4aa846b16bb27d48f567b9a070848dbc364cba45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128383Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754695}
      04dff0a3
    • Antonio Gomes's avatar
      [css-flexbox]: Migrate multiline-min-max.html to WPT · bec3d92e
      Antonio Gomes authored 
      BUG=1063749
R=cbiesinger@chromium.org

Change-Id: I14718b6bb2b9c48653e737fb08a9f780f86da000
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128426
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: default avatarChristian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754694}
      bec3d92e
    • Peter Kasting's avatar
      Make ui/views lint check more aggressive. · ba654270
      Peter Kasting authored 
      This enables all non-blacklisted checks at verbosity 1 and above.  I
locally spot-checked the verbose=0 errors and found them useless
(mostly false complaints about "more than one command on the same line"
for lambdas), so not going down that far.

This should prevent regressing on any of the failures I've fixed.

Bug: none
Change-Id: Ia5db45e7e372a6147d58f463bbc47c81e00aac5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126254
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: default avatarRobert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754693}
      ba654270