- 11 May, 2019 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8ab4053f00b0..b16655545f81 git log 8ab4053f00b0..b16655545f81 --date=short --no-merges --format='%ad %ae %s' 2019-05-11 swiftshader.regress@gmail.com Regres: Update test lists @ 8ab4053f Created with: gclient setdep -r src/third_party/swiftshader@b16655545f81 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I2dd0830b68ff063a279d9b228691da91e1402e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607429Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658883}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/750843e02c8c..4f10af669c14 Created with: gclient setdep -r src-internal@4f10af669c14 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I01b56864de671a2cc1839cb4d83d0c08d2c45997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607428Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658882}
-
rajendrant authored
Bug: 961968, 961966, 961962 Change-Id: I1a7b65e2a534231989975fe933397e097251e7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607620 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#658881}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iff8cb3102397c2e96b3241d76c37847319d589e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607427Reviewed-by:
-
Dominic Battré authored
This reverts commit 42b45514. Reason for revert: Broke Mac 10.10 and 10.11 builders, see crbug.com/957033 Original change's description: > Notifications: Delay closing out of workarea bounds pop-ups. > > When the pop-up is expanded to show inline settings, the new height can overflow > the work area. Deleting the pop-up in this scenario triggers a crash as we're > still in the same call stack. > > BUG=957033 > > Change-Id: Ie8d4db393893b662b72f9c04317f9ca640a25607 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600155 > Commit-Queue: Tim Song <tengs@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658793} TBR=peter@chromium.org,tengs@chromium.org,pbos@chromium.org Change-Id: Ie8f23f1a0e12c4c61386458e03d426c84b47dd88 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 957033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607640Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#658879}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0b7c9598623e..750843e02c8c Created with: gclient setdep -r src-internal@750843e02c8c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: Ica7bbe33b81a458f7a93bb6b04ab90e1155fd3ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607423Reviewed-by:
-
Koji Ishii authored
This patch changes the test to the standard (non-quirks) mode, and updates expectated file accordingly. Blink has a quirk to compute the height when: a. The document is in line-height quirks mode, and b. The element is `<br>`, and c. The `<br>` is not the only element in the line. AX relies on this quirk by computing the `offscreen` property if the size is (0, 0). LayoutNG has implemented some quirks but not all, when it's not interoperable and we think we can deprecate. This is one of such quirks. Since the standard mode is more common these days, this patch avoids the difference between legacy and NG by switching the test to the standard mode. Change-Id: I4fed1921a7512ea82057ac46320de7f85b49d4c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605586Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#658877}
-
Xiaohan Wang authored
ScopedCallbackRunner has been moved and renamed to mojo::WrapCallbackWithDefaultInvokeIfNotRun. But some comments are not updated. This CL updates them. Tbr: csharp@chromium.org Bug: 775358 Test: Comment update only Change-Id: I82fa7406dbce68b3bf4a7c74a63a45779b9d1f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606401 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#658876}
-
Thanh Nguyen authored
This flag is necessary for Blink team to test the new function that cancels single touches. Bug: 946868 Change-Id: I5799fdd3d39abff99d5d0c4e36424c65d4c505e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604382Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#658875}
-
rajendrant authored
Plumbs the useragent from chrome/browser down to components/ and sends to the WarmupUrlFetcher. Bug: 961963 Change-Id: I544ba393c4356badb821395b029f7b991c62eacc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607129Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#658874}
-
Peter Kasting authored
This eliminates |is_on_|, since tracking it via the animation state is possible. Bug: 957267 Change-Id: I93b3a879227727bd72f8b8d1325912ebd3724222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592689 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#658873}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I8e3e6cdfa307d5ff00d3d103cb81b134207b2dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607600Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#658872}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d4bdb8b0e03e..0b7c9598623e Created with: gclient setdep -r src-internal@0b7c9598623e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I08a5ae9edcdc5d609927f90d5604414bdceacf3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607361Reviewed-by:
-
Zentaro Kavanagh authored
- No behavior change BUG=None TEST=compiles Change-Id: I4d76673906f80d2a5398c5b8aaa0c2246221deb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607143Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#658870}
-
Jeevan Shikaram authored
Show descriptions of extension apps in the detail page. Bug: 958172 Change-Id: I80195fb191f6da279949018d58ed8a73a586982e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605257 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#658869}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e7fe3e3c..bebf7514 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5611e5bbf2ea3a02c04a566537ff18755e76d03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606638Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658868}
-
Yuwei Huang authored
I have introduced quite a few VLOG(0)'s to /remoting to help debugging FTL signaling issues, and we are in a stage where this information is not much needed. This CL changes VLOG(0) to VLOG(1), or HOST_LOG if it is still useful. Change-Id: I017d23331589b3b0978376f493b4d5d7b0655ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607441 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#658867}
-
Bruce Long authored
If a username isn't a valid 8.3 short file name (even just a lengthy name like "user with long name"), Windows will set the TMP and TEMP environment variables to be 8.3 paths: TMP=C:\Users\USERWI~1\AppData\Local\Temp TEMP=C:\Users\USERWI~1\AppData\Local\Temp base::GetTempDir internally calls ::GetTempPath, which just uses the value specified by TMP or TEMP, and so can return a short path. This behavior can make checks on whether temp files that back virtual files are actually created in the temp directory fail, because of potential mismatches between normal/long and 8.3/short filenames. The bug is fixed by adding a new Windows FileUtil method to normalize a path (internally ::GetLongPathName is used). The method is currently only used in test code so there will be no product code regressions. Bug: 957925 Change-Id: Id6310aa99a8feb86b08c84a358b571454241f46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592044 Commit-Queue: Bruce Long <brlong@microsoft.com> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658866}
-
Peter Kasting authored
Bug: 957266 Change-Id: I027cd6b8803026bd5e638d49e675cd8a1f62e231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600646 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#658865}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 07e52c45. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" faed29aa "[EventTiming] Remove unneeded prefix from WPT tests" 9d5bc5ec "Portals: Add support for frame-src CSP directive." d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" 82728505 "[Animation Worklet] Do not allow undefined/NaN local time" 12376bce "Correctly invalidate snap container data when relevant css props change" 01d571da "Rename touch tap function in pointerevent_support.js" a7718cb5 "Revert "[EventTiming] Fix programmatic click test"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6ca2848d05909feb753910d5b4f87440ceb53f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606972Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658864}
-
Matt Wolenetz authored
Adds coverage previously missing for when a SourceBufferStream::Append call overlaps the current track_buffer_ with a keyframe such that all of track_buffer_ is pruned by the append. BUG=771349 TEST=SourceBufferStreamTest.Overlap_That_Prunes_All_of_Previous_TrackBuffer Change-Id: Id4eb7e1df41dfa0f7190d489071bf03a2e122d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601778Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#658863}
-
Dan Beam authored
This decreases the time until most visited/likely is visible to users. R=kristipark@chromium.org Bug: 868432 Change-Id: I1ee9d46b8f85e1cb9f0ff9f1b1830fb78a11dc39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606970 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#658862}
-
Zhongyi Shi authored
Bug: 901501 Change-Id: Ic778c96c1bb10a9f4bb2f8f3efd883e452bc9742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606770 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#658861}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/efef0e4b1fc4..97f08fa2e68f git log efef0e4b1fc4..97f08fa2e68f --date=short --no-merges --format='%ad %ae %s' 2019-05-11 natlee@microsoft.com Create nonzero_clear_resources_on_creation_for_testing toggle Created with: gclient setdep -r src/third_party/dawn@97f08fa2e68f The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I6a2f5a52345cd47dfbd0f7e86498c5a03cc59399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607282Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3fa919347bc7..6f8388801226 git log 3fa919347bc7..6f8388801226 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 thestig@chromium.org Remove impossible code related to CPDF_Type3Font. 2019-05-10 thestig@chromium.org Fix nits in CPDF_Pattern and related code. Created with: gclient setdep -r src/third_party/pdfium@6f8388801226 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Id78bc13bba9aa55f0a78a6336c328fe272c963b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607039Reviewed-by:
-
Peter Kasting authored
* Use in-declaration initializers where possible * Avoid bare new * Reset the cached preferred size on PreferredSizeChanged() Bug: none Change-Id: I68a8a9a3b868d2065d767e5f30b86ae70842378a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601577 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#658858}
-
Matt Wolenetz authored
With recent removal of LegacyByDts buffering logic, this change does the last of the major cleanup to SourceBufferStream such that it now uses base::TimeDelta for presentation time, removes the now-unnecessary wrappers of SourceBufferRange that converted time type from/to DecodeTimestamp, and updates the callers and tests of SourceBufferStream's API. Also adds a TODO around tangential compliance work remaining to fix https://crbug.com/623729. BUG=771349,623729 Change-Id: Ib87004719319ca34e917d54b1004ed111eab609c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597544Reviewed-by:
-
Nigel Tao authored
This adds a new event to extensions::ExtensionPrefsObserver, called OnExtensionLastLaunchTimeChanged, and makes apps::ExtensionApps react to this event. With the App Service disabled (the status quo), this test worked because answering the FilterDuplicate query involves asking the ExtensionPrefs directly, which returns the newer answer. With the App Service enabled, answering an app list search query doesn't ask ExtensionPrefs directly, because the purpose of the App Service is that app list code doesn't know about extensions (or ARC++, or Crostini, etc.). Instead, it asks the App Service. But because of Mojo asynchronous-ness, the App Service works on a push model (you observe it, it will send you updates) instead of a pull model (you ask it directly). The push model only works if the server side of the App Service can be notified whenever the relevant ExtensionPrefs are updated. Hence, the new OnExtensionLastLaunchTimeChanged event. Also update AppSearchProviderTest::AddExtension to install, not just load, the new extension. apps::ExtensionApps listens for installs, not loads. For example, OnExtensionLoaded is triggered when an extension is *re*-loaded, so having apps::ExtensionApps listen to that instead would mean spurious updates. Also fix a couple of typo's in AppSearchProviderTest. This fixes `unit_tests --enable-features=AppServiceAsh --gtest_filter="AppSearchProviderTest.FilterDuplicate"`. It fails before and passes after this commit. Note that `unit_tests --gtest_filter="AppSearchProviderTest.FilterDuplicate"`, without AppServiceAsh enabled, passes both before and after this commit. BUG=826982 Change-Id: I044eab158eaa1ee2c17d6b9a873033d8fcfb1a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553127Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Stefan Zager authored
When a LocalFrame with a RemoteOwner becomes detached, the RemoteFrameView in the parent process must be notified that it should not generate occlusion information. Prior to this patch, that notification originated in the process of the detached frame and was sent via IPC to the RemoteFrameView in the process of the embedding page. With this patch, the flag will be set by RemoteFrameView::Dispose running in the process of the embedding page. This should be fine, and avoids problematic IPC to a frame that's being torn down; but it relies on the assumption that the RemoteFrameView will be reliably torn down when the remote frame becomes detached. If there are any exceptions to that, then the embedding process may continue to (expensively) generate occlusion information for the defunct remote frame. The test included in this CL checks that occlusion tracking is disabled for a detached frame in the common case, but it is not comprehensive. BUG=957543 R=dcheng@chromium.org,eae@chromium.org Change-Id: I7fbc401f908934da2a6ffe99930ea21ddfb802ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606760Reviewed-by:
-
Findit authored
This reverts commit bfa78d12. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 658504 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYmZhNzhkMTI1ODAxNzVhNGJmZjRmOTVkZGFmZjMzZGYwYTQ2ZGVhNww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/12318 Sample Failed Step: base_unittests Sample Flaky Test: AbstractPromiseTest.CantRejectIfpromiseDeclaredAsNonRejecting Original change's description: > Reland: Promises: Add AbstractPromise > > Origional patch: https://crrev.com/c/1539981 > > This is the internal promise representation. It implements the machinery > needed to marshal and dispatch promises as they become ready for > execution. > > Care has been taken to try and minimize the size of the AbstractPromise > class and to keep down the number of heap allocations. The promise result > and the executor are both stored in the base::unique_any since they are > never needed at the same time. The size of AbstractPromise on x64 is 96 > bytes in builds without DCHECKS. > > In builds with DCHECKS it's larger because there's additional storage > used to diagnose and prevent various usage hazards: > > * Unhandled rejection > * Double move of promise results to callbacks > * Mixed move and non-move semantics of promise results to callbacks > > The base::any_internal type has been adjusted so it can store the > SmallUniqueObject<> inline, which is used to store the promise executor. > The largest anticipated promise executor base::All is the size of > 3x sizeof(void*) to hold a vtable and a std::vector. > > Design: https://docs.google.com/document/d/1l12PAJgEtlrqTXKiw6mk2cR2jP7FAfCCDr-DGIdiC9w/edit > > TBR=fdoray@chromium.org, etiennep@chromium.org > > Bug: 906125 > Change-Id: I15dbb78d4aecb6ae60f5dfaca8f73aba3fdd0963 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605683 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658504} Change-Id: I47ac4ae4e307b1e9a048cd1fa7bc18712dc55966 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 906125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606973 Cr-Commit-Position: refs/heads/master@{#658854}
-
Zentaro Kavanagh authored
- The unique pointer will be destroyed/reset anyway - Setting a member to null right before destruction is redundant BUG=None TEST=compiles Change-Id: Ie1115e064133cea85c538aeb11daf9bbed7bfadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607122Reviewed-by:
-
Oriol Brufau authored
This patch makes two 'repeat()' values for 'grid-template' be considered to be different if one uses 'auto-fill' and the other 'auto-fit'. Previously, they were considered to be equal if the repeated values were the same, without comparing the repeat type. Therefore, the grid was not updated when setting both values one after the other. BUG=961407 TEST=fast/css-grid-layout/grid-change-auto-repeat-tracks.html Change-Id: I4e0202097097337aef600e5e8cb732b076bc8ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606840Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#658852}
-
Matt Wolenetz authored
With recent removal of LegacyByDts buffering logic, there is no longer a need to split the internals of SourceBufferRange into ByDts and ByPts implementations. This change merges the ByPts implementation into SourceBufferRange (SBR), makes SBR a concrete type, and updates a multitude of references to SBRByPts to be to SBR. BUG=771349 Change-Id: I0f96ea98733c8f124d616433c2f3e3324f06e9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594277Reviewed-by:
-
Kristi Park authored
Bug: 851335 Change-Id: Ia5e1ca86f1940851337009b923c6259fb5a05676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606766 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#658850}
-
Sergey Ulanov authored
1. Update StructTraits for NativePixmapHandle to allow null vmo handle. VMO handle is set only for NativePixmap instances that can be mapped to memory. 2. Updated the test to set buffer_collection_id as it is required for all NativePixmap's on Fuchsia. 3. Removed gfx_unittests test filter as we no longer need to filter any tests. Bug: 952652 Change-Id: I9882849a302700b411ded0a9e9f4a805d8425c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603542 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#658849}
-
Sergey Ulanov authored
Some targets were already enabled on Fuchsia, but were not in gn_all. This moves them to gn_all Change-Id: I707812fa1394f87fd48e4078fccbef5fc749d028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603882Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#658848}
-
Zentaro Kavanagh authored
- No change to behavior BUG=None TEST=compiles Change-Id: I55d53415dbce1b004fdda015695d3a10b7eb118c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607121Reviewed-by:
-
Ilia Samsonov authored
Fail TestLauncher if disabled tests shares a name with another test. Added unit tests for TestLauncher disabled tests logic. Changed TestResultTracker unit test to better reflect disabled test tags. Changed problematic disabled tests name that caused CQ to fail. DISABLED_BrowserCloseInfiniteBeforeUnload was removed since it is a copy of BrowserCloseInfiniteBeforeUnload. Bug: 961424,960619 Change-Id: I064a6d5c06e5dfccab2e54d2d5e54ff3903e81f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603483 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fd99d6f2..e7fe3e3c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2280b7dbf4ecb518cce5ac6141e94c63e0b5496b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606632Reviewed-by:
-
Kyle Milka authored
This should make things a bit more clear. Choose to use richerPicker_fooBar instead of richerPickerFooBar to stand out more. Bug: 937570 Change-Id: I2db7d65c6d7aaaea424a95511b57bef8b7849ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607220 Commit-Queue: Kyle Milka <kmilka@chromium.org> Auto-Submit: Kyle Milka <kmilka@chromium.org> Reviewed-by:
-
