- 06 Dec, 2014 21 commits
-
-
tengs authored
The new test case reproduces the same stack trace as in the bug, so it's very probable that this case is causing the crash. BUG=435600 Committed: https://crrev.com/9391c0e45bc3ae50008d0aebf11437550e7f38c6 Cr-Commit-Position: refs/heads/master@{#306504} Review URL: https://codereview.chromium.org/754763005 Cr-Commit-Position: refs/heads/master@{#307140}
-
tonyg authored
XP was the only platform that hung last time we tried this and the other platforms sped up considerably. BUG=417812 Review URL: https://codereview.chromium.org/752393005 Cr-Commit-Position: refs/heads/master@{#307139}
-
alexmos authored
This is the first step towards making origin information available for RemoteFrames in Blink. This CL ensures that we pass origin information whenever we create a RemoteFrame, which is currently three cases: 1. New view 2. As part of SwapOut 3. NewFrameProxy message The origins are tracked on FrameTreeNodes in the browser process and updated when frame navigations commit (in NavigatorImpl::DidNavigate). This CL doesn't yet address these issues, to be fixed in later CLs: - situations that will require an explicit "origin update" message, including document.domain changes and certain frame navigations. - iframe sandbox flags - RenderFrameProxies aren't created in all cases (crbug.com/423587) - for now, the origin on the browser side is a url::Origin which doesn't support calls like canAccess. Eventually, we may need to use a richer origin class (like WebSecurityOrigin from Blink). More information: https://docs.google.com/a/chromium.org/document/d/1Y0s76YK0ziiL8hddiFlNUyAF4hqRAGpZM8cfnnLsZPg/edit#heading=h.lrzgurbjttfm The Blink-side of this CL is: https://codereview.chromium.org/520213002/ BUG=426512 Review URL: https://codereview.chromium.org/692973005 Cr-Commit-Position: refs/heads/master@{#307138}
-
gunsch authored
R=wzhong@chromium.org,jar@chromium.org,tsepez@chromium.org,creis@chromium.org BUG=419909 Review URL: https://codereview.chromium.org/730833004 Cr-Commit-Position: refs/heads/master@{#307137}
-
rfevang authored
BUG=419528 Review URL: https://codereview.chromium.org/620453004 Cr-Commit-Position: refs/heads/master@{#307136}
-
afakhry authored
Removing the top_most_at_end parameter which was always set to false and was never used. R=oshima@chromium.org BUG=None Review URL: https://codereview.chromium.org/786513003 Cr-Commit-Position: refs/heads/master@{#307135}
-
brucedawson authored
CompareDelaySeconds takes two bool parameters when it is clearly intended to take two int64 parameters. This was found by VC++'s /analyze which said: src\components\gcm_driver\gcm_driver_desktop_unittest.cc(1067) : warning C6323: Use of arithmetic operator on Boolean type(s). This bug was introduced in: https://codereview.chromium.org/561943002 BUG=427616 Review URL: https://codereview.chromium.org/772383003 Cr-Commit-Position: refs/heads/master@{#307134}
-
nharper authored
BUG=425645 Review URL: https://codereview.chromium.org/778543004 Cr-Commit-Position: refs/heads/master@{#307133}
-
isherman authored
Revert of Make ui::Compositor use ui::Scheduler (patchset #13 id:360001 of https://codereview.chromium.org/638653003/) Reason for revert: This appears to be causing crashes on the Windows perf bots. See the linked bug for a stack trace. BUG=439649 Original issue's description: > Make ui::Compositor use ui::Scheduler > > Taken from enne's CL 535733002 and rebased. It has been taken out of CL 134623005. > > BUG=329552 > > Committed: https://crrev.com/36b7fc7f8b05ea627873e58a162c1c26784e472d > Cr-Commit-Position: refs/heads/master@{#298779} > > Committed: https://crrev.com/b821b71ff0166e250ae4b30b56c1b7b6d3bd5db6 > Cr-Commit-Position: refs/heads/master@{#306954} TBR=ben@chromium.org,danakj@chromium.org,piman@chromium.org,sky@chromium.org,weiliangc@chromium.org NOTREECHECKS=true NOTRY=true BUG=329552 Review URL: https://codereview.chromium.org/784653002 Cr-Commit-Position: refs/heads/master@{#307132}
-
ernstm authored
R=aelias@chromium.org BUG=430702 Review URL: https://codereview.chromium.org/780413003 Cr-Commit-Position: refs/heads/master@{#307131}
-
jbauman authored
Surfaces should be feature-complete, so try enabling them on Windows, Linux, and Mac OS. They're still disabled on Chrome OS because they rely on single-threaded browser compositing, and on Android because they haven't been implemented there yet. BUG=334090 Review URL: https://codereview.chromium.org/756453003 Cr-Commit-Position: refs/heads/master@{#307130}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/c28ac8e..5ae2306 TBR=schenney@chromium.org,dominicc@chromium.org Review URL: https://codereview.chromium.org/753533003 Cr-Commit-Position: refs/heads/master@{#307129}
-
estade authored
It was only by luck that this used to work. After a recent refactoring, the destruction order changed and the AutofillMetrics object no longer outlasts the infobar. AutofillMetrics doesn't need to be an instance object; make the relevant function a static instead. TBR=sgurun@chromium.org BUG=439551, 439620 Review URL: https://codereview.chromium.org/780423002 Cr-Commit-Position: refs/heads/master@{#307128}
-
johannkoenig authored
Remove all remaining obj_int_extract / offset generation: https://codereview.chromium.org/757313004 R=tomfinegan@chromium.org Review URL: https://codereview.chromium.org/779403002 Cr-Commit-Position: refs/heads/master@{#307127}
-
byungchul authored
BUG= TBR=gunsch, lcwu1 Review URL: https://codereview.chromium.org/785663002 Cr-Commit-Position: refs/heads/master@{#307126}
-
xdai authored
BUG=343005 Review URL: https://codereview.chromium.org/772963002 Cr-Commit-Position: refs/heads/master@{#307125}
-
reillyg authored
Instead of re-enumerating all HID devices whenever asked this change registers with Windows to receive window messages whenever a HID device is added or removed. This will allow Chrome to notify apps when devices are connected so that they do not need to poll. BUG=376719 Review URL: https://codereview.chromium.org/783773002 Cr-Commit-Position: refs/heads/master@{#307124}
-
scottmg authored
Includes --dry-run. TBR=dpranke@chromium.org BUG=439591 Review URL: https://codereview.chromium.org/781173002 Cr-Commit-Position: refs/heads/master@{#307123}
-
thestig authored
Review URL: https://codereview.chromium.org/779413002 Cr-Commit-Position: refs/heads/master@{#307122}
-
xhwang authored
BUG=416570 TEST=Existing tests pass. Review URL: https://codereview.chromium.org/785643002 Cr-Commit-Position: refs/heads/master@{#307121}
-
kelvinp authored
When a Remote Assistance session is connected on Chrome OS, the status tray says, "Sharing the control of your screen via Hangouts" even when the user is only using CRD without Hangouts. This change renames the string to "Sharing the control of your screen via Remote Assistance". Remote Assistance is also the name of the Hangouts app, so it would work for both Hangouts and CRD. BUG=439590 Review URL: https://codereview.chromium.org/754873004 Cr-Commit-Position: refs/heads/master@{#307120}
-
- 05 Dec, 2014 19 commits
-
-
samuong authored
BUG=chromedriver:845 Review URL: https://codereview.chromium.org/761963007 Cr-Commit-Position: refs/heads/master@{#307119}
-
andresantoso authored
Now that http://crrev.com/646703002 has landed for awhile, it might be a good time to cleanup workarounds that are no longer needed. We are no longer adding and removing subviews from NSThemeFrame, now we add/remove from the window's full-size content view instead. Also renamed VersionIndependentWindow to FullSizeContentWindow, I think the original name relates to special handling for 10.10 that is no longer the case, we now use full-size content view across all OS versions. Review URL: https://codereview.chromium.org/772263003 Cr-Commit-Position: refs/heads/master@{#307118}
-
sebmarchand authored
BUG=439214 Review URL: https://codereview.chromium.org/783783002 Cr-Commit-Position: refs/heads/master@{#307117}
-
chrishenry authored
Also make startup_url immutable. BUG=439512 Review URL: https://codereview.chromium.org/782033002 Cr-Commit-Position: refs/heads/master@{#307116}
-
sungmann.cho authored
BUG=none Review URL: https://codereview.chromium.org/769153004 Cr-Commit-Position: refs/heads/master@{#307115}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/f02068c..c28ac8e TBR=schenney@chromium.org,dominicc@chromium.org Review URL: https://codereview.chromium.org/781183002 Cr-Commit-Position: refs/heads/master@{#307114}
-
kelvinp authored
This CL enables Remote Assistance on Chrome OS by default. BUG=439582 Review URL: https://codereview.chromium.org/782823002 Cr-Commit-Position: refs/heads/master@{#307113}
-
sandersd authored
BUG=133828 Review URL: https://codereview.chromium.org/780713004 Cr-Commit-Position: refs/heads/master@{#307112}
-
jdduke authored
Create a RenderWidgetHostLatencyTracker that manages all latency-related bookkeeping for the RenderWidgetHost. Review URL: https://codereview.chromium.org/779763002 Cr-Commit-Position: refs/heads/master@{#307111}
-
dtseng authored
Depends on https://codereview.chromium.org/743273002/ This enables ChromeVox to use the new Automation extension API based background page for the chrome of Chrome. TEST=interactive_ui_tests *SpokenFeedbackTest.* Review URL: https://codereview.chromium.org/756713003 Cr-Commit-Position: refs/heads/master@{#307110}
-
vabr authored
It can happen that a website presents multiple forms matching the same PasswordFormManager. Currently, PasswordManager only issues an autofill request for the first such form. This CL makes sure that for all such forms the fill info is sent to the renderer. BUG=435364 Review URL: https://codereview.chromium.org/773823002 Cr-Commit-Position: refs/heads/master@{#307109}
-
xhwang authored
Changes include: - Separate the media app and the renderer_service. In the future, we'll have more services in the same app (e.g. cdm_service). Also, we may need to host the services in Chromium directly (e.g. in the browser process) instead of in a mojo app. - Rename several media/mojo target names for clarity and consistency. BUG=432998 TEST=No functionality change. Review URL: https://codereview.chromium.org/780433005 Cr-Commit-Position: refs/heads/master@{#307108}
-
vabr authored
Currently, when a credential for an IP-specified host is saved in the LoginDatabase, it cannot be retrieved, because it is subjected to the PSL matching check, and that fails for IP addresses. The reason is that IP addresses cannot be PSL matched (there is no subdomain structure to meaningfully match against). This CL makes sure, that PSL matching for IP addresses reduces to identity checking. Also, it makes sute that the LoginDatabase does not even attempt PSL matching on non-HTML forms (PSL matching is not intended for those). BUG=423327 Review URL: https://codereview.chromium.org/779183003 Cr-Commit-Position: refs/heads/master@{#307107}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/ced9010..28f9c60 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=halcanary@google.com Review URL: https://codereview.chromium.org/782063002 Cr-Commit-Position: refs/heads/master@{#307106}
-
reillyg authored
Add an observer list to HidService that is notified when a device is added or removed from the enumeration. This currently works as expected on Linux and OS X while on Windows devices are only enumerated on request and so these are not as useful. BUG=376719 Review URL: https://codereview.chromium.org/779353003 Cr-Commit-Position: refs/heads/master@{#307105}
-
wolenetz authored
This change adds more debug logging to help diagnose issues occurring during completing pending reads of ChunkDemuxerStream. It also includes more logs in SourceBufferStream::GetNextBuffer(). These logs are useful for debugging issues like the referenced bug. R=dalecurtis@chromium.org BUG=423858 Review URL: https://codereview.chromium.org/761963006 Cr-Commit-Position: refs/heads/master@{#307104}
-
sullivan authored
BUG= Review URL: https://codereview.chromium.org/757233006 Cr-Commit-Position: refs/heads/master@{#307103}
-
samuong authored
BUG=chromedriver:980 Review URL: https://codereview.chromium.org/783593003 Cr-Commit-Position: refs/heads/master@{#307102}
-
penghuang authored
In Pepper, glBind*() may generate resource in GPU process, so we have to flush command buffer to make sure the Bind* command is executed by GPU before any future Delete* commands. BUG=437432 Review URL: https://codereview.chromium.org/763383002 Cr-Commit-Position: refs/heads/master@{#307101}
-