- 08 Jan, 2021 40 commits
-
-
Josiah K authored
Currently, when Switch Access captures a switch, it doesn't care which device it comes from. For example, if you have a Bluetooth switch that emulates keyboard keys '1' and '3', those keys will also be intercepted for Switch Access from your built-in Chromebook keyboard. Ideally, we would be able to distinguish between keys depending on the device they come from. Structural code in place at crrev.com/c/2613009. Before: https://screenshot.googleplex.com/7StUsjssf5XqmzG After: https://screenshot.googleplex.com/4EhHjsYdJUqBQ4G Fixed: 1163371 AX-Relnotes: N/A. Change-Id: I610e25bd9057db2ecb7b470e3990ef4a27c0444b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610992 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
Josiah Krutz <josiahk@google.com> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#841708}
-
Ghazale Hosseinabadi authored
This CL documents extension layer's interactions with service worker layer. Bug: 1152530 Change-Id: If66b51440d79400f619ca8b03ae72897976aa813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559213 Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841707}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fa449cf3b0d0..038ae1448ac1 2021-01-08 jmadill@chromium.org Vulkan: Fix up varying component limits. 2021-01-08 jmadill@chromium.org Program: Move more common code to ProgramLinkedResources. 2021-01-08 m.maiya@samsung.com Vulkan: Add GL_EXT_clip_control entry points If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I0c97a36e0c136aa7a38e91a3a616f55576ee2bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618598Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841706}
-
Simon Pelchat authored
Bug: 1163983 Change-Id: Ic16c8a3015d29df741fbd50b4496205255bc5512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618541 Commit-Queue: Simon Pelchat <spelchat@chromium.org> Auto-Submit: Simon Pelchat <spelchat@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#841705}
-
Adam Langley authored
This root may now be used by Google. Change-Id: I7ad0c8348a21cfa1f00ea4d1bdfa0360f6cace52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618543 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#841704}
-
Daniel Cheng authored
As of https://crrev.com/c/1684998, FrameLoader::Init() no longer calls FrameLoader::DetachDocument(). Since this was the only case where the Document and DocumentLoader could be null, FrameLoader::DetachDocument() no longer needs to handle this case. Bug: 855189 Change-Id: I10fe2b6ecc6765e73675676dda72c666401b5f9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617001 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#841703}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/59450acba8d5..3be8a6b93877 2021-01-08 cjamcl@chromium.org [Lighthouse] Avoid reprocessing the same Network events. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I490d59fe08c542767939335720fe41f8de3fe02f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618599Reviewed-by:
-
Xianzhu Wang authored
1. Move the code checking requirement of overflow clip for printing from PaintPropertyTreeBuilder into LocalFrame::ClipsContent(). 2. Combine LocalFrameView::ClipPaintRect() into LayoutView::ViewRect(), so that all code paths calling ViewRect() (e.g. LayoutView::OverflowClipRect()) can be dev tool viewport overriding aware. This means that the overriding viewport is reflected in the paint property tree, and CompositedLayerMapping::RecomputeInterestRect() no longer needs to apply the viewport clip separately. Change-Id: Ib743a891e4d4fc0749ff799a04ed0f09757e9f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613388Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841701}
-
Mingjing Zhang authored
This CL checks if the |history_service| is valid before it is used to build a DomainDiversityReporter. This is a guard against unexpected crashes in DomainDiversityReporter which always requires a valid history service. Bug: 1161727 Change-Id: Ie946abe755f7a32bf7b7173e3b146326459edcf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611668Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#841700}
-
rbpotter authored
Bug: 1132403 Change-Id: Ia48978c88c7c4c04172ed7fc64a187cb4af37427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616880Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#841699}
-
rbpotter authored
Add js_library targets for: model_settings_availability_test model_settings_policy_test model_test Bug: 1000989 Change-Id: Ida87d1c829e06fb3026f8251d7fe5c36012a3d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617214Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2a735ba1cb32..00e43df25bea 2021-01-08 mtklein@google.com rename Arg to Ptr 2021-01-08 mtklein@google.com a little more unused code cleanup 2021-01-08 mtklein@google.com SkCanvas::makeSurface() can fail 2021-01-08 johnstiles@google.com Remove unused context argument from compareConstant. 2021-01-08 reed@google.com Actually abort playback on error 2021-01-08 bungeman@google.com Make SkBase64 interface less unpleasant. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: Iad3bd573742b00244048ed604da0b019d81514b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618095Reviewed-by:
-
Richard Townsend authored
This test was flaky because occasionally one or more paint events were included in the Performance API data. The check's been relaxed to remove the intermittent failure. Bug: 901056, 1164166, 1160655 Change-Id: I1fc89ad1cd60bd326b1516ae6b93814f10922b30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618483 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#841696}
-
Kyle Horimoto authored
This metric records one bucket when a connection is accepted and another bucket when a WebRTC upgrade occurs, as a measure of the effectiveness of WebRTC upgrades. If these buckets have equal counts, this means that WebRTC upgrades occurred 100% of the time. However, WebRTC upgrades are not instantaneous; the median upgrade time is ~5s, and the 95th percentile is 30s. For short-lived connections, we don't provide enough time for the connection to upgrade, so this shouldn't really be counted as a "failure" to upgrade. If a connection disconnects in under 30s, we now log to a new bucket indicating that the connection disconnected before 30s was up. This will help us measure a more accurate success rate for WebRTC upgrades. Bug: 1163779, 1106937 Change-Id: I135820c6541e96818cced0e91719a591ec1510d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617304 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#841695}
-
Hui Yingst authored
This CL migrates `plugin_size_`, `plugin_dip_size_` and `plugin_offset_` from OutOfProcessInstance to PdfViewPluginBase, and provides accessors and mutators for them, so that these members can be used by both PdfViewWebPlugin and OutOfProcessInstance. Bug: 1140629 Change-Id: I0c3e2e6fa46233eab8e3b25b0d6101c6a557f80e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616732 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#841694}
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/a86dded0f15e..a4e3a5aaf64c 2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from ebd3ea2ecbac to 04cf3fd95555 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com Change-Id: I8aedb8797f2d773d5a0ab93fc9d2426ffb6e9941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618094Reviewed-by:
-
Eric Orth authored
Remove all the old UMAs. They're all expir(ing/ed) and nobody is looking at them anymore. Also remove various result codes in favor of simple boolean success returns. The more specific results were only used for the now-removed UMAs. Bug: 1157492,972782,809675 Change-Id: Id210715285bfc601ae664158f820769676dd270e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611964 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Toni Barzic authored
Resets current holding space model before calling holding space detached, so HoldingSpaceController::Get()->model() can be used test whether a model is currently attached from the observer method. Also, updates HoldingSpaceTray to cancel previews update when previews icon gets hidden. BUG=1164145 Change-Id: I1f0b50cc52c5b348b0e034e65751b9a0047bd096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618093Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841691}
-
Tanya Gupta authored
Bug: 1153969 Change-Id: Ib4310ee117e1833f02a78cf93f802c434428b423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599444Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#841690}
-
dpapad authored
CardSlider and TouchHandler are not used anywhere else, therefore there is no need to reside in shared WebUI code. Moreover, since those files are inlined with flattenhtml=true, there was no need to include and serve them separately as stand-alone files. Bug: None Change-Id: I482b4ef71a1f80025c16568e62e5681085d2e981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616971 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#841689}
-
Michael Lippautz authored
Similar to WTF, refactor collections into their own files, allowing for IWYU but also simplifying the library transition as these data structures should work with the Blink and the library implementation. Blink users include `heap_allocator.h` to get the data structures and not HeapAllocator. HeapAllocator is now provided through `heap_allocator_impl.h` which is pulled in by the corresponding data structures. We cannot work with forward declarations of HeapAllocator, as WTF doesn't work solely on the type but on Allocator::kIsGarbageCollected. Bug: 1056170 Change-Id: I1e6f0a481b2e332b0299a6487c41b6b1112f355b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616561 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#841688}
-
Scott Lee authored
There are only 3 builders, running local gtests. - chromium.fyi.Win 10 Fast Ring - chromium.linux.Cast Audio Linux - chromium.linux.Cast Linux The LocalGTest steps with rdb on the FYI builder have been running successfully, and the two other builders have been tested with LED builds. Bug: 1084332 Change-Id: I17e39d855b4d306ccb68b02cfb05626cc0a030d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618522 Commit-Queue: Scott Lee <ddoman@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#841687}
-
Ted Meyer authored
There were three uses of NotifyError(std::string) that should have been using NotifyError(media::Status). It was causing decode errors to show up with the initialization error code. Also added the VDA error number to the log, if it is a decode error. It'll usually be 4 though. This doesn't actually fix the issue where the video isn't decoding, it just makes the debugging situation much easier. Bug: 1164463 Change-Id: I399898e3b2ca02ade3ef5a0f8c4e2a0af87d722a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618526 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#841686}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610107094-52dce87c233c024b300dbf806becfa12ff1bc3d4.profdata to chrome-win64-master-1610128749-54768dc60943741e5d54665b25111b4653768898.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I050090f068f3949e1c880eeeec9070456b97c72c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617047Reviewed-by:
-
Clark DuVall authored
This seems to be flaky on TSan builds when set_default_result is called from SetUpOnMainThread(). This should prevent calling it in this case. Bug: 1159734 Change-Id: Id08167574874af6bb7aab5dd03df6622d062b7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618393 Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#841684}
-
John Delaney authored
What: Add a new param to window.open to register an impression for the conversion measurement API. See https://github.com/WICG/conversion-measurement-api/blob/master/README.md#registering-impressions-for-windowopen-navigations for details. Why: Lots of ads perform navigations via JS, making the anchor tag conversion API difficult to integrate into existing techstacks. Note that origin trial features cannot control IDL function overloads per https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/bindings/scripts/v8_interface.py;l=1099?q=v8_interface.py&ss=chromium%2Fchromium%2Fsrc Bug: 1154096 Change-Id: Ib84bbd224262d35ffde357b01448670f0ae37933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566343 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#841683}
-
Aleks Totic authored
nodesFromRect returned table elements in an incorrect order in legacy table code. Test was modified to expect elements in correct order. It now passes in TablesNG. Change-Id: Ibdd1aef2b0fe5636c2bf8d560a7590acc463818d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616945Reviewed-by:
-
Simeon Vincent authored
Change-Id: I107736901fddf919bb7cd61c08488f4fd79003e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618579Reviewed-by:
-
Jarryd authored
* Add a method that will take the set difference of the test case file and the ignored test file. * Add support for per-platform ignore files. Bug: 1145240 Change-Id: I9c28d6f1fb82a6b13fcd0c9fae738c9aff0bd630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599831 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#841680}
-
Lukasz Anforowicz authored
This CL adds an AbstractOriginTest test suite that covers both blink::SecurityOrigin and url::Origin. Having tests that are shared across Blink and //url will help 1) avoid code duplication and 2) ensure that Blink and //url behave in the same way (at least wrt things covered by the shared tests). Bug: 1164416 Change-Id: I1a4ecb32eba4d31ca07328a43f4392586588aca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606715 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#841679}
-
Michael Crouse authored
This change provides the file for the language detection model needed in the TranslateAgent. Bug: 1151422 Change-Id: I24870758adf8b00ee378ca7ccc55bd45edb164d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599580Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Trevor Perrier <perrier@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#841678}
-
Jeroen Dhollander authored
This is a reland of ccba8bc4 The problem was that the fixes for the review comments had caused us to call AudioDevices::SetAudioDevices() before the constructor of |AudioDevices| had finished initializing all variables. Unfortunately this only happened on real hardware, and I had not retested these review comment fixes on hardware. Original change's description: > Consolidate interactions with |CrasAudioHandler|. > > Previously 2 places in the code were interacting with |CrasAudioHandler|: > - |PlatformApiImpl| subscribes to device changes, and passes this > information to |AudioInputHost|. > - |AudioInputHost| posts the new hotword model to |CrasAudioHandler|. > > This made it hard/impossible to split |AudioInputHost| from > |PlatformApiImpl|, which is needed to handle audio input in the > Libassistant mojom service. > > To solve this I moved all interactions with |CrasAudioHandler| inside a > new class |AudioDevices|, of which an instance is owned by > |AudioInputHost|. > > This also allowed me to add a bunch of new unittests. > > deployed on real hardware. > > Bug: b/171748795 > Test: chromeos_unittests --gtest_filter="Assistant*:Audio*" and manually > Change-Id: I8ec9cec6672236f6365345b292efbe828518be69 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610953 > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841155} Bug: b/171748795 Change-Id: I9b8b970fbd1011ce911bf99961159805a4c0d2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617568 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841677}
-
Michael Lippautz authored
Bug: 1056170 Change-Id: Ib9f1b70a8ccb2dd8a026981f4be6751b97cbd528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617922 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Aya ElAttar authored
- Changed the return type of DragDropDelegate::OnDragUpdated to return a struct of DragOperation and DataTransferEndpoint. - The returned DataTransferEndpoint should be used in DragDropController for allowing/disallowing dropping the data according to the policy rules, See crrev.com/c/2595382. Bug: 1139886 Change-Id: Ic80f2d55bf1df350d24778f01a43c8cba0ff67cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595411 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#841675}
-
Josh Nohle authored
Previously, callbacks passed into SecureMessage delegate methods were being forwarded directly to the EasyUnlock dbus service, which the delegate does not own. So, these callbacks can still be invoked after the SecureMessage delegate object is destroyed. In this CL, we bind callbacks sent to the dbus client to weak pointers. This ensures that consumers of the SecureMessage delegate will not have their callbacks invoked after the delegate is destroyed. Manually tested CryptAuth Enrollment, DeviceSync, and SmartLock flows. Fixed: 1163335 Change-Id: I69b24c675808312d4310f37ac830c7326c971275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616944 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#841674}
-
Hui Yingst authored
This CL migrates `plugin_size_`, `plugin_dip_size_` and `plugin_offset_` in OutOfProcessInstance from using pp::Point/pp::Size to their gfx:: equivalents, so that they can be migrated into PdfViewPluginBase later. Bug: 1101101 Change-Id: I5c36d6fcb99f9f4f92edeeb044fd6f2f04287565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616488Reviewed-by:
-
Xinghui Lu authored
As we add more fields into the proto, we'd like to monitor the network usage of real time URL check. Metrics added: SafeBrowsing.RT.Request.Size Bug: 1161342 Change-Id: I3bafe5bf7c8a2724d3c75adb2af869702a2db4be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617575Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841672}
-
Joel Riley authored
AX-Relnotes: N/A Bug: 1163684 Change-Id: Ief0ce745ba348f6ad374d6ecf1ca088ffa59ef52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616520Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Joel Riley <joelriley@google.com> Cr-Commit-Position: refs/heads/master@{#841671}
-
Brandon Wylie authored
TBR=meiliang@chromium.org Bug: 11644850 Change-Id: Ie1965d1b608f179864430516a5c370e6ccd20204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618553 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841670}
-
David Black authored
Per UX request, restoring slight elevation to holding space tray icon previews to add depth and dilineation. This CL also makes a slight tweak to shrinking of white backgrounds that was done to prevent paint artifacts from showing behind images. Previously we shrunk backgrounds by twice as much as was necessary. Bug: 1163304 Change-Id: I1b65bb65de3e331f2e58c2993fe1634d5dabcb98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618560Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#841669}
-
