- 26 Jan, 2016 12 commits
-
-
rnephew authored
BUG=581159 Review URL: https://codereview.chromium.org/1635763002 Cr-Commit-Position: refs/heads/master@{#371362}
-
dzhioev authored
* Updated README.chromium. * Suppressed non-zero exit status of some commands in reproduce.sh (this caused premature exit). * Added script which generates a short summary of presenting components. Presubmit complains about removed copy of README.chromium, that is why NOPRESUBMIT is set. BUG=none NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1623693002 Cr-Commit-Position: refs/heads/master@{#371361}
-
haraken authored
BUG=581203 TBR=dstockwell@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1632103002 Cr-Commit-Position: refs/heads/master@{#371360}
-
robpercival authored
- Use uint64_t in place of size_t where we need to guarantee 64-bit integers. - Minor formatting and diagnostic improvements. - Extracted timestamp decoding into its own function, ReadTimeSinceEpoch. This will be used more in future code. BUG=506227 Review URL: https://codereview.chromium.org/1575543002 Cr-Commit-Position: refs/heads/master@{#371359}
-
jdufault authored
BUG=532545 Review URL: https://codereview.chromium.org/1623603002 Cr-Commit-Position: refs/heads/master@{#371358}
-
jkarlin authored
There is only one periodicity now, refer to it as a registration instead of a one-shot registration. If we add periodic back in the future we can refer to those as periodic registrations. * Remove power monitor: https://codereview.chromium.org/1617063002/ * Remove periodic code: https://codereview.chromium.org/1614063002/ * Remove mention of one-shot: https://codereview.chromium.org/1613053004/ BUG=552031 Review URL: https://codereview.chromium.org/1613053004 Cr-Commit-Position: refs/heads/master@{#371357}
-
ianwen authored
There are times where the doodle server sends PNG instead of GIFs in the url field of image data. This will make BaseGifDrawable to think that its content is not valid and thus we will always try to download the valid PNG again on click. This behavior is corrected by this CL. BUG=580624 Review URL: https://codereview.chromium.org/1634843002 Cr-Commit-Position: refs/heads/master@{#371356}
-
primiano authored
After crrev.com/1584893002 base/ can use directly allocator. The grand plan is to dismantle all the indirection layer such that: - base is the only thing that knows about allocator-specific details. - non-base code uses only base abstractions and stops looking at USE_TCMALLOC build flags. This CL specifically deals with tc_malloc_skip_handler and tc_set_new_mode and removes the unnecessary base -> content -> base hops. BUG=564618 Review URL: https://codereview.chromium.org/1610153002 Cr-Commit-Position: refs/heads/master@{#371355}
-
wfh authored
These tests made invalid assumptions about the WOW64 virtualization state and were partially disabled. Now they all pass on all platforms. BUG=580800,6944 Review URL: https://codereview.chromium.org/1624083003 Cr-Commit-Position: refs/heads/master@{#371354}
-
donnd authored
At least one test that relies on counters was flaky because counters were not being consistently reset for testing. The counter resetting code was inexplicably calling code to update counters as if an open action had occurred (removed). This change may fix other flaky tests. Update the test code to just reset all preferences instead of trying to remember to add reset code when adding a new counter. Fixes testLongPressShowsPeekPromo. BUG=540820,569123 Review URL: https://codereview.chromium.org/1517883003 Cr-Commit-Position: refs/heads/master@{#371353}
-
zmo authored
BUG=429053 TEST=gpu_unitests R=vmiura@chromium.org Review URL: https://codereview.chromium.org/1625573003 Cr-Commit-Position: refs/heads/master@{#371352}
-
tommi authored
BUG=549021 Review URL: https://codereview.chromium.org/1621313002 Cr-Commit-Position: refs/heads/master@{#371351}
-
- 25 Jan, 2016 28 commits
-
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/02cb4d469a2a..7869bbff26b7 $ git log 02cb4d469..7869bbff2 --date=short --no-merges --format='%ad %ae %s' 2016-01-25 msarett Fix gyp files so that gyp_to_Android.mk succeeds 2016-01-25 robertphillips Fix memory leak in pixelxorxfermode GM GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1633773002 2016-01-25 iroth Changes to public.bzl to support building on iOS with objc_library bazel target. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=msarett@google.com Review URL: https://codereview.chromium.org/1637543003 Cr-Commit-Position: refs/heads/master@{#371350}
-
lukasza authored
Previous CL (crrev.com/1484093002) made it possible to save contents of all frames - even if some of them have the same URI, they still get saved into separate files / SaveItems. This CL makes sure that we rewrite links in a html document, based on frame identity if possible (rather than always doing the rewriting based on the uri): - SaveItem now stores a frame_tree_node_id that can be potentially used (if the SaveItem is for a frame rather than for a savable resource) as a key in the map into the local paths. - WebFrameSerializerImpl now rewrites link uris based on 2 maps (url -> local path map as well as frame -> local path map). BUG=106364, 106158, 538188 Review URL: https://codereview.chromium.org/1502563004 Cr-Commit-Position: refs/heads/master@{#371349}
-
mathp authored
Trim whitespace and remove stop chars. BUG=580679 TEST=AutofillManagerTest Review URL: https://codereview.chromium.org/1627843002 Cr-Commit-Position: refs/heads/master@{#371348}
-
nharper authored
Adds a new method to SSLClientSocket to get the Token Binding from an SSL connection where Token Binding was negotiated, and uses that to add the Set-Token-Binding HTTP header (only when Token Binding was negotiated). BUG=467312 Review URL: https://codereview.chromium.org/1378613004 Cr-Commit-Position: refs/heads/master@{#371347}
-
jbudorick authored
Revert of add remaining unittests to new android bots (patchset #2 id:20001 of https://codereview.chromium.org/1633713002/ ) Reason for revert: isolate paths aren't quite right, e.g. https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/2236/steps/base_unittests/logs/stdio Original issue's description: > add remaining unittests to new android bots > > BUG=514857 > > Committed: https://crrev.com/3476f7c84c16ed45a8404f491fab9fb4691bda5f > Cr-Commit-Position: refs/heads/master@{#371331} TBR=martiniss@chromium.org,bpastene@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=514857 Review URL: https://codereview.chromium.org/1639603002 Cr-Commit-Position: refs/heads/master@{#371346}
-
fmalita authored
The SkPath API supports all SVG path verbs, so there's no need to normalize paths when converting to the Skia representation. Switch buildPathFromString() and buildPathFromByteStream() to unaltered parsing, and expand SVGPathBuilder to handle the full path vocabulary. This yields a more natural verb conversion (arcTo, in particular, is no longer decomposed into cubics), with correctness and perf implications. BUG=453040 R=fs@opera.com,caryclark@google.com Review URL: https://codereview.chromium.org/1623073003 Cr-Commit-Position: refs/heads/master@{#371345}
-
asvitkine authored
It seems the issue is caused by the button being drawn into a layer early on and being cached. Adding a -setNeedsDisplay: when we actually determine whether it should be visible fixes the problem - so that the first actual paint to the screen has the correct appearance. I'm not sure why Cocoa draws it to a layer earlier than this (this doesn't happen for other buttons), nor why it's background color is black when that happens. However, this change does fix the bad appearance. BUG=563395 Review URL: https://codereview.chromium.org/1630453002 Cr-Commit-Position: refs/heads/master@{#371344}
-
apacible authored
Currently, shownComponentsChanged_() assumes the first run flow has been stamped before getting the offsetHeight. This is not always the case if the first run flow has already been acknowledged but the current view of the media-router-container is modified. Review URL: https://codereview.chromium.org/1615633002 Cr-Commit-Position: refs/heads/master@{#371343}
-
yawano authored
BUG=533750 TEST=build passes Review URL: https://codereview.chromium.org/1606013005 Cr-Commit-Position: refs/heads/master@{#371342}
-
sigbjornf authored
Until Oilpan is firmly enabled, always use GeolocationControllerPrivate to wrap up the non-owned GeolocationController* object. The previous implementation was performing an untidy downcast with undefined behavior; no need for such shortcuts here. R= BUG=581112 Review URL: https://codereview.chromium.org/1638573002 Cr-Commit-Position: refs/heads/master@{#371341}
-
xidachen authored
Now that we have 3 LGTMs for ImageBitmap and createImageBitmap to ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/jRzvehX9U1U/discussion, let's ship it and expose it to larger audience! This CL removes the Runtime flag in ImageBitmapFactories.idl and updates some global interface layout tests results. BUG=249384 Review URL: https://codereview.chromium.org/1636633002 Cr-Commit-Position: refs/heads/master@{#371340}
-
oshima authored
BUG=493167,504885,581105 TBR=dpranke@chromium.org, georgesak@chromium.org Review URL: https://codereview.chromium.org/1635673002 Cr-Commit-Position: refs/heads/master@{#371339}
-
kcwu authored
content/ incorrectly depends on components/arc. Revert first before work out how to fix it properly. This reverts commit daa96926. BUG=b/25057601 TBR=holte Review URL: https://codereview.chromium.org/1634443002 Cr-Commit-Position: refs/heads/master@{#371338}
-
pfeldman authored
Review URL: https://codereview.chromium.org/1577153002 Cr-Commit-Position: refs/heads/master@{#371337}
-
creis authored
This will log a crash dump without crashing the browser process, letting us see how a params object is unexpectedly created with both a main frame routing ID and a proxy routing ID. BUG=575245 TEST=Crash dumps in RenderViewHostImpl::CreateRenderView. Review URL: https://codereview.chromium.org/1624413002 Cr-Commit-Position: refs/heads/master@{#371336}
-
primiano authored
After crrev.com/1584893002 base/ can use directly allocator. The grand plan is to dismantle all the indirection layer such that: - base is the only thing that knows about allocator-specific details. - non-base code uses only base abstractions and stops looking at USE_TCMALLOC build flags. This CL, specifically, addresses the profiling-related methods moving the tcmalloc-specific dependencies to base and base only. Other parts of the codebase will be cleaned up in separate CLs. Also this CL removes a stale base/debug/OWNERS. That file makes no sense these days as tracing has been moved to base/trace_event/. BUG=564618 Review URL: https://codereview.chromium.org/1607303002 Cr-Commit-Position: refs/heads/master@{#371335}
-
eranm authored
Revert "Revert of CT Verify test utilities change - Moved the following common functions (patchset #1 id:1 of https://codereview.chromium.org/1498983004/ )" This reverts commit 13cb74df. BUG=568282 Review URL: https://codereview.chromium.org/1639483002 Cr-Commit-Position: refs/heads/master@{#371334}
-
tapted authored
Revert of Remove Metro mode avatar/profile switcher assets (patchset #2 id:20001 of https://codereview.chromium.org/1605243002/ ) Reason for revert: Broke Win10 BUG=581097 Original issue's description: > Remove Metro mode avatar/profile switcher assets > > BUG=558054 > > Committed: https://crrev.com/327f4816de86c9408c8638e9c91add65424affd3 > Cr-Commit-Position: refs/heads/master@{#370906} TBR=msw@chromium.org,oshima@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=558054 Review URL: https://codereview.chromium.org/1631973002 Cr-Commit-Position: refs/heads/master@{#371333}
-
boliu authored
Follow up to r369480. Use the main frame routing number for setting background color IPC. BUG=580765 Review URL: https://codereview.chromium.org/1622913002 Cr-Commit-Position: refs/heads/master@{#371332}
-
bpastene authored
BUG=514857 Review URL: https://codereview.chromium.org/1633713002 Cr-Commit-Position: refs/heads/master@{#371331}
-
oshima authored
Revert of Enable handle verifier for tests and add some tests. (patchset #7 id:120001 of https://codereview.chromium.org/1580873003/ ) Reason for revert: A lot of test are crashing on DrMemory x64 bot, so I'm reverting this speculatively. I'll reland this if it didn't help. Original issue's description: > Enable handle verifier for tests and add some tests. > > BUG=571304 > > Committed: https://crrev.com/ff6cc3d794e1285c68f74ec9ae6d59dc3e523d5b > Cr-Commit-Position: refs/heads/master@{#371075} TBR=cpu@chromium.org,wfh@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=571304,580795 Review URL: https://codereview.chromium.org/1633623003 Cr-Commit-Position: refs/heads/master@{#371330}
-
davidben authored
We can assume the system verifier handles both SHA-256 and ECDSA now. No need to inject SHA-256 support or disable ECDSA ciphers. BUG=554410 Review URL: https://codereview.chromium.org/1610833004 Cr-Commit-Position: refs/heads/master@{#371329}
-
ianwen authored
When there is no logo, the server sends out a json with an empty update field. This is not the same as what we conjectured when the UMA for logo was recorded. This CL fixes it. BUG=543308 Review URL: https://codereview.chromium.org/1618043002 Cr-Commit-Position: refs/heads/master@{#371328}
-
ianwen authored
There can be race cases where a deleted bookmark is opened in edit activity. This CL prevents such crashes from happening. This CL also shortens an unnecessarily long variable name. BUG=574680 Review URL: https://codereview.chromium.org/1630893002 Cr-Commit-Position: refs/heads/master@{#371327}
-
jbudorick authored
BUG= Review URL: https://codereview.chromium.org/1630953002 Cr-Commit-Position: refs/heads/master@{#371326}
-
mdjones authored
When the OverlayPanel is only using two states, the amount of swipe it takes to move from one panel state to another is excessive. This change allows adjustment of how sensitive the panels are to a swipe. BUG=565585 Review URL: https://codereview.chromium.org/1614953004 Cr-Commit-Position: refs/heads/master@{#371325}
-
liberato authored
If the GVD tears down AVDA before Initialize is called on the strategy, usually due to an unsupported format, then the deferred rendering backing strategy would access |shared_state_| before it was initialized. It now detects this, and skips all cleanup if Initialize wasn't ever called. BUG=580335 Review URL: https://codereview.chromium.org/1632793002 Cr-Commit-Position: refs/heads/master@{#371324}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/72f5bd6b1981..de5b559df615 $ git log 72f5bd6b1..de5b559df --date=short --no-merges --format='%ad %ae %s' CQ_INCLUDE_TRYBOTS= TBR=catapult-sheriff@chromium.org Review URL: https://codereview.chromium.org/1632843002 Cr-Commit-Position: refs/heads/master@{#371323}
-