- 16 Sep, 2020 40 commits
-
-
Benoit Lize authored
On some platforms, the OOM path calls free(), which deadlocks as a consequence, since we are holding the lock from this path. Release it before OOM. Bug: 998048 Change-Id: I6aec2b8aa7e4ce64f2b9754284ec8c42ee2bdc2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410872Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#807371}
-
Jing Wang authored
Now we can independently enable/disable each type, which is useful when we rollout personal info experiment in stable. Bug: 1042084 Change-Id: I2e355fa2fb00fddc2bb94cf66e5056153c205abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409684Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#807370}
-
dpapad authored
In some cases, like the FilesApp which is served from a chrome-extension:// scheme, converting all chrome:// URLs to scheme-relative URLs is not desired. Adding a |preserve_url_scheme| to opt-out of the default behavior. Bug: 1128313 Change-Id: I48fe8fda4320d8ff3eaca35229c8c34cd55407de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411563Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#807369}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4108364efc3f..2610e8261e9e 2020-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 183a454b9d54 to 4d3a0f602852 (29 revisions) 2020-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2c970cbe to da6c6f8f (442 revisions) 2020-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0f14b7ab7a55 to b33e0b36a08c (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Test: Test: Test: Manual verificationTest: Test: Manual verification in AOSP checkoutTest: Test: dEQP-GLES3.functional.fbo.invalidate.*.unbind_blit_msaa_* Change-Id: I027d75e4f630f25429c41c2e67ae031fec28a93b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413392Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807368}
-
Morten Stenshorne authored
We were setting the *position* of the column row after a spanner correctly, but the *size* was wrong, if there was a trailing spanner margin. Just update the layout position up front when entering layout of a column row, which simplifies the code and fixes bugs. Bug: 829028 Change-Id: I473ff1fe43da3b8b852a0a2f199c7537d7bfc3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410242Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#807367}
-
Gyuyoung Kim authored
As the second step to convert ViewMsg_UpdateWebPreferences to Mojo, this CL moves needed methods from content::RenderViewImpl to blink::WebView because they will be called by UpdatePreferences() Mojo implementation method in the following CL. - Move ApplyWebPreferences() to Blink. - Rename Get|SetWebkitPreferences() to Get|SetBlinkPreferences(). - Remove |webkit_preferences_| variable in RenderViewImpl. - Remove webkit_preferences(), then start to use GetBlinkPreferences(). - Move needed content switches to Blink. Bug: 1097943 Change-Id: Ifff24d84c3dbcd8abceaf4ece8a03f2c17b28d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409887 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807366}
-
Morten Stenshorne authored
We were resolving the block-size of column content against the columns, but that's only correct if the column happens to take up all the space in a multicol container (which typically ISN'T the case when there are column spanners, or when a lone column row is balanced to use less space than what's specified on the multicol container). So, resolve percentage block-size against the computed content-box block-size of the multicol container (not the columns). Also provide the correct percentage resolution size in the initial column balancing pass. This doesn't really do much for correctness, since the column stretching machinery will eventually give us the right column size, but this will hopefully give a better initial size guess, so that we don't have to stretch and re-lay out as many times as we would have without this change. Some work left to do (TODO added) for OOF descendants. No intended behavior changes there for now. Bug: 829028 Change-Id: Iddc5b1f53ca375a05768385bab35ce2215c2ccbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412728Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
-
Alex Rudenko authored
The test was disabled in https://crrev.com/c/2403560 and it can be enabled now becaused DevTools has been rolled. Bug: 1125357 Change-Id: Ic09d1bc8437ad6c1a5efc80a58867fee79eb956b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413250Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#807364}
-
Alan Screen authored
Interactions with print drivers via operating system APIs is being moved from out of the highly privileged browser process into a sandboxed utility service process. Changes to support rolling this update out will be guarded behind a feature flag "enable-oop-print-drivers". This feature is currently only applicable for desktop operating systems. Bug: 809738 Change-Id: I938df469b6108a7b5a8dd9d5e0225d12bbe1f6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412449Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#807363}
-
Eugene But authored
Chrome for iOS bots no longer run perf tests Bug: 978949 Change-Id: I3f45e349a3c9605716fb6e230bf6fa10fb67a20f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411477 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807362}
-
Frédéric Wang authored
This CL disables multicol for MathML, since it has been causing issue and is not needed for math layout. This is consistent with flexbox, grid, table or custom layout for example. In particular, this fixes an assertion failure when multicol is used on MathML token elements. Bug: 6606, 1128267 Change-Id: I9bb365b7af25e11b994dfc8f2470b3fa4ea2adeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410131Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#807361}
-
Glen Robertson authored
This is a reland of 93d899e2 OCL incorrectly added a dep on telemetry in official build. TBR=dpranke@google.com,blundell@chromium.org,dominickn@chromium.org,ericorth@chromium.org Original change's description: > Enable `gn check` on //chrome/browser. > > Changes are: > - adding deps when missing. > - adding "nogncheck" when needed (see below explanation). > - deleting nonexistent files from sources. > - new target :net_dns_access for files that depend on > //net/dns:host_resolver (which has restricted visibility). > Alternative: could open visibility to all of //chrome/browser instead > of adding a new target that has visibility. > - moving //c/b:test_support sources to //c/b/chromeos:test_support or > //c/test:test_support when they depended on headers there (cannot > add a dependency, there is a cycle). > - moving includes to conditional sections when they are used only in > conditional sections (where it caused deps issues). > - removing unused includes of test code from non-test code. > - merging sections in //c/b/BUILD.gn that had the same if() conditions. > Alternative: revert these changes, they are cosmetic. > - adding some asserts/conditional blocks in build files that only work > under those conditions. > > "gn check" does not understand #if statements in cc/h files so it > complains about missing deps in configurations where those deps were > never actually included. "nogncheck" has been added to the include lines > to suppress these spurious errors where necessary (sometimes it is not > necessary because the include is used outside of #if statements in other > files). > > Bug: 898837, 1125897 > Change-Id: I77e7dd3780fb93edb2b555a82b681a870990b496 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383400 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Eric Orth <ericorth@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Glen Robertson <glenrob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807321} Bug: 898837 Bug: 1125897 Change-Id: If1dc6009b640c0b6ae33b1455b6ccf27c1cf274b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413427Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#807360}
-
Darwin Huang authored
This allows us to avoid an unnecessary and repetitive translation layer in ClipboardAndroid, between ClipboardFormatType and std::string. Bug: 1123230 Change-Id: Idd749fba9bbe13c9e5e13aa0f4ea6d93d7f74b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383112Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807359}
-
Alan Cutter authored
This CL adds two fields to the default web app config JSON: - load_and_await_service_worker_registration: bool - service_worker_install_url: URL string These allow default apps to control their service worker registration behaviour during the install flow. Bug: 1123435 Change-Id: Id389c347066a8dbcaa2c2350b884cdb5872e5721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409057 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I18cab16dfca1199c8d6d6cdbb6ca351866a511a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413390Reviewed-by:
-
Jarryd authored
There have been a number of reports about the storage pressure notification being shown, even when there is an absence of storage pressure. This is due to a numerical precision issue, where division of two ints would almost always return 0. This 0 meant that a condition that checked for storage pressure would always pass, and QuotaManger would fire storage pressure notifications for all write errors, regardless of disk availability. This change removes the division operation entirely with a little trick: - Given percent_available = 100 * available_space / total, - percent_available < kStoragePressureThresholdRatio is equivalent to (substitution): - 100 * available_space / total < kStoragePressureThresholdRatio is equivalent to (multiply both sides by total): - 100 * available_space < kStoragePressureThresholdRatio * total TBR=pwnall@chromium.org Bug: 1127237 Change-Id: I79c5ff47f27824d25ff8e47dc4aed859c8d3cd7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412758Reviewed-by:Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#807356}
-
Jimmy Gong authored
Bug: 1106937 Change-Id: I51abad3789200555295b284d5823bdccfbffb11f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413173Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#807355}
-
John Chen authored
All builds on MacOS are failing on perf waterfall due to Widevine signature errors. Adding a quick workaround with gn flag enable_widevine_cdm_host_verification=false, as suggested by the error message. TBR=wenbinzhang@google.com Bug: 1128811 Change-Id: Iffa58fe5ff0676e185b8cb381268d28482011172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412934Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#807354}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3e72b3ff8ca7..4108364efc3f 2020-09-16 mtklein@google.com _mm256_blendv_epi8 needs avx2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: Ide1b54be351734e9c1d491030cab00e2ec9e431a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413389Reviewed-by:
-
Yoichi Osato authored
This reverts commit ad63f7bc. Reason for revert: Causes many CRASHes: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/18398#overview-tab Original change's description: > [XProto] Obtain Xcursor path from libXcursor > > Some distros (eg. Gentoo) use a non-default libXcursor path, so the > path (which was previously hardcoded) must now be obtained from > libXcursor. This patch uses dlopen()/dlsym() to get the path when > available. > > BUG=1127712 > R=sky > > Change-Id: Ib99dff0448c521c1a6cf8ad03bfe981572b9627c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410305 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807158} TBR=sky@chromium.org,thomasanderson@chromium.org Change-Id: I0337fe6838a1bcbde6d71166650db1424a83c8db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413509Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#807352}
-
Ian Kilpatrick authored
Changes the NGPhysicalBoxFragment::RareData fields to all be named consistently, and removes an extra space allocation that isn't needed anymore. There should be no behaviour change. Change-Id: Ib2ff9544c40a63c400b5068f7a5c656e8475439d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412191 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#807351}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a1f84f4a7300..d22b57cd6cee 2020-09-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib6600e4bdc37dde6560bc6277d2a3bcc818b96d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413387Reviewed-by:
-
Moja Hsu authored
This CL adds whiteBalanceMode(continuous/manual) and colorTemperature MediaTrackCapabilities. Bug: b:148527288 Test: Test controls on krane and eve. Change-Id: I823b7644f5494883161c5bd9567918114c038012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235145Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807349}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/40d3f47d189c..5b4eaf71f78b 2020-09-16 thestig@chromium.org mac arm64: Use the correct page size for this platform in PartitionAlloc 2020-09-15 thestig@chromium.org Download the selected version of hermetic Xcode via custom_vars. 2020-09-15 tsepez@chromium.org Rework pdf_fuzzer_init_public.cc 2020-09-14 thestig@chromium.org Remove unused RenderDeviceDriverIface methods. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1128457 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I9450d2b37c49846415ecee7bf552a8daf0d09b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412978Reviewed-by:
-
K. Moon authored
Implements DidReceiveData() to save data received from the blink::WebAssociatedURLLoader, and ReadResponseBody() to return the data to the caller. Based largely on whatever ppapi::proxy::URLLoaderResource::ReadResponseBody() does. Bug: 1099022 Change-Id: Ibaa7db0a7af5996e153d8dc106066ca6133ba95c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407175Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#807347}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1520b4d0fe34..4d3a0f602852 2020-09-16 jmadill@chromium.org GN: Componentize D3D format tables. 2020-09-16 jmadill@chromium.org Test Runner: Fix shard parameter script types. 2020-09-16 jmadill@chromium.org GN: Remove build/ dependency in "Null" GN file. 2020-09-15 jmadill@chromium.org Add feature for disabling compressed formats. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I8fa5d860f11ec8365d3d23c945d97b4ae9a08c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413303Reviewed-by:
-
K. Moon authored
Implements a state machine to bridge the gap between chrome_pdf::UrlLoader's pull model and blink::WebAssociatedURLLoader's push model. This change only handles the basic state transitions; this is sufficient to simulate an empty response. A future change will deal with handling the data received by DidReceiveData(). Also fills in a basic blink::WebURLRequest, since BlinkUrlLoader calls WebAssociatedLoader::LoadAsynchronously() now. Note that RequestContext and RequestDestination must be set to pass certain security checks. Bug: 1099022 Change-Id: I20840e44adda63816f8c7d6a531ffe106dd8bfdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411547 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
-
jongdeok.kim authored
In this CL, has_potential_filter_animation, has_potential_backdrop_filter_animation are considered while calculating node_or_ancestor_has_filters, affected_by_backdrop_filter to avoid rerasterization during the animation. Bug: 1115564 Change-Id: If58e1e71477758fc0c56e46f5dfd5ad6687cd43e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412028 Commit-Queue: jongdeok.kim <jongdeok.kim@navercorp.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807344}
-
Yoichi Osato authored
This reverts commit f1458788. Reason for revert: Still flaky on mac: https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/58334 Original change's description: > [WebOTP] Fix flaky test SameSiteNavigationResetsDocumentUsedWebOTP > > Gives more time to propagate the WebOTP bit. > > Bug: 1120305 > Change-Id: Id350a03de42d3ea5895f01f47cdb5fff7ce801e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405374 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807065} TBR=kenrb@chromium.org,yigu@chromium.org Change-Id: I00eaf5dad7403127a62af0d8c6e67c580846df9d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1120305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409466Reviewed-by:
-
Kyle Horimoto authored
This is in preparation for giving this class additional functionality unrelated to BLE. Bug: 1106937 Change-Id: Ib060a446580310df97651d0145e6f7e0d0784961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412835 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#807342}
-
Hiroshige Hayashizaki authored
#1. Remove importScripts() special handling WorkerOrWorkletScriptController has a special logic for exceptions in importScripts(), which plumbs ErrorEvent outside V8 (i.e. via error_event_from_imported_script_) while rethrowing exceptions in V8, in order to transmit the original exception location information, eventually to WorkerGlobalScope's error event. In order to merge WorkerOrWorkletScriptController logic with its counterpart in ScriptController, this CL removes this importScripts() special logic and makes the logic look more spec conformant. This CL: - Uses v8::TryCatch::ReThrow() instead of ExceptionState::RethrowV8Exception(), because ReThrow() seems to preserve the original exception location while RethrowV8Exception() doesn't seem so. - Uses `v8::TryCatch::SetVerbose(true)` to #report-the-error, instead of `DispatchErrorEvent()`. After this CL, WorkerGlobalScope's error event is triggered from inside V8, and the original exception location is plumbed through V8. By doing so, the original exception location is passed using V8's error rethrowing mechanism, and thus the followings are removed: - ExecutionState - RethrowExceptionFromImportedScript This CL makes exceptions around cross-origin importScripts() spec conformant: - Previously cross-origin importScripts() throws `null` when there are parse errors or evaluation errors, and muted errors ("Script error.") is reported to WorkerGlobalScope error event handler. After this CL, it throws and reports to error event handler NetworkError DOMException as spec'ed. (crbug.com/1111750) - This CL also fixes exceptions around same- and cross-origin importScripts() from setTimeout(). As a result of switching to `v8::TryCatch::SetVerbose(true)`, the following things are achieved: #2. Fire WorkerGlobalScope error events before a microtask checkpoint Before this CL: 1. Script evaluation (top-level worker script or setTimeout(string)) 2. Microtasks checkpoint in V8ScriptRunner::RunCompiledScript() 3. WorkerGlobalScope error events in EvaluateAndReturnValue() After this CL: 1. Script evaluation (top-level worker script or setTimeout(string)) 3. WorkerGlobalScope error events in v8::Script::Run() 2. Microtasks checkpoint in V8ScriptRunner::RunCompiledScript() observable changes are: crbug/1114028 and crbug/1120293 are fixed. #3. Fix error's `message` value. This CL fixes the `message` field values of `Error` objects reported to WorkerGlobalScope error events, because the code path for `v8::TryCatch::SetVerbose(true)` handles such cases appropriately while `DispatchErrorEvent()` doesn't. For background and previous attempts, see crbug/590219 and https://codereview.chromium.org/2090953006/#msg42. #4. Use `v8::TryCatch::SetVerbose(true)` for all classic script evaluation This makes easier to unify script evaluation code paths (crbug.com/1111134). An alternative considered was to switch all classic script evaluation to `V8ScriptRunner::ReportException()`, but it would be much harder: - We'll need to fix `V8ScriptRunner::ReportException()` and its underlying V8 code to handle cases like #3 appropriately. _ We'll need more subtle behavior/ordering changes, affecting broader range of script evaluation (i.e. not limited to workers). Bug: 1111134, 1111750, 1114028, 1120293, 590219 Change-Id: I9395088a73ed76e241e89ce7d15e95417ca829d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328394 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:Dominic Farolino <dom@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#807341}
-
John Chen authored
Disable failing story system_health.memory_mobile/load:tools:dropbox:2019 on Nexus 5X. TBR=wenbinzhang@google.com NOTRY=true Bug: 1128019 Change-Id: I6ab6b976b57d644d56db92423b2881a4d27fae1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412980Reviewed-by:
-
Glen Robertson authored
This reverts commit 93d899e2. Reason for revert: Breaks on official build due to inclusion of //chromeos/components/telemetry* Original change's description: > Enable `gn check` on //chrome/browser. > > Changes are: > - adding deps when missing. > - adding "nogncheck" when needed (see below explanation). > - deleting nonexistent files from sources. > - new target :net_dns_access for files that depend on > //net/dns:host_resolver (which has restricted visibility). > Alternative: could open visibility to all of //chrome/browser instead > of adding a new target that has visibility. > - moving //c/b:test_support sources to //c/b/chromeos:test_support or > //c/test:test_support when they depended on headers there (cannot > add a dependency, there is a cycle). > - moving includes to conditional sections when they are used only in > conditional sections (where it caused deps issues). > - removing unused includes of test code from non-test code. > - merging sections in //c/b/BUILD.gn that had the same if() conditions. > Alternative: revert these changes, they are cosmetic. > - adding some asserts/conditional blocks in build files that only work > under those conditions. > > "gn check" does not understand #if statements in cc/h files so it > complains about missing deps in configurations where those deps were > never actually included. "nogncheck" has been added to the include lines > to suppress these spurious errors where necessary (sometimes it is not > necessary because the include is used outside of #if statements in other > files). > > Bug: 898837, 1125897 > Change-Id: I77e7dd3780fb93edb2b555a82b681a870990b496 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383400 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Eric Orth <ericorth@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Glen Robertson <glenrob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807321} TBR=dpranke@google.com,blundell@chromium.org,dominickn@chromium.org,ericorth@chromium.org,glenrob@chromium.org Change-Id: I13f4705899734213dd3f82fe60ac431f85584e70 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898837 Bug: 1125897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413370Reviewed-by:
-
Youkichi Hosoi authored
We will use UUIDs for the paths of shared external storage volumes (MyFiles, removable devices) in ARC. BUG=b:123377807 BUG=b:123641356 BUG=b:163951541 TEST=$ unit_tests --gtest_filter="FileManagerPathUtilConvertUrlTest.*" TEST=$ unit_tests \ TEST= --gtest_filter="NoteTakingHelperTest.LaunchAndroidAppWithPath" TEST=Open image files in MyFiles / removable devices with the Android TEST=Google Photos app from the Chrome OS Files app. Change-Id: Id2166c3a793bf0eae25fbd5e07c5d1ec6b892067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275514 Commit-Queue: Youkichi Hosoi <youkichihosoi@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#807338}
-
Glen Robertson authored
Origin Trial on Android only for now. Bug: 1032423,1096428 Change-Id: I8329c798138d800156bbe3f90de6d05f2d9662b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404284Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/52fdd1ffcefb..8e500174f4bb 2020-09-16 chanli@chromium.org [depot_tools] Roll led to latest If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1099018 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: If1d95c2bf1b50ee7d3c87e271e645db5546c88b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413300Reviewed-by:
-
Liquan (Max) Gu authored
Context: According to payment_request.idl, PaymentOptions and PaymentDetailsInit are {} when missing, and so both impossible to be null in non-compromised renderer. When renderer delivers PaymentOptions to browser, it doesn't create null for an empty PaymentOptions, so Java should expect options and details to be non-null, reject the null cases from a compromised renderer, and assert PaymentOptions in rest of the code to be not null. Before this patch, the Java payment codebase does not treat null as invalid for PaymentOptions, in many places spending extra effort in considering this case. This CL changes the payment code to achieve what it should be as stated above. Change: * Assert option not to be null in PaymentOptionsUtils.requestShipping(), inline the method, and do the same for requestPayerName(), requestPayerPhone(), requestPayerEmail(), getShippingType() * CPRImpl adds invalid renderer data check for getShippingType. * Correct the @Nullable annotation of PaymentDetails and PaymentOptions in java payment code. Bug: 1106563 Change-Id: I096cf67543bcba59e9555d157a093e99a47e2866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404566 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#807335}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: If5390bfa5184e5a83af221a6f4dfd6602b845dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413302Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d9c55ce8edbb..3e72b3ff8ca7 2020-09-16 mtklein@google.com jit q14x2 ops If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: Ib121a3b4ed3033ca56632548edccf3bb78f44ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413294Reviewed-by:
-
Seokho Song authored
Currently, PaintPropertyTreeBuilder makes an issue about z-order with 3D transform operations such as trasnalteZ(). So we need to check this issue on the tests whether wrong results or not. In this patch, a test will check if rendered correctly. Now it would be expected '[Failure]' It will remove the expectation when we fix the issue Bug: 1116358 Change-Id: I8f5be9e1ed186df1e779cf9e8a7f0462e079232b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409476 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
