- 03 Oct, 2019 40 commits
-
-
Peter Kasting authored
Also does other misc. cleanup. Bug: 1005568 Change-Id: I0f6203636ae60937ddf35b01fa985d0bb415853f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837079 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#702597}
-
Eric Roman authored
In unittests for NetLogging of cookie inclusion status, verify the entire NetLog params and not just the value of "exclusion_reason". This way the test catches regressions where the parameters contain more information than it should (say the cookie name). Bug: 1005217 Change-Id: I7531e822bae67654fcac14b1b9900f8b3b0b98b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838552Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#702596}
-
Francois Doray authored
When we are notified on the IndexedDB sequence that a frame acquired an IndexedDB lock, we will post a task to the PM sequence with the process and frame routing ids. We will then invoke GraphImpl::GetFrameNodeById() (added by this CL) to retrieve the FrameNode and update its "holds IndexedDB lock" property. Bug: 980533 Change-Id: Ic80a06c9177bb7abb6e28b6caf0ee3c344df0dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834402 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#702595}
-
Nico Weber authored
This makes it easier to copy the triple to the goma upload commandline, and it puts pre- and post-roll git revs in the CL title. Bug: none Change-Id: Ided99e2bf1977e12fb4626422e07daf9e2b2eb26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837078Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#702594}
-
Etienne Bergeron authored
This CL is adding a global singleton to hold the FontConfig config used by gfx API. The singleton is initialized on startup and the reference counter is incremented to avoid the FcConfig to be deleted. The problem we are fixing is described here: https://bugs.chromium.org/p/chromium/issues/detail?id=1004254#c28 The FontConfig may be deleted by an other thread while being used. This is causing memory corruption and use-after-free. To avoid these races between threads, the gfx component is keeping the same configuration for the whole execution. The global configuration needs to be manually passed to the font-config API to avoid to load the default global configuration. New code that are calling FcFontMatch and FcFontSort should use that configuration too. Otherwise, these calls will work but will be flaky and may crash. Bug: 1004254 Change-Id: I1c12ff88c39c5eb5e384a7bfb572b427632d2a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835026 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#702593}
-
John Rummell authored
On Linux the Widevine CDM is loaded into the zygote at startup. When the component updater runs sometime later and finds a newer version of the Widevine CDM, don't register it as the newer version can't be used. Instead, similar to Flash, save the path to the new Widevine CDM in the file latest-component-updated-widevine-cdm. Next time at startup this file will be checked, and if it references a usable Widevine CDM, use this version instead of the bundled CDM. Tested this by running Chrome built with an older version of the Widevine CDM, and then checking chrome://components for a newer (QA) version. As there is one, it gets updated. When restarting Chrome, the newer version is loaded. In both cases Widevine content was played using Shaka. Bug: 971433 Test: see description, plus new unit_tests pass Change-Id: I2d188f5206ba45de8e87b7c51cb45a59a2875b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826077Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#702592}
-
Nico Weber authored
Bug: 1010111,1010458 Change-Id: I5b873760e6cc0ffc0a957705f566ef99a3018864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837333Reviewed-by:
-
Sunny Sachanandani authored
GpuMemoryBufferVideoFramePool uses RGBA/BGRA as the output format for I420A video frames, and those are promoted to overlays on all platforms. This causes SwapBuffers to fail in the GPU process on Windows since the direct composition path can only handle YUV video. This wasn't a problem until we started promoting TextureDrawQuads to overlays in crrev.com/c/1746796 assuming that the is_overlay_candidate flag would only be set for low latency canvas that uses a swap chain. A pixel test with yuva420p vp9 video is added. The video was generated using the following ffmpeg command: ffmpeg -i four-colors.mp4 -filter_complex \ "color=c=#7F7F7F7F:s=960x540:rate=12[a];[0][a]alphamerge,format=yuva420p" \ -c:v libvpx-vp9 -auto-alt-ref 0 four-colors-vp9-i420a.webm Bug: 1005028 Change-Id: Idc84d29c588cf3b9273fb605b2542be5441d61d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829556 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#702590}
-
Samuel Huang authored
This reverts commit aaa2ec5c. Reason for revert: Compile failure in WebLayerBrowserTestsActivity.java. Original change's description: > Add weblayer browser_tests APK so we can run the tests on Android. > > The Shell C++ class isn't used on Android (unlike in content_shell) because we want to consume WebLayer there using the idiomatic Java API. At the same time, we want to write browser tests the same way for all platforms. So fake this by creating a Shell that reuses the existing BrowserController class that was created by Java. > > Change-Id: I946957f39eb79cff2e84c8abda56eed98b28d0a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815884 > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702563} TBR=jam@chromium.org,cduvall@chromium.org Change-Id: I3e1fbf1c3668aa4fe1799a102d9009f2ffcb3283 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838619Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#702589}
-
Ella Ge authored
To make the names make more sense and easier to understand. Change-Id: I86cf70e26f6248495d28f77bf85978f50c4b64e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832715Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#702588}
-
John Budorick authored
Bug: 1008734 Change-Id: If035ff53997e314e1c7ade677d99af6088f82e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838292Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#702587}
-
Manu Cornet authored
Bug: 1010827 Change-Id: Ib03c22e708bca1d2fb2fe48dad15c1757c8d4db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838299 Commit-Queue: Manu Cornet <manucornet@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Auto-Submit: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#702586}
-
James Forshaw authored
This CL changes the base sandbox level used by the audio sandbox to the USER_RESTRICTED_NON_ADMIN level. This level provides the same access as USER_NON_ADMIN but is a restricted token and so passes AppLocker checks to allow the audio sandbox process to start when AppLocker is enabled. Bug: 1007260 Change-Id: If2ab1c8671e3717b486dfdc395995f7cd6c59019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838156Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#702585}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/99938eab593d..6021fbd09b1c git log 99938eab593d..6021fbd09b1c --date=short --no-merges --format='%ad %ae %s' 2019-10-03 capn@google.com Fix commit message validation reporting Created with: gclient setdep -r src/third_party/swiftshader@6021fbd09b1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/141892461 Change-Id: I41df185067d72e7d8546ee6c302b47df0a26092c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838414Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702584}
-
Aran Gilman authored
This prevents the UI and the content's text from moving off the edge of the screen at large font sizes. Bug: 952034 Change-Id: I0d7600a79d24ea48c3fd0cc25718e74b536dd0eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838142 Auto-Submit: Aran Gilman <gilmanmh@google.com> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702583}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/687249cc9ed7..19400f0641be git log 687249cc9ed7..19400f0641be --date=short --no-merges --format='%ad %ae %s' 2019-10-03 treehugger-gerrit@google.com Merge "metatrace: remove memset and trivial-ctor assumption" Created with: gclient setdep -r src/third_party/perfetto@19400f0641be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I591a4d12ab0c5a5b772f600ca0713f5a8f9ae7ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838532Reviewed-by:
-
Eric Stevenson authored
Moved to a subdirectory of the build target using it. The old location was confusing because it's in the same directory as non test code. Bug: 1010218 Change-Id: I1de7cd4ec72c7967506ebd8451fcf2b9378a9fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838522 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#702581}
-
Andrew Grieve authored
Bug: 982762 Change-Id: If26bd60eaeda65d27870591908efc84981cc581f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836892 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#702580}
-
Hiroshige Hayashizaki authored
Follows https://github.com/WICG/import-maps/pull/180 that removes fetch scheme check in the spec. (Chromium already didn't have fetch scheme checks in other callers of `parse a URL-like import specifier`, so after this CL Chromium will fully align with the PR #180) Bug: 990561, 1011075 Change-Id: Ieb0c3f09ab1014d462b8ef7c898a5abe1afb5b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836972 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#702579}
-
Renjie Tang authored
Bug: 1005646 Change-Id: I3cf1a7210a0038b438d38cb375f813f4e8edf891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834026Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702578}
-
Nick Diego Yamane authored
In crrev.com/c/1813417 KeyEvent::ApplyLayout() has been modified so that it does not uses XEvent anymore, shifting the resposibility of extracting and setting DomKey/DomCode to components that translate XEvent into ui::Event. In case of ozone/x11 (and soon in Aura/X11, once it migrates its PlatformEvent to ui::Event, see crbug.com/965991), which happens in X11EventSourceDefault, which is also used in "CrOS on Linux" builds. In CrOS specifically, keyboard layout manangement follows a completely different code path and setting DomKey/DomCode at event construction causes regressions which prevent linux host keyboard layout to be used in CrOS interface. To fix it up, this adds a ifdef to not set DomKey/DomCode in CrOS. Bug: 1007389 Change-Id: Ie5c18e43625048d87583ccda275f7edca9ebc5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823795 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#702577}
-
Oystein Eftevaag authored
Also made the test a little bit more predictable. Bug: 1008387 Change-Id: I652a1032b3442bbfeed1d16e75b251e55e675221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837071Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#702576}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/608083b66e54..78c82a40409d git log 608083b66e54..78c82a40409d --date=short --no-merges --format='%ad %ae %s' 2019-10-03 sprang@webrtc.org Adds trial to always start probes with a small padding packet. Created with: gclient setdep -r src/third_party/webrtc@78c82a40409d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Id0ed2e8e5351049d8aa4c9eab0aa6481f30fc143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838518Reviewed-by:
-
Joel Hockey authored
Static function IsEnabled is moved to be a member function of CrostiniFeatures to allow easier testing of the function, and easier testing of code which calls it. TBR=benwells@chromium.org TBR=calamity@chromium.org Bug: 1004708 Change-Id: If055e47932bcb21ccde84f92b5e8dac4e99e4e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827267 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#702574}
-
Julie Jeongeun Kim authored
This CL converts TcmallocTunables to new mojo types using PendingReceiver and SelfOwnedReceiver. Bug: 955171 Change-Id: I8860a39d62511c9e2e36943bcda37814476f7045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828673Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Mohit Bansal authored
This CL adds a few tests to validate text extraction and accessibility tree for the newly enhanced accessibility support for PDFs. The tests added make use of an already available test file as well as add another test file. Bug: 981448 Change-Id: I821751efc9cf2c586c41ecdf29a071d95a52dd70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817857 Commit-Queue: Mohit Bansal <mohitb@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#702572}
-
John Budorick authored
Bug: 922145 Change-Id: Ibb6324e7a0a31bade8052da57cf29ae0c3020987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808788Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#702571}
-
Adam Langley authored
Results are in. Time to clean this up. Bug: 801302 Change-Id: Ie23c51edad45896920334f6666f02cecfac389c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832786 Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#702570}
-
Kevin Bailey authored
It appears that the arguments to a function have changed, without the comment being updated. This CL tries to update it. Change-Id: I42e9cb9306d4e844d9d13901a549c75617e002bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838432Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#702569}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1850492e30ce..c847a75f95be git log 1850492e30ce..c847a75f95be --date=short --no-merges --format='%ad %ae %s' 2019-10-03 shrekshao@google.com Fix redundant draw in DrawBaseVertexBaseInstanceTest Created with: gclient setdep -r src/third_party/angle@c847a75f95be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: chromium:3402 Change-Id: I812846ab5380f33e529efe395c9a69f46f1648e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838631Reviewed-by:
-
Ahmed Fakhry authored
This CL fixes the top-chrome slide behavior in tablet mode for WebUI Tabstrips when the page is scrolled with touch gestures. This is handled by asking the BrowserView to give us a list of all its attached NativeViewHosts (such as the active tab's webcontents' and the WebUI tabstrip WebView's) so that we can transform the layers of their native window containers. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=1003122#c14 BUG=1003122 TEST=Manual, Expanded existing tests. Change-Id: I90ae377235219ec7cfc1a0213d88648b7d9dc179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836382Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Dmitry Gozman authored
- Unused: HttpBody(), ErrorCode(), SetTickClockForTesting(), previews_state(). - Exposed for testing, but can be retrieved elsewhere: GetIPAddressSpace(). - Now passed to the single caller directly: WasBlockedAfterCSP(), AppcacheHostId(). Bug: none Change-Id: If0914a9e536d2cc64acb5ce1442bc86e9bc45b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833787Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#702566}
-
John Lee authored
- When the tab strip is closed, the newly activated tab should be moved to the beginning of the list. - When the tab strip is open, the newly activated tab should just be scrolled to. - Whenever the tab strip switches from visible to hidden, the active tab should be moved to the beginning. The idea is what when a tab is activated, the tab strip will close and the active tab will be then be moved to avoid jumping while the tab strip is animating in and out. - Regardless of whether or not the tab strip is visible, newly created active tabs should be created at the beginning of the list to enforce the MRU model. - Disable drag and drop for unpinned tabs. Bug: 1005554 Change-Id: I35f16ae111d949326533f45ce1d9494f578b774e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829555 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#702565}
-
Regan Hsu authored
* Update update_engine_client to accept (from Dbus) and provide specific eol date. * Update eol notification to show 3 eol notifications (6 month, 3 month, Eol). * Wrap notifications in a base::Feature, default-enabled flag. * Do not show notifications if user is managed. Integration test is at https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1834921 Design Doc: https://docs.google.com/document/d/10xiHcl2WT1jWYinFhX677N2B8r08jFFK4iHi0252nf8/edit?usp=sharing Bug: 998983 Change-Id: I1b6af1375909bdf59970931ca066c43c245499c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775160 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#702564}
-
John Abd-El-Malek authored
The Shell C++ class isn't used on Android (unlike in content_shell) because we want to consume WebLayer there using the idiomatic Java API. At the same time, we want to write browser tests the same way for all platforms. So fake this by creating a Shell that reuses the existing BrowserController class that was created by Java. Change-Id: I946957f39eb79cff2e84c8abda56eed98b28d0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815884Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#702563}
-
Reilly Grant authored
In r678566 the type converter for UsbDeviceInfo was removed and a UsbDevice now owns its own UsbDeviceInfo that is provided to consumers. In so doing the active_configuration field of that UsbDeviceInfo is no longer updated when ActiveConfigurationChanged() is called. This exacerbates issue 1009886 because now more platforms appear to start with no active configuration selected and causes issue 1003561. Bug: 1009886,1003561 Change-Id: Ib63c591aed33f0041b4b5cb384106c8cd34a9632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836355Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702562}
-
Tibor Goldschwendt authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/2ecd66c696c4..93a34f0ec19e $ git log 2ecd66c69..93a34f0ec --date=short --no-merges --format='%ad %ae %s' 2019-10-01 tiborg Add assets and copy target for extra ICU data file Created with: roll-dep src/third_party/icu TBR=jshin@chromium.org Bug: 1006794 Change-Id: Ia47475f5a11e9ffc9cb51ae61f6ea0e7c934869b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838356Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702561}
-
BUG=762641 TBR=rkc@chromium.org Change-Id: I773ca832b861fe8e87548798c0f0ae8b65abda1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838672Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702560}
-
Andrew Xu authored
It is a regression issue introduced by the CL on Hotseat. When the flag is disabled, the init of DelegateView returns early then it fails to set the layout manager. Bug: 1009609 Change-Id: Id53ee51556e10d60985abcabbbcba186d5afcc01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838472Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#702559}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0f4ac587a4ae..e5c62b37f645 git log 0f4ac587a4ae..e5c62b37f645 --date=short --no-merges --format='%ad %ae %s' 2019-10-03 thestig@chromium.org Remove use of deprecated v8::V8::SetNativesDataBlob() in PDFium. 2019-10-03 thestig@chromium.org Roll third_party/googletest/src/ 3a4503986..f2fb48c3b (6 commits) 2019-10-03 thestig@chromium.org Roll third_party/icu/ 53f6b233a..2ecd66c69 (4 commits) 2019-10-03 thestig@chromium.org Roll third_party/depot_tools/ e5641be5f..e90e5fe20 (89 commits; 25 trivial rolls) 2019-10-03 thestig@chromium.org Roll third_party/catapult/ 884c81e17..830565958 (80 commits) 2019-10-03 thestig@chromium.org Roll third_party/jinja2/ 45571de47..b41863e42 (1 commit) 2019-10-03 thestig@chromium.org Roll tools/code_coverage/ b53d904eb..4a898be73 (7 commits) 2019-10-03 thestig@chromium.org Roll third_party/libjpeg_turbo/ baa5dc242..38c693569 (2 commits) 2019-10-03 thestig@chromium.org Roll third_party/zlib/ 8c79b6c8d..ddebad26c (2 commits) 2019-09-30 thestig@chromium.org Roll third_party/freetype/src/ 432efa25b..839a02361 (6 commits) Created with: gclient setdep -r src/third_party/pdfium@e5c62b37f645 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Ia2f3437d8c66884a1d7bb2a3418aa5df83635176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838413Reviewed-by:
-
