- 16 Jul, 2020 40 commits
-
-
Kartik Hegde authored
Validate the communication between NetworkDiagnosticsImpl and the routines. BUG=chromium:1096551 TEST=unit_tests --gtest_filter=NetworkDiagnosticsImplTest.* Change-Id: Id0868b88791e4b3fe9ec18b6257b68ef64ed41b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274149 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#789240}
-
Alan Screen authored
Printing from within the context of a pepper plugin for a Flash object started crashing once the print composite usage stopped the inefficient practice of generating metafiles for both individual pages and the full document, in r751614. Even though this issue of printing a Flash object is not of much interest because of Flash being near end-of-life, we can at least not crash the tab on users who happen to invoke such a print. This restores ability of print preview to complete and provide page images, although the content of the Flash object is empty. This at least matches the behavior prior to r751614. Bug: 1098860 Change-Id: I86f7030ade0f126d6994b810f26775bf8cfe2693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298036Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789239}
-
Pete Williamson authored
Some switches treat offline pages differently depending on the namespace. The proper namespace should be NTP_SUGGESTIONS_NAMESPACE. Bug: 1099057 Change-Id: I83b6e0dfa73d4601c831a534e8e47d2643b44f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297529 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#789238}
-
adamta authored
Removes default section inset on the NTP for the section that contains the Discover feed. Was preventing users from tapping the 3 dot menu on cards. Bug: 1085419 Change-Id: I24b9010aa847f3d24104165ba6f3ef0b00dbb081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300201Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#789237}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1594814211-6e9c837aecb05743d0a6513baf4c13c15785a909.profdata to chrome-win64-master-1594878809-f70bebc20790ac0846ac45f570a81eb656b74862.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I11f05a0c62bb25bb671fdc3a5eb2a5d38bf3b80b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302089Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789236}
-
Megan Jablonski authored
Also update Translate subframe histogram owner from dougarnett to sclittle. Bug: 1105002 Change-Id: I8647c4dfb511c66f27fc3a35c95e96fca07976de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300405Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#789235}
-
Sophie Chang authored
Bug: 1106448 Change-Id: Iffdcda8a392ee50b24ac482dfa437363ddbab7d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302922Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789234}
-
Adrian Taylor authored
Sheriffbot sets M-<current stable milestone> for Security_Impact-Stable, Security_Severity-{High,Critical}... but only if the M- is not already set. This is the desirable pattern: * Sheriff sets something to Security_Severity-High and Security_Impact-Stable * Sheriff does not set M- label * Sheriffbot sets it to the current stable milestone (e.g. M-84) * Later, when it's fixed, Sheriffbot adds merge requests to 84, and we ship it in the next security fix. We sometimes see this pattern: * Sheriff sets something to Security_Severity-High and Security_Impact-Stable * They also set the M- tag, but set it to the next stable milestone * Sheriffbot therefore does not set a M- label * Later when it's fixed, Sheriffbot does not add merge-requests to 84. * We don't ship the fix as soon as we should. This change calls out that the main sheriff labelling responsibility is Impact and Severity, and most other things are set downstream by Sheriffbot. Change-Id: Ie8d518dfa9230599f6f941de219e43382b991369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302739Reviewed-by:Max Moroz <mmoroz@chromium.org> Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#789233}
-
Abigail Klein authored
Add a button to expand and collapse the caption bubble from 2 lines of text to 8 lines. The spec for this is in go/chrome-live-caption-ux. Once a bubble is expanded, it stays expanded for the duration of its lifetime (or until it is collapsed). It remains expanded on new tabs in the same window, or when a tab is refreshed. The bubble has the following make-up: Caption Bubble: Box layout, Vertical orientation, End cross-aligned Close Button Content Container: Flex layout, Vertical orientation, Stretch aligned Wait Text Label Error Message: Box layout, Horizontal orientation Error Icon Error Text Expand Button Collapse Button Screenshots: Collapsed state: https://screenshot.googleplex.com/RPSwG1R5n5H Expanded state: https://screenshot.googleplex.com/MPVExFxsum8 Bug: 1055150 Change-Id: Icb9d81bd68cc4a657e3241662ce5d90f3b63aadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284284Reviewed-by:Dana Fried <dfried@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#789232}
-
Oleh Lamzin authored
Migrate message pipe browser tests from MediaApp. Bug: b:159927590 Change-Id: Icc3d4d759bce94a739a6fe0b56c85129c5b58b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282597 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#789231}
-
Justin DeWitt authored
No-Try: true Change-Id: Ib269d60dcb6daf7de927a306f0f8b19671df3aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302940Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/71892ba52d17..19856e664354 2020-07-16 bsheedy@chromium.org [Telemetry] Capture CrOS logs as artifacts 2020-07-16 cduvall@chromium.org Reland "Set WebView implementation for any WebView APK" 2020-07-16 awdavies@google.com [telemetry][fuchsia] dev_finder -> device-finder 2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1102653,chromium:1105096 Tbr: oysteine@google.com Change-Id: Ib789224ef2741feedfe3d279e082f8b0c09f4669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303040Reviewed-by:
-
Brian Sheedy authored
Rolls the goldctl CIPD revision to pick up the newest version. This is so that the service account used by tests will no longer need read permissions for the GCS bucket that images are uploaded to, which will prevent it from potentially leaking internal image data in the future when internal results exists. TBR=ynovikov@chromium.org Bug: 1077274 Change-Id: Ib8d231905a684a7891a145dcce911fae46909383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303357Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#789228}
-
Sean Harrison authored
Continuing work on desktop privacy settings, extending histogram expiry dates accordingly. Bug: 1032584 Change-Id: I3f8ba2806b84c1d3307e09e1255b530d29aa9938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303389Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#789227}
-
Matt Menke authored
We're still only allowing one push per URL and cancelling push requests when the NIK doesn't match, which leaks data across NIKs. I'll fix those in followups. Bug: 1105544 Change-Id: Ica297f93071d2d72744750db68b727ac340d8719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302916Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#789226}
-
Theresa Wellington authored
Bug: 1105831 Change-Id: Ic433031ce79b7eb837bbc6599f5a098760006704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299470Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#789225}
-
Clark DuVall authored
This conversion should have no functional change. Note: I will convert base::Bind calls to base::BindOnce all at once once all the uses of Callback and Closure are converted in //chromeos/network. Bug: 1007660 Change-Id: Idd9e92559fcb7adce3104269ee0014c7b7863aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289191Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Xinan Cheng authored
Previously FuchsiaAudioRenderer dependent on FuchsiaMediaResourceProvider, but not all clients will use it. Bug: b/149863069 Change-Id: I7a8c46c7acdfa6a90674d23b25fb50fe5d8a7437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293467Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Xinan Cheng <xinan@google.com> Cr-Commit-Position: refs/heads/master@{#789223}
-
Clark DuVall authored
This conversion should have no functional change. Note: I will convert base::Bind calls to base::BindOnce all at once once all the uses of Callback and Closure are converted in //chromeos/network. Bug: 1007660 Change-Id: Id38c76057055ffb3eac02f31c37763928e98e6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289086 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Henrique Nakashima authored
Make the centering force strong for filtered classes, average for 1st level dependencies, and weak for 2nd+ level dependencies. Bug: 1106108 Change-Id: Iad51bec900e150a13161a9d7a86f8ead721b713e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301041 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#789221}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I7729c3b94f12daee7d80483bb881c18aff1b11ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303099Reviewed-by:
-
Sahel Sharify authored
Flake portal: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUAsSBUZsYWtlIkVjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFVuaWZpZWRBdXRvcGxheVNldHRpbmdCcm93c2VyVGVzdC5EZWZhdWx0QWxsb3cM TBR=sergeyu@chromium.org Bug: 1101524 Change-Id: I81a5e4e4f8c175c88cda9be3e80285c790ab8c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303124Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#789219}
-
Stephen Roe authored
Build times, stability, and capacity look good in a 100% CQ experiment run from 2020-07-09 through 2020-07-15. Pending times for the fuchsia arm64 100 %CQ bot are similar to the existing fuchsia x64 trybot: builder fuchsia_arm64 fuchsia_x64 tasks 48025 60618 pending_seconds_p90 2 4 pending_seconds_p95 6 10 pending_seconds_p99 238 175 Build times for the fuchsia arm64 100% CQ experiment are similar to the existing fuchsia x64 trybot: builder fuchsia_arm64 fuchsia_x64 builds 2579 2607 build_minutes_p50 28.88 30.60 build_minutes_p70 47.63 48.45 build_minutes_p90 57.88 58.72 Stability is good at 100%: https://ci.chromium.org/p/chromium/builders/try/fuchsia_arm64 Capacity is good at 100%. The average number of bots running varies from 40 to 54 over weekdays out of 240 bots. There are spikes from 180 to 240 bots when multiple CL builds overlap. Bot usage percentages for the 54-bot weekday are p50 46 bots p90 105 bots p99 169 bots out of 240 bots Pending time data is from: https://docs.google.com/spreadsheets/d/1UFZCo52fm5ysfFzrK0OC3SMaAnRCOVWBlJzpakxVmc8 Build time data is from: https://docs.google.com/spreadsheets/d/18xUnQqVuWrIxenEsRZBJYpi94kr6ICaQcrdw04ezWl4 Capacity and bot loading data is from: https://docs.google.com/spreadsheets/d/1F04LjQf11s-itlgsAQg3J57I8mjWMSE_h-2bt8ABSb4 Bug: 1042511 Change-Id: I12f2213fa43dd0b3d10d1306b1ae252034285798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303359Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#789218}
-
Torne (Richard Coles) authored
Add the SDK 30 packages to android-sdk-packager. Bug: 1106471 Change-Id: I2819109ac43e7dafeb36fea015fcf6f651a57b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303550Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#789217}
-
Maxime Charland authored
The new Bookmarks empty state, when inside empty folders, will be implemented by TableViewIllustrated. Bookmarks will take care of creating and keeping a reference to its own TableViewEmptyView instead of using ChromeTableViewController's helper functions because the view's insets will need to be tweaked by the view on the root level when the Sign in promo is visible. This particularity will be visible in a future CL. (Googlers only links) Screenshot: https://drive.google.com/file/d/1ji5vMJpt_qEd7VWJMpayuw59zLBokrDx/view?usp=sharing Design Doc for Chrome Empties: https://docs.google.com/document/d/1JM2sKT4oghkol51U7_3xv9sfaB26C89CCGa2uwYBgsI/edit?usp=sharing Mocks of the new Chrome Empties look: https://docs.google.com/presentation/d/1x1lSTOSQ1zkJu87SoigiUhX2f9oHACglR22yYg-lSHo/edit?usp=sharing Bug: 1098328 Change-Id: I704aeebb60717c061f610614dbf8a86f199091f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293219 Commit-Queue: Maxime Charland <mcharland@google.com> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#789216}
-
Caitlin Fischer authored
Opening new tabs was used as a workaround to avoid continuous animations problems crbug.com/640977. Also, clean up some comments as the Android tests in Java files were moved into ukm_browsertest.cc. Bug: 1096582 Change-Id: I07a4e12ef92575b75bc5c8580200857c827828d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297662Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#789215}
-
Yuke Liao authored
This CL encapsulates the lacros test runner with either xvfb.py or test_env.py to be consistent with other Desktop platforms. Bug: 1104318 Change-Id: I00980225aff8856e5747d15f7e57814fb2e4043c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303169Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#789214}
-
Yuke Liao authored
This CL fixes argument helper to clarify how unknown arguments are handled. Bug: 1104318 Change-Id: Id2eeeb25f5f601c8c2f66d1b8a0f76e0991391f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302936Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#789213}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iab2b165c27a4a2c9be977e00b1316d4d0c7b102f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302943Reviewed-by:
-
Sahel Sharify authored
Flake portal: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyawsSBUZsYWtlImBjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFRyYW5zbGF0ZU1hbmFnZXJXaXRoTWFpbkZyYW1lTGFuZ3VhZ2VEZXRlY3Rpb25Ccm93c2VyVGVzdC5UcmFuc2xhdGVJZnJhbWUM TBR=dougarnett@chromium.org Bug: 1106446 Change-Id: I6008f48820b05353fcef9fe23fa8d9b68d1b44a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303051Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e7945d6e..72a5712e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4c6f6149da71531e4b40b3b82847b0b7a97ff94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303489Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789210}
-
rbpotter authored
Add new rotate counterclockwise label, and hook up the button for the new toolbar. Bug: 1105965 Change-Id: I9e665a4f3f547fd574c0f797cfd4a46046f42f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300230Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#789209}
-
Will Harris authored
Before this CL, only EXE files had CFG bitmap generated and PE DLL Characteristics "Control Flow Guard" enabled. This CL enables these for DLLs as well. It is a no-op for Chrome code as the dispatch guards are not being generated but will protect indirect calls from e.g. system libraries from being able to call into arbitrary Chrome code. This CL also updates checkbins.py to ensure that shipped binaries always have /guard:CF enabled, and also enables longjmp support as compiler issues were isolated to MSVC which we no longer use. See Comment 30 on bug for size impact analysis. TEST=Verify by running dumpbin.exe on Chrome DLLs and checking for "Control Flow Guard" in the "DLL characteristics" header field, or run tools/checkbins/checkbins.py on output directory. BUG=584575 Cq-Include-Trybots: luci.chromium.try:win7-rel,win_archive,win_x64_archive Change-Id: I4b78b97e93cd81dee70d0b3d1edd3d8e522a5495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298284 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#789208}
-
Yuke Liao authored
The owner file should end with a 's'. Bug: 1104318 Change-Id: I3910a8c99cccba42e46a17671bf179fda25a86ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302744 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
-
Dirk Pranke authored
I accidentally introduced some unused code paths in the test() GN template when adding the first pass of the bin/run_ GN wrappers for desktop in 956c4dcc (#784653). This CL removes them. Bug: 816629 Change-Id: If84195eec47d93c1260a063ca6cbb81f74e7c2d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303039Reviewed-by:
-
Nicolás Peña Moreno authored
* Add prototype of Frame Timing as a stretch goal. * Fix a typo with a link. Change-Id: Ic1cbdb7d2a0a83d18ded0f00bb67df9a44e2d93f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303557 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#789205}
-
Greg Thompson authored
- add a const get() - add a nofail assign() from a same-sized string - add an empty() BUG=None Change-Id: Iaea64cccd408deedb5d5b605815e98a6c943096c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302849 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#789204}
-
Garrett Beaty authored
Change-Id: If1026afabd6da9f61bb0f6371d7d521271b6eefe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303038 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Ana Salazar authored
While repareting an app from a folder into the main grid, we could drag it to create a new blank page. If the repareting is cancelled, the app will snap back to the folder but the blank page will remain, causing the system to crash eventually. We need to update the apps grid paging in this case, so that the blank pages are discarded. Bug: 1100011 Change-Id: I5e28ed61bb50f3bde85cceaca9c5c7d0be1693b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300836 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#789202}
-
Jia Li authored
This will enable implementation of the ML Service with complete service features. Summary of changes: - Implemented deserialization and validation of the model. - Added tests for |DecisionTreePredictor| and |DecisionTreeModel|. Bug: 1102428 Change-Id: Ib1328f69dca76c5f47b361259e181a8ab12e45e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290330Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Jia Li <jiakl@google.com> Cr-Commit-Position: refs/heads/master@{#789201}
-
