- 16 Feb, 2018 40 commits
-
-
Gustav Sennton authored
A lot of classes in the glue depend on the WebViewChromiumFactoryProvider because they need to post tasks to the UI thread. In this CL we move that task-posting functionality into WebViewChromiumRunQueue to allow glue classes (including classes shared between the webkit glue and the support library glue) to depend on WebViewChromiumRunQueue instead of WebViewChromiumFactoryProvider. We're leaving the original methods in WebViewChromiumFactoryProvider for now to avoid having to change all callers at the same time. Bug: 813089 Change-Id: I5f01179b1917df9aaa345f53f2292bcab8238368 Reviewed-on: https://chromium-review.googlesource.com/924184Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Gustav Sennton <gsennton@chromium.org> Cr-Commit-Position: refs/heads/master@{#537345}
-
Dave Tapuska authored
Shadowed variables can make code harder to read. Don't support them in the content layer. BUG=794619 This CL was uploaded by git cl split. R=csharrison@chromium.org Change-Id: Ia68095876eb2a6de4337cee243c0ae5b4c93ff8c Reviewed-on: https://chromium-review.googlesource.com/924171 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#537344}
-
Carlos IL authored
Bug: 766233 Change-Id: I0af9b95727cd334af60f6e50904a9d04339bd7da Reviewed-on: https://chromium-review.googlesource.com/923181Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#537343}
-
bsheedy authored
Adds simNfcScanUntilVrEntered, which in most cases, replaces simNfcScan. This is to deal with flakiness that stems from VrCore thinking that it's still in VR from a previous test and nooping when it receives an NFC scan in a following test. Bug: 736527, 812306 Change-Id: If7b135b99df03c463f5b393bfbe6290e06d0ee4e Reviewed-on: https://chromium-review.googlesource.com/923099Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#537342}
-
Leonard Grey authored
This is more prep for Mac support. The current root is a WindowElement which is backed by aura::Window. Bug: 769352 Change-Id: Ie7e05fb528f9f54fc07bc5ce96397715e0e34f1e Reviewed-on: https://chromium-review.googlesource.com/876307 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#537341}
-
Rune Lillesveen authored
Also a couple of other places where ComputedStyle could be made immutable. Bug: 813068 Change-Id: I7cebac7951adbf65dbb057ef7b75d4ddab62e90c Reviewed-on: https://chromium-review.googlesource.com/924145Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#537340}
-
jonross authored
A proposal to allow the renderer to notify the browser of frame submission, along with RenderFrameMetadata. This change adds cc::RenderFrameObserver which LayerTreeHostImpl can notify of frame submission. This change adds content::RenderFrameObserverImpl which implements the above. RenderWidget sets this on the LTHI. MainThreadFrameObserver has been updated to enable observing. NonBlockingEventBrowserTest.StartTouch has been updated to make use of this. TEST=NonBlockingEventBrowserTest.StartTouch Bug: 785013 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ic01e81331b34119a08488778f5dbe0c86a1775a3 Reviewed-on: https://chromium-review.googlesource.com/886655 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#537339}
-
Dave Tapuska authored
The test was disabled a year and a half ago due to flakiness. I cannot reproduce it anymore. BUG=376668 Change-Id: I7b6c99187f9ce53af2252dfe95e0b68da322af98 Reviewed-on: https://chromium-review.googlesource.com/922341Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#537338}
-
Francois Doray authored
This code is not used anymore. Bug: 810049 Change-Id: I029652468ec67d8b238a89e25b8cb9193435b4dd Reviewed-on: https://chromium-review.googlesource.com/909289 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#537337}
-
Min Qin authored
Simply moving the files, no structural change BUG=803135 Change-Id: I2c986f07eae2fef2bd316cda512054c27c01758c Reviewed-on: https://chromium-review.googlesource.com/920643Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537336}
-
Rune Lillesveen authored
Bug: 813068 Change-Id: Ie5e3b8ccafd801575a5f886f1902abc547d9bacc Reviewed-on: https://chromium-review.googlesource.com/923983Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#537335}
-
Thiemo Nagel authored
BUG=813098 TBR=editing-dev Change-Id: I9005cfc1cf4011ee0b424cb7f06270786115a386 Reviewed-on: https://chromium-review.googlesource.com/924221Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#537334}
-
Aga Wronska authored
Pin keyboard should be only visible when there is no virtul keyboard displayed. Observe virtual keyboard state in order to update pin keyboard visibility. Bug: 799082 Change-Id: I9ef33faf699dfc78cdd09145f4c2aee43e52afab Reviewed-on: https://chromium-review.googlesource.com/903414 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#537333}
-
stkhapugin@chromium.org authored
Removes mentions of iOS <10 and removes one unnecessary if-condition. Bug: None Test: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I14b5e26b5b311011f3430fad813c164a8c682a27 Reviewed-on: https://chromium-review.googlesource.com/893186 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#537332}
-
Mike Wasserman authored
Avoid GetAllWidgets in classic ash and mus Chrome OS browser tests. These configs cannot get a list of root windows at the Views layer. Add a DCHECK to avoid using GetAllWidgets in those scenarios. Win/Linux/Mac query their WMs directly for root windows; on Chrome OS: 1) Mash can use MusClient to get a list of root windows. 2) Unit tests can use AuraTestHelper to get the root window. 3) Non-mash browser tests must use ash::Shell to get root windows. This should land after http://crrev.com/c/919922 Bug: 811940 Change-Id: I609531529ff5c4379f6c1de47ca878b30e7dd614 Reviewed-on: https://chromium-review.googlesource.com/922268Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#537331}
-
Katie D authored
The next change will follow onto this one by scrolling to the currently spoken node if it is offscreen. Bug: 812874 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9ad68a2e88885ea7e94f09eb95b8b689eb9a0fd2 Reviewed-on: https://chromium-review.googlesource.com/923085Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#537330}
-
Mike Wasserman authored
This test seems to work as-is, and passed 100 times in a row locally. Hopefully it's no longer flaky; let's give it a shot. Bug: 676746 Change-Id: I28857f2c97b354160bd945bb284083b080938899 Reviewed-on: https://chromium-review.googlesource.com/922794Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#537329}
-
stkhapugin@chromium.org authored
In many situations two views are constrained by three sides, and: a) the fourth side is constraint to another view b) the fourth side is constraint with an offset This implements a new helper: void AddSameConstraintsToSidesWithInsets( id<LayoutGuideProvider> innerView, id<LayoutGuideProvider> outerView, ios::LayoutSides sides, ios::ChromeDirectionalEdgeInsets insets); This should allow writing things like: AddSameConstraintsToSidesWithInsets(view1, view2, LayoutSides::kTop|LayoutSides::kLeading, ChromeDirectionalEdgeInsets{10, 5, 8, 8}); and a simplified version with no insets: AddSameConstraintsToSides(view1, view2, LayoutSides::kTop|LayoutSides::kLeading); These helpers should reduce boilerplate in layout code. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If1ef5427dde1fe7e098f212b6917d9566d1df0e6 Reviewed-on: https://chromium-review.googlesource.com/859789 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#537328}
-
Xi Cheng authored
Bug: 734095 Change-Id: Ied49badaccb894dc7f7637d855788d79ec7c79df Reviewed-on: https://chromium-review.googlesource.com/920362Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#537327}
-
Brian White authored
A bad merge used the wrong code and caused the wrong counter to be incremented. Also: Add sampled-out entries to the DroppedDataReason. Bug: 766909 Change-Id: I1dc695248920dce431ada6a5e085be58b3edc895 Reviewed-on: https://chromium-review.googlesource.com/922271Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#537326}
-
Thiemo Nagel authored
This reverts commit d70e8035. Reason for revert: compilation error Original change's description: > [Mash] Serialize the rest of RichNotificationData and Notification. > > TBR=rdevlin.cronin@chromium.org > > Bug: 578868 > Change-Id: I362564a5469fedd7f16024303b8dfd54046da8b1 > Reviewed-on: https://chromium-review.googlesource.com/917527 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537315} TBR=jamescook@chromium.org,stevenjb@chromium.org,rdevlin.cronin@chromium.org,estade@chromium.org,tsepez@chromium.org Change-Id: I1aba72cf82a62a469f44441795d02053b832b71e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 578868 Reviewed-on: https://chromium-review.googlesource.com/924059Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#537325}
-
Shivani Sharma authored
This CL adds a flag to ResourceRequest which is currently set based on the subresource filter component matching. Subsequently this will also be set when the initiator of this resource is an ad resource even if this does not match the subresource filter ruleset. This plumbs the flag from blink::ResourceRequest up to content::ResourceRequest so that it can be used in the browser process as well in a future CL. Bug: 807640 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I09fe5b3168cae53b47b4eefff4a1bddfac6a98b4 Reviewed-on: https://chromium-review.googlesource.com/860619 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#537324}
-
Olga Sharonova authored
This is a follow-up CL which makes the code to use AudioService for access to audio systeminformation. Follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/875927 Done separatly to simplify a revert if one is required. Bug: 792441 Change-Id: I9664b5f8b4364bb019232b10d7aa2dd93ddaf957 Reviewed-on: https://chromium-review.googlesource.com/918901 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#537323}
-
https://chromium.googlesource.com/angle/angle.git/+log/b66de58fc571..17448956b720 $ git log b66de58fc..17448956b --date=short --no-merges --format='%ad %ae %s' 2017-01-05 fjhenigman Vulkan: vertex attributes in client memory. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: Icc1be1c0148445edbc00717df4360cb7b9209872 Reviewed-on: https://chromium-review.googlesource.com/923355Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537322}
-
David Trainor authored
Expose the various process ids in chrome to the feedback collection system. BUG=773408, 773409 Change-Id: I352645c5e76213150cf2a46f58c2db5ca7523866 Reviewed-on: https://chromium-review.googlesource.com/832508 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#537321}
-
Ashley Enstad authored
Bug: 781312 Change-Id: Ia8c7eba3853f1dff32e95c6f89d2fbfcc2e73aeb Reviewed-on: https://chromium-review.googlesource.com/921926Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#537320}
-
Elly Fong-Jones authored
TBR=lgrey@chromium.org Change-Id: If0c2462b6c72b6ba77f61e1dd249e38c82999748 Reviewed-on: https://chromium-review.googlesource.com/924084Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#537319}
-
Xi Han authored
In this CL, we split the creation of the BrowserThread::IO thread and initialization of its delegate: 1. The BrowserThread::IO is created in the BrowserMainLoop::PostMainMessageLoopStart() after the UI thread is created. Adjust the tracing events in the BrowserMainLoop. 2. Simplify the logic in BrowserMainLoop::CreateThreads() since only the launcher thread is created there. Initializes the delegate of the BrowserThread::IO there. 3. Update the logic in the BrowserThreadImpl when checking whether the BrowserThread::IO has initialized. 4. Update BrowserMainLoopTest and BrowserProcessImplTest. This is the first step of starting ServiceManager earlier. Bug: 729596 Change-Id: I7a08fd7c7bf5548f8039c8c38152ecfde3bd20c4 Reviewed-on: https://chromium-review.googlesource.com/905424 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#537318}
-
Robert Flack authored
There are multiple accessibility notifications but the test should only continue when it receives the one for the programmatic scroll. This patch also fixes another use after free from trying to use the smooth scroll coordinator. Bug: 797298,812702 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1340d8cd1d5d3e53e75d9ab0c5f50b523041b187 Reviewed-on: https://chromium-review.googlesource.com/922685 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#537317}
-
Leonard Grey authored
Change-Id: I7e2aa4037ef014ccc9b5943ef01c005f58139000 Reviewed-on: https://chromium-review.googlesource.com/922762Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#537316}
-
Evan Stade authored
TBR=rdevlin.cronin@chromium.org Bug: 578868 Change-Id: I362564a5469fedd7f16024303b8dfd54046da8b1 Reviewed-on: https://chromium-review.googlesource.com/917527 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#537315}
-
Amirhossein Simjour authored
Fling is not consumed by content anymore, so we can remove it from the controller. BUG=none Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I85c958e4e8b4ca2dde4f20948978bebfad732543 Reviewed-on: https://chromium-review.googlesource.com/919544 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#537314}
-
Sylvain Defresne authored
Refactor IOSChromeBrowsingDataRemover to have a queue of pending removals (based on similar refactor that happened to BrowsingDataRemover in //content). Remove helper class BrowsingDataRemoverHelper as it is now redundant (it implemented the pending removal tasks queue). Change IOSChromeBrowsingDataRemover from thread-affinity to sequence-affinity (as is recommended). Fix references to old enumeration RemoveDataMask. Bug: none Change-Id: I4d18b2d0db59954af723e72af034b57acdc7e85d Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/918666 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537313}
-
Troy Hildebrandt authored
This reverts commit 6df08e7d. Reason for revert: Tests fail on K tablet. TBR=tedchoc@chromium.org Original change's description: > [Android] Show voice search icon alongside delete button in omnibox. > > Allows the voice search button to display alongside the delete icon in > the omnibox, as long as voice search is enabled. Hides the feature > behind a flag. > > Bug: 807726 > Change-Id: I3695222b9ca0f74673ca286e052b121fdfde924b > Reviewed-on: https://chromium-review.googlesource.com/896002 > Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537289} TBR=mariakhomenko@chromium.org,tedchoc@chromium.org,thildebr@chromium.org Change-Id: Iac939cc82ba49be164bdfcf0f2be9c7c20136213 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 807726 Reviewed-on: https://chromium-review.googlesource.com/923423Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#537312}
-
Raymond Toy authored
Replace the tests that are using ScriptProcessor and online contexts with an offline context and verify all the output values instead of just one. This change exposed a couple of issues: - setTargetAtTime wasn't actually testing setTargetAtTime because a linearRampToValueAtTime event was called at the same time, effectively replacing the setTargetAtTime event - linearRampToValue and exponentialRampToValue tests expose bugs in Chrome's implementation of these when the event is scheduled in the past, and there is no preceding event. Bug: 812285, 626703 Change-Id: Iad3f54dd4373411431c019de44d4c3bad07587ff Reviewed-on: https://chromium-review.googlesource.com/919151 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#537311}
-
Francois Doray authored
Some code in Chrome needs to change the window tree in response to a change of visibility for a WebContents (e.g. close zoom bubble, create a new RenderWidgetHostViewAura). Because of that, we need to allow changes to the window tree from aura::WindowDelegate::OnWindowOcclusionChanged(). With this CL, aura::Window::SetOcclusionState() is not called immediately when the occlusion of a tracked window is computed. Instead, we compute occlusion for all tracked windows. Then, we call aura::Window::SetOcclusionState() on all tracked windows. Having separate phases ensures that the window tree is not modified while occlusion is being computed. If a call to aura::Window::SetOcclusionState() in the 2nd phase changes the window tree in a way that could affect occlusion, we go back to phase 1. There is a hard cap of 2 iterations, after which we crash. Bug: 668690, 813076 Change-Id: I61e5cdbb605343a5b587aeb96effcbd8dc07de33 Reviewed-on: https://chromium-review.googlesource.com/861953 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#537310}
-
Charlie Andrews authored
TBR=ashleymarie@chromium.org NOTRY=true Bug: 812615 Change-Id: Ib89c68b30e3b0f33eded7e35572dd71208d60a4d Reviewed-on: https://chromium-review.googlesource.com/922788Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#537309}
-
Charlie Andrews authored
TBR=chiniforooshan@chromium.org NOTRY=true Bug: 812618 Change-Id: I626b76647aa5dd8b85f681ca9d33c0f10cf24931 Reviewed-on: https://chromium-review.googlesource.com/922911Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#537308}
-
Gabriel Charette authored
As requested @ https://chromium-review.googlesource.com/c/chromium/src/+/738469/8/docs/design/threading.md#b122 Already had "Keep the Browser Responsive" and "Use Sequences instead of Locks" sections, but amended them with a bit more text from the old docs. R=jam@chromium.org Bug: 752144 Change-Id: I67857ad21f8cc5884aeb65fe08fe184f63deed44 Reviewed-on: https://chromium-review.googlesource.com/921041Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#537307}
-
Rune Lillesveen authored
We currently don't compute style for elements being reattached in the style recalc step when the element has custom style callbacks. The reason is that some CustomStyleForLayoutObject() implementations rely on ancestor elements being attached. Here, we stop relying on SVG corresponding elements having a LayoutObject by retrieving ComputedStyle from the Node instead. If the parent element is being (re-)attached, we will get the non-attached style through Node::GetComputedStyle(). Bug: 813057 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I18b6a41087836746869071a409841692fa168537 Reviewed-on: https://chromium-review.googlesource.com/923732Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#537306}
-