- 27 Mar, 2019 40 commits
-
-
Ben Wells authored
Auto top level navigations include things like command line navigations, in product help links, and other similar navigations. It is possible for these types of navigations to earn engagement if they meet other checks (e.g. have a valid scheme). The reason to change this is to allow command line navigations to earn engagement. Bug: 944396 Change-Id: I7846675fd7955a2473c0951df60251661eaa1f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535201 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#644702}
-
Sam McNally authored
Sort the file names - the order of entries passed to onLaunched is not deterministic so expecting a particular order is incorrect. Bug: 946025 Change-Id: I7c3933f916e8411e6b8357a7555999fe1ad6efe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539494 Commit-Queue: Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#644701}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/022c8317d085..d1c271bd39f0 git log 022c8317d085..d1c271bd39f0 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-03-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@d1c271bd39f0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I301cd62ff3ea465033d36bd9cf43727f75bf9d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540546Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644700}
-
Alexey Baskakov authored
Rename AppInfo to InstallOptions to avoid confusion with WebApplicationInfo. We will reuse InstallOptions as a parameter object in web_app::InstallManager. Bug: 916381 Change-Id: I7e4ea7ea7986ca537d9327b190443e72c2a16661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535306 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#644699}
-
Yashar Dabiran authored
The design doc for this change: https://docs.google.com/document/d/1Qog5qwZ-6Rfx10AKkJxN-LrwhCw_GJ1xdLoQSnpsT1Q/ Changes in this CL: - Add origin trial functions to RuntimeEnabledFeatures class. To access the ExecutionContext for OT checks, FeatureContext class (defined in "runtime_enabled_features.h") has been added which ExecutionContext inherits from. - Support runtime features depending on origin trial features. * All of the OT check functions in "origin_trials.h" will be removed once all of the function calls are directed to |RuntimeEnabledFeatures| in the upcoming CLs. Bug: 934451 Change-Id: Iee47370c9309ddfbc27c17df9a5319c4a30e54a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495798Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Yashar Dabiran <yashard@google.com> Cr-Commit-Position: refs/heads/master@{#644698}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f02277bf..135b6f21 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idec8814dce8aa02013dd97965cce47e0523b98a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540545Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644697}
-
Raul Tambre authored
The script still works with Python 2. There are no intended behaviour changes. Bug: 941669 Change-Id: I1556e3083ce4b858ea2753ffd10ef2caac36df67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537100Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#644696}
-
Wei Li authored
Calling layout code in StatusView's constructor would need to call its parent's virtual functions as well, which may not be ready in its constructor. This fix moves layout code into Layout() function to avoid such problem. BUG=945650 Change-Id: I93526fe84e92d1f601dbb5d08cbf45e1a88c6fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539031Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#644695}
-
Luciano Pacheco authored
Move Drive context menu tests related to directory tree to directory_tree_context_menu.js. Delete tests for removable that have been migrated to directory_tree_context_menu.js. For both set of tests (Drive and Removable) were checking only 1 menu item, the new tests checks for all menu items on those entries. Remove TODOs that aren't relevant anymore. Change-Id: I92db7ac5229cd588066f1b47410e2b160549a916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534912 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#644694}
-
Naoki Fukino authored
This implements write operations in Chrome OS file system backend. It enables Files app to perform following operations. * Delete file in documents providers. * Rename file in documents providers. * Create file in documents providers. * Copy files inside the same document provider. * Move files inside the same document provider. Design doc: go/files-dp-rw Android side change: ag/6550846 Bug: 895479 Test: Manually tested, and ran unit_tests. Change-Id: I14f623cd39dc039477f0b0251a50fc3260e24345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490361 Auto-Submit: Naoki Fukino <fukino@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#644693}
-
Findit authored
This reverts commit 85b389ca. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 644624 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzg1YjM4OWNhYTdkNzI1Y2RkMzFmNTllOWEyYjc5ZmY1NDgwNGI3YjcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/57482 Sample Failed Step: content_unittests Original change's description: > AppCache: Add padding to cross-origin responses. > > Bug: 918293 > Change-Id: I4f16640f06feac009d6bbbb624951da6d2669f6c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488059 > Commit-Queue: Staphany Park <staphany@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644624} Change-Id: Iab68370e154f858ae05b9cebc0e07ce666e93a1f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 918293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540723 Cr-Commit-Position: refs/heads/master@{#644692}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/62c6a3871085..022c8317d085 git log 62c6a3871085..022c8317d085 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2019-03-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a47e2a23ab4c..518c679da109 (3 commits) Created with: gclient setdep -r src/third_party/skia@022c8317d085 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I8af2057a80cbc7b054bca5a4a209fd0afc322bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540462Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644691}
-
Simon Que authored
This reverts commit 58e8d8c6. Reason for revert: Cannot combine mixins Original change's description: > infra: Add and use mixins for Goma RBE server settings > > R=tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org > > Bug: 945701 > Change-Id: I98b2a8a2d644eccde84224171bbe7e9885041046 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539416 > Commit-Queue: Simon Que <sque@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644219} TBR=sque@chromium.org,ukai@chromium.org,yyanagisawa@chromium.org,tikuta@chromium.org Change-Id: Ife0174d62bec2bf99d75647b864fd6c7992fa30e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 945701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539490Reviewed-by:
Simon Que <sque@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#644690}
-
Luciano Pacheco authored
Converted with lebab: $ lebab --replace tree.js --transform class Then manually: 1. Move @extends {cr.ui.TreeItem} to actual ES6 extends. 2. call super() in the ctor. 3. Move Closure markup from class to its ctor. 4. Remove return from ctor. 5. Rename item.* to this.* in ctor. 6. Check FunctionName.prototype = { __proto__: ... } move getters/ setters to class body, removing trailing commas. 7. Fix closure errors, mostly declaring attributes in the ctor. 8. Run clang format in the file, because lebab format style is very different. $ buildtools/linux64/clang-format -i \ ui/file_manager/file_manager/foreground/js/ui/directory_tree.js Test: No change in behavior, so current tests already covers it. Bug: 778674 Change-Id: I2f11ea6d85ef9546fc3b54e5b0a5e187e8b3e90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539479 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#644689}
-
Gayane Petrosyan authored
Bug: 944941 Change-Id: I550c11f4ff5177be7ec7c4d23be457b1c05e3b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540070 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#644688}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9a2d4c59. With Chromium commits locally applied on WPT: 685a1df9 "Extend canvas getContextAttributes WPTest" 11eae161 "HTMLVideoElement: implement playsinline and auto-fullscreen." 1bf12f7c "Revert "Fix external/wpt/event-timing/event-timing-onloadobserve.html to be more deterministic"" efbe41b8 "Change unoptimized-images feature policy to unoptimized-lossy-images." 34ea864a "Revert "Change unoptimized-images feature policy to unoptimized-lossy-images."" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I25ad3999ceb2b767be1348341f17bc1f25e9c22b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540816Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644687}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I6d772cc5f7a62c0d708ae1d78eb89ae34e9520bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540740Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644686}
-
Simon Que authored
This will increase the load. We can adjust the overall load by turning individual builders on/off. R=tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org Bug: 945731 Change-Id: I30792178e164acc210785d3a7670e0b0159de996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539489 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#644685}
-
Elly Fong-Jones authored
Bug: None Change-Id: I14bec876c5320c6f34b3d285de74839f3e76acb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539797 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#644684}
-
Koji Ishii authored
This patch ensures OOF within truncated inline-blocks are propagated when 'text-overflow: ellipsis'. Bug: 945690 Change-Id: I856469cc76e083ad3be2e82cde8f571a9467478a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539483 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#644683}
-
Simon Que authored
These should come after Linux Goma RBE Prod, since they use the Prod backend. R=tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org Bug: 945731 Change-Id: Ib230774e7923d9745998d2f2ffce4928c7732844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540024Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#644682}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1fb2e697..f02277bf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I90fe1864ab34283fb302be8f3dcefcf5f0e61d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540818Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644681}
-
Eli Ribble authored
Reland commit f4f6c5ff Revert 1 was 172ccc05 Revert 2 was cd0e1d01 The previous attempt at a reland failed during gclient sync when lastchange.py attempted to perform "git log -1 --format=%H %ct --grep=^Change-Id: HEAD" The new logic shows the git failure but falls back to the original logic of defaulting to a version of 0.0.0 when the git command fails. Bug: 917159 Change-Id: I22a03fe773a3507e566abb9d29eac08d7e56a647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533261Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Eli Ribble <eliribble@chromium.org> Cr-Commit-Position: refs/heads/master@{#644680}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/52233432102f..62c6a3871085 git log 52233432102f..62c6a3871085 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 4035f6c8..83d44af5 (535 commits) Created with: gclient setdep -r src/third_party/skia@62c6a3871085 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I6734502eac073df26555c00996cc640cd21faf87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540722Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644679}
-
Oksana Zhuravlova authored
This change exports a 'lite_closure_type' filter and modifies the corresponding function to put an underscore instead of a dot for nested enums. This new filter is now used in the enum template. Bug: 939078 Change-Id: I0c4c1a7b08b6df09d460350a22f5b8cbcf318bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538707 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#644678}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c5119b1cfe05..3a6175755f55 Created with: gclient setdep -r src-internal@3a6175755f55 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=sahel@chromium.org,horo@chromium.org,pkasting@chromium.org,andruud@chromium.org Change-Id: Ie966d413b4962a8a24532f8f60c6ee09470a5e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540721Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644677}
-
Dan Beam authored
Screencast: https://drive.google.com/open?id=11JgUXbqgQJJViZsNC35v98zOwRVs5Ymh R=rbpotter@chromium.org BUG=939731 Change-Id: I5df51c152163f9995316ef5a706c56d3e9c5dc40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540409 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#644676}
-
Sara Kato authored
Android side change ag/6513593 Tooltip actions added in API28, in AccessibilityNodeInfo. - ACTION_SHOW_TOOLTIP - ACTION_HIDE_TOOLTIP Wire these to Chrome side, by adding a new type of action to the automation API. Test: manual (manually check that tooltip action is sent correctly) Bug: b:77885472 Change-Id: I2f708a6646259fb38f5b10a4c9f1299ca91ea1ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488401Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#644675}
-
Noel Gordon authored
In RELEASE approximation: keep it on ASAN MSAN DEBUG waterfall bots. No-try: true Tbr: lucmult@ Bug: 946025 Change-Id: I7ff0e557b3b1e0bf3b1d895de4eadb0d78e050f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539485Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#644674}
-
chrome://app-iconsLucas Tenório authored
With this change we will be able to show any app icons just by appending their app id to chrome://app-icons. If we don't do this type of whitelisting, the only other way we can pass the icons to the Kiosk Next Home is to encode their images and pass them through mojo. That other approach was implented here but it's much more cumbersome: http://crrev/c/1539156. Bug: 927809 Change-Id: Id1b63b3959d335dabcccd6d8a743e2e6e825ef01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534414Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#644673}
-
Nigel Tao authored
BUG=826982 Change-Id: I92ae60805aecd9be96afebf8c28a96f8d4b91963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539633Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#644672}
-
Xianzhu Wang authored
They occasionally timeout on all platforms, and occasionally fail on Win7. Mark them [ Pass Timeout ] on all platforms, and [ WontFix ] on Win7. Bug: 946022,919789 Change-Id: I86fe6fa5324871737d04a9c40c664e9c7b1a7a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540483 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#644671}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bf341ae88c83..52233432102f git log bf341ae88c83..52233432102f --date=short --no-merges --format='%ad %ae %s' 2019-03-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@52233432102f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Ife5fa6d301cfcae3dabf1653195f41088c6b4b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540720Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644670}
-
Patrick Monette authored
As part of moving the ModuleDatabase to its own sequence, the chrome://conflicts page still needs to access its content from the UI thread. This is done by the ConflictsDataFetcher, which lives on the ModuleDatabase task runner and returns the resulting data to the conflicts handler. Bug: 943303 Change-Id: I73c1413afaa1555abc2ba3c3bc891851b75ad71a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531090 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#644669}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I62f20c327c6ee780d10bc0806bf14bc2dbc35da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540660Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#644668}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/261711304bcc..c5119b1cfe05 Created with: gclient setdep -r src-internal@c5119b1cfe05 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=sahel@chromium.org,horo@chromium.org,pkasting@chromium.org,andruud@chromium.org Change-Id: If83afabde6471dc636f244aea6b4caba566bfe6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540718Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644667}
-
Andrew Grieve authored
Change-Id: Id4f175a316925cdac169cb67622dae3f172fec44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539868 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#644666}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ffb1c9fdaf5e..2b058ca0584c git log ffb1c9fdaf5e..2b058ca0584c --date=short --no-merges --format='%ad %ae %s' 2019-03-27 rmhasan@google.com Move calling of ExpectationsFiles function Created with: gclient setdep -r src/third_party/catapult@2b058ca0584c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:698902 TBR=sadrul@chromium.org Change-Id: I7971bf30afe8c6f62b32b7a149c638fb9504fd54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540719Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644665}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8244b454..1fb2e697 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I127609053f31e3682d1a47947767acb767108078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540144Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644664}
-
Toni Barzic authored
Updates UpdateScreen browser tests to test UI state changes in addition to interactions with Chrome OS system state. Adds coverage for testing the screen state when update requires user confirmation to proceed (when the current network connection is detected as metered), and reboot request timeout. To make testing easier: * extracts logic for setting up network portal state into NetworkPortalDetectorMixin (this will be reused for other tests). * refactors OobeScreen waiter to have only one Wait method, and wait parameters are expected to be set before a call to Wait() * introduces an option to confirm that no other oobe screen is shown before the target screen * remove unused WaitForInitialization BUG=945133 Change-Id: I1c9899f9adad6d70a5de5d206fa1d3adf2f7e06f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536112Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#644663}
-