GitLab

1) Compute it at most once in the lifetime of the browser (rather than at most once per PrefHashCalculator).

2) Explicitly AllowIO in the scope of this computation. This isn't ideal, but there is no other good way until we can get rid of this legacy artifact in a few milestones.

Note that I have to skip a presubmit error for (2): "Banned functions were used. New code should not use ScopedAllowIO." :(.

BUG=361687
R=erikwright@chromium.org

Review URL: https://codereview.chromium.org/231673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262995 0039d316-1c4b-4281-b951-d872f2087c98

Once gpu rasterization is disabled on a layer, it will stay disabled.

BUG=329722

Review URL: https://codereview.chromium.org/222903005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262994 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357050
TEST=none

Review URL: https://codereview.chromium.org/230503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262993 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262991 0039d316-1c4b-4281-b951-d872f2087c98

In both aura/views and mac, notifications are done through the message-center. So
the implementations of BalloonCollection are never used. So remove these. Only the
GTK version of the implementation remains.

BUG=354062, 361784
R=mukai@chromium.org, rsesek@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/231213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262988 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361585

Review URL: https://codereview.chromium.org/226183015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262987 0039d316-1c4b-4281-b951-d872f2087c98

 - The 'compare and swap' operations should enforce memory ordering even when
   the exchange does not occur.
 - The exclusive monitor does not need to be cleared by CLREX if a LDRX was
   not followed by a matching STREX.
 - Use LDAR and STLR where possible.
 - Use the 'I' and 'J' constraints to hint for constants valid for immediate
   values

Based on V8 changes at https://codereview.chromium.org/220793002

BUG=354405

Review URL: https://codereview.chromium.org/230963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262986 0039d316-1c4b-4281-b951-d872f2087c98

Fix an issue where keyboard events improperly reset the scroll status while
a touch scroll was active in InputHandlerProxy.

BUG=361160

Review URL: https://codereview.chromium.org/230663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262985 0039d316-1c4b-4281-b951-d872f2087c98

Since we disabled StackTrace::OutputToStream and StackTrace::Print
for uClibc builds, we should disable the related unittests for uClibc
too.

BUG=361130

Review URL: https://codereview.chromium.org/227503009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262984 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262983 0039d316-1c4b-4281-b951-d872f2087c98

This picks up just one change, r262949: "Enable x64 build of host
toolset".

BUG=346626
TBR=jshin@chromium.org

Review URL: https://codereview.chromium.org/232673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262982 0039d316-1c4b-4281-b951-d872f2087c98

BUG=352046

Review URL: https://codereview.chromium.org/228763006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262981 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344836, 235466
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/232723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262980 0039d316-1c4b-4281-b951-d872f2087c98

Disable rasterize_and_record_micro.top_25 on Windows because of crashes
to make the performance bots green while investigation continues.

BUG=360666

Review URL: https://codereview.chromium.org/231393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262979 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338338
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/231923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262978 0039d316-1c4b-4281-b951-d872f2087c98

This allows to change the implementation of InfoBarDelegate::web_contents()
such that it no longer calls InfoBarManager::web_contents() (which will be
removed), but InfoBarService::web_contents() instead.

BUG=354379
TBR=jochen

Review URL: https://codereview.chromium.org/228293004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262976 0039d316-1c4b-4281-b951-d872f2087c98

Before this patch, InvokeCallbackTask was holding onto a callback using v8::Persistent, and v8::Persistent do not release on d-tor by default.
This patch changes it to use UniquePersistent, so it will release callback on |~InvokeCallbackTask|.

BUG=None

Review URL: https://codereview.chromium.org/232733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262975 0039d316-1c4b-4281-b951-d872f2087c98

The presubmit check is failing because of this.

Review URL: https://codereview.chromium.org/231843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262974 0039d316-1c4b-4281-b951-d872f2087c98

Remotely for event/object rewiring.

This also fixes all int32 used in IPC for in-memory object IDs to int

BUG=349919
TEST=no functional changes yet

Review URL: https://codereview.chromium.org/225403014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262973 0039d316-1c4b-4281-b951-d872f2087c98

BUG=317931
R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/228823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262972 0039d316-1c4b-4281-b951-d872f2087c98

Two little fixes which did not fit in any of the major CLs for the internals page.

BUG=347927

Review URL: https://codereview.chromium.org/232663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262971 0039d316-1c4b-4281-b951-d872f2087c98

Before deleting a profile, cancel all in-progress downloads to prevent a "Do you really want to exit Chrome" popup, which (1) is confusing because the message is not accurate, and (2) prevents a window corresponding to the deleted profile from closing, leaving it in an inconsistent state.

A UI update (warning the user that downloads will be canceled) will follow in a separate CL.

Note: I'm aware that this doesn't address crbug.com/289390 which is another way to trigger the same underlying bug. Working on it...

BUG=336725

Review URL: https://codereview.chromium.org/214523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262970 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354405,346626

Review URL: https://codereview.chromium.org/225093007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262969 0039d316-1c4b-4281-b951-d872f2087c98

BUG=352046

Review URL: https://codereview.chromium.org/231793008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262968 0039d316-1c4b-4281-b951-d872f2087c98

The string.h is required only when using the address sanitizer.

Review URL: https://codereview.chromium.org/229973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262967 0039d316-1c4b-4281-b951-d872f2087c98

BUG=335764
TEST=build and run the test on snow

Review URL: https://codereview.chromium.org/227613005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262966 0039d316-1c4b-4281-b951-d872f2087c98

ChromeNativeAppWindowViews now installs the EasyResizeWindowTargeter
into the content window, not its root window. The root window does not
have a delegate, which means it doesn't handle events on Linux.

BUG=357049
COLLABORATOR=sadrul@chromium.org
TEST=Open Text chrome app. All edges and corners should be draggable to
resize the app.

Review URL: https://codereview.chromium.org/224903022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262965 0039d316-1c4b-4281-b951-d872f2087c98

Added the chromeos::BluetoothRemoteGattCharacteristicChromeOS class which
implements a remote instance of device::BluetoothGattCharacteristic for the
Chrome OS platform.

BUG=360266,340529
TEST=device_unittests

Review URL: https://codereview.chromium.org/228643004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262964 0039d316-1c4b-4281-b951-d872f2087c98

This enables permissions bubble policies that rely on user gesture signals for deciding when/how to show bubble UI for permission requests.

BUG=332115

Review URL: https://codereview.chromium.org/185813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262963 0039d316-1c4b-4281-b951-d872f2087c98

Mainly nits related to preference protection.

BUG=349158

Review URL: https://codereview.chromium.org/220203011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262962 0039d316-1c4b-4281-b951-d872f2087c98

Changes TranslateUIDelegate to:
- Take in a TranslateClient and TranslateManager rather than a WebContents.
- Go through TranslateDriver and TranslateClient APIs rather than talking
  directly to TranslateTabHelper.

Moves TranslateUIDelegate into the Translate component.

BUG=335084
TBR=thakis

Review URL: https://codereview.chromium.org/229363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262961 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces an interface that will be used to access all of chrome/ API.
It is implemented by the FaviconTabHelper, and allows moving the
GetFaviconService() method out of the FaviconHandler.

BUG=359095

Review URL: https://codereview.chromium.org/228783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262960 0039d316-1c4b-4281-b951-d872f2087c98

* Added new mode in TrayUser for the case when new account management is
  enabled (--new-profile-management flag). In fact TrayUser is now supporting
  four different modes, depending of states of |multi-profiles| flag and
  |new-profile-management| flag.
* Massive refactoring were made in tray_user.cc to isolate UserCardView
  creation in separate class and make code more clear.
* UI for the cases when new account management is disabled remained without
  changes.

Known issues:
* There are no tests for new UI. Hopefully old UI is covered by tests already.
* New UI is not accessible yet.
* Stub implementation of UserAccountsDelegate is used for backend.

BUG=344844
TEST=manually

Review URL: https://codereview.chromium.org/210903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262959 0039d316-1c4b-4281-b951-d872f2087c98

The webRequestInternal permission was unused, thus:
- Remove the permission webRequestInternal.

While there, also does:
- Remove manual registration of webRequest API and instead rely on automatically generated registration.
- Remove context 'content_script' from webRequestInternal API.

BUG=359964

Review URL: https://codereview.chromium.org/228343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262958 0039d316-1c4b-4281-b951-d872f2087c98

R=dcarney@chromium.org
R=jochen@chromium.org (OWNERS)
BUG=276323

Review URL: https://codereview.chromium.org/230613005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262957 0039d316-1c4b-4281-b951-d872f2087c98

The only purpose of this change is to rename some member
variables and accessors in BrowserAccessibility so that in the
subsequent change we can repurpose BrowserAccessibility to
make use of AXNode instead.

There should be no code logic changes here - just look at
browser_accessibility.h, everything else just follows from
that.

BUG=316726

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262673

Review URL: https://codereview.chromium.org/224803005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262956 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262955 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff dcarney@chromium.org in case of problems.

TBR=dcarney@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/231793009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262954 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262951 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Chrome for ChromeOS build is failing:
chromeos-chrome-36.0.1934.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/dom/CharacterData.cpp: In member function 'void WebCore::CharacterData::replaceData(unsigned int, unsigned int, const WTF::String&, WebCore::ExceptionState&)':
chromeos-chrome-36.0.1934.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/dom/CharacterData.cpp:146:36: error: 'realCount' may be used uninitialized in this function [-Werror=maybe-uninitialized]
chromeos-chrome-36.0.1934.0_alpha-r1:      newStr.remove(offset, realCount);
chromeos-chrome-36.0.1934.0_alpha-r1:                                     ^
chromeos-chrome-36.0.1934.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/dom/CharacterData.cpp: In member function 'void WebCore::CharacterData::deleteData(unsigned int, unsigned int, WebCore::ExceptionState&, WebCore::CharacterData::RecalcStyleBehavior)':
chromeos-chrome-36.0.1934.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/dom/CharacterData.cpp:132:36: error: 'realCount' may be used uninitialized in this function [-Werror=maybe-uninitialized]
chromeos-chrome-36.0.1934.0_alpha-r1:      newStr.remove(offset, realCount);
chromeos-chrome-36.0.1934.0_alpha-r1:                                     ^

Original issue's description:
> Blink roll 171141:171225
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=171141:171225&mode=html
> TBR=
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262942

TBR=eseidel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/233003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262950 0039d316-1c4b-4281-b951-d872f2087c98