- 01 Nov, 2018 40 commits
-
-
Jordan Demeulenaere authored
See b/118735405. Change-Id: Ia759ad8bab73d9479d832aa7dd187b51337773fc Reviewed-on: https://chromium-review.googlesource.com/c/1312479Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#604589}
-
Antonio Gomes authored
This is a reland of 947d8086 Compared to the reverted CL, this CL changes the way profiles are created, making use of the helper IdentityTestEnvironmentProfileAdaptor::CreateProfileForIdentityTestEnvironment, by overriding CreateBrowserContext. It is worth saying that the original memory failure was reproduced locally with the original CL and is now fixed. Original change's description: > [s13n] Convert c/b/ui/webui/settings/people_handler_unittest.cc to IdentityManager > > This CL converts the PeopleHandler unittests away from SignManager and > ProfileOAuth2TokenService, in favor of the new IdentityManager. > > Production code has been converted in [1]. This is a follow up steps. > > [1] https://crrev.com/c/1261637 > > BUG=890810 > > Change-Id: I405e46d2126180a2da61393bf32263ae43877b6b > Reviewed-on: https://chromium-review.googlesource.com/c/1311093 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/master@{#604377} Bug: 890810 Change-Id: I0aa039575603765bf4cec86cbb87bc86fd0b301f Reviewed-on: https://chromium-review.googlesource.com/c/1312909 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604588}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f0bf6da3705..83a7a95315fa Created with: gclient setdep -r src-internal@83a7a95315fa The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7aa172f8eb70914040249f75335de8b1d4e9a98a Reviewed-on: https://chromium-review.googlesource.com/c/1312622Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604587}
-
Evan Stade authored
Bug: 814675 Change-Id: I0eef36c50c2ec3b6dcc5566e553ed26f27379528 Reviewed-on: https://chromium-review.googlesource.com/c/1311657Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#604586}
-
Lei Zhang authored
The flag is a no-op and will be deprecated/removed in the future. Change-Id: I51532a2bc2b8e03f0489b2ac05589101d709d0c1 Reviewed-on: https://chromium-review.googlesource.com/c/1312310 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#604585}
-
erikchen authored
The TearDown method on several contexts will invokes ADB. In some instances [e.g. on receiving a SIGTERM due to timeout] there's a high probability that ADB is non-responsive. In these cases, sending an ADB command will potentially take a long time to time out. Before this happens, the process will be hard-killed for not responding to SIGTERM fast enough. This CL makes the test_runner.py SIGTERM handler set allow_adb_on_teardown=False. This prevents these contexts from invoking ADB, increasing the likelihood that SIGTERM will handled within the 30 second limit and emit JSON test results. Bug: 895027 Change-Id: Ic30cff73a82a5415c5f531eae5c8f62fb4c953aa Reviewed-on: https://chromium-review.googlesource.com/c/1311259Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604584}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e16778c0abc9..5cb84f85868b git log e16778c0abc9..5cb84f85868b --date=short --no-merges --format='%ad %ae %s' 2018-11-01 primiano@google.com Create sqlstats table with query perf logs Created with: gclient setdep -r src/third_party/perfetto@5cb84f85868b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:115958658 TBR=perfetto-bugs@google.com Change-Id: I681a6b5c2f68ef8df1d44739a14f366939b4a7ee Reviewed-on: https://chromium-review.googlesource.com/c/1312620Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604583}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/763fc966993d..e4dda60c7111 git log 763fc966993d..e4dda60c7111 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 mtklein@chromium.org remove unreachable paths in SkBlitter::Choose() Created with: gclient setdep -r src/third_party/skia@e4dda60c7111 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I08246ed8e3b51fd166c213292d469bec581f7262 Reviewed-on: https://chromium-review.googlesource.com/c/1312643Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c39d9737dc28..4115d82f09e2 git log c39d9737dc28..4115d82f09e2 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 dtu@chromium.org [pinpoint] Add metric label to chart y-axis. Created with: gclient setdep -r src/third_party/catapult@4115d82f09e2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia01320166958cf99a2c16c11bca33a2e4318bd2d Reviewed-on: https://chromium-review.googlesource.com/c/1312623Reviewed-by:
-
Anders Hartvoll Ruud authored
Initial values are currently not stored at all on ComputedStyle, and we must refer to the PropertyRegistration to figure out what the initial value for a given property is. The problem with this, is that registering a property also has the effect of giving all styles that are already computed new values (effectively). For example, if a property '--x' is not registered (and not applied on any style), the computed value of that property is the "empty value" as described in css-variables. If the property then becomes registered, the initial value suddenly becomes whatever is specified by the registration, even on the ComputedStyle objects that already exist. This causes problems for calculating transitions, because we incorrectly consider the previous computed value to be "initialValue" from the registration rather than what it really was: "empty value". This CL adds a StyleInitialData class which contains the initial values for all registered variables. This class is instantiated for the initial style, and then referenced by all ComputedStyles that inherit from that style. This makes it possible to know what the initial value was for a certain property at the time style calculation took place. R=futhark@chromium.org Bug: 848250 Change-Id: I0a44e06608738aab15cb35fbc448a47188932600 Reviewed-on: https://chromium-review.googlesource.com/c/1309736Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#604580}
-
Bin Wu authored
In QuicCryptoClientConfig, change the preferred encryption algorithm from chacha20 to aes-gcm. Client side code, not flag protected in GFE. Merge internal change: 219390992 Change-Id: I812be51b1ebacfd3c8a2fcbdac054da098306c3f Reviewed-on: https://chromium-review.googlesource.com/c/1312093Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#604579}
-
Yutaka Hirano authored
Bug: 898179 Change-Id: Ief4827898994347056aa731b30c42b9c496e5838 Reviewed-on: https://chromium-review.googlesource.com/c/1312186 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#604578}
-
Peter Wen authored
This will be used when Crashpad is turned on. Tracking these counts client-side with histograms gives us more reliable numbers than counting the minidumps that have made it server-side, since for a number of reasons further down the codepath the minidump could not end up being successfully uploaded. e.g. Unable to get to network before 3 upload attempts complete. Bug: 894027 Change-Id: I6e385a22650254a10206a78b8eab49350b989b5f Reviewed-on: https://chromium-review.googlesource.com/c/1299926 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604577}
-
Vladislav Kaznacheev authored
Apply MD icon normalizer to icons returned by Play Store search to ensure that the they are roughly the same size as regular app icons. Bug: 900685 Test: manual Change-Id: I1960397c1ef3179590cccaac4fd69176849bce17 Reviewed-on: https://chromium-review.googlesource.com/c/1310915Reviewed-by:
-
gogerald authored
This solves the problem of card autofill failure when not choosing save to Chrome Bug: 806868 Change-Id: I80668ffe9f25661e735a1d2b7cc211f9c2c4e59c Reviewed-on: https://chromium-review.googlesource.com/c/1306640 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#604575}
-
Guido Urdaneta authored
This CL adds: * NumericRangeSet::Contains(). * NumericRangeSet::EmptySet(). * ResolutionSet::FromNativeResolution(). These utilities are in preparation for supporting the resizeMode constrainable property in getUserMedia() and applyConstraints(). Drive-by: minor fixes/improvements. Bug: 854980 Change-Id: I858f406308aa9bba40521d5e740219b72e2c8a48 Reviewed-on: https://chromium-review.googlesource.com/c/1308133Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#604574}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4e9332983946..be837ac3bc79 git log 4e9332983946..be837ac3bc79 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 philipel@webrtc.org Remove RTPFragmentationHeader from LibvpxVp8Encoder. 2018-11-01 saza@webrtc.org Remove deprecated AudioProcessing::GetStatistics function Created with: gclient setdep -r src/third_party/webrtc@be837ac3bc79 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib70a8b1d0a0b7faa75f987ebd7311e99ff5a573a Reviewed-on: https://chromium-review.googlesource.com/c/1312642Reviewed-by:
-
Ella Ge authored
Fractional Mouse type pointerEvent shipped in M64 https://chromium-review.googlesource.com/753511 https://www.chromestatus.com/feature/5117956774166528 Remove the flag and clean up related todo. BUG=773813 Change-Id: Id8e17705b43d3bfe55deeed2a3bf7d39b61a71ed Reviewed-on: https://chromium-review.googlesource.com/c/1230577Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#604572}
-
Sean Gilhuly authored
Watch for a server socket when the frame sink manager is created, and run the viz devtools server on the compositor thread if it is present. The server socket is not passed in through mojo yet, so the devtools server will not be created. Bug: 816802 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic02853a2e1f845df365716c29e4f974ffd7482dc Reviewed-on: https://chromium-review.googlesource.com/c/1285078Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#604571}
-
Rune Lillesveen authored
LayoutNG used kNeedsReattachStyleChange instead of kSubtreeStyleChange on Document when changing designMode to force a re-attach. However, Document::UpdateStyle() does not have separate behavior for the two. The LayoutNG code triggers layout tree changes on style recalc appropriately. We would like to get rid of kNeedsReattachStyleChange for a full separation of style recalc and layout tree building. TEST=editing/ with LayoutNG enabled Change-Id: Iac04f705e56233de6771da224fc9e8edc9a487be Reviewed-on: https://chromium-review.googlesource.com/c/1312476Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#604570}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/682dcdd0a083..5f0bf6da3705 Created with: gclient setdep -r src-internal@5f0bf6da3705 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I71437041194e0818c259fdd1733bf07783240e78 Reviewed-on: https://chromium-review.googlesource.com/c/1312641Reviewed-by:
-
Fady Samuel authored
When parent-allocated and child-allocated LocalSurfaceIds are merged, a new LocalSurfaceId may result which represents a new allocation. The allocation timestamp was not updated upon this UpdateFrom(Child|Parent). This CL fixes that and adds corresponding unit tests. The existing unit test framework is also cleaned up a bit. Change-Id: I41038c281c6a2de48a1e3c36ae871018bbb842e8 Bug: 655231 Reviewed-on: https://chromium-review.googlesource.com/c/1310117Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#604568}
-
Mike Reed authored
Bug: skia:8493 Change-Id: Ic967d74a87741ba7e6044154730b98e44672a5a1 Reviewed-on: https://chromium-review.googlesource.com/c/1310356 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#604567}
-
Tsuyoshi Horo authored
CalculateOverheadSize() calls resource_request_.Url(), so resource_request_ must be set before setting overhead_size_. Bug: 900529 Change-Id: I7b373395c018a43934f92ef2e67acd18f00211f3 Reviewed-on: https://chromium-review.googlesource.com/c/1312187Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#604566}
-
Mike Reed authored
The current behavior of setting the embedded bitmap flag based on avoid_embedded_bitmaps_ has been in place for ~1 year. This is overriding the older size based tests which are now effectively dead code. Change-Id: I26d4d338d7a5169932ff8b665bfcbdab222e125f Reviewed-on: https://chromium-review.googlesource.com/c/1310673 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#604565}
-
Juan Antonio Navarro Perez authored
These stories ara failing with an unhandleable error, preventing the rest of the benchmark to run. Disable these as a short term quick fix. NOTRY=true TBR=nednguyen@google.com Bug: 900909 Change-Id: I8e51ced1644853469ff8310de03cb232abba9253 Reviewed-on: https://chromium-review.googlesource.com/c/1311924Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#604564}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7f4dfa4106c9..4e9332983946 git log 7f4dfa4106c9..4e9332983946 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 yvesg@webrtc.org Properly setup MockPeerConnectionObserver in tests (continued). 2018-11-01 tomas.popela@gmail.com Add support for screen sharing with PipeWire on Wayland Created with: gclient setdep -r src/third_party/webrtc@4e9332983946 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:682122 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ief57bdc07575588747837a3474c880e514bd82bf Reviewed-on: https://chromium-review.googlesource.com/c/1312640Reviewed-by:
-
Guido Urdaneta authored
This CL exposes the current resizeMode setting to the Web Platform. As of this CL, the resizeMode is 'none' if the track resolution corresponds to the native resolution of the video source, without any resolution adjustment. It is 'crop-and-rescale' if rescaling is necessary. The resizeMode currently cannot be set explicitly with getUserMedia() or applyConstraints(), but this functionality will be added in a follow-up CL. Drive-by: Add separate WPT tests for all getSettings() properties. Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V2srjdzRCXE Bug: 854980 Change-Id: Id4c683e6b2f228b17cf2354cb7fc589ca9e593a6 Reviewed-on: https://chromium-review.googlesource.com/c/1307448 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#604562}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e008d6feb2d0..763fc966993d git log e008d6feb2d0..763fc966993d --date=short --no-merges --format='%ad %ae %s' 2018-11-01 halcanary@google.com docs: fix ASAN instructions Created with: gclient setdep -r src/third_party/skia@763fc966993d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I94f9f271e420739a98033e9921061a7594837859 Reviewed-on: https://chromium-review.googlesource.com/c/1312638Reviewed-by:
-
Rune Lillesveen authored
It was almost the same. The kNeedsReattachLayoutTree flag was already set explicitly after creation when needed. The only difference apart from that was the kChildNeedsStyleRecalcFlag. Having that set on pseudo elements also should not hurt. Change-Id: I354beda2cee8c5c0f3c585a79141a74e3675bced Reviewed-on: https://chromium-review.googlesource.com/c/1311921Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#604560}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f92910970a44..c39d9737dc28 git log f92910970a44..c39d9737dc28 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 perezju@chromium.org [telemetry] Fix bad timeout=None in platform.PathExists Created with: gclient setdep -r src/third_party/catapult@c39d9737dc28 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:900877 TBR=sullivan@chromium.org Change-Id: I985b1740a83d54391b95bcdfba6cd6d35a6a4c84 Reviewed-on: https://chromium-review.googlesource.com/c/1312639Reviewed-by:
-
Robert Sesek authored
This isn't supported by posix_spawn. Bug: 179923 Change-Id: I26527e25ffb7c6bfb72f1d7b4f885866f8d277f4 Reviewed-on: https://chromium-review.googlesource.com/c/679076Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#604558}
-
Sam McNally authored
While Drive is mounting, a fake Google Drive entry is shown in Files app. If mounting fails, begin returning false for the is drive enabled "pref" to Files app and dispatch an event notifying it about the change in prefs. Bug: 889732 Change-Id: Ia79c19a36904bb73f7a3a8ed86ab52dd685689dc Reviewed-on: https://chromium-review.googlesource.com/c/1312442 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#604557}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7bdc5b6f6574..682dcdd0a083 Created with: gclient setdep -r src-internal@682dcdd0a083 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie38b1b3089be442827e27f11dc745ef9d70f1b42 Reviewed-on: https://chromium-review.googlesource.com/c/1312637Reviewed-by:
-
Stephane Zermatten authored
Before this change, the stop action, which indirectly calls AutofillAssistantUiController.onShutdown, would just leave the UI open, even after deleting the native instances. This isn't what should happen; stop/shutdown should close the UI. This also causes crashes, if the user tries to dismiss the UI. With this change, the UI is hidden by stop/shutdown before the native instances are deleted. Bug: 806868 Change-Id: Ia5d4d2e8973d0a68fb5bca4c3841429d91d1b98f Reviewed-on: https://chromium-review.googlesource.com/c/1309735 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#604555}
-
Jordan Demeulenaere authored
Before this CL, progress animations worked on debug builds but not on release builds. I suspect that it was because of ProGuard or some other mechanism that stripped away some classes/reflection information previously used by the ObjectAnimators (which only knew about the name of the property to set during the animation). This CL fixes progress animations by defining progress and color properties to use in the ObjectAnimators. Change-Id: Idcfe71e63547672d42bf50274fd838b9efcd48ad Reviewed-on: https://chromium-review.googlesource.com/c/1312477Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/59844ce57e1f..7f4dfa4106c9 git log 59844ce57e1f..7f4dfa4106c9 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 saza@webrtc.org Remove locks from AEC2 and move it into private_submodules_ Created with: gclient setdep -r src/third_party/webrtc@7f4dfa4106c9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7c3df3bee953ab0939d76946319691d56eba167a Reviewed-on: https://chromium-review.googlesource.com/c/1312636Reviewed-by:
-
Rune Lillesveen authored
kNeedsReattachStyleChange is meant to be used on DetachLayoutTree, it behaves the same as kSubtreeStyleChange on Document, and we would like to get rid of it altogether. Change-Id: I21e525206c879229c85eb57304d23bf01f3ca3a9 Reviewed-on: https://chromium-review.googlesource.com/c/1311920Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#604552}
-
Asami Doi authored
with different script type and identical script content. These tests check that a registration is updated correctly with different script type. At first Service Worker is registered as classic script type, then it is re-registered as module script type, and vice versa. A main script is identical. Bug: 824647 Change-Id: I2a3f87da1013f84c6e9495f362899dfe6ab97b45 Reviewed-on: https://chromium-review.googlesource.com/c/1298822 Commit-Queue: Asami Doi <asamidoi@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#604551}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f37be071f8e8..e16778c0abc9 git log f37be071f8e8..e16778c0abc9 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 primiano@google.com Merge "Improve performance of /proc/pid/status poller" 2018-11-01 primiano@google.com Merge "perfetto-ui: Add process tracks" 2018-11-01 primiano@google.com Merge "Add signal_deliver ftrace events to ftrace parser" Created with: gclient setdep -r src/third_party/perfetto@e16778c0abc9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I31f88750147f48f70ae660b2889dcfb591d5855f Reviewed-on: https://chromium-review.googlesource.com/c/1312635Reviewed-by:
-
