- 19 Nov, 2019 40 commits
-
-
Alexey Baskakov authored
This is a preparation CL to implement Uninstall for the new web apps. A web app can't be fully uninstalled by any call site. Instead: A call site may request uninstallation, but the app may stay installed if it is required by other sources. CanUserUninstallFromSync+UninstallWebAppFromSyncByUser is just one scenario for uninstallation. UninstallExternalWebApp will be extended. Bug: 901226 Change-Id: I91f13754c0cc4a2fe80fd2a7b79e340ea9c3b2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921019Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#716438}
-
Xianzhu Wang authored
This reverts commit 93235d0e. Reason for revert: The failing test just needs a rebaseline (done in this CL). We don't have CQ coverage for mac10.10 so the original CL passed CQ. Original change's description: > Revert "[CompositeAfterPaint] Remove internals.elementLayerTreeAsText()" > > This reverts commit bd07dee9. > > Reason for revert: Fails color-layer test on Mac10.10: > https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/48789 > > Original change's description: > > [CompositeAfterPaint] Remove internals.elementLayerTreeAsText() > > > > The layer tree mode is not supported in CompositedAfterPaint. > > Remove it and rewrite the tests so that the tests will pass in > > CompositeAfterPaint. > > > > Change-Id: Ided24dc50b6804397777fec8fbce45d8d6cb3174 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918295 > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#716300} > > TBR=kenrb@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org > > Change-Id: I5a8667762698a7879975510df28578558c29295e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923208 > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#716389} TBR=kenrb@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,loyso@chromium.org Change-Id: I1d26efe39fb7dd21ce0509a43cdd62981c68ad1d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923329 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#716437}
-
Gavin Williams authored
-Read the name of the popUpButton before the value to give the user better context. Change-Id: I824f3382df5164cf03e24941d678d575b9baaf5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919525Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#716436}
-
jonross authored
The angle_end2end_tests have begun failing on the Win10 FYI x64 Release (AMD RX 550) bot. While this is a regression, we are interested in qualifying the GPU currently, not pursuing regressions. With all other bots fine we are just temporarily removing these tests from this bot. TBR=ynovikov@chromium.org TEST=angle_end2end_tests Bug: 1025745 Change-Id: Iffa03627dd8e6f4e6151c8aef6730189d6ae3ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922694Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#716435}
-
Matthew Wang authored
Bug: 1025854 Change-Id: Idd237754668d1d9f13a47ff914bee0c143c0d721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922451 Auto-Submit: Matthew Wang <matthewmwang@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#716434}
-
Rayan Kanso authored
The new Background Service features just hit the latest version of Chrome. It would be good to monitor the overall usage metrics for a few more milestones. Bug: 988721 Change-Id: I6cea481310b519e0e9965bae8cca0dc80296c3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919765 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#716433}
-
Alexey Baskakov authored
This reverts commit c42ecf7b. Reason for revert: Breaks chromedriver_unittests on Linux CFI https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/15659 Original change's description: > [ChromeDriver] Wait for Current Frame to load > > When Waiting for Pending Navigation, code will respond to loading events > for the current frame as well as the top frame. ChromeDriver will > therefore wait for changes in the current frame to complete before > running the next command. > > Bug: chromedriver:3164 > Change-Id: Id9000afcb7e7a7689466c395071dcccc09c8b23d > Fixed: chromedriver:3164 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859637 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Tricia Crichton <triciac@chromium.org> > Cr-Commit-Position: refs/heads/master@{#716204} TBR=johnchen@chromium.org,triciac@chromium.org Change-Id: I8d840ae0c9cd1e24c5537e5dfe101f4aedc120df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromedriver:3164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923213Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#716432}
-
Caleb Rouleau authored
This follows the advice from https://stackoverflow.com/questions/1408356/keyboard-interrupts-with-pythons-multiprocessing-pool I tested it and it works. Bug: 1026004 Change-Id: Ic57ba9fec12d4838b0c5b7c7ca9278d8d0fc8e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922592 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#716431}
-
Caleb Rouleau authored
TEST=Ran instructions from https://bugs.chromium.org/p/chromium/issues/detail?id=1023441 manually and it seems to work now. Bug: 1023441 Change-Id: Ic36dcd5e74c884d7636bd57ccb9e7e014b8484b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912916 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#716430}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d0f5ec35. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." c8b6e1ce "Chromedriver] Fix PerformAction to support multi touch points cases" 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." eb07c684 "[scroll-snap] Add keyboard test to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-method-basic-card NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic138c9cce75d19378605f955e39fceb06c705422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921544Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716429}
-
chrome://new-tab-pageEsmael El-Moslimany authored
The launch of WebUI NTP depends on an effort that has begun that will allow WebUI pages to use <iframe>'s. The embedded <iframe> content will be site-isolated from the embedder if the embedder is a WebUI page. The parts of the page that depend on this are the OneGoogleBar, doodle, voice search and promo. I plan to work on tasks that do not depend on embedding isolated content. - Create placeholder WebUI page - Create parts of the page * search box * shortcuts and most-visited sites * customization * search suggestion chips (if still relevant after zero-suggest) - Flag that uses chrome://new-tab-page in place of chrome-search://local-ntp/local-ntp.html Bug: 997229 Change-Id: I333588a379193d9fe6c542eaed589ff2e6cb4f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769054 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#716428}
-
Reilly Grant authored
Bug: 1007665 Change-Id: I0c22e26a575e4cb346944c6419d26ea4bc165eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918648 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#716427}
-
Sara Kato authored
ChromeVox reading placeholder text was done in a previous change (crrev/c/1855621). However this placeholder text should be appended to the name of the node, rather than part of the hint_ method. Also note that Android often uses the hint_text attribute to store the placeholder text in textfields. TEST: AXTreeSourceArcTest.AccessibleNameComputation Bug: 1014802 Change-Id: I84863595f84dfa12ddc40c3e96f27bc3d41b51c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889270 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#716426}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d0c07f112eb2..9c81f8738a47 git log d0c07f112eb2..9c81f8738a47 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 bryan.bernhart@intel.com Allow SetBindGroup command to be skipped with dynamic offsets. Created with: gclient setdep -r src/third_party/dawn@9c81f8738a47 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I0883606da353b7b37ead17e781e405a80d8b1ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922628Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716425}
-
Frank Liberato authored
Change-Id: I263abe356ff2227624658beda01b794dc0892e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917978 Auto-Submit: Frank Liberato <liberato@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#716424}
-
Alex Newcomer authored
This shouldn't move the shelf or hotseat. Bug: 1025080 Change-Id: I70f48b99e96ca590890706edc84b623509bb561d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919629 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#716423}
-
Aaron Colwell authored
This is a minimal fix to avoid renderer kills for about:blank URLs being committed in the wrong process. This restores M78 about:blank behavior in a very narrow case and is intended to be easily merged to the M79 branch. Bug: 931895 Change-Id: Ie958b667f6879afbcebfe18e3f3f80f8cd88884b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922693 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#716422}
-
Matt Wolenetz authored
BUG=1025493 TBR=tangltom@chromium.org Change-Id: Ibad0fbe19cd7ea6ab4327a966b168508de0a61f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923327Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#716421}
-
rbpotter authored
Update the bookmarks Web UI to use Polymer 3/JS modules, and remove usage of HTML imports. Also update all bookmarks tests. This slightly reduces the size of the bookmarks resources on optimized builds, by around 6%: Before: vulcanized.html 100k crisper.js 207k Total: 307k After: vulcanized.html 1k bookmarks.js 287k Total: 288k Note: Not running clang-format on chrome/browser/resources/bookmarks or chrome/test/data/webui/bookmarks, to make reviewing/rebasing simpler. Both these folders will be formatted separately in a followup CL. Bug: 1022213 Change-Id: Ib7093f3f10e89f7bd08fc3cc23dee445c3662f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917946Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#716420}
-
Yun Liu authored
android-code-coverage-native builder page: https://ci.chromium.org/p/chromium/builders/ci/android-code-coverage-native?limit=200 Bug: 985574 Change-Id: Ica03ac3ce5471b886323ad294da3894d96b73e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922692Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#716419}
-
Ted Choc authored
BUG= Change-Id: Ief8e44188b95ac8ad85b11570f766fa04cec4a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921731 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#716418}
-
Sebastien Marchand authored
Change-Id: I7a645b839bb2a09f24929001b8f8017069b6216f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903955 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#716417}
-
Emilio Cobos Álvarez authored
Bug: 916631 Change-Id: I307aac195ddb9c30ff7408f6f33f729669f5a855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923287 Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: Emilio Cobos Álvarez <emilio@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#716416}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ifecedd1210fb98d191c6b8feabfc137bea33d10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922771Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716415}
-
Henrique Ferreiro authored
This CL ports calls to Foo::Create() factory functions in //third_party/blink/renderer/bindings/core to MakeGarbageCollected<Foo>. Bug: 939691 Change-Id: Iee958f00400fd662c09e64371be97fc676341f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920825Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#716414}
-
Jeroen Dhollander authored
Previously when the Assistant greeting label was not needed it remained visible but with an opacity of 0. This causes it to still be part of the accessibility tree, and the user could still tab over it when enabling ChromeVox. To solve this a new |FadeOutAndHide| method was introduced that will fade out a view and set its visibility to |false| when the fade out is completed. This method is now used both in the embedded and standalone Assistant UI. Tests: Manually tested and added tests to |ash_unittest|. Bug: b/142672872 Change-Id: I2e734ef13b90f0e43dfda52d12c59b7deff5633f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913615 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#716413}
-
Sean Topping authored
QuicContext needs to be provided for every URLRequestContext. Otherwise, a crash occurs. Bug: internal b/144527786 Test: CQ Change-Id: Ideac2eeefe6b12450906a47b711ebd9afda90e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923032Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#716412}
-
Xianzhu Wang authored
This reverts commit e1220602. Reason for revert: The CL that caused the failure has already been reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1923208. Original change's description: > Mark compositing/contents-opaque/control-layer.html flaky on Mac10.10 > > BUG=1026046 > TBR=wangxianzhu@chromium.org > > Change-Id: Ib36bd8f64b65f2a2d8a51e61ae5ac3e795c73118 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922703 > Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org> > Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#716401} TBR=wolenetz@chromium.org,wangxianzhu@chromium.org Change-Id: I758bcf1930d738fd19dddc1c244406ebefc7f455 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922970Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#716411}
-
Peter Kasting authored
These were both based off GG600 and both used for text, but one was made to have 4.5 contrast and one wasn't. Since they're both used for text, we always want to ensure 4.5 contrast. Unify these. This results in slight changes to disabled buttons and disabled menu items. See the ButtonDisabledForeground and MenuItemDisabledForeground entries in https://docs.google.com/spreadsheets/d/1JoxAN5E-92ziNhIyWySVW4qzwRYtdNdVDsUtk894R3s/edit?usp=sharing for more. Bug: 1024091 Change-Id: I11e31e6784a3d8e651b3a936bb285edf1a8a36ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922453 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#716410}
-
Alex Ilin authored
This CL removes the last references to deprecated shared memory classes in media/. It's a dead code that is no longer needed. This also fixes some missing includes that used to be added transitively. Bug: 849207 Change-Id: I29483f5af8fe69bec69ace124e92b3aed91c6c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919216 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#716409}
-
Kent Tamura authored
Now keywords specified by ReflectOnly in IDL files need to be added to keywords.json5, and keywords for enterkeyhint and inputmode attributes are in keywords.json5. This CL removes enter_key_hint_names.json5 and input_mode_names.json5 because they are redundant. This CL has no behavior changes. Bug: 1024669 Change-Id: I49ea9d26cae9bc98da8849ed9bcfab875f487017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918784Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#716408}
-
Nathan Zabriskie authored
This CL refactors Canvas2DLayerBridge::FinishRasterTimers() to use RasterInterface in place of GLES2Interface. It also updates RasterImplementationGLES::CreateAndConsumeForGpuRaster() so that it can be called with shared image mailboxes and calls into RasterInterface during CanvasResourceSharedImage initialization. Finally, it checks for RasterInterface and GLInterface before making calls in code shared with WebGL. The references to GLES2Interface are being removed as part of the OOPR-Canvas2D project with the goal of fully transitioning Canvas2D to use RasterInterface. For more info about the project see the tracking bug here: crbug.com/1018894 Bug: 1018898 Change-Id: If2bcb8dc5ba88fa4b41322cfefa83397671736d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891851 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#716407}
-
Esmael El-Moslimany authored
possible In the code, we were using to similar colors for the same blended color. This CL makes use of a defined opaque hex code representation of the color in places were either the colors were blended or where the hex code is used directly. Change-Id: If1f4989b595df4441a9407161388efc64d40a45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921335 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#716406}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/94acd86a..2ddefb8d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I05997af89cbe996e8a90b5aedeca4678eedcd696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921896Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716405}
-
David Tseng authored
TBR=akihiroota@chromium.org Change-Id: Iebe61b27eddcf7fb9261e741f211c5795842ae28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923030 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#716404}
-
Doug Arnett authored
This is preparation for being able to implement a queuing policy in the hints manager. Basically, HintsFetcher needs to surface different cases as to why hints weren't fetched in order for caller to know if should try again soon or try again later. This change also lands UMA for these status values to help us understand more about what queueing policy might be useful/needed. Bug: 1021310 Change-Id: I27d5cd72c597344db6844f5833c674edbc350e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918145 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#716403}
-
Daniel Cheng authored
Bug: 1025358 Change-Id: Ifea58dfbd5062919e3786886d84ee16b833e63af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922450 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#716402}
-
Matt Wolenetz authored
BUG=1026046 TBR=wangxianzhu@chromium.org Change-Id: Ib36bd8f64b65f2a2d8a51e61ae5ac3e795c73118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922703Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#716401}
-
Matt Falkenhagen authored
Optimizing email. Change-Id: I7b32bf2ae2916d616428e95185445d6d3736c4d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923209 Auto-Submit: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#716400}
-
James Cook authored
The assistant service runs in the browser process on the UI thread. It can directly use the Profile's PrefService* to access prefs. This simplifies the code and is a step toward deleting the mojo pref service entirely. The only non-trivial change is that the AssistantServiceConnection object needs to destroy itself earlier in Profile teardown. AssistantStateBase has a PrefChangeRegistrar that needs to be destroyed before the Profile's PrefService is destroyed. I manually tested on linux-chromeos under ASAN and on device. TBR=battre@chromium.org Bug: 977637 Test: chromeos_unittests Change-Id: I6dec70a346b611c0825746cd1c39321d0dce466c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919790 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#716399}
-