- 29 Jun, 2018 40 commits
-
-
Tetsui Ohkubo authored
This CL fixes label and icon color of notifier settings view and IME list view in UnifiedSystemTray. TEST=manual BUG=850396 Change-Id: I11bc88e3420b45641773ac7b1185db477a294455 Reviewed-on: https://chromium-review.googlesource.com/1117728Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#571391}
-
Tetsui Ohkubo authored
This CL changes feature pod toggle behavior as follows: Current behavior: The feature was enabled. -> The feature is disabled. The feature was disabled. -> The feature is enabled. Expected behavior (This CL): The feature was enabled. -> The feature is disabled. The feature was disabled. -> The feature is enabled & transition to the detailed view. As currently we only have three feature pod buttons which are togglable & having a detailed view, so it changes behavior of these buttons: * Network * Bluetooth * Quiet Mode TEST=manual BUG=856028 Change-Id: I860bd9501bc651d74d982130d22b5006e0fba6e0 Reviewed-on: https://chromium-review.googlesource.com/1116503Reviewed-by: -
Kenneth Russell authored
Suppressing the following flaky test on Linux NVIDIA: deqp/functional/gles3/texturespecification/ random_teximage2d_cube.html Tbr: ynovikov@chromium.org Bug: 618447 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia22432c9cfd71fc4d26e21eea26576ecedfe8593 Reviewed-on: https://chromium-review.googlesource.com/1119542Reviewed-by:Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571389}
-
Tetsui Ohkubo authored
Currently, network feature pod button may show Ethernet, mobile data & tether in addition to WiFi. However, clicking on the button always toggled WiFi enabled / disabled. TEST=manual BUG=856030 Change-Id: If39e3360a045e0b0ba64cb89c43999dd11151549 Reviewed-on: https://chromium-review.googlesource.com/1116510Reviewed-by:
-
Ryan Cui authored
Adds new Event.Touch.GestureTarget histogram for browser UI elements, and stops including browser events in Ash.GestureTarget. Removes header and runtime dependency between browser and ash for gesture metric handling. BUG: 826476 Change-Id: I87e8de2c4cae6f5e30939726917f5f811cb61ba8 Reviewed-on: https://chromium-review.googlesource.com/1116250Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ryan Cui <rcui@chromium.org> Cr-Commit-Position: refs/heads/master@{#571387}
-
Patti authored
This is a reland of e2cac39f Original change's description: > Settings: Content settings can now be reset for a group of origins in All Sites. > > Add a three-dot / overflow menu to groups of origins in All Sites. This overflow > menu allows the entire list of origins to have all their content settings reset > in one go. This will be preceded with a confirmation dialog. > > Manual test - With #enable-site-settings turned on, change a content setting via > Page Info > Site settings on both https://permission.site and > http://permission.site. Navigate to chrome://settings/content/all and see that > both sites are listed under 'permission.site'. Verify there is an overflow menu > on this entry and that inside the overflow menu, there is a 'Reset permissions' > option. Clicking this should bring up a reset permission dialog and confirming > the dialog should remove this entry from All Sites. > > Bug: 835712, 717468 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833 > Reviewed-on: https://chromium-review.googlesource.com/1098577 > Commit-Queue: Patti <patricialor@chromium.org> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568742} TBR=stevenjb@chromium.org Bug: 835712, 717468 Change-Id: I88522c41a536e86e27b831358c61842d69f42d34 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1116318 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#571386}
-
Muyuan Li authored
Per privacy requirement, incognito windows should not be included in screenshot sent to assistant server. ash_unittests --gtest_filter=AssistantControllerTest.Screenshot browser_tests --gtest_filter=BrowserNonClientFrameViewAshTest.IncognitoMarkedAsAssistantBlocked* Bug: b/78193324 Test: Change-Id: Idf55135959721d69414a1ec6fae396f9763ebe49 Reviewed-on: https://chromium-review.googlesource.com/1114293 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#571385}
-
Sadrul Habib Chowdhury authored
Add async trace-events for selected commands to see how long they spend in the queue. This can then be used to measure the impact of the gpu-scheduler. This can be done by adding 'trace_queueing_time' attribute to the commands. This CL adds this only to SwapBuffers. BUG=858895 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I75146dd806f54357d0d669e92c1d461dc04d912c Reviewed-on: https://chromium-review.googlesource.com/1114057 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#571384}
-
Esmael El-Moslimany authored
Bug: 850243 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7f028f7541a60f0aa15495823969fdd243609845 Reviewed-on: https://chromium-review.googlesource.com/1115589 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#571383}
-
Tetsui Ohkubo authored
This CL * Fixes the behavior when date is clicked while system does not allow manual time change (we still allow users to change time zone & 12/24 clock). * Closes system tray bubble when managed button is clicked. * Adds material design ripple to date button and managed button. TEST=manual BUG=none Change-Id: I43df968100952940d21e87132bbb1007a7bacdca Reviewed-on: https://chromium-review.googlesource.com/1118091Reviewed-by:
-
Joel Hockey authored
Bug: 825010 Change-Id: I384e1fc1e24572a2fc185d2ceac1bd9fa0b8a5bc Reviewed-on: https://chromium-review.googlesource.com/1119611 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#571381}
-
Peter Kasting authored
Bug: 856896 Change-Id: I5897da89ffbf38a5ca7fbce3205aefb770d81ecc TBR: kylixrd Reviewed-on: https://chromium-review.googlesource.com/1119646Reviewed-by:
-
Jordy Greenblatt authored
I ran into a display bug when I tried to pass the host name and the mode separately from the multidevice-container-page to the multidevice- page in which only the first property sent updated the display. To solve this, I am refactoring to pass an object with all the data the page needs from the container in a single object, the new typedef PageContentData. This CL involves a refactor to handle the infrastructural changes. It uses this functionality to pass the host device name from the container to the page. Manual testing revealed that it is no longer showing the same buggy display behavior (i.e. the heading shows up and changes appropriately regardless of the initial mode set by the container). Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I3e19bcaa8ed8ed774a947ffc9f24fc71dc406038 Reviewed-on: https://chromium-review.googlesource.com/1117201Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#571379}
-
Hiroki Nakagawa authored
Bug: 680046 Change-Id: I8b3894bfbc8df999952fa82e8f2b3abb4088f434 Reviewed-on: https://chromium-review.googlesource.com/1114566Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#571378}
-
Kevin Marshall authored
Some CLs are affected by a nondeterministic package install bug which is occurring in content_unittests, preventing those CLs from being landed. This CL unblocks those CL owners by temporarily removing content_unittests from the CQ. TBR=jbudorick@chromium.org Bug: 858692 Change-Id: I8416f238f248ed1a16e406ef80e801859df10a0b Reviewed-on: https://chromium-review.googlesource.com/1119198Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#571377}
-
Weiliang Chen authored
When apply masks, we only use the alpha channel. For TileMaskLayer that appended SolidColorDrawQuads, only cheak the alpha channel instead of the entire color. R=danakj Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic66497ed3aa4e8b4b9befc80649ea09f21930467 Reviewed-on: https://chromium-review.googlesource.com/1087778Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#571376}
-
Kinuko Yasuda authored
ServiceWorkerSubresourceLoader does not necessarily run on a SingleThreadTaskRunner. Bug: 857040 Change-Id: I8e1d65da88a25a49a01d0d8da951c85be54f6190 Reviewed-on: https://chromium-review.googlesource.com/1118404 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#571375}
-
Ke He authored
This is one step of "moving //device/geolocation into //services". TBR=benchan@chromium.org BUG=800659 Change-Id: I566db835e7df596374cd341048d9734bf82398f6 Reviewed-on: https://chromium-review.googlesource.com/1107637Reviewed-by:
Ben Chan <benchan@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#571374}
-
Ken Rockot authored
Introduces an internal PlatformHandleInTransit type to safely scope the lifetime of platform handles which may belong to a remote process. Uses this everywhere for handles stored in messages, eliminating all remaining use of some InternalPlatformHandle properties which aren't covered by PlatformHandle (namely |owning_process| and the MACH_NAME "handle" type). This is a precursor to removing InternalPlatformHandle and ScopedInternalPlatformHandle altogether. Bug: 753541 Change-Id: Ibc223669c935bdde72c2af3b6b3d7cd1474e2bdf Reviewed-on: https://chromium-review.googlesource.com/1114462 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#571373}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I844f390af365da793f4adb1393906890cab7d67e Reviewed-on: https://chromium-review.googlesource.com/1119413Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#571372}
-
Xing Liu authored
Currently download location feature may access disk on main thread to retrieve download directories. This CL moves this operation to a background thread. Also, the Android API to retrieve directories may cause issue if multiple asynchrounous tasks are fired on certain device. In this CL, we introduced a glue layer between Android API and chrome to manage unreliable API behavior. Bug: 844107 Change-Id: Ic9dcabea48895a705079029f9fa260ce6efbfec3 Reviewed-on: https://chromium-review.googlesource.com/1116247 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#571371}
-
Joel Hockey authored
FakeConciergeClient test updates in crosreview.com/1119611 Bug: 825010 Change-Id: I8d5a5f37a4f5dd30f450a36c4e0c61d4c4b41598 Reviewed-on: https://chromium-review.googlesource.com/1119506 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#571370}
-
Darren Shen authored
Bug: 731537 Change-Id: I9383c7a646cb12a4136cc1ac8999fbdb4958196d Reviewed-on: https://chromium-review.googlesource.com/1111490 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cb0889ef01d0..6d97dd7fb70f git log cb0889ef01d0..6d97dd7fb70f --date=short --no-merges --format='%ad %ae %s' 2018-06-28 moragues@google.com nocturne: mark paladin as important (not experimental) Created with: gclient setdep -r src/third_party/chromite@6d97dd7fb70f The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib0ff50d3e91c05e2eeb9d44588c177bc2d9864a3 Reviewed-on: https://chromium-review.googlesource.com/1119334Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571368}
-
Shakti Sahu authored
Details : 1 - Added DownloadOfflineContentProvider class and registered it to OfflineContentAggregator. 2 - Filtered out download items from the aggregator in the Java bridge. 3 - OpenItem() and GetVisualsForItem() not yet implemented. 4 - It doesn't wait for download history is loaded currently, may be we have to do that too. BUG: 854845 Change-Id: Id0956ec82732de2fffcda1b5e63d12f10abc8aa3 Reviewed-on: https://chromium-review.googlesource.com/1109275 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
Cold mode spellchecker cuts text into chunks and expands each chunk to sentence boundaries for spell checking. However, due to bugs in sentence boundary finding algorithms, sometimes the expanded range may extend outside the root editable element, causing crashes. This patch stops the crash by fixing the expanded range if it extends outside the root editable. Bug: 856376 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I18d060cbafa07b594e72f537eabbed31cd3d2b02 Reviewed-on: https://chromium-review.googlesource.com/1117565Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#571366}
-
Esmael El-Moslimany authored
Bug: 855570 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1263ec15699c5169ac45b1cf19690031d5b26fa6 Reviewed-on: https://chromium-review.googlesource.com/1113909Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#571365}
-
Makoto Shimazu authored
Bug: 806658 Change-Id: Ic69f20cf695db78e6cec1661d76904015f3d41e5 Reviewed-on: https://chromium-review.googlesource.com/1117959 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This patch simplifies the functions so that we can easily understand RecordMarker creates PaintRecord only by color. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idb3ebc9a0c376731e4202b277a8380bfd26957d9 Reviewed-on: https://chromium-review.googlesource.com/1116636Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#571363}
-
weiliangc authored
Didn't find any implementation or caller, so remove one function. Change-Id: Id8ffc1544dc7670622c68684405d681e04f518c8 Reviewed-on: https://chromium-review.googlesource.com/1118570Reviewed-by:
-
Mathias Bynens authored
Our recommendation is to use `mjs` to denote JavaScript modules as opposed to classic scripts: https://developers.google.com/web/fundamentals/primers/modules Bug: chromium:857076 Change-Id: I6d3f77c62bd9a14bec484dfe897aff754301bff7 Reviewed-on: https://chromium-review.googlesource.com/1117070Reviewed-by:
Paul Irish <paulirish@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#571361}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4a933ce4. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20307 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=markdittmer No-Export: true Change-Id: I74c2030bbcfd8f82779c16a38514d634b88787b8 Reviewed-on: https://chromium-review.googlesource.com/1119541 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#571360}
-
David Black authored
The actual Assistant Settings URL is not yet available. Not sure yet if we will hardcode it on the client, fetch it from the server, or if it will be synced to the client via flag. This CL: - Creates AssistantControllerObserver to observe events broadcast from the top level Assistant controller. - Implements AssistantControllerObserver in AssistantUiController to hide UI on opening a URL in a new tab, and to show UI when receiving a web UI deep link. - Implements AssistantControllerObserver in AssistantWebView to embed rendered WebContents on receipt of a web UI deeplink received event. See bug for screenshot. Bug: b:110433859 Change-Id: Ie48fad9de91bc8886e723a5b510c31a6243a7aaa Reviewed-on: https://chromium-review.googlesource.com/1118752 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a782dcb3c407..7e2327b133db git log a782dcb3c407..7e2327b133db --date=short --no-merges --format='%ad %ae %s' 2018-06-28 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-28 egdaniel@google.com Revert "Reland "Make GrVkBackendContext no longer derive from SkRefCnt."" 2018-06-28 egdaniel@google.com Revert "Reland "Move Vulkan DebugCallback code into tools."" 2018-06-28 egdaniel@google.com Revert "Reland "Let client pass in full extension to GrVkBackendContext."" 2018-06-28 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 a26de2500503..fa5d84be4145 (11 commits) 2018-06-28 caryclark@skia.org fix blank catalog images 2018-06-28 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-28 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@7e2327b133db The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I85f01fc13c36fe6dea3f462b15253154ed66e5f1 Reviewed-on: https://chromium-review.googlesource.com/1119333Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571358}
-
Mina Almasry authored
The timestamp at which the PTS measured is incorrect. It should be the timestamp returned by video_decoder()->GetCurrentPts, and not MonotonicClockNow. Bug: b/110629346 Test: Manual Change-Id: I59412ff3f9d2286a3e01d58e097c125eb2454245 Reviewed-on: https://chromium-review.googlesource.com/1114320 Commit-Queue: Mina Almasry <almasrymina@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#571357}
-
Kurt Horimoto authored
Bug: 852429 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I32d6cae65a26ab3439caa41447a8ffd027b8e0ac Reviewed-on: https://chromium-review.googlesource.com/1111382 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#571356}
-
Devlin Cronin authored
Handle the case of a context being invalidated before accessing chrome.app.isInstalled. This can happen in cases where the owning frame is removed. Add a regression test for the same. Bug: 855853 Change-Id: Ic9e5f5a45fc2a833c5c1a45d3b7c1e8c04c71a18 Reviewed-on: https://chromium-review.googlesource.com/1119066Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571355}
-
Paul Miller authored
The WebView requesting a variations seed opens a file descriptor to receive the seed. We should close it after the request. BUG=857223 Change-Id: I594067ce0c33bed2137bc39e5c133ba22bca0c04 Reviewed-on: https://chromium-review.googlesource.com/1117707 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#571354}
-
Qiang Xu authored
This CL aims at removing APIs from ash::SearchResultContainerView, which is part of the cleanup of app list focus. Bug: 766807 Test: covered by tests Change-Id: I6292ac38d157c23984b6151b2dd522be1e5caabe Reviewed-on: https://chromium-review.googlesource.com/1116896 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
-
Findit authored
This reverts commit a6dc11ea. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 571213 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2E2ZGMxMWVhNjMwMzc4ZWE4OWNhNGY1ODdlNWVlYmM2NjYxNTExMjAM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28074 Sample Failed Step: ash_unittests Original change's description: > Handle custom/bitmap cursors in ws2. > > Go through CursorFactoryOzone to load the PlatformCursor (which > confusingly could be CursorData, but for now is X11CursorOzone). Also > set fields on the cross-platform Cursor type so that code which relies > on it such as CursorWindowController::UpdateCursorImage will work. > That code path can be exercised with --ash-enable-cursor-motion-blur > although there is currently no use of custom cursors with ws2. > > Bug: 837705 > Change-Id: I9f725c5a5350e28cf8bded6b53bf48759cb644f8 > Reviewed-on: https://chromium-review.googlesource.com/1105562 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571213} Change-Id: I5bda2cd762ef24cbf5b31eac96a7e0d1e96e84c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 837705 Reviewed-on: https://chromium-review.googlesource.com/1119586 Cr-Commit-Position: refs/heads/master@{#571352}
-
