GitLab

TBR=hanxi@chromium.org

Bug: 1092642
Change-Id: I434447c3a14e45a4ba6b6b1d911e03bd002239de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236737Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776322}

Move share sheet files to chrome/browser/share/...

This move leaves two dependencies to be resolved:

BottomSheet, tracked in crbug.com/1002277

SendTabToSelf, tracked in crbug.com/1090917. This should be fairly easy
to resolve in a follow-up CL.

Bug: 1022172
Change-Id: I65e3b983e9d773b4ee78cf65fcac369258ef1413
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231542
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776321}

This reduces the size of pdf_viewer.js, in preparation for making it a
Polymer element that defines the UI of the PDF viewer. There will need
to be two versions of this element, one for Print Preview, so moving
shared code out of pdf_viewer.js itself will reduce the amount of
duplication.

Change-Id: I40e2a0565159bc028cab52fffb0eb8de8984da16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233487Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776320}

https://quiche.googlesource.com/quiche.git/+log/8212c45924e3..6cccce4f5870

$ git log 8212c4592..6cccce4f5 --date=short --no-merges --format='%ad %ae %s'
2020-06-08 fayang Deprecate gfe2_reloadable_flag_quic_notify_handshaker_on_connection_close.
2020-06-08 fayang In quic, adjust blackhole detection configs based on connection options. protected by existing gfe2_reloadable_flag_quic_default_enable_5rto_blackhole_detection.
2020-06-05 fayang Default enable 5rto blackhole detection. protected by gfe2_reloadable_flag_quic_default_enable_5rto_blackhole_detection.
2020-06-05 nharper Add port field to ProofVerifier::VerifyCertChain
2020-06-05 nharper Discard server 0-RTT read key when QUIC TLS handshake completes

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

R=dschinazi@chromium.org

Change-Id: Id08bb2df54f342dac304a0c8dda3df40506b5868
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235986
Commit-Queue: Fan Yang <fayang@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Auto-Submit: Fan Yang <fayang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776319}

Retried locally on Mac and Linux, the test seems fine.

Bug: chromium:899919
Change-Id: I48d50f2f25a7111d4713b1b826eca36893e03289
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236886
Auto-Submit: Shengfa Lin <shengfa@google.com>
Commit-Queue: Shengfa Lin <shengfa@google.com>
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776318}

https://dawn.googlesource.com/dawn.git/+log/f5657af110a6..0a79bee135cd

2020-06-08 yunchao.he@intel.com Vulkan: Combine all pass barriers in a single call

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: Ibcf1c776531c6ab725cfeda6f821a2a54aeb3a83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236323Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776317}

This reverts commit f4376b7b.

Reason for revert: This change broke code search builders for chromeos and fuchsia.

Failed builds: https://ci.chromium.org/p/infra/builders/codesearch/codesearch-gen-chromium-chromiumos
https://ci.chromium.org/p/infra/builders/codesearch/codesearch-gen-chromium-fuchsia

Original change's description:
> Build the Ozone Wayland platform for codesearch-gen bots
> 
> Bug: 1091153
> Test: trybots
> Change-Id: I48c79a52fd5af68db40b1c53bd908643e331b424
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230423
> Reviewed-by: Michael Spang <spang@chromium.org>
> Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#775441}

TBR=rjkroege@chromium.org,spang@chromium.org,edcourtney@chromium.org,msisov@igalia.com,sokcevic@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1091153, 1092043
Change-Id: Ie588f04b65102f2ddcbe15f387048bfc95e0cef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236600Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Andy Perelson <ajp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776316}

Move the expiry of Extensions.InstallPrompt.TimeToInstall/Cancel to M95

Bug: 1088789
Change-Id: I5591c91897862d0647caacc0bae9833bcd5bd1bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233497Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776315}

This reverts commit 231e6f6b.

Reason for revert: Test consistently fails in android builders.
See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.share.clipboard.ClipboardImageFileProviderTest%23testClipboardSetImage

Original change's description:
> Enable the test testClipboardSetImage
> 
> Because strict mode violation issue fixed, we can enable the test now.
> 
> Bug: 1076643
> Change-Id: I2a4283aef68767fedc850fa2a538ccf2eaaa5042
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233921
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Commit-Queue: Gang Wu <gangwu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#776148}

TBR=tedchoc@chromium.org,gangwu@chromium.org

Change-Id: Idddd1e8a59330503457804b7993c0e83c458375e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1076643
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236909Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#776314}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1e6bb06ceaf3..2040ac7e6d33

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC dimich@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1074446
Tbr: dimich@google.com
Change-Id: I1bdb06fdb395de3081eba2454d752d53cb5ed831
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236103Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776313}

The sampling profiler expects build ids to be present in Chrome's
modules. Enabling in unofficial builds permits testing its behavior on
the commit queue.

Bug: 870919
Change-Id: I08c69070155ff572a63fc1e1f8959e6c308a8569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236753Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776312}

The X11 desktop-resizer was recently switched from XLib to XProto.
This CL fixes some bugs introduced by that change.

Bug: 1092630
Change-Id: I947ca8af0311d91db014c2afa235929532e06634
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236682
Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776311}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I5133d5aff479b4469526331cbb4a1fb68f7c56f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236712Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776310}

This reverts commit a47390a0.

Reason for revert: "Instant_Return" related tests fail in a couple of android builders. For examples:
https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/25649
https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/1907

Original change's description:
> [Instant Start] Create ToolbarManger before showing overview.
> 
> In this CL, we introduce an additional state in InflationObserver:
> onInflationComplete. This event happens between onPreInflationStartup
> and onPostInflationStartup, thus provides a way to split the
> implementation of onPostInflationStartup into two methods.
> 
> In RootUiCoordinatior, the ToolbarManger is created in
> onInflationComplete, and ChromeTabbedActivity calls showOverview()
> after RootUiCoordinatior#onInflationComplete but before initializing
> other components in onPostInflationStartup. Thus, ToolbarManager setups
> an OverviewModeObserver and won't lose any early events that an
> overview is shown or overview mode is changed.
> 
> Bug: 1077022
> Change-Id: I6bc8b96906a9519a928c6490bec0ca158b3d6241
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181667
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Reviewed-by: Ender <ender@google.com>
> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> Commit-Queue: Xi Han <hanxi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#776073}

TBR=yfriedman@chromium.org,hanxi@chromium.org,mdjones@chromium.org,wychen@chromium.org,ender@google.com

Change-Id: I826c512c34d8e945d9cea6dcada8da023d840d1e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1077022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236946Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#776309}

Bug: 1085630
Change-Id: If0e6e852458aedf448647e3ab8320519c4775bd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216630Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776308}

Re-enable testWindowFullScreen and Maximize so that we can look into
flakiness from log. Add state normal check after changing to normal
and return error status if failed. Add sleep and retry in test full
screen to see if it can help with size change.

Bug: chromium:867511
Change-Id: I17c551135775eaf607ff2f2b92f9488a5b8f4716
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231810
Commit-Queue: Shengfa Lin <shengfa@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776307}

This test is flaky, marking it as such.

Bug: 984467
Change-Id: I856266bd6bc4713e6269ecf348b5ec6bb6717c3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235256Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Auto-Submit: Juanmi Huertas <juanmihd@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776306}

Currently, only one hyphen '-' is ignored when normalizing strings
for comparison purposes. This CL adds all hyphen chars that should
be ignored when processing characters to bold in search result rows.

Fixed: 1072912
Change-Id: I8ef5210d5d75e9a342b423d07ca88e26090a1974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233480Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776305}

For finch beta channel, we need to disable pixel copy for interop. So
if both GL and Vulkan are using hardware GPU (instead of swiftshader),
or features::kVulkan is specified by command line (instead of finch
server), interop related GL extensions will be checked. and fallback to
GL, if interop is not supported.

Known issue:
 * Intel Linux GL doesn't support interop, however upstream is working
   on it. https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4337

Bug: 1002166
Change-Id: I9a8971f0c53fd06f8673fffa5fa80107fb19e41e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234062Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776304}

Makes the Maps_maps pixel test crop the screenshot so that only the
tested content is visible, i.e. the white background is removed.

Bug: 1091410, 1090518
Change-Id: I1a894202844ac6a7f12d47985e7540b09810e874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231457
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776303}

This reverts commit c027dce3.

Reason for revert: Breaks browser tests that expect the camera component app to be loaded - the component loader seems to be trying to load the app from an invalid path.
see
https://bugs.chromium.org/p/chromium/issues/detail?id=1092703

BUG=1092703

Original change's description:
> [CCA WebUI] Move CCA and its WebUI to chromeos/components
> 
> In this CL, we move some CCA related components to
> //chromeos/components/camera_app_ui
> 
> to make it consistent to Help app and Media app.
> 
> 1. CCA resources
>   From: //chrome/browser/resources/chromeos/camera/
>   To: //chromeos/components/camera_app_ui/resources/
> 
> 2. CCA WebUI
>   From: //chrome/browser/ui/webui/chromeos/camera/
>   To: //chromeos/components/camera_app_ui/
> 
> 3. Camera App Helper Implementation
>   From: //components/chromeos_camera/
>   To: //chromeos/components/camera_app_ui/
> 
> Bug: 980846
> Test: Launch CCA and CCA works normally as a platform app
> Test: tast run [DUT] camera.CCAUI*
> Change-Id: Ic70bd54b35194e3c3398e9f3de9af200346491d4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131542
> Commit-Queue: Wei Lee <wtlee@chromium.org>
> Reviewed-by: Shik Chen <shik@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
> Reviewed-by: calamity <calamity@chromium.org>
> Auto-Submit: Wei Lee <wtlee@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#775987}

TBR=stevenjb@chromium.org,sky@chromium.org,shik@chromium.org,thestig@chromium.org,calamity@chromium.org,rockot@google.com,hidehiko@chromium.org,alexmos@chromium.org,afakhry@chromium.org,jochen@chromium.org,dominickn@chromium.org,wtlee@chromium.org

Change-Id: I05bed35e74a2888cac72a524fc438ee6cb1d84d9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 980846
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236892Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776302}

According to the flake portal, this test is flaky on linux, windows and
mac.

Bug: 1091843
Change-Id: Ibb820e94585f243f108ba4bb68ff6e5f326b930a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233305
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776301}

This change allows a PhishingClassifierDelegate
object to always exist and removes the dependency
on the Safe Browsing pref on the renderer
side. We are checking the Safe Browsing pref
on the browser side which should make this safe.
Reordered methods in chrome_render_frame_observer.cc
to match the declaration position in the header.

Bug: 1078964
Change-Id: If7388a1c038d2558abcadf3b50e41f7748dfae7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225819
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776300}

After this CL, the rewriter may be run twice, in the following fashion:
1. First run will gather a blocklist of fields to ignore
   1.1. edit/replacement directives from this run will be discarded
2. Second run will consume the blocklist of fields to ignore
   (via --exclude-fields cmdline parameter - see r771819)
   2.1. edit/replacement directives from this run will be applied
        to the source code
   2.2. filters emitted by this run will be discarded

This CL adds code to emit additional output from the rewriter - the list
of fields that should be ignored, because they are used as in-out
arguments.  See "In-out function parameter" section in the design doc
[1] for rationale for ignoring such fields.  See the
tests/in-out-arg-expected.txt file added in this CL for example output.

[1] https://docs.google.com/document/d/1chTvr3fSofQNV_PDPEHRyUgcJCQBgTDOOBriW9gIm9M

Bug: 1069567
Change-Id: I792bb85677ca27f543a3c6da2922cdf8cf991e24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161774Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776299}

It's failing on asan/lsan builders. It wasn't reproducible locally
after 1000 tries, so uploading a speculative fix. According to the
stack in the builders, it seems there's no animation running after
waiting for tablet mode to enter. It seems plausible the animation
has been scheduled but not started yet, so add a waiter if the
animation is not running.

Test: ash_unittests TabletModeControllerScreenshotTest.ScreenshotVisibility
Bug: 1091085
Change-Id: I8bf796016122b0368edf860fe93299d8718f6f86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231270Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776298}

Explicit benchmark (unittest) name in the benchmark result record makes
it easier to read and/or automatically collect into benchmarks table.

Bug: 158517134
Test: build and run
Change-Id: I5c9de48c052d411a5facf09eaceaf613ae0667c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236603
Auto-Submit: Michael Montvelishsky <mont@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776297}

Also use polymer-eque array mutations.

Bug: 1024113
Change-Id: Ic793abb4bf5498be63f6bd66ee100c1f4dedbf85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236501
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776296}

The goal of this is to share the core of js_java_interaction with weblayer.
As WebLayer and WebView will use different java types, this refactors all
usage of java types out of the core classes. To make it possible to share
the code this introduces the following types:

. WebMessage: wrapper around the contents of a message.
. WebMessageReplyProxy: mirrors JsReplyProxy.
. WebMessageHost: represents the host side of connection
. WebMessageHostFactory: factory for creating WebMessageHosts.

In order to make it clear when the WebMessageReplyProxy has gone away,
WebMessageHost is created for each page a particular
WebMessageListenerHolder is matched to.

BUG=1042771
TEST=covered by android_webview tests

Change-Id: Iad6ed99963c93bf6594f48e8f5dae23b6bd578cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234542
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776295}

The interface isn't used anymore so the plumbing can all go.

BUG=1073560

Change-Id: Ic49792481913f96a2a7a232a3112236b132d9137
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231261
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776294}

Fix polution -> pollution

BUG=None

Change-Id: Ie084b87deccbc0884bbc6c22024d9ec3313e35a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236724
Auto-Submit: Ian Barkley-Yeung <iby@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776293}

When the Expect-CT database is being keyed on NetworkIsolationKey,
net-internals will now set/query Expect-CT information using the
Expect-CT origin for both the frame and top frame sites in
the NetworkIsolationKey.

Bug: 969893
Change-Id: I1b6a0f168a2454a75c6baea66d0889b2d7ecebf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231742
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776292}

QuotaManager and UsageTracker are only supposed to call QuotaClient APIs
with supported QuotaType values. The only supported type is kTemporary,
for all QuotaClients except for FileSystemQuotaClient.

QuotaClient::DoesSupport() is going away in an upcoming CL, to support
the Quota subsystem's migration to the Storage Service.

Bug: 1016065
Change-Id: Ibd3faa915afb6f32a9012e7c607adcb9049666b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233490Reviewed-by: Jarryd Goodman <jarrydg@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776291}

ButtonController::OnGestureEvent() should behave in the same
way as ButtonController::OnKeyPressed() and
ButtonController::OnMousePressed(); it should not change the
button state if the button is disabled, and just early out.

This bug caused the new desk button to show as enabled, even
though it is disabled, only when gesture tapped. This didn't
happen when mouse clicked.

BUG=1084241
TEST=Added a new test that fails without the fix.

Change-Id: Ifd007a8b123a26c7109b13e0a7929c0f77f4725b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233362
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776290}

This flag was flawed as it only signals the Assistant has started,
but not that it is ready to handle queries.
The NEW_READY flag does signal Assistant is ready to handle queries,
and will be used going forward (and will be renamed to READY in a
follow up CL).

Bug: b/142428671
Change-Id: I1343d9b36c1164d95e55e14f38f8bef57033b84f
Tests: ash_unittest, chromeos_unittest, and manually launched.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236284Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/master@{#776289}

https://skia.googlesource.com/skia.git/+log/7b1355e5093a..c14701a51232

2020-06-08 bungeman@google.com Remove SkStream_mac.cpp.
2020-06-08 bungeman@google.com Remove SkFontHost_mac.cpp.
2020-06-08 reed@google.com minor reordering of fields to save space
2020-06-08 johnstiles@google.com Update GrLumaColorFilterEffect to use a child FP.
2020-06-08 johnstiles@google.com Remove PremulInput and GrPremulInputFragmentProcessor.fp from Skia.
2020-06-08 johnstiles@google.com Fix housekeeper 'check generated files' warning.
2020-06-08 adlai@google.com Move lastRenderTask into drawing manager
2020-06-08 senorblanco@chromium.org Dawn: implement GrBackendTexture::isSameTexture().
2020-06-08 johnstiles@google.com Add JavaInputStreamAdaptor files into third_party directory.
2020-06-08 jlavrova@google.com Optimize findLimitingClusters

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: bungeman@google.com
Change-Id: I9d3d9800bc25aec04b2242d9801839d90a35741b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236637Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776288}

This reverts commit 45e0194e.

Reason for revert: Breaks tests:
virtual/webrtc-wpt-plan-b/external/wpt/webrtc/RTCPeerConnection-getStats.https.html
external/wpt/webrtc/RTCPeerConnection-getStats.https.html

-----
First build with broken tests: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/25785
------
Sample of the diff: 
https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=16ebfc26e79fdeaf98748ad686bbaa6208658dee&as=RTCPeerConnection-getStats.https-diff.txt
------


Original change's description:
> Revert "Disable tests for landing a WebRTC name change"
> and rebase changed tests.
> 
> This reverts commit 328f27b7.
> 
> Reason for revert: Change has now landed
> 
> Original change's description:
> > Disable tests for landing a WebRTC name change
> > 
> > Bug: webrtc:8787
> > Change-Id: I5a166726bf236e088426734456f2d503e3c6875e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232554
> > Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> > Commit-Queue: Harald Alvestrand <hta@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#775594}
> 
> TBR=hta@chromium.org,hbos@chromium.org,guidou@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: webrtc:8787
> Change-Id: Ic074a1b1231f90363bf6af7a581c8044bef947c8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235041
> Reviewed-by: Harald Alvestrand <hta@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Commit-Queue: Harald Alvestrand <hta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#776151}

TBR=hta@chromium.org,hbos@chromium.org,guidou@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: webrtc:8787
Change-Id: I17941d275de9e918529944428f69fdec511684e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236471Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776287}

Adds crbug.com/1091410 as an example of weird GPU flakiness to
//docs/gpu/gpu_testing.md.

TBR=kbr@chromium.org

Bug: 1091410
Change-Id: I2431da72aa5408a8adac0fc87197d28181cd552c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236195Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776286}

The test has new expectations as mock scrollbars have been removed. We
expect it's not flaky with the improvements made to the test harness
and site isolation. If it is flaky, we will investigate.

R=vmpstr@chromium.org

Bug: 891427
Change-Id: I4791036524bcae1095f26b534d4416d941178bea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232749
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776285}

Enterprise.UploadJobSuccess histogram was set to expire in M82,
this CL pushes the decision until M87.

Bug: chromium:1052976
Change-Id: Icaab2c14de1baad0f66841b560bc2e05d7aca8c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236455Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Zach Trudo <zatrudo@google.com>
Cr-Commit-Position: refs/heads/master@{#776284}

Add an API for getting the feed items for a feed
when we want to display them and also feed items
for continue watching.

BUG=1053599

Change-Id: Id40e56035adb5fea25176f4ee9ed983d54c2f1da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227885
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776283}