GitLab

Currently the bookmark bubble builds its own button row, but that's
unnecessary and causes it to miss out on shared framework code for
layout and button style.

BUG=726187

Review-Url: https://codereview.chromium.org/2908963002
Cr-Commit-Position: refs/heads/master@{#475833}

This adds Feature Policy checks to the mojo permission service and
corresponding tests. Because multiple permissions can be requested at the same
time, part of a request can be answered synchronously (by feature policy) and
the other part asynchronously (by quering the PermissionManager). Thus we need
to track the partially answered request in the PendingRequest class.

Feature policy checks are done here (in content) as they will form part of the
specifications for various features and thus it is best if other embedders of
content also benefit from these checks.

BUG=689802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2874053003
Cr-Commit-Position: refs/heads/master@{#475832}

In an empty text prompt with ghost text visible, the ghost text would
capture the first character typed.

BUG=none

Review-Url: https://codereview.chromium.org/2907553004
Cr-Commit-Position: refs/heads/master@{#475831}

Currently, the line-break property is a 'storage_only' field,
so it has no generated public getters/setters. This patch changes it to
a 'keyword' field so that its getters/setters can be generated as well.
We also generate the ELineBreak enum and use the generated
CSSValueID <-> ELineBreak mappings.

BUG=628043

Review-Url: https://codereview.chromium.org/2911383002
Cr-Commit-Position: refs/heads/master@{#475830}

910cca2 Fix crash detected by asan test

BUG=726198
TEST=gclient sync, make
TBR=brettw@chromium.org

Change-Id: Ie46fc45719262f11a142d335edd920161366eea4
Reviewed-on: https://chromium-review.googlesource.com/518763
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475829}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/20ee3efa..02777351

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2916503002
Cr-Commit-Position: refs/heads/master@{#475828}

A couple of tricky points:
* The requirement to always call CloseStream is added to
  media/audio/audio_output_ipc.h. This requirement isn't new, but it
  wasn't documented before.
* If the RendererAudioOutputStreamFactory used by MojoAudioOutputIPC is
  destroyed prior to receiving authorization (e.g. because of frame
  destruction), we need to signal the AudioOutputDevice anyways to
  avoid waiting forever. We pass a ScopedClosureRunner into the
  authorization callback to make sure we get a callback even if the
  factory is destroyed early.
* Code for intergrating this into the AudioDeviceFactory is in
  https://codereview.chromium.org/2890753003
* Browser tests (using this and the dependent CL) in
  https://codereview.chromium.org/2812883003/#ps380001.

BUG=425368
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2821203005
Cr-Commit-Position: refs/heads/master@{#475827}

This adds feature policy checks for Geolocation, Midi/sysex, Protected media,
and Mic/Camera to the browser process. These checks are also implemented in
the content layer in the Permission Service
(see https://codereview.chromium.org/2874053003/). The reason to have these
checks implemented in the content/ layer is because they are standardized
checks and we want to ensure that other embedders of content implement the same
behavior.

However there are 2 pitfalls to this:
1) The results returned from the permission service are used to make decisions
in the renderer process and so are not trustworthy. Because of this, most
features that have permission will add additional checks in the browser
process.
2) The permission checks that happen in the browser process most often happen
in the chrome/ layer (through the PermissionManager) so this is also where
feature policy checks need to happen.

In the long term, both chrome/ and content/ should make permission checks
through the same API/mojo service where common permission checks like this one
can live.

BUG=689802
TBR=tommycli@chromium.org,peter@chromium.org

Review-Url: https://codereview.chromium.org/2898663002
Cr-Commit-Position: refs/heads/master@{#475826}

This reverts commit 9a9457b3.

Reason for revert: Relanding this change as the broken test was invalid anyway and has since been removed. Sorry for the churn!

Original change's description:
> Revert "Mojo EDK: Refactor layered message serialization"
> 
> This reverts commit 77c59a87.
> 
> Reason for revert: Broke build. See the comment on the original review.
> 
> Original change's description:
> > Mojo EDK: Refactor layered message serialization
> > 
> > Consolidates and simplifies user message serialization within the EDK.
> > Namely:
> > 
> >   * The ports layer no longer operates under the assumption that all
> >   events exist exclusively in serialized form. This eliminates the
> >   complexity of layered message allocation at the cost of a small amount
> >   of extra copying in some cases.
> > 
> >   * ports::Message is now more aptly named ports::Event, and different
> >   event types are subclasses.
> > 
> >   * Introduces a ports::UserMessage base class for ports embedder
> >   message types. These can be attached to ports::UserMessageEvent
> >   objects.
> > 
> >   * The MessageForTransit and PortsMessage types have been flattened
> >   into a single UserMessageImpl type, a subclass of ports::UserMessage.
> > 
> >   * Nearly all user message serialization and deserialization logic has
> >   been consolidated into UserMessageImpl. A few small pieces remain
> >   isolated in node_controller.cc and will eventually move elsewhere
> >   after additional refactoring.
> > 
> > All of this work is a precursor to supporting lazy serialization.
> > 
> > BUG=725321
> > 
> > Change-Id: Ib9e66cd0d5b88ac0e6dc898f248c958039078023
> > Reviewed-on: https://chromium-review.googlesource.com/516402
> > Commit-Queue: Ken Rockot <rockot@chromium.org>
> > Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#475731}
> 
> TBR=jcivelli@chromium.org,rockot@chromium.org
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> BUG=725321
> 
> Change-Id: I84f950290e6c45dc830f2bc3177af09ae955f432
> Reviewed-on: https://chromium-review.googlesource.com/518742
> Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#475805}

TBR=abarth@chromium.org,jcivelli@chromium.org,aa@chromium.org,rockot@chromium.org,tyoshino@chromium.org,darin@chromium.org,chromium-reviews@chromium.org,findit-for-me@appspot.gserviceaccount.com
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=725321

Change-Id: I5a2dbe4abf2e1f576bcf3f7f651f3557583d9033
Reviewed-on: https://chromium-review.googlesource.com/518427Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475825}

We decided DocumentMarkers shouldn't ever be copied. After
https://codereview.chromium.org/2905753002, we no longer need to copy
DocumentMarkers to create TextMatchMarkers, so we can remove the copy
constructor. We can also remove the TextMatchMarker constructor that takes a
DocumentMarker.

We need to remove the copy constructor anyway because we're turning
DocumentMarker into a polymorphic class hierarchy, and copying the base class
will no longer produce correct behavior.

BUG=707867

Review-Url: https://codereview.chromium.org/2902393003
Cr-Commit-Position: refs/heads/master@{#475824}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/32a3f0b8f49b..deb4a2aa8f11

$ git log 32a3f0b8f..deb4a2aa8 --date=short --no-merges --format='%ad %ae %s'
2017-05-30 dtu [pinpoint] Exclude StandardError from the Execution exception block.
2017-05-30 dtu [pinpoint] Request builds using Buildbucket.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I6c026faa2672fbaec85d13bf85582aad461fdaa8
Reviewed-on: https://chromium-review.googlesource.com/518564
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475823}

Revert of Compute tail time from Biquad coefficients (patchset #7 id:120001 of https://codereview.chromium.org/2862373002/ )

Reason for revert:
The added layout tests are failing on "WebKit Linux Trusty MSAN" bot.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN/builds/1242

Original issue's description:
> Compute tail time from Biquad coefficients
>
> Instead of using a fixed tail time of 200 ms for all biquad filters,
> we compute the actual tail time from filter coefficients.  Many
> typical filters in applications have a tail time of 10 ms or less.
> This allows biquads and downstream nodes to stop processing much sooner
> than what currently happens, reducing CPU usage and allowing GC to
> collect nodes sooner.
>
> BUG=612215
> TEST=
>
> Review-Url: https://codereview.chromium.org/2862373002
> Cr-Commit-Position: refs/heads/master@{#475632}
> Committed: https://chromium.googlesource.com/chromium/src/+/0be695dcb495cade0ed5c4b70aba95eb3dce49bd

TBR=hongchan@chromium.org,rtoy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612215

Review-Url: https://codereview.chromium.org/2912293002
Cr-Commit-Position: refs/heads/master@{#475822}

BUG=none

Review-Url: https://codereview.chromium.org/2867133002
Cr-Commit-Position: refs/heads/master@{#475821}

R=kouhei@chromium.org

Bug: 723841
Change-Id: I1a87c594c90ecec6388122cf3796931b3cc4fa7e
Reviewed-on: https://chromium-review.googlesource.com/518018Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475820}

This patch makes |TextIterator| constructor to take only proper range to
simplify code for improve code health.

Note: This patch is passed all tests, but there are some cases to pass
improper range to |TextIterator|. To catch such case and avoid infinite loop,
we use |CHECK()| to make blink crash.

BUG=727537
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2912053002
Cr-Commit-Position: refs/heads/master@{#475819}

Bug: 
Change-Id: I79db155731d01055cf6121b14b18fbd550d62a6f
Reviewed-on: https://chromium-review.googlesource.com/518664Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475818}

Currently, the ruby-position property is a 'storage_only' field,
so it has no generated public getters/setters. This patch changes it to
a 'keyword' field so that its getters/setters can be generated as well.
We also generate the ERubyPosition enum and use the generated
CSSValueID <-> ERubyPosition mappings.

BUG=628043

Review-Url: https://codereview.chromium.org/2915683002
Cr-Commit-Position: refs/heads/master@{#475817}

Revert of Enable redirection of SequencedWorkerPool to TaskScheduler in TestBrowserThreadBundle. (patchset #3 id:40001 of https://codereview.chromium.org/2769693002/ )

Reason for revert:
Caused ServiceWorkerResourceStorageDiskTest.* tests in content_unittests to crash.

See https://bugs.chromium.org/p/chromium/issues/detail?id=727994

Reverting locally fixed the crashes, so I'm going to revert this CL.

Original issue's description:
> Enable redirection of SequencedWorkerPool to TaskScheduler in TestBrowserThreadBundle.
>
> Motivation:
> - Redirection of SequencedWorkerPool to TaskScheduler is enabled in
>   browser tests and on Canary and Dev. It makes sense to enable it
>   in unit tests too.
> - It is not possible to wait until there are no more blocking pool
>   *and* TaskScheduler tasks (new tasks in the blocking pool during
>   a FlushForTesting() call on TaskScheduler and vice versa). If
>   the blocking pool is redirected to TaskScheduler, calling
>   FlushForTesting() on TaskScheduler guarantees that there are no
>   more blocking pool *and* TaskScheduler tasks.
>
> BUG=667892
>
> Review-Url: https://codereview.chromium.org/2769693002
> Cr-Commit-Position: refs/heads/master@{#475144}
> Committed: https://chromium.googlesource.com/chromium/src/+/e1aa28915a28da266d406202a07112d44d6cc018

TBR=gab@chromium.org,robliao@chromium.org,sky@chromium.org,fdoray@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=667892,727994

Review-Url: https://codereview.chromium.org/2909393003
Cr-Commit-Position: refs/heads/master@{#475816}

This patch makes TextUnderlinePosition an enum class for better type
safety.

BUG=684966
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2909423002
Cr-Commit-Position: refs/heads/master@{#475815}

This patch renames some StyleRareNonInheritedData members so that they
match the format expected by the generator.

BUG=628043

Review-Url: https://codereview.chromium.org/2911403002
Cr-Commit-Position: refs/heads/master@{#475814}

This is an initial step to merge MainThreadWorklet and ThreadedWorklet into
Worklet. No tests added, no behavior change.

In the current implementation, ThreadedWorklet implements the loader client for
classic script loading. That's blocking the merge effort. This CL moves the
client implementation from ThreadedWorklet to ThreadedWorkletMessagingProxy as
LoaderClient and reduces differences between MainThreadWorklet and
ThreadedWorklet.

DesignDoc: https://docs.google.com/document/d/1cgLcrua7H_7x_o5GlzYrAi2qt-TqTzgtOeixFAugR6g/edit?usp=sharing

Bug: 727194
Change-Id: I9b9adc04ff5a633a2d9afef3ded6a2f57b89e6ba
Reviewed-on: https://chromium-review.googlesource.com/517454
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475813}

https://skia.googlesource.com/skia.git/+log/b365cf590f87..b5e484254331

$ git log b365cf590..b5e484254 --date=short --no-merges --format='%ad %ae %s'
2017-05-30 mtklein clean up now that min_stride == 1
2017-05-30 mtklein call compile in convert_with_pipeline()
2017-05-30 egdaniel Allow GPU blur fast path for circles and rects when using ignore xform
2017-05-31 fmalita Revert "Delete SkGaussianEdgeShader"

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: I72c40a57d7eb0c2bfd81b069c6ea65565031049c
Reviewed-on: https://chromium-review.googlesource.com/518450Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475812}

My previous CL https://chromium-review.googlesource.com/c/514424/
change the warm-up connection erroneously to use
bindAsExternalService in place of bindToCallerCheck.
Fixing it and adding a test.

BUG=726901

Change-Id: I8b2dfc7ccc8dbf6db22af45714d7777c437e8f16
Reviewed-on: https://chromium-review.googlesource.com/518289Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475811}

The initial CL to support borders/paddings of the containing block of
inlines[1] added the block start of borders/paddings to every line.

This patch fixes to add it only once, to the content_size_, the same way
as NGBlockLayoutAlgorithm does.

[1] https://codereview.chromium.org/2886453005

BUG=636993, 725359
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2914523002
Cr-Commit-Position: refs/heads/master@{#475810}

This patch introduces two mojom types: ServiceWorkerProviderHost and
ServiceWorkerProvider. They are currently used for managing the lifetime of
ServiceWorkerProviderHost from the renderer, but these interfaces will have
methods managing registrations, registration associated by the document and
controller.
These interfaces are now associated with SWDispatcherHost which is already bound
with the channel. After crrev.com/2779763004, interfaces for worker's context
will be associated with EWInstanceClient. This will solve the ordering issue
between messages of Stopped and ProviderDestroyed.

BUG=629701,676983,668633

Review-Url: https://codereview.chromium.org/2653493009
Cr-Commit-Position: refs/heads/master@{#475809}

MediaStreamTrack::applyConstraints() currently resolves with
PhotoCapabilities bc Caps+Settings are retrieved after applying
those constraints.

This CL changes this to resolve applyConstraints() with the
constraints that were applied. 

LayoutTests are updated and slightly cleaned up by factoring
out a service method into resources/imagecapture-helpers.js

Bug: 723251
Change-Id: I0db8671c75154fbeff1ef03f385ed277cf5ce17e
Reviewed-on: https://chromium-review.googlesource.com/517280
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475808}

This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//device/geolocation starts using base::OnceCallback instead of
base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018

Review-Url: https://codereview.chromium.org/2866003002
Cr-Commit-Position: refs/heads/master@{#475807}

This forwards accSelect to the AXPlatformNode. In order to do this, we
had to extension AccessibilityPerformAction a bit to be able to handle
AX_ACTION_FOCUS. Not that the node id is not passed as part of the AXActionData
and is not being used by the delegate at this point.

BUG=703369

Review-Url: https://codereview.chromium.org/2913553003
Cr-Commit-Position: refs/heads/master@{#475806}

This reverts commit 77c59a87.

Reason for revert: Broke build. See the comment on the original review.

Original change's description:
> Mojo EDK: Refactor layered message serialization
> 
> Consolidates and simplifies user message serialization within the EDK.
> Namely:
> 
>   * The ports layer no longer operates under the assumption that all
>   events exist exclusively in serialized form. This eliminates the
>   complexity of layered message allocation at the cost of a small amount
>   of extra copying in some cases.
> 
>   * ports::Message is now more aptly named ports::Event, and different
>   event types are subclasses.
> 
>   * Introduces a ports::UserMessage base class for ports embedder
>   message types. These can be attached to ports::UserMessageEvent
>   objects.
> 
>   * The MessageForTransit and PortsMessage types have been flattened
>   into a single UserMessageImpl type, a subclass of ports::UserMessage.
> 
>   * Nearly all user message serialization and deserialization logic has
>   been consolidated into UserMessageImpl. A few small pieces remain
>   isolated in node_controller.cc and will eventually move elsewhere
>   after additional refactoring.
> 
> All of this work is a precursor to supporting lazy serialization.
> 
> BUG=725321
> 
> Change-Id: Ib9e66cd0d5b88ac0e6dc898f248c958039078023
> Reviewed-on: https://chromium-review.googlesource.com/516402
> Commit-Queue: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#475731}

TBR=jcivelli@chromium.org,rockot@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=725321

Change-Id: I84f950290e6c45dc830f2bc3177af09ae955f432
Reviewed-on: https://chromium-review.googlesource.com/518742Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475805}

BUG=720058

Review-Url: https://codereview.chromium.org/2917433002
Cr-Commit-Position: refs/heads/master@{#475804}

Non-secure HTTP cannot meet users’ security and privacy expectations
when browsing the web. This change introduces new flag states which will
control marking HTTP pages as non-secure in Incognito mode and after
editing HTML forms. Subsequent CLs will detect the new flag states and
adjust the Security Chip UI warnings accordingly.

BUG=721896

Review-Url: https://codereview.chromium.org/2907153006
Cr-Commit-Position: refs/heads/master@{#475803}

This test is no longer correct and doesn't have any real value anyway.
Bye, Felicia.

BUG=None
TBR=jcivelli@chromium.org

Change-Id: Ia13c63a5a8741db739c2c197f2164fea8180e719
Reviewed-on: https://chromium-review.googlesource.com/518485Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475802}

Due to conflicts with the GVR library, we had to stop using this for the VR
browser mode. I think this attribute is still useful for the future, but we
should use it to reduce priority of possibly-slow user GL code instead of using
"high" priority ourselves.

BUG=725684
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2914593003
Cr-Commit-Position: refs/heads/master@{#475801}

This patch generates getters/setters/mapping for TextEmphasisFill,
TextEmphasisPosition, TextEmphasisCustomMark.

BUG=628043

Review-Url: https://codereview.chromium.org/2904403002
Cr-Commit-Position: refs/heads/master@{#475800}

This patch implements inline margin/border/padding. NGTextFragment is
placed according to these properties. The border is not reflected to
fragment tree yet, adding NGBoxFragments will be in following patches.

This patch also supports when inter-item is not breakable. Inline
margin/border/padding belong to different NGInlineItem than its
text, but between them are not breakable.

Includes a fix for LazyLineBreakIterator where offset 0 should not be
breakable.

This patch also adds tests when inter-items are not breakable.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2865903002
Cr-Commit-Position: refs/heads/master@{#475799}

This works behind flag. Currently only normal notification is supported.

BUG=723144

Review-Url: https://codereview.chromium.org/2892893002
Cr-Commit-Position: refs/heads/master@{#475798}

BUG=chromium:726811

Review-Url: https://codereview.chromium.org/2908383002
Cr-Commit-Position: refs/heads/master@{#475797}

This is a generated CL by a clang refactoring tool at //tools/clang/base_bind_rewriters.
It rewrites base::Bind to base::BindOnce where the resulting Callback is converted to
OnceCallback immediately.
E.g.:
  base::PostTask(FROM_HERE, base::Bind(&Foo));
is rewritten to:
  base::PostTask(FROM_HERE, base::BindOnce(&Foo));

In terms of the behavior change after the rewrite, the OnceCallback
implementation moves out the bound argument to the target function, unlike
Callback.

Bug: 554299
Change-Id: Id0d8d60e6c0104d89093522a030fa05d7c50ae67
Reviewed-on: https://chromium-review.googlesource.com/517845Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475796}

Revert of Making answer card to behave like other results. (patchset #6 id:100001 of https://codereview.chromium.org/2905523004/ )

Reason for revert:
This broke a build
https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20x86-generic%20Compile/builds/36279

Original issue's description:
> Making answer card to behave like other results.
>
> Now it lives in a search result container, which can be selected,
> highlighted, navigated with keyboard etc.
>
> Opening the result (i.e. what happens upon clicking on it) is not yet
> implemented.
>
> Unit test for the new result container isn't yet implemented since both
> result opening and accessibility behavior are not yet implemented.
>
> Bug=712331
>
> Review-Url: https://codereview.chromium.org/2905523004
> Cr-Commit-Position: refs/heads/master@{#475782}
> Committed: https://chromium.googlesource.com/chromium/src/+/2420a92712ee82be175bea6750774bec8006c5ce

TBR=xiyuan@chromium.org,jam@chromium.org,sky@chromium.org,vadimt@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Bug=712331

Review-Url: https://codereview.chromium.org/2910173003
Cr-Commit-Position: refs/heads/master@{#475795}

BUG=n/a
TEST=n/a

Review-Url: https://codereview.chromium.org/2907333002
Cr-Commit-Position: refs/heads/master@{#475794}