- 28 Apr, 2015 40 commits
-
-
sorin authored
BUG=479904 Review URL: https://codereview.chromium.org/1112623002 Cr-Commit-Position: refs/heads/master@{#327311}
-
primiano authored
Up until now the API surface of the MemoryAllocatorDump has been strongly typed, enforcing three basic counters (physical_size, allocated_objects_count and allocated_objects_size) + arbitrary extra attributes. This CL simplifies the MAD interface as follows: - Remove the two argument (allocator_name, heap_name) in favor of a simpler and single argument absolute_name (e.g., CreateAllocatorDump("v8/isolate1/heap2") instead of CreateAllocatorDump("v8", "isolate1/heap2")) - Remove the storngly typed properties in favor of a generic Add(attribute_name, type, units, value) method. - Add helper methods MAD.AddScalar() and AddString(). - Rewrite the existing dumpers to use the new simpler API. - Fix the tests. BUG=466141 Review URL: https://codereview.chromium.org/1105143003 Cr-Commit-Position: refs/heads/master@{#327310}
-
skyostil authored
BUG=450977 Review URL: https://codereview.chromium.org/1115443002 Cr-Commit-Position: refs/heads/master@{#327309}
-
dewittj authored
Tests will appear in a future CL. BUG=NONE Review URL: https://codereview.chromium.org/961993007 Cr-Commit-Position: refs/heads/master@{#327308}
-
rogerta authored
Profile chooser on mac was passing wrong value to signin error controller. At the same time, I noticed another case where an infinite spinner could happen on any platform, see fix in inline_login_handler_impl.cc. Fixed MutableProfileOAuth2TokenService to canonicalize the primary account id given to it in order to properly support loading older profiles. This could cause chrome to show an auth error even after a successful reauth. Refactored auth error providers to provide only the account id. Signin error controller should no longer care about username. BUG=476739 Review URL: https://codereview.chromium.org/1094103005 Cr-Commit-Position: refs/heads/master@{#327307}
-
halliwell authored
BUG= Review URL: https://codereview.chromium.org/1104853002 Cr-Commit-Position: refs/heads/master@{#327306}
-
fukino authored
- instantiate ImportController only when the Files.app type is PAGE_FULL. - remove unused flag 'importEnabled_'. BUG=454148 TEST=manual test Review URL: https://codereview.chromium.org/1109073002 Cr-Commit-Position: refs/heads/master@{#327305}
-
danakj authored
This function grabs locks in different orders depending on the order of the layers being drawn. But they are all released before being any are grabbed again, and more than one lock grab only occurs on the compositor thread. R=pbos@chromium.org,earthdok BUG=476529 Review URL: https://codereview.chromium.org/1081103009 Cr-Commit-Position: refs/heads/master@{#327304}
-
nhiroki authored
CacheStorageListener and CacheStorageDispatcher are now in a 1:1 relationship and the indirection is no longer necessary. This CL moves the rest of the stuff to the dispatcher, and removes the listener. 1st CL: https://codereview.chromium.org/1111713002/ BUG=474233 TEST=content_unittests --gtest_filter=CacheStorage* TEST=run-webkit-tests http/tests/cachestorage/ Review URL: https://codereview.chromium.org/1107293002 Cr-Commit-Position: refs/heads/master@{#327303}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/f4219dd..438de49 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=humper@google.com Review URL: https://codereview.chromium.org/1110113003 Cr-Commit-Position: refs/heads/master@{#327302}
-
vkuzkokov authored
BUG=482002 TBR=rdevlin.cronin@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1103143004 Cr-Commit-Position: refs/heads/master@{#327301}
-
dgozman authored
BUG=476496 TBR=jochen Review URL: https://codereview.chromium.org/1114503002 Cr-Commit-Position: refs/heads/master@{#327300}
-
dgn authored
The tag provided to the log functions is now directly used. Getting the full tag from the group tag should now be done once at class initialization, which will allow catching long tag errors earlier. Replaced the "chromium" base tag by "cr" Added convenience functions to make it easier to call isLoggable(tag, level) BUG=472152,469807 Review URL: https://codereview.chromium.org/1113563004 Cr-Commit-Position: refs/heads/master@{#327299}
-
ttuttle authored
Log connection attempts in {Transport,SSL}ConnectJob and copy them into the ClientSocketHandle. Form there, copy them up the stack through the HttpStreamRequest (on job completion) to the HttpNetworkTransaction (on stream creation or failure). SPDY is covered by this change -- sockets for new SPDY sessions are connected on the same path as sockets for HTTP connections, and then passed off to the SPDY code. QUIC is not covered by this change -- sockets for new QUIC sessions are created in the QUIC code, and Chrome's current QUIC behavior does not let us see those results easily. My current plan is to log those *in* the QUIC code and then grab them on the next request that would use that QUIC session. I still need to see if this is actually practical. BUG=480565 Review URL: https://codereview.chromium.org/1006643002 Cr-Commit-Position: refs/heads/master@{#327298}
-
scottmg authored
The allocator shimming doesn't work on the 2015 CRT and we are hoping to be able to remove it if an additional feature lands in the 2015 CRT API. For now, don't shim and revisit once VS2015 is RTM. R=wfh@chromium.org BUG=481611 Review URL: https://codereview.chromium.org/1105213002 Cr-Commit-Position: refs/heads/master@{#327297}
-
tfarina authored
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/622/steps/compile/logs/stdio This fixes the following kind or warnings: warning(clang): [chromium-style] Complex constructor has an inlined body. warning(clang): [chromium-style] Complex destructor has an inline body. BUG=467287 R=thakis@chromium.org,sky@chromium.org Review URL: https://codereview.chromium.org/1103323004 Cr-Commit-Position: refs/heads/master@{#327296}
-
csharp authored
Also add two older values to dllhash. BUG= Review URL: https://codereview.chromium.org/1110123002 Cr-Commit-Position: refs/heads/master@{#327295}
-
mnaganov authored
This is to bring in some sanity, and to facilitate extracting common test code to be used by both ContentShellTests and AwShellTests. BUG=476880 Review URL: https://codereview.chromium.org/1102753002 Cr-Commit-Position: refs/heads/master@{#327294}
-
bnc authored
Verify that the certificate presented by the alternative server is valid for the origin when using HTTP/2, both when opening a new connection or when pooling to an existing one. Patch Set 1: * Enable hopping to a different host for HTTP/2 (not for QUIC). * Add unittests for both new connection and pooling cases. Note in trybot output that *Valid tests pass and *Invalid tests fail. Patch Set 2 and up: * Verify certificate validity in HttpStreamFactoryImpl::Job. BUG=474217 Review URL: https://codereview.chromium.org/1074193003 Cr-Commit-Position: refs/heads/master@{#327293}
-
jbudorick authored
BUG=428727 Review URL: https://codereview.chromium.org/1104273002 Cr-Commit-Position: refs/heads/master@{#327292}
-
penghuang authored
BUG=476589 Review URL: https://codereview.chromium.org/1088553004 Cr-Commit-Position: refs/heads/master@{#327291}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c541d594..901c4c6d Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1114523003 Cr-Commit-Position: refs/heads/master@{#327290}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/714fdfc..2d6802a TBR=pdr@chromium.org Review URL: https://codereview.chromium.org/1110963002 Cr-Commit-Position: refs/heads/master@{#327289}
-
fdegans authored
This CL updates the list of disbled tests on the Browser Side Navigation Linux FYI bot. BUG=475027 Review URL: https://codereview.chromium.org/1113473005 Cr-Commit-Position: refs/heads/master@{#327288}
-
mlerman authored
BUG=466799 Review URL: https://codereview.chromium.org/1110743002 Cr-Commit-Position: refs/heads/master@{#327287}
-
shuchen authored
BUG=474828 TES=Verified on local linux box. Review URL: https://codereview.chromium.org/1108733002 Cr-Commit-Position: refs/heads/master@{#327286}
-
bnc authored
The receiving window as known and obeyed by the peer is |unacked_recv_window_bytes_| less than |recv_window_size_|, this should be reflected in the check in DecreaseRecvWindowSize(). Otherwise |DCHECK_GE(recv_window_size_, unacked_recv_window_bytes_)| might fail in IncreaseRecvWindowSize(). This CL fixes that in both SpdySession and SpdyStream. BUG=478836 Review URL: https://codereview.chromium.org/1051213006 Cr-Commit-Position: refs/heads/master@{#327285}
-
pkotwicz authored
BUG=None TEST=None Review URL: https://codereview.chromium.org/1081003002 Cr-Commit-Position: refs/heads/master@{#327284}
-
rsorokin authored
BUG=479091 NOTRY=true Review URL: https://codereview.chromium.org/1108243003 Cr-Commit-Position: refs/heads/master@{#327283}
-
primiano authored
crrev.com/1107093004 performed a mass-rename of the MemoryDumpProvider.DumpInto() method, but forgot to rename the exclusion rule. BUG=481231 TBR=bruening@chromium.org,sebmarchand@chromium.org Review URL: https://codereview.chromium.org/1108323002 Cr-Commit-Position: refs/heads/master@{#327282}
-
timurrrr authored
This picks up the most recent RTL changes, as well as llvm-symbolizer support for Windows. BUG=430156, 345874 TBR=inferno@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1105423002 Cr-Commit-Position: refs/heads/master@{#327281}
-
dpolukhin authored
MenuModel escapes all ampersands in menu item labels but on network selection screen this name used not as real menu item so we need to unescape it back. BUG=480457 TEST=manual Review URL: https://codereview.chromium.org/1107343002 Cr-Commit-Position: refs/heads/master@{#327280}
-
vkuzkokov authored
Tests fail on Vista bots. BUG=481924,479359 TBR=orenb@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1114533002 Cr-Commit-Position: refs/heads/master@{#327279}
-
sky authored
I added the new gn target mandoline_native_application that creates the directory and changed html_viewer to use it. URLResource tries to find a directory, if it exists the directory is preferred over the raw name. If the directory doesn't exist, than use foo.mojo. R=ben@chromium.org Review URL: https://codereview.chromium.org/1109993002 Cr-Commit-Position: refs/heads/master@{#327278}
-
torne authored
WebView was incorrectly suppressing debuggerd crash handling after breakpad microdumps were triggered on all user builds of android, as the process type was not empty as expected for the Chrome browser process. This went unnoticed as the normal behaviour was still in place for userdebug/eng builds. Fix by also treating "webview" process type as a browser process in the crash component. BUG=481420 Review URL: https://codereview.chromium.org/1105293003 Cr-Commit-Position: refs/heads/master@{#327277}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#327276}
-
peter authored
When resetting notification permission for web pages to the default value from the toast's context menu, only the notifier's name would be considered, but that's empty for the context menu code-path. Instead, like the derive-from-default case, also consider the notifier's URL when changing whether the notifier should be enabled. BUG=481001 Review URL: https://codereview.chromium.org/1103203002 Cr-Commit-Position: refs/heads/master@{#327275}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/2abb865..714fdfc TBR=pdr@chromium.org Review URL: https://codereview.chromium.org/1113533002 Cr-Commit-Position: refs/heads/master@{#327274}
-
rijubrata.bhaumik authored
Blink API files. update the content side usage of the Blink WebDevice{Motion|Orientation} related API headers to match the new locations of these files. This is part of the 3 sided patch: [1] https://codereview.chromium.org/1079983003/ [2] This patch [3] https://codereview.chromium.org/1106933002/ BUG=453032 Review URL: https://codereview.chromium.org/1093433005 Cr-Commit-Position: refs/heads/master@{#327273}
-
primiano authored
This is in preparation of crrev.com/1105143003 which simplifies the MemoryAllocatorDump attributes model with a more generic one. BUG=466141 Review URL: https://codereview.chromium.org/1104413002 Cr-Commit-Position: refs/heads/master@{#327272}
-