- 20 Apr, 2016 40 commits
-
-
svaldez authored
BUG=604728 Review URL: https://codereview.chromium.org/1910523002 Cr-Commit-Position: refs/heads/master@{#388546}
-
davidben authored
Relanded with a fix to TestDownloadRequestHandler. > Do //chromecast at the same time as //net since there aren't many > uses in //chromecast and one needs to be changed to mirror a //net > API change. > > Review URL: https://codereview.chromium.org/1869503003 > > Cr-Commit-Position: refs/heads/master@{#386485} TBR=lcwu@chromium.org,mmenke@chromium.org BUG=576864,554287 Review URL: https://codereview.chromium.org/1897033002 Cr-Commit-Position: refs/heads/master@{#388545}
-
rouslan authored
This patch enables non-activities to receive intent callbacks for intents that they have not launched. For example, Android Pay API launches an intent with the given callback ID on your behalf: Wallet.Payments.loadFullWallet(apiClient, dataRequest, CALLBACK_ID); https://developers.google.com/android-pay/android/tutorial#request_the_full_wallet BUG=602658 Review URL: https://codereview.chromium.org/1902903003 Cr-Commit-Position: refs/heads/master@{#388544}
-
skyostil authored
Fix handling of replies to DevTools commands which don't include any parameters. Previously we used th presence of the reply dictionary to decide between a callback with or without parameters, but this dictionary can be present in the reply also when there are no actual parameters in it. BUG=595353 Review URL: https://codereview.chromium.org/1898633006 Cr-Commit-Position: refs/heads/master@{#388543}
-
bsep authored
Renamed many methods and constants. Updated their associated comments to be consistent with how they're actually used and to hopefully be less confusing to future readers. Also did some minor code cleanup. No visible differences are intended as a result of this change. Review URL: https://codereview.chromium.org/1869163003 Cr-Commit-Position: refs/heads/master@{#388542}
-
gogerald authored
This CL directs the Settings link in sign in confirmation screen to sign in settings screen instead of sync settings screen. BUG=595349 Review URL: https://codereview.chromium.org/1893643002 Cr-Commit-Position: refs/heads/master@{#388541}
-
xhwang authored
Also check that AVDATimerManager is only accessed on one thread. BUG=604869 TEST=No functionality change. Review URL: https://codereview.chromium.org/1903013002 Cr-Commit-Position: refs/heads/master@{#388540}
-
svaldez authored
This removes the definition of use_openssl from build/common.gypi since nothing should be relying on it anymore. R=thakis@chromium.org BUG=604728 Review URL: https://codereview.chromium.org/1904453002 Cr-Commit-Position: refs/heads/master@{#388539}
-
samuong authored
This contains the changes to net_util.*, which now uses "localhost" instead of "127.0.0.1", so that we can connect to IPv6-enabled instances of DevTools. It also contains some extra logging for debugging purposes. BUG=chromedriver:779 TBR=stgao@chromium.org Review URL: https://codereview.chromium.org/1879863002 Cr-Commit-Position: refs/heads/master@{#388538}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/09aa1fce69b2..36db3f44b6cd $ git log 09aa1fce6..36db3f44b --date=short --no-merges --format='%ad %ae %s' 2016-04-20 brianosman Add control of the sRGB global hack flag in SampleApp 2016-04-20 halcanary gyp: add osmesa target to factor out common code 2016-04-20 halcanary SkFontHost/FreeType/ToUnicode: add an assert 2016-04-20 scroggo Add instructions for building with MSAN CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=fmalita@google.com Review URL: https://codereview.chromium.org/1909583002 Cr-Commit-Position: refs/heads/master@{#388537}
-
piman authored
BUG=None CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review URL: https://codereview.chromium.org/1900013004 Cr-Commit-Position: refs/heads/master@{#388536}
-
qinmin authored
New pdfviewer starts to handle http scheme. As a result, clicking a pdf link will no longer trigger a download. Instead, the navigation will be intercepted and passed to pdfviewer. We previously added the referrer extra for analytics purpose for pdfviewer. But that only happens in the download code. This CL fixes the referrer field issue for intercepted navigations. BUG=603730 Review URL: https://codereview.chromium.org/1887173003 Cr-Commit-Position: refs/heads/master@{#388535}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/373e8ae0a5f8..d3578ff8c479 $ git log 373e8ae0a..d3578ff8c --date=short --no-merges --format='%ad %ae %s' TBR=catapult-sheriff@chromium.org Review URL: https://codereview.chromium.org/1910513002 Cr-Commit-Position: refs/heads/master@{#388534}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/05c1f97e..afcc5532 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1898033007 Cr-Commit-Position: refs/heads/master@{#388533}
-
perezju authored
This sets the default value of --pageset-repeat, so it doesn't have to be known or specified by, e.g., bisect bots. The benchmark is split in two versions: - memory.memory_health_quick: pageset_repeat of 1, same as before. - memory.memory_health_plan: pageset_repeat of 5, disabled by default on bots (but can be run manually just fine). BUG=605079 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Review URL: https://codereview.chromium.org/1902423002 Cr-Commit-Position: refs/heads/master@{#388532}
-
skyostil authored
BUG=604558 Review URL: https://codereview.chromium.org/1903163002 Cr-Commit-Position: refs/heads/master@{#388531}
-
droger authored
The loading trace database is now reloaded from the cloud when the worker starts, which prevents losing data when the worker restarts after a failure. There is also now one trace database per worker, which solves the issues of concurrent access to the database. The CL also adds supports for the 'pushStart' and 'pushEnd' events that were added by CL: https://codereview.chromium.org/1828203005/ Review URL: https://codereview.chromium.org/1908483002 Cr-Commit-Position: refs/heads/master@{#388530}
-
brettw authored
In order to roll GN e5510883..b17c5d23 (r387371:r388502) and pick up the following changes: fb8986d4 GN: Make write_runtime_deps take effect only a target is resolved e4b98e2d Fix GN freeze on generating Visual Studio projects 440b117b Add arflags to GN 31500019 GN: Use std::unique_ptr for owned pointers in VisualStudioWriter. 959ec4e4 GN: Use std::unique_ptr for owning pointers in InputFileManager. f9b6b5ae GN: Use std::unique_ptr in Loader::ToolchainRecordMap. ac5bf2c0 GN: Use std::unique_ptr for owning pointers in Scope::NamedScopeMap. 647a1af2 GN: Use std::unique_ptr for owned pointers in ImportManager. 6ce99c70 GN: Replace vector<ParseNode*> with vector<unique_ptr<ParseNode>> in parse_tree.h. c065bd83 gn: Use .obj extension for pch objects on Windows. 8ea3910c [MIPS] Fix gn_unittests LoaderTest.Foo test a67a258a Make it easy to run `gn format' on an emacs buffer. 3a93fa5a Add shell=True for gn-format.py on Windows TBR=dpranke@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel Review URL: https://codereview.chromium.org/1909523002 Cr-Commit-Position: refs/heads/master@{#388529}
-
petrcermak authored
Rationale: The benchmark is causing persistent redness on one Linux and several Android perf bots: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20(5) https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%20(2) https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%20(2) https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf%20(2) https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%20(2) https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%20(2) https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%20(2) TBR=skyostil BUG=600377,605120 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Review URL: https://codereview.chromium.org/1907463002 Cr-Commit-Position: refs/heads/master@{#388528}
-
skyostil authored
Implement conveniene overloads for DevTools commands which only take required parameters. For example, instead of this: client->GetPage()->Navigate( page::NavigateParams::Builder() .SetUrl("https://www.example.com")) .Build()); you can now do this: client->GetPage()->Navigate("https://www.example.com"); BUG=595353 Review URL: https://codereview.chromium.org/1906503002 Cr-Commit-Position: refs/heads/master@{#388527}
-
rob authored
BUG=603725 Review URL: https://codereview.chromium.org/1902263006 Cr-Commit-Position: refs/heads/master@{#388526}
-
owenlin authored
This class runs in the GPU process. It takes video decoding requests from the ARC and talk with real ArcVDA implementations to decode the video. BUG=b/25829285 Test=Compile the code on veyron_minnie. Review URL: https://codereview.chromium.org/1549473002 Cr-Commit-Position: refs/heads/master@{#388525}
-
about://flagsnzolghadr authored
Add a flag in about://flags which enables "PointerEvent" blink feature BUG=575239 Review URL: https://codereview.chromium.org/1568913003 Cr-Commit-Position: refs/heads/master@{#388524}
-
stevenjb authored
Revert of command_buffer_gles2: Implement EGL default Display as a global object (patchset #20 id:380001 of https://codereview.chromium.org/1714883002/ ) Reason for revert: Unfortunately I have to revert this, it is causing compile failures in the chroot. Example builder: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/x86-alex-tot-chrome-pfq-informational/builds/19729 Failure: chromeos-chrome-52.0.2714.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/gpu/khronos_glcts_support/native/egl_native_windowless.cc: In member function 'virtual tcu::NativeWindow* egl::native::windowless::Platform::createWindow(tcu::NativeDisplay&, EGLConfig, const EGLint*, int, int, qpVisibility)': chromeos-chrome-52.0.2714.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/gpu/khronos_glcts_support/native/egl_native_windowless.cc:79:69: error: 'CommandBufferGLESSetNextCreateWindowSurfaceCreatesPBuffer' was not declared in this scope chromeos-chrome-52.0.2714.0_alpha-r1: height); Original issue's description: > command_buffer_gles2: Implement EGL default Display as a global object > > Make EGL Display a global. eglGetDisplay(EGL_DEFAULT_DISPLAY) will > return the same object. > > Store EGL state in a new thread-local object (ThreadState). One > display, multiple surfaces, multiple contexts. > > Fix the currently implemented entry points to return specified errors > and behave as specified. Notable changes: > * eglGetDisplay() does not create new displays for each invocation > * eglTerminate() invalidates the created egl objects but leaves the > current context intact as specified > * eglMakeCurrent() is implemented more correctly with refcount semantics > * eglQueryStrings() works without display for some names > * eglReleaseThread() is implemeted > * Config are now separate for pbuffers and windows, so that contexts > can be created separate from surfaces > * Context can be made current with different surfaces > * Catches errors related to context being set current to multiple > threads > * Tries to be thread-safe > > In the implementation, the Display contains a lock ensuring all thread > accesses are consistent. All functions using or changing thread-local > state have explicit egl::ThreadState parameter. > > BUG=581634 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/de9aa3be41bca094454babbd62907815fad7f5c2 > Cr-Commit-Position: refs/heads/master@{#377535} > > Committed: https://crrev.com/7b01a0867be0895009b120f37fcd4166a84f404b > Cr-Commit-Position: refs/heads/master@{#386613} > > Committed: https://crrev.com/f9d5c7e6fd53570c0decc63e8ec51d30e0701c89 > Cr-Commit-Position: refs/heads/master@{#387871} TBR=piman@chromium.org,thakis@chromium.org,vabr@chromium.org,kkinnunen@nvidia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=581634 Review URL: https://codereview.chromium.org/1909573002 Cr-Commit-Position: refs/heads/master@{#388523}
-
ajuma authored
This adds browser and renderer histograms for the number of render surfaces in the render surface layer list. This also splits the existing histogram for the number of layers into separate browser and renderer versions, making it more useful for evaluating SPv2 layerization (which will only affect the renderer). CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1906523002 Cr-Commit-Position: refs/heads/master@{#388522}
-
sigbjornf authored
URL, WorkerLocation and implementations of HTMLHyperlinkElementUtils are required per spec to expose an enumerable toString() method. Remove uses of [NotEnumerable] for these. R=philipj@opera.com, jochen BUG=306606 Review URL: https://codereview.chromium.org/1905553002 Cr-Commit-Position: refs/heads/master@{#388521}
-
weiliangc authored
Calculation of content rect used to live in LayerTreeHostCommon, but is only useful for render surface. Move it to RenderSurfaceImpl class. Render surface now hides the SetContentRect function. This also leads to deletion of helper function CalculateVisibleRect since it's only used in calculating content rect. BUG=504464 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1902893002 Cr-Commit-Position: refs/heads/master@{#388520}
-
chongz authored
Support |inputType| and |data| field. 'beforeinput' will be fired when: 1. Typing without IME 2. Pressing hot keys like Ctrl-Z 3. Typing with IME, will be fire before compositionUpdate 'beforeinput' will not be fired by Document.execCommand(). SPEC=http://w3c.github.io/editing/input-events.html#event-type-beforeinput BUG=585875 Review URL: https://codereview.chromium.org/1752933002 Cr-Commit-Position: refs/heads/master@{#388519}
-
boliu authored
CleanupReference can't use the DestroyRunnable as the referent, since CleanupReference itself is a gc root that will keep DestroyRunnable alive, in which case the referent is never garbage collected. BUG=597167 Review URL: https://codereview.chromium.org/1905623002 Cr-Commit-Position: refs/heads/master@{#388518}
-
svaldez authored
macro since we no longer have any platforms using NSS for crypto/SSL. BUG=604728 TBR=kelvinp@chromium.org Review URL: https://codereview.chromium.org/1882433002 Cr-Commit-Position: refs/heads/master@{#388517}
-
fs authored
By pushing the update of the m_didTransformToRootUpdate flag out of the various calculateLocalTransform() implementations, we both get implementations of those methods that are more to the point, and expose the redundant calls to SVGLayoutSupport::transformToRootChanged(). This also means that didTransformToRootUpdate() is devirtualized, although it was never called "virtually" before either. Also turn m_needsBoundariesUpdate into a single-bit flag. BUG=603956 Review URL: https://codereview.chromium.org/1904683002 Cr-Commit-Position: refs/heads/master@{#388516}
-
timvolodine authored
Currently the shell restarts the activity with the webview in it when changing screen orientation (e.g. from portrait to landscape). It is disruptive and forces the user to completely reload the page. This patch fixes this issue and allows to flip between orientations seamlessly while viewing a page. BUG= Review URL: https://codereview.chromium.org/1901703002 Cr-Commit-Position: refs/heads/master@{#388515}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/b0ec9836dbf7..09aa1fce69b2 $ git log b0ec9836d..09aa1fce6 --date=short --no-merges --format='%ad %ae %s' 2016-04-20 egdaniel Refactor how we store and use samplers in Ganesh CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=fmalita@google.com Review URL: https://codereview.chromium.org/1895873007 Cr-Commit-Position: refs/heads/master@{#388514}
-
perkj authored
WebRTC 12441:12447 Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/b6d6f27..fcc3833 TBR= CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_archive_rel_ng;tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review URL: https://codereview.chromium.org/1909463002 Cr-Commit-Position: refs/heads/master@{#388513}
-
lukasza authored
The replicated flags mean that in some cases test output includes "duplicated" calls to WebFrameClient::willSendRequest and/or WebFrameClient::didFinishResourceLoad methods. This is expected [1] without PlzNavigate. Replication of the test flags is still desirable, so to make the tests behave the same with and without --site-per-process we suppress dumping of these kinds of callbacks - we can do this, because verification of the presence of this callbacks was not essential to the core verification done by the tests (that cross-site access is blocked). [1] https://groups.google.com/a/chromium.org/d/topic/site-isolation-dev/XRYuFNi4Px0/discussion BUG=587175 Review URL: https://codereview.chromium.org/1895543002 Cr-Commit-Position: refs/heads/master@{#388512}
-
miguelg authored
BUG=571056 Review URL: https://codereview.chromium.org/1902403003 Cr-Commit-Position: refs/heads/master@{#388511}
-
kylechar authored
Split /ui/events/devices into //ui/events/devices + //ui/events/devices/x11 to keep X11 code in a different component. Also udpate GYP targets in a similar fashion. Update some dependent targets and fix a few GN check problems that crop up because GN check doesn't fully understand #if defined(USE_X11) and includes. Originally commited at r388472 and reverted at r388474. There were missing deps in the GN Chrome OS X11 non-Ozone component build that I missed. Nothing in the CQ runs that configuration but it made a waterfall bot fail. TBR=sky@chromium.org,sievers@chromium.org BUG=588026 Review URL: https://codereview.chromium.org/1908473002 Cr-Commit-Position: refs/heads/master@{#388510}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d34463a9..05c1f97e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1908503002 Cr-Commit-Position: refs/heads/master@{#388509}
-
dtapuska authored
Scroll gestures may be generated twice, as a plugin may 'resend' them if not fully consumed by the plugin, and they may be generated once again inside the main renderer host. Re-sending of gesture scroll events from the plugin causes double scroll values in PDFs This was more noticable on Windows which uses a larger tick counter (120) vs 53 on Linux. Fix is to not generate gestures inside the plugin container. BUG=604734 Review URL: https://codereview.chromium.org/1898333002 Cr-Commit-Position: refs/heads/master@{#388508}
-
sadrul authored
It's very easy to create a gfx::Display instance with incorrect values for bounds/work-area when device-scale factor ≠ 1. This is because when the gfx::Display is created with a specified bounds, it attempts to automatically convert the bounds from pixel to DIP values. However, work-area needs to set separately, and so the caller can use different scaling factor when setting the bounds vs. setting the work-area. To fix this, have the gfx::Display creator explicitly do the pixel-to-DIP conversion before setting the bounds and work-area on the gfx::Display instances. BUG=600815, 605124 Review URL: https://codereview.chromium.org/1903003002 Cr-Commit-Position: refs/heads/master@{#388507}
-