- 10 Apr, 2018 40 commits
-
-
Balazs Engedy authored
Interface requests to RenderFrame::GetRemoteInterfaces are dropped when they arrive to the RenderFrameHostImpl after the RenderFrameHostImpl had already committed the next cross-document navigation. In follow-up to crrev.com/c/974263, this CL adds a histogram to record, for each load, and for each dropped Mojo interface request in a frame, a sample with a value corresponding to the hash of the dropped interface's name, calculated as the lower 31 bits of the base::HashMetricName(name). Bug: 795258 Change-Id: I0a4a3aa552c4bc2eb543b4aad3a3a35ecae9f831 Reviewed-on: https://chromium-review.googlesource.com/993059Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#549505}
-
Max Morin authored
This is a reland of 21f2ef4c Per offline discussion, this code is fine. Original change's description: > Bind StreamFactory in audio service. > > Bug: 803102 > Change-Id: I4d8cb112445095045c492488f7c3b8d9853b6c23 > Reviewed-on: https://chromium-review.googlesource.com/1004634 > Commit-Queue: Max Morin <maxmorin@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549481} Tbr: Bug: 803102 Change-Id: I3b14b633dd1419eae570d2b9ab411fc8732fad4c Reviewed-on: https://chromium-review.googlesource.com/1005080Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549504}
-
Sriram authored
This reverts commit e6b16d30. Reason for revert: https://crbug.com/824746 Original change's description: > Remove old position adjustment for non-snap-to-lines WebVTT cues > > This is a remnant of what the spec originally said. Just like the bug > report says, this turned out to be pretty confusing: > https://www.w3.org/Bugs/Public/show_bug.cgi?id=19178 > > Bug: 551245 > Change-Id: I1063b940db81555a65211fa93e84441b53e2b091 > Reviewed-on: https://chromium-review.googlesource.com/753102 > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> > Cr-Commit-Position: refs/heads/master@{#513819} TBR=fs@opera.com,srirama.m@samsung.com # Not skipping CQ checks because the original CL landed 4 months ago. Bug: 551245 Change-Id: Ic0fa56ae68b11332f6e0336c290290f434c7df3c Reviewed-on: https://chromium-review.googlesource.com/1004974 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#549503}
-
Jan Krcal authored
This CL is part of the process of switching from protobuf nano to protobuf lite. Bug: 782237 Change-Id: Iffbdafb225d2ba2dadee14a5b17e7be88a452341 Reviewed-on: https://chromium-review.googlesource.com/1000698Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#549502}
-
Christian Biesinger authored
Addresses kojii@'s comment on https://crrev.com/c/1001721 R=kojii@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I3632cc61d4eb957d1cff67bbdd41cd9cbe0d0f75 Reviewed-on: https://chromium-review.googlesource.com/1005095Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#549501}
-
Kent Tamura authored
- InternalRuntimeFlags.h.tmpl -> internal_runtime_flags.h.tmpl - InternalRuntimeFlags.idl.tmpl -> internal_runtime_flags.idl.tmpl - InternalSettingsGenerated.cpp.tmpl -> internal_settings_generated.cc.tmpl - InternalSettingsGenerated.h.tmpl -> internal_settings_generated.h.tmpl - InternalSettingsGenerated.idl.tmpl -> internal_settings_generated.idl.tmpl This CL has no behavior changes. Bug: 768828 Change-Id: I1538695125ff78b701a71e4cb50024cb4e5e6eab Reviewed-on: https://chromium-review.googlesource.com/1004395Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#549500}
-
Darren Shen authored
Some failures: - fill & stroke shorthands do not seem to follow spec (it should be list valued) - fill-opacity & stroke-opacity do not clamp their values (ComputedStyle should clamp values, like opacity). - fill-color is not implemented. Bug: 820299 Change-Id: I0879e353cd22291aa8a34f2a10895809b43d8aa5 Reviewed-on: https://chromium-review.googlesource.com/998454Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#549499}
-
Vasilii Sukhanov authored
TBR=georgesak@chromium.org Bug: 663847 Change-Id: Iefaed745947d459821b29b0726bcac79e89d23a6 Reviewed-on: https://chromium-review.googlesource.com/1005214Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549498}
-
Adam Rice authored
The browser test ProxyBrowserTest.BasicAuthWSConnect was flaky because the testserver.py proxy it configured could only handle one request at a time, and other parts of the browser randomly launched unrelated requests while the test was running, occasionally taking the proxy's one request until the test timed out. testserver.py's basic auth proxy mode has been modified to support multiple simultaneous requests, so the ProxyBrowserTest.BasicAuthWSConnect test should no longer be flaky. Re-enable it. BUG=822614 Change-Id: Id390f01807b532316e3aa2d4de199e8082ae0bf0 Reviewed-on: https://chromium-review.googlesource.com/999374Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#549497}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/86b145e5..4acb5079 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Iae9b04497f44470ddb6d874589597bee1c6b3016 Reviewed-on: https://chromium-review.googlesource.com/1004596Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#549496}
-
Daniel Vogelheim authored
Allow control of the deprecation via runtime enabled features, with a first step for logging a warning to the console, and the second step to block it outright. Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/35t5cJQ3J_Q/FH45dl0vAwAJ Change-Id: I1be1001cbbef152458119b1516750bb4f1d1e4de Reviewed-on: https://chromium-review.googlesource.com/975611 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#549495}
-
Mark Cogan authored
As a follow-up to crrev/999712, this CL updates the GridCommands protocol to, where possible, express actions on tabs in the tab grid in terms of item IDs instead of indexes. Bug: 986379 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib92ba83fe37ac789b693d006e0ca60cb665b22b5 Reviewed-on: https://chromium-review.googlesource.com/1000860 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549494}
-
David Roger authored
This CL adds an API to OAuth2TokenServiceDelegate::Observer to listen to changes in auth errors. AccountReconcilor uses this API to trigger a ListAccount call when a token becomes invalid. This is necessary because in that case, the account can be invalid in the cookie without the cookie changing. Chrome needs to make a call to ListAccount to have an accurate view of the Gaia accounts in the cookie. Bug: 823714 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie22226adfe6c425acaffe875a314c4a6b8de5e88 Reviewed-on: https://chromium-review.googlesource.com/986268 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#549493}
-
Henrik Grunell authored
Bug: 826664, 830624 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I08e1ee4237f4e221baca4a0adec7a8bff19c1fa6 Reviewed-on: https://chromium-review.googlesource.com/997740 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549492}
-
Elad Alon authored
As a feature, the value could only be off/on. As a switch, the value can be force-off, force-on, or default. Default is at the moment OFF, but will later be made ON for non-mobile builds where the user has given appropriate consent. Bug: 775415 Change-Id: I75b46074434505d65a3a60f2858068d1ad6513c2 Reviewed-on: https://chromium-review.googlesource.com/1002849Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#549491}
-
Vasilii Sukhanov authored
TBR=huangml@chromium.org Bug: 814990 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6db1b62ec0b0d007fdcde56b866ce6500ec71234 Reviewed-on: https://chromium-review.googlesource.com/1005078 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549490}
-
Yutaka Hirano authored
ChannelState was invented in order to address synchronous IPC failures. As mojo doesn't have such synchronous failures, we can remove it to simplify the code. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ia4e5c57c65b0f431a6770fa29bd71b706c15479d Reviewed-on: https://chromium-review.googlesource.com/1004072 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#549489}
-
Matthew Cary authored
This prevents a reload scheduled after TabWebContentsObserver.renderProcessGone from racing with a subsequent page load. Bug: 828400 Change-Id: I5743736aded76a227a1cda0a4fa1824751df9a3f Reviewed-on: https://chromium-review.googlesource.com/992612Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#549488}
-
stkhapugin@chromium.org authored
Makes the location bar transform to a new defocused state where the ToolbarModel's display URL and security icon are displayed. Transitions to normal textfield on touch. Introduces new class: LocationView, a simple view displaying the location icon and text. Introduces new class: LocationBarViewController, which displays the two location bar views: LocationView and LocationBarView. Removes unused focus/defocus animation code from location bar view. Bug: 821801, 821799 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If058ec14fdc466b13f7917ba668be80d4781a4f8 Reviewed-on: https://chromium-review.googlesource.com/943861 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#549487}
-
Max Morin authored
This reverts commit 21f2ef4c. Reason for revert: Will rewrite this. Original change's description: > Bind StreamFactory in audio service. > > Bug: 803102 > Change-Id: I4d8cb112445095045c492488f7c3b8d9853b6c23 > Reviewed-on: https://chromium-review.googlesource.com/1004634 > Commit-Queue: Max Morin <maxmorin@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549481} TBR=kinuko@chromium.org,olka@chromium.org,maxmorin@chromium.org Change-Id: I7ecdcf316e904356ba8373d888fbec910a1b71d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 803102 Reviewed-on: https://chromium-review.googlesource.com/1005174Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549486}
-
Vasilii Sukhanov authored
TBR=hbos@chromium.org Bug: 829401 Change-Id: I98b7d3149599e876d673a84718215521ddf6cfac Reviewed-on: https://chromium-review.googlesource.com/1004995Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549485}
-
Alexander Hendrich authored
Fixed typo as requested by translators. Bug: b:74624289 Change-Id: Ib9474151f11ca655c857d411d0190ad521b6bce8 Reviewed-on: https://chromium-review.googlesource.com/1001578 Commit-Queue: Alexander Hendrich <hendrich@google.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#549484}
-
Hirokazu Honda authored
There are many declarations to create scopedFD from MojoHandle. Create util header file, arc_video_accelerator_util.h, to collect the duplicated declarations. BUG=None TEST=Play Youtube App Change-Id: I9252757831c5c1edd34ebc4bd82bf93c991166d0 Reviewed-on: https://chromium-review.googlesource.com/1002715Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#549483}
-
Michael Lippautz authored
Some phases require iterability of a page. This property is already established before LazySweep during OutOfLineAllocate but was missing in the case where we completed sweeping for *all* arenas. Bug: chromium:757440 Change-Id: I103b55a0d9dba11574ef56fae38db482f7fdad6a Reviewed-on: https://chromium-review.googlesource.com/1004581Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#549482}
-
Max Morin authored
Bug: 803102 Change-Id: I4d8cb112445095045c492488f7c3b8d9853b6c23 Reviewed-on: https://chromium-review.googlesource.com/1004634 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#549481}
-
Mounir Lamouri authored
Instead of the proper value that may have many digits and make no sense to a human. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/998915 It is fixing the test to make it more reliable and rebased the CL. Bug: 829627 Change-Id: Ic550051859367dcd92237d527285f00210098142 Reviewed-on: https://chromium-review.googlesource.com/1000864Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#549480}
-
Morten Stenshorne authored
We used to rely on this taking place lazily via MinPreferredLogicalWidth(), but that method won't necessarily be called if the table is a flex/grid item. Bug: 810327 Change-Id: Ic817bd109544d4b9e961552d0a3a38f127e6e548 Reviewed-on: https://chromium-review.googlesource.com/1000781 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#549479}
-
Igor Kobylin authored
R=dpapad@chromium.org Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5a18ac1278077545aee2c69be4d20102af4b325b Reviewed-on: https://chromium-review.googlesource.com/997844Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#549478}
-
Mikel Astiz authored
Instead of first manually updating SyncedSessionTracker and later producing the protos (SessionTab, SessionSpecifics), we now propose the opposite and: 1. Produce the specifics first from SyncedTabDelegate. 2. Update the tracker using the specifics. This flow is a lot nicer because, once other calling sites are updated, we could move the updating of SyncedSessionTracker a lot closer to where the persistence layers & sync are updated (LocalSessionEventHandlerImpl::WriteBatch), to guarantee that the two stay consistent. This patch does not address the analogous updates for placeholder tabs and the header updates. Bug: 681921 Change-Id: I6bf7e90f9a3b236ce9e7b1f985fc0626369d8659 Reviewed-on: https://chromium-review.googlesource.com/1002176 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#549477}
-
Vasilii Sukhanov authored
TBR=hubbe@chromium.org Bug: 825733 Change-Id: If99bac5fc625623fb79e8a12b92a3f070478955e Reviewed-on: https://chromium-review.googlesource.com/1004955Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549476}
-
Becca Hughes authored
This reverts commit 16d83bf5. Reason for revert: Performance issues Original change's description: > Media Controls: Move to different layer > > will-change will force the media controls to use a different > layer. According to Pinpoint this will reduce CC memory usage > by 18% and GPU memory usage by 6%. > > BUG=821961,821414 > > Change-Id: I13c62f79577dfef253acf5f3b89cecaf0c5c1ad3 > Reviewed-on: https://chromium-review.googlesource.com/996309 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548524} TBR=mlamouri@chromium.org,beccahughes@chromium.org Bug: 821961, 821414 Change-Id: I5df8f67e4e779dc673ca9cf89221c734c5a2235c Reviewed-on: https://chromium-review.googlesource.com/1003332 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#549475}
-
Koji Ishii authored
Following bot results are included. 4683 4686 4687 4698 Deflaking was skipped due to too few results since the last update. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iac1eeb7e2f3836130eb38555272f85780d68d8fd Reviewed-on: https://chromium-review.googlesource.com/1002415 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549474}
-
Darren Shen authored
Had to modify the test harness to allow numbers in keywords. This coincidentally fixed an error in one of the tests (transform-style). Bug: 820299 Change-Id: Ia7e2854f38a5b960e6537d2c4ba309cb71c1e963 Reviewed-on: https://chromium-review.googlesource.com/999225Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#549473}
-
spqchan authored
This reverts commit 2b9a46a9. Reason for revert: <INSERT REASONING HERE> Original change's description: > [MacViews] Fix for incorrect extension padding > > Move the extensions 2pt to the right on Mac to match the native Mac > placements. > > Bug: 792593 > Change-Id: I579520a37043667dfa289b110287c034447c3812 > Reviewed-on: https://chromium-review.googlesource.com/982353 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Sarah Chan <spqchan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#546536} TBR=ellyjones@chromium.org,spqchan@chromium.org Bug: 792593 Change-Id: I517f941cd1b950e45d2879636e1ad0c07c2f5a49 Reviewed-on: https://chromium-review.googlesource.com/989535 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#549472}
-
Vasilii Sukhanov authored
TBR=eae@chromium.org Bug: 591099 Change-Id: Idd34bd927a74e7411eb7f8e0067063330cb316f6 Reviewed-on: https://chromium-review.googlesource.com/1000861Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549471}
-
Rayan Kanso authored
Resolving post-merge nits in cr/980993. Bug: 826257 Change-Id: Ifd201f8ee98f71079d5377034ff593d731061308 Reviewed-on: https://chromium-review.googlesource.com/1000862 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#549470}
-
Yoshifumi Inoue authored
This patch changes "{paragraph,word}-granularity.html" to utilize |selection_test()| for ease of maintenance. Because of "{paragraph,word}-granularity.html" does similar steps, double-click vs. triple-click, this patch integrates them into "word-granularity.html". Following patch will move "word-granularity.html" to "selection/mouse/" for better categorization of tests. Bug: 679977 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Idadf93448d31d6b72ff9dfdd6fbefeb55cb8be2d Reviewed-on: https://chromium-review.googlesource.com/1004534 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#549469}
-
Kent Tamura authored
Bug: 768828 Change-Id: Ib191dd491b06a9c465fad3f645f24e4977c924e7 Reviewed-on: https://chromium-review.googlesource.com/1004565 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#549468}
-
stkhapugin@chromium.org authored
Exposes the location bar flag to chrome://flags. Uses it to switch between the two location bars. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1ec939de576ff14aa75b3db4b7082ecd7a801975 Reviewed-on: https://chromium-review.googlesource.com/1000778 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#549467}
-
tanvir.rizvi authored
For code health we use Ephemeral range instead of passsing position in RemoveInlineStyle. With this we catch a bug at call sites, as EphemeralRange construction takes care of the current DCHECKS in RemoveInlineStyle Bug: 826106 Change-Id: Ibaa37789f7671aa464b4c87d30f12bd023a67a3d Reviewed-on: https://chromium-review.googlesource.com/1001437Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Cr-Commit-Position: refs/heads/master@{#549466}
-