- 13 Apr, 2020 40 commits
-
-
Nnamdi Theodore Johnson-Kanu authored
With most of routes shared between ChromeOS and browser renamed except for Sync routes, a DCHECK can be used when opening browser settings pages to that the |sub_page| is not an OS-specific setting. Bug: 990169 Change-Id: I84ca6c5584d405d3a2deed2d61878c70d3744c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138115 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#758529}
-
Tomasz Wiszkowski authored
This CL addresses the SimpleRecyclerViewAdapter propagating incomplete events to the parent RecyclerViewAdapter, resulting in partial UI updates. The CL also adds a few tests that confirm the behavior of the SRVA. Change-Id: I4c35b54e925853e91d686fde5cc476f3d2efe6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146063 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#758528}
-
Yann Dago authored
Extensions installed by policy as "normal_installed" were disabled by default contrary to what is documented. They are now silently enabled by default. Bug: 1029516 Change-Id: I5b11b3fdd85ff39f5bbb9e0505d26294c5c5f935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118575 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#758527}
-
Antonio Gomes authored
BUG=767015, 1063749 R=jfernandez@igalia.com Change-Id: I4f88f5540f9d3999081718501399465920d36ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144993 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#758526}
-
Peter Kasting authored
That seems more consistent to me. Bug: none Change-Id: I962a8e1eee04a33436157dc132e81e0231c0d088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147079Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#758525}
-
Leonard Grey authored
This pushes the decision on when to hide/show the download bar into the browser frame instead of ping ponging back and forth with the fullscreen controller. Also cleans up some cruft left over from Cocoa/different fullscreen implementations. Could still be a little better (handling download shelf visibility in BrowserViewLayout), but it's tricky between immersive mode, DownloadShelf expecting to handle its own visibility, etc. so I'm holding off for now to land this. Bug: 902501 Change-Id: If0ba982c8ecbad40eda21e985b77cdda8621c791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141040Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#758524}
-
Thomas Lukaszewicz authored
Eliminated the need for ViewsInteractiveUITestBase, cleaned up more of the Widget test related code. Bug: None Change-Id: Ie4a6410e023e0f9edcaf52b997063e70fa6f3f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146332 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#758523}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dabe38f611af..f61ee1ecac14 git log dabe38f611af..f61ee1ecac14 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 johnstiles@google.com Fix assertion in ImGui::NewFrame if getBackbufferSurface returns null. 2020-04-13 robertphillips@google.com Expand PlotLocator into a class Created with: gclient setdep -r src/third_party/skia@f61ee1ecac14 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I865b14edf5afbe21d09b87790ff87af576807f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147615Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758522}
-
Matt Jones authored
This patch removes ReaderModeInfoBar's use of TabImpl.getActivity() and passes the relevant tab around instead of trying to access it via TabModelSelector. Bug: 1069815, 952703 Change-Id: I359597d1a71914653a948a246275f88bb9de1666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145816 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#758521}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8b4d25b6741b..ee7525af4712 git log 8b4d25b6741b..ee7525af4712 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src fd593d5f0834..46572440189e (1 commits) Created with: gclient setdep -r src/third_party/angle@ee7525af4712 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I915947be77f31bc1913c936b0fa65a25374a21c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147614Reviewed-by:
-
Scott Violet authored
This typically means the delegate is calling Stop() from start or a redirect. To continue on is likely to lead to use after free. BUG=none TEST=none Change-Id: I42ffb6081abd282968aaad2243795746906e73e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144478 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#758519}
-
Carlos Knippschild authored
A small follow up to https://crrev.com/c/2138633. Bug: 1010916 Change-Id: I2227fbaedc2104f15e9968421f3bed0f9e134961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145733Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#758518}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/97d7f070200a..e9d37e79b47f git log 97d7f070200a..e9d37e79b47f --date=short --first-parent --format='%ad %ae %s' 2020-04-13 morg@google.com Add Android arm64 support for cbuildbot_run 2020-04-13 hirokisato@chromium.org Revert "device: Don't assume '--device=localhost' means VM." 2020-04-11 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-11 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-10 saklein@chromium.org commandline: Fix ssh parsing. 2020-04-10 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-10 richardfung@google.com Remove betty-arcmaster 2020-04-10 bpastene@chromium.org device: Don't assume '--device=localhost' means VM. Created with: gclient setdep -r src/third_party/chromite@e9d37e79b47f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Id56272f0673fd63544a135d1b3f78c1c74a26dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147062Reviewed-by:
-
Matt Menke authored
We want to get rid of the single argument AddHeader() method as the two argument AddHeader() and SetHeader() methods are safer and more flexible. Bug: 1068194 Change-Id: If46c344d0fbf3751041568aff529feef2ffb7d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147652 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Matt Menke <mmenke@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#758516}
-
Katie D authored
Reader mode should be considered by users to be a view of the original, rather than its own page. We do not expose reader mode URLs to users in the omnibox, so we should not allow users to bookmark those URLs directly. Instead, bookmarks added on dom-distiller pages will apply to the original article's URL and title. If a user looks at a Reader Mode page which corresponds to a bookmarked URL, the star icon will be active. Bug: 1066165 Change-Id: I2e323977fdd8b218d433e3fef2175af81e0f1b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130446Reviewed-by:
-
Hirokazu Honda authored
RtcVideoEncoder is the chrome's implementation of webrtc::VideoEncoder . Some of webrtc::VideoEncoder interfaces are blocking functions but VideoEncodeAccelerator interface is asynchronous. RtcVideoEncoder::impl needs to have values in order to block in webrtc::VideoEncoder and notify later. The values are shared in RtcVideoEncoder, so that the values might accidentally overwritten. This fixes the problem by isolating the values used by RtcVideoEncoder functions, concretely, split them into the value for the initialization and the value for the encode task. Bug: 1068074 Test: webrtc.* on eve Change-Id: I6efd3038b0db016e1257ecda206271e501901d70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141871Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#758514}
-
Tom Anderson authored
After CL [1], the cursor name changed from "all-scroll" to "move" on X11. On older DMZ/Adwaita cursor themes (default on Ubuntu 16.04 LTS), this resulted in the DND-move cursor (left-arrow with a small move icon) instead of the all-scroll cursor (four arrows). The comment in cursors_aura.cc explains why we should be using all-scroll [2]: // Returning "move" is the correct thing here, but Blink doesn't // make a distinction between move and all-scroll. Other // platforms use a cursor more consistent with all-scroll, so // use that. This CL restores the cursor CSS name to all-scroll to fix older cursor themes. The newer themes don't have this issue. [1] https://chromium.googlesource.com/chromium/src/+/4b135039432a487e84547308fea5703a198a1297%5E%21/#F0 [2] https://source.chromium.org/chromium/chromium/src/+/master:ui/base/cursor/cursors_aura.cc;drc=163115502d4bff646602baa9af3b0a8522809351;l=361?originalUrl=https:%2F%2Fcs.chromium.org%2F BUG=1069738 R=sky Change-Id: Ib82900c62a23b3efc5ce556b652019ce31045b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145919 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: -
Oystein Eftevaag authored
The 'abcnews' pageset was hitting this limit and failing perf runs. R=sullivan@chromium.org Bug: 2052598 Change-Id: If7d36791611dc42cacff5e083f7d38fb83a61cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146086 Auto-Submit: oysteine <oysteine@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#758512}
-
Matt Menke authored
NavigationHandle::GetIsolationInfo() calls into RenderFrameTreeNode and RenderFrameImpl to calculate the IsolationInfo for navigation. This in turn calls into other RenderFrameTreeNodes. ThirdPartyMetricsObserver::OnDidFinishSubFrameNavigation(), which is where the DCHECK is, can be called in the destructor of a RenderFrameImpl and RenderFrameTreeNode, so this re-entrancy while in the middle of a destructor. Worse, we could already have deleted the other RenderFrameTreeNodes at this point, resulting in dereferencing a destroyed object. Fixed: 1070142 Change-Id: I1d2122ce867160cabfbad6499177c276fd66956a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146933Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#758511}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a9439a50..984c85e7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic52b7f938b5a9416e42983be36ad4d9bac65fa54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145638Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758510}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I364c818d7dc04e616114f50f8265e3c5a04b3718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147393Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#758509}
-
Yuichiro Hanada authored
ui/keyboard no longer exists. Bug: 1060272 Change-Id: Ie42724fb6b00d44d91ba8050f2a7703eb6f9fe6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143175 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 767015, 1063749 Change-Id: Ibb7d0fd6d18ee498e878033b433684548a85ef17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146534 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#758507}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d468a1619a2f..dabe38f611af git log d468a1619a2f..dabe38f611af --date=short --first-parent --format='%ad %ae %s' 2020-04-13 egdaniel@google.com Add submits after flushes in ProgramsTest. Created with: gclient setdep -r src/third_party/skia@dabe38f611af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I3685b68cae7811c14024680b45e8994ebe678f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147540Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6034567f9d0a..04ab397e8e8a Created with: gclient setdep -r src-internal@04ab397e8e8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,yutak@google.com,rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: xhwang@google.com,yutak@google.com,rhalavati@google.com Change-Id: I7636e8e2d8d06567c37ea3b747512325aa2068a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147538Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758505}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ic6be109302b4c199ddae5726ee7b4f857a0c98e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145740Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I5264649499cc8e9507ca18aa2bf62ccfe0506b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145527Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I502ccd86afdaf871f533417bab9af2677a7f7dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144710Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758502}
-
Philip Rogers authored
This patch makes will-change: filter a compositing reason. The approach is similar to will-change: transform where filter changes do not cause DiffNeedsFullLayoutAndPaintInvalidation (see change in computed_style_diff_functions.json5). LBMO::StyleDidChange is used to invalidate when the will-change property changes. Bug: 960953 Change-Id: I7600c141baf11d1e10fae229a6261926c44923fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145466 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758501}
-
Elly Fong-Jones authored
It's always gfx::Rect() anyway, and the bubble has an anchor view. Bug: 1064663 Change-Id: I94cfcd1c64dbb5bbce7f9990dda75b91186aa56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144772Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#758500}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8128233d3354..8b4d25b6741b git log 8128233d3354..8b4d25b6741b --date=short --first-parent --format='%ad %ae %s' 2020-04-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 2fd41fab58c8..490e39372126 (2 commits) Created with: gclient setdep -r src/third_party/angle@8b4d25b6741b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I18991ec514e8a4ee4b554a39397349bafee9ba98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147152Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/828ceef7d7ff..cef0af8e6c7f git log 828ceef7d7ff..cef0af8e6c7f --date=short --first-parent --format='%ad %ae %s' 2020-04-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@cef0af8e6c7f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaa6eb594bb633f5900eda858f4d8cb249dd3b0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147536Reviewed-by:
-
Reilly Grant authored
As an optimization SerialChooserController and HidChooserController were written to use std::move() to move the select device (or list of devices) out of the list of options. This leaves the list in an inconsistent state (a single null entry) which causes the crash reported in issue 1069057. These classes have been updated to follow the pattern from UsbChooserContext of returning a clone of the selected option instead. Bug: 1069057 Change-Id: I016d12adad2977e49939dfb00044bfd7201767ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145052 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4b4efe4d6f1f..d468a1619a2f git log 4b4efe4d6f1f..d468a1619a2f --date=short --first-parent --format='%ad %ae %s' 2020-04-13 reed@google.com [skvm] approx_[asin,acos,atan] Created with: gclient setdep -r src/third_party/skia@d468a1619a2f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I7851ea488a40f0085705214ef848b200c42e4e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147535Reviewed-by:
-
Frédéric Wang authored
This CL improves the stretchy operator shaper code after more testing in MathML layout. The following changes are performed: * Add an OUT Metrics parameter to StretchyOperatorShaper::Shape and improve this function. As discussed in [1], it is expected that LayoutNG algorithms perform both text shaping and measurements, and pass the shape result to the painter classes, so it is not necessary to have a separate GetMetrics method. * Remove GetGlyphStretchSize and ToMetrics helper functions since they are now only used in only one place. * Remove the stretch axis direction parameter from the version of CreateForStretchyMathOperator that outputs a single glyph since MathML only supports horizontal mode and vertical operators still correspond to horizontal text. * Improve code documentation and update tests. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2051923 Bug: 6606 Change-Id: Icc755adf9460ac59b68e0d904c062296700fd3c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144110Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#758495}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4950853060fdf50dd1c2aab9f5a645f04e24a66b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147382Reviewed-by:
-
Maksim Sisov authored
This Cl doesn't bring any functional changes, but just moves the X11 code down to ui/base/x. Bug: 1069469 Change-Id: Idaddec11dfbe88226a190d2ba4b5050ad38eed6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144056 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#758493}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cf2c8e6068c8..8128233d3354 git log cf2c8e6068c8..8128233d3354 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader e6f65d9265e7..9d2fd9c161ab (2 commits) Created with: gclient setdep -r src/third_party/angle@8128233d3354 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I20a734fdc8041427b568293b3ae233d7bc1fe98f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147380Reviewed-by:
-
Miyoung Shin authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames it to negative-flex-margins-crash.html. Bug: 1063749 Change-Id: Ibd2006646b62247ec4b0fd77165b7bb5fc058040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144801Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#758491}
-
Miyoung Shin authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames it to negative-flex-rounding-crash.html. Bug: 1063749 Change-Id: Ia5e1488b0f7681ffebf726300977e406cf58dcb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142877Reviewed-by:
-
