- 09 Jul, 2019 40 commits
-
-
Emil A Eklund authored
Tbr: drott@chromium.org Bug: 982221 Change-Id: Ifbe5ab69899ea8a165813efab652caabe2e35d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692034Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#675776}
-
Becca Hughes authored
Remove the Media.Controls.Overflow.TimeTo* histograms as they are expiring in M77. BUG=974947 Change-Id: Iab0a0c31a4b627c6b25fd8116fbe3851178c12e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691582 Auto-Submit: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#675775}
-
Vadym Doroshenko authored
The problem was that after a successful Chrome sign-in, a tab navigates to the new tab page which is processed in different way than web pages. That CL introduces saving a password hash in case when the tab navigates to the new tab page after Chrome sign-in. Bug: 979046 Change-Id: Idd030e32876647b4ed995ff8fbda617697820774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690844 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#675774}
-
Tibor Goldschwendt authored
Previously, we used runtime deps to collect the shared libraries. That worked due to some special runtime dependency propagation rules around shared_library targets. However, this will stop working with the new linker assisted native feature module approach where some shared libraries will become action targets. To solve this, this CL - adds the shared library output file to metadata of each shared_library target, - adds the new partitioned shared library output files to metadata as well, - adds barriers where propagation should be interrupted, and - adds generated_file targets to read the metadata. Bug: 980569 Change-Id: Ib3f49a00d04d066a2fc1f0bb916d469adabac447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693023 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#675773}
-
Becca Hughes authored
Convert the GetMediaImageBitmap to use a weak ptr of the ImageObserverHolder to fix a crash. BUG=982073 Change-Id: I3f97e778d2c99e55bdc4287c8073a6f3639d069a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692219Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#675772}
-
Dan Beam authored
R=dpapad@chromium.org BUG=979875 Change-Id: I08350578fd1649f686b598016bc65436042a14d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683924 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#675771}
-
Joe DeBlasio authored
PageInfo used to have tabs, but it doesn't anymore. This removes a lingering unused enum. Change-Id: I1d1c3722436ae25532fd85a84704bfc5e839f5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692871 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#675770}
-
John Lee authored
Change-Id: I222db62bbec8664c0ebc97d4086841007bd5a595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690713Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#675769}
-
Julien Racle authored
Provides a wrapper to WindowsCompareStringOrdinal function. This CL is needed for base/win/IMap's equality to work properly. BUG=728870 TBR=gab@chromium.org BUILD.gn change Change-Id: Ibf8f4442ff25b7525710182c8dc5969ae68c44ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683293 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#675768}
-
Geoff Lang authored
Recent versions of Android use GLSurfaceEGLSurfaceControl which only implements the Async swaps. BUG=979342 Change-Id: I0bc624de5d3ddbbdce09b614a927a11a9cb73213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686785 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#675767}
-
Ahmed Fakhry authored
The multiprofile feature is expected to be removed by the end of the year, so keep its histograms until then. BUG=975004 Change-Id: I6a8f058d62b2a01fe282d95e83249392bfad674e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692002Reviewed-by:
-
Josh Nohle authored
These strings identify the supported and enabled states of BetterTogether features. They are used in DeviceSync v2 RPCs BatchNotifyGroupDevices, BatchGetFeatureStatuses, and BatchSetFeatureStatuses. Bug: 951969 Change-Id: I3f922f7aa0dcbcb0f8656519905d706b21666508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684244Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#675765}
-
Xiaohui Chen authored
Currently there are code duplication that does similar things to detect hotword input device. Now we move all the logic into cras_audio_handler to simplify the code. Bug: None Test: locally build and run Change-Id: I08df6cef18a17dd3c5b2eff6f5b4193aecf0b3e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686951Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#675764}
-
Jacques Chen authored
-Add the "compress='brotli'" flag option in grdp files -Grit will now automatically brotli compress if flag is included -Previous Cl that was split into this one: https://chromium-review.googlesource.com/c/chromium/src/+/1660352 Bug: 826858 Change-Id: I010ad1650394e4bdd58e066486b161cf74f2fff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692234 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Lucas Tenório authored
Bug: 977606 Change-Id: I0bfd0152cc958c624ca2566925da367a60a46f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683579 Auto-Submit: Lucas Tenório <ltenorio@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Sadrul Chowdhury authored
Document LayerTreeHostImpl::is_synchronous_single_threaded_, since it is often a source of confusion. Change-Id: I7753afe66348e9aad9ec7ac727396cad6ec486c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693093 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#675761}
-
Yun Liu authored
JaCoCo counter data conforms to code coverage Metric: JaCoCo coverage counter type definition: https://www.jacoco.org/jacoco/trunk/doc/counters.html Code coverage Metric message definition: https://chromium.googlesource.com/infra/infra/+/HEAD/appengine/findit/model/proto/code_coverage.proto#77 Also use findall() instead of iter() to find only elements with a tag which are direct children of the current element. Bug: 843307 Change-Id: Id35a4af0dae250f6c07763e01cfbac71b6802d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689341 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#675760}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb5517877b5e..f93d4fb40451 Created with: gclient setdep -r src-internal@f93d4fb40451 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mcnee@google.com,hcarmona@google.com,hajimehoshi@google.com Change-Id: Id1cadde53ad488108f29631eb59841e890c3f41f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691874Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#675759}
-
Ryan Hamilton authored
https://quiche.googlesource.com/quiche.git/+log/014740d30571..7498c8c59b8a $ git log 014740d30..7498c8c59 --date=short --no-merges --format='%ad %ae %s' 2019-07-02 renjietang In HTTP/3, write Priority on control stream before writing headers. Created with: roll-dep src/net/third_party/quiche/src [Reland https://chromium-review.googlesource.com/c/chromium/src/+/1691429] Bug: 982169 Change-Id: I8ecb5b77439e02965371a5d15d716f04b57f2e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692963 Commit-Queue: Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#675758}
-
Mehran Mahmoudi authored
This moves the re-display code for progress bar from on activity resume to on activity start. It also adds the new skipShowingProgressBarOnNextActivityStart to TouchlessUiCoordinatorImpl. When called, the next activity start event will not cause the progress bar to show. Downstream CL: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/1450627 Bug: 971902 Change-Id: If959fbff9503ae3789bf0d1d3668bb43b47fb1d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692486Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#675757}
-
Kristi Park authored
Screenshots: http://screen/WTjRzjawxg6.png http://screen/e9MfGSpBMtu.png http://screen/nWOM2XTy8R2.png http://screen/8UJGZFTXrGx.png Bug: 953822, 976494 Change-Id: Iaf3f5a9598a982075861777fb4fd93312efa24f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688436 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#675756}
-
Elly Fong-Jones authored
This change: 1) Sets item_{top,bottom}_margin to 4 (rather than {4,3}) in material menus; 2) Removes some code in AppMenu::PopulateMenu that messes with the vertical margins on two of the menu items for no apparent reason Bug: 981532 Change-Id: I7add25d4fb328769aec2242685ab6bb4e64f7754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687797 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: -
Kevin McNee authored
Tbr: ericwilligers@chromium.org Bug: 966249 Change-Id: I06f2daae2e0b1bcacb50e9223ae9657e69d34e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692237 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#675754}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cb60a8b64c94..b249c5420944 git log cb60a8b64c94..b249c5420944 --date=short --no-merges --format='%ad %ae %s' 2019-07-09 danilchap@webrtc.org Delete GlobalTaskQueueFactory as now unused 2019-07-09 ssilkin@webrtc.org Use max bitrate limit recommended by encoder. 2019-07-09 titovartem@google.com Fix collection of audio metrics from PC test framework for audio test 2019-07-09 titovartem@webrtc.org Add support of specifying audio sample rate for PC test framework 2019-07-09 danilchap@webrtc.org Remove cricket::WebRtcMediaEngineFactory as now unused Created with: gclient setdep -r src/third_party/webrtc@b249c5420944 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If3cd2ae368947fafe227c4e8043cb7d57d6377cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692728Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#675753}
-
dpapad authored
Bug: 965770 Change-Id: I1484770d101afca91562db6757b37ff8019ea28f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693165 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#675752}
-
Philip Rogers authored
Overlay scrollbars should not clip content because they can be transparent. This was true for platform overlay scrollbars but we had a bug that did not ignore CSS overlay scrollbars when calculating the overflow clip. This was not caught because CSS overlay scrollbars are not standardized and are rare. Bug: 974185 Change-Id: Idce3488ed03da02613a71c160d9ac1e232392e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692240 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#675751}
-
Anton Bikineev authored
Metrics are changed as follows: BlinkGC.CompleteSweep -> BlinkGC.TimeForCompleteSweep BlinkGC.TimeForSweepingAllObjects -> BlinkGC.TimeForSweepingSum Two more metrics are introduced: BlinkGC.TimeForSweepingForeground -> sweeping on the main thread BlinkGC.TimeForSweepingBackground -> sweeping on background helpers. Bug: 967258 Change-Id: Ic9988bb402857bc14e13a122c4b2ece0853ddd9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690970 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#675750}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8679d594ec31..8c5abeafb24a git log 8679d594ec31..8c5abeafb24a --date=short --no-merges --format='%ad %ae %s' 2019-07-09 groeck@chromium.org config: Prepare for generic builders running chromeos-4.19 kernels Created with: gclient setdep -r src/third_party/chromite@8c5abeafb24a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ie9913bf116b7bad7df68fac374646dc2134533e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693092Reviewed-by:
-
Kevin McNee authored
This test flakes under TSAN. Tbr: mrobinson@igalia.com Bug: 981913 Change-Id: Ibd4143285ddedc3bc0feaa5f36d5c1bb4d436117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692880Reviewed-by:
-
Steven Bennetts authored
Bug: 982206 Change-Id: I0d87e231aa0bea1526286c8907cb40304717a300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680106 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#675747}
-
Tarun Bansal authored
Dispatch requests that are currently queued if the effective connection type (ECT) changes since the newer ECT may allow more requests to go in flight. Change-Id: I095feaaf17965909c3dc36612da0960324e7f6ea Bug: 913424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692482Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#675746}
-
rbpotter authored
The resize cursor should only appear within 8px of the lines, not on or near the textboxes. Bug: 980442 Change-Id: I63dc48bcdd48bae7d484584078189f0b9739a1bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689343Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1540b3ba37cf..b42af2f2cc97 git log 1540b3ba37cf..b42af2f2cc97 --date=short --no-merges --format='%ad %ae %s' 2019-07-09 bsalomon@google.com vk_format_to_pixel_config behind GR_TEST_UTILS 2019-07-09 halcanary@google.com ModifierKey unifies sk_app::Window::ModifierKey & Sample::Click::ModifierKey 2019-07-09 brianosman@google.com Reland "Make the SkSL interpreter opt-in" 2019-07-09 jvanverth@google.com Re-enable Vulkan MSAA support in Viewer 2019-07-09 bsalomon@google.com Use vkCmdClearColorImage to clear backend textures 2019-07-09 reed@google.com create outer forloop to support loops=-1 2019-07-09 fmalita@chromium.org [skottie] Motion blur fast path 2019-07-09 egdaniel@google.com Move uses of functions taking SkColorType to GrColorType versions in GrCaps. 2019-07-09 fmalita@chromium.org [skottie] Motion blur support 2019-07-09 brianosman@google.com Revert "Enable MSAA on Gen8 Intel GPUs" 2019-07-09 scroggo@google.com Check for uninitialized memory during jpeg encode Created with: gclient setdep -r src/third_party/skia@b42af2f2cc97 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:951893 TBR=fmalita@google.com Change-Id: I0fe3bfef1f16899ba02fad4a24dfd4083cddbc69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693091Reviewed-by:
-
Shimi Zhang authored
This comes from the discussion of crrev/c/1306240. We want to migrate - AssociatedInterfaceRequest to PendingAssociatedReceiver. - AssociatedInterfacePtr to AssociatedRemote However AssociatedInterfaceRegistry and AssociatedInterfaceProvider don't have such support yet. Bug: 955171 Change-Id: I350dba2dac66b37cfc59f08daa06b000352b0c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685837Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#675743}
-
Becky Zhou authored
Bug: 975719 Change-Id: I9c3ba71b1434f3edebf7ca6557ae4344c0828e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682225Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#675742}
-
Sadrul Habib Chowdhury authored
LayerTreeFrameSinkClient::DidNotNeedBeginFrame() is never used from LayerTreeFrameSink instances. So it is removed. However, LayerTreeHostImpl::DidNotNeedBeginFrame() is still used to notify when the compositor stops asking for begin-frames, so keep it as a direct member function. BUG=none TBR=oshima@ for mechanical changes in ash/ and components/exo Change-Id: Ia5b7dac845e12a487e25f635cdc6ee9d8de2bd26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692485 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#675741}
-
David Bokan authored
This bug occurs because of an issue in ordering of cc::Layer destruction. LayerTreeHost maintains a mapping of ElementId to cc::Layer. When scroll deltas are committed from the compositor thread to the main thread, the deltas are associated with an ElementId. LTH uses the mapping to determine the layer onto which the delta is applied. The problem here occurs when a scroller loses its compositing layer, then becomes composited again within the same lifecycle frame. The event sequence: 1) Scroller becomes decomposited due to style change, GraphicsLayer is destructed but the root cc::Layer still has a pointer to the child layer so we don't yet destroy the associated cc::Layer 2) Scroller becomes composited again due to another style change. 3) During compositing portion of lifecycle we'll create a new GraphicsLayer. 4) In PaintArtifactCompositor::Update, we create a new cc::Layer which causes us to initialize the ElementId mapping in LTH when we call Layer::SetLayerTreeHost. This clobbers the ElementId->cc::Layer mapping for the layer removed in step 1. 5) At the end of PAC::Update, we set the new layer list on the root which removes pointer to the layer removed in step 1. This causes the layer to be deleted which calls cc::Layer::SetLayerTreeHost(nullptr) causing the layer to remove its ElementId mapping. However, the mapping for the ElementId now points to the new layer created in step 4. 6) Compositor scrolls against the ElementId now don't commit any delta because the mapping doesn't contain an entry for ElementId. This CL fixes the issue by causing the cc::Layer to remove itself from the layer list when the GraphicsLayer is deleted. This will cause the layer to be deleted and unregister itself at that time. Bug: 979002 Change-Id: I76b195982cc09d9ed208e6f96271b7539898da4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690036Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Jordan Demeulenaere authored
Change-Id: I2af9127a7fb62afdfb83e37fe8db10f40e986f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692746 Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#675739}
-
Kristi Park authored
Enable FakeboxSearchIconOnNtp by default in preparation for launch. Bug: 958655 Change-Id: Ibe559f30ac8cb73d63d0fdd38ebffbab5abe781f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691432Reviewed-by:
-
Ian Clelland authored
When 'self' was specified in a feature policy header for a sandboxed page, the resulting policy would not actually allow the feature in that page, even when it would otherwise have been allowed. This corrects that by assigning the correct origin to the policy and accepting that origin in allowlists. Bug: 973880, 690520 Change-Id: I93325bf24119068f8138f6e38507598cc30cbb06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689958 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#675737}
-
