- 28 May, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b9529e3a6998..f7a7fb49cfe7 2020-05-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 2b0eafb1de5b to e00d27c6d65b (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ica8f059302fb68f358b394640771da3627862df6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219909Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772678}
-
Kevin Schoedel authored
WebContentController is a RenderWidgetHost::InputEventObserver in order to receive acks and generate gestures. RenderFrameCreated and RenderFrameDeleted have been used to manage this, deriving the RenderWidgetHost from the given RenderFrameHost. However, deletion of a RenderFrame does not actually imply deletion of the associated RenderWidget, so that should not be cause for unregistering the InputEventObserver. This does mean that we don't definitely know when a RenderWidgetHost goes away, but this is safe because ~WebContentController already checks its validity, and a deleted RenderWidgetHost certainly won't be calling any observers. Bug: b/151325287 Test: manual on device Change-Id: I5085d048dfd2f4ec240e7035d2c2e9d06e598f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218764Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#772677}
-
Mohamed Amir Yosef authored
This comment was written before LoginDatabase got a proper primary key field. Change-Id: I9802cd6576d462da91b98f87f347b5ed1cc41d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220025Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#772676}
-
Bartek Nowierski authored
This code is currently unused, but is needed to evaluate performance impact of the CheckedPtr initiative. https://docs.google.com/document/d/1pnnOAIz_DMWDI4oIOFoMAqLnf_MZ2GsrJNb_dbQ3ZBg The current implementation is an expensive no-op. It offers no run-time verification of pointer correctness, but it performs work as if it did. It is expected to have similar performance characteristics to the designed CheckedPtr2. CHECKED_PTR2_PROTECTION_ENABLED and "TEST" comments show how the actual code would look like had all needed support been already implemented. Bug: 1073933 Change-Id: I4fc6a1a3b6701dcae9bb38ff3fa01fd6276812fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162493 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#772675}
-
Alex Ilin authored
The Gaia reauth page displayed in a modal dialog contains links to help pages. The dialog provides a WebContentsDelegate implementation for the contents it's hosting. This WebContentsDelegate should implement the AddNewContents method to allow opening the links. Bug: 1045515 Change-Id: Ib5a62296a085187a4f96d6d1be41ccbff839d52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218269 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#772674}
-
Michael Thiessen authored
The ordering of events is different for skipped tests and completed tests, so in order to support both skipped and completed tests reporting duration I had to modify the python result generation code. Now all tests report duration as a separate status after completion. Bug: 989569 Change-Id: I1a837bc2707a1517db6fdea91220aace7e1745d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218559Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#772673}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ffb43685b117..4fb71e30e397 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jdoerrie@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1073377 Tbr: jdoerrie@google.com Change-Id: Ie005e0df1869a7d54aec60dde66e87fa8adc1197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219911Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772672}
-
Jan Wilken Dörrie authored
TBR=alancutter Bug: 1087382 Change-Id: I4777fab9196321e993688947e604b53f3afe3d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218279Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#772671}
-
Jan Wilken Dörrie authored
TBR=mcnee Bug: 1087381 Change-Id: Ic9467c8425a05cb92270ec97e27447b7c44ec763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219894Reviewed-by:
-
Jan Wilken Dörrie authored
This reverts commit 5416e508. Reason for revert: Likely culprit of Cast Audio Linux breakage: https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/75925 Original change's description: > base/allocator: Respect malloc() alignment guarantees in PartitionAlloc. > > Generally speaking, malloc() must return data suitably aligned for > std::max_align_t. In practice this means 16 bytes on 64 bit > architectures, whereas PartitionAlloc only provides 8 there. This is > problematic to use it as a malloc() replacement. > > This CL makes PartitionAlloc respect the alignment guarantees on 64 bit > architectures. > > Bug: 787153,998048 > Change-Id: I860f9d0439d59f8d494306452b8cdbff515c8300 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219498 > Commit-Queue: Benoit L <lizeb@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Takashi Sakamoto <tasak@google.com> > Cr-Commit-Position: refs/heads/master@{#772662} TBR=tasak@google.com,haraken@chromium.org,lizeb@chromium.org Change-Id: Ic3266b40748d22cb25d91ab041db79da42851f4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787153, 998048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220085Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I946d8f382bcbbc9c71d90933c04d42c456984ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219179Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772668}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e00d27c6d65b..d0c9129d2f37 2020-05-28 shuizhuyuanluo@126.com fix warning unused parameter in release build (#2251) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: Ia0a4102934da4ffbc785363c97b9eda8e0821f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219912Reviewed-by:
-
Liviu Tinta authored
The tests in pointer_lock_browsertest.cc were flaky for 3 reasons: - requestPointerLock being asynchronous - mouse events being asynchronous - native mouse events interfering with tests during execution All the above were addressed in prior CLs. Bug: 766450 Change-Id: I30c9d3df7101be6ccd0686b051b83bfb0754300c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213103Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#772666}
-
Jan Wilken Dörrie authored
This reverts commit 91eda9e8. Reason for revert: testImageSearch is flaky: https://crbug.com/1087333 Original change's description: > Fix image search from search activity > > SearchActivity did not handle image search data since image search need > post data, so the fix is add the post data into intent to pass to chrome. > > Bug: 1078773 > Change-Id: I04efdad0bba315508e0b05d3d9e444d8c1a5d955 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187191 > Commit-Queue: Gang Wu <gangwu@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Ender <ender@google.com> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772335} TBR=tedchoc@chromium.org,gangwu@chromium.org,rsesek@chromium.org,ender@google.com Change-Id: I7bce956c3e6ed21fce50f97a45bfd3bbe700473d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1078773, 1087333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218074Reviewed-by:
-
Jan Wilken Dörrie authored
TBR=rch Bug: 1087378 Change-Id: I66e9fedd96223751fb369ca7e85d710b304226fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220045Reviewed-by:
-
Anna Malova authored
Bug: 1085115 Change-Id: I5bce43e5538b1f7395fb094585a281848c8884f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207157 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#772663}
-
Benoit Lize authored
Generally speaking, malloc() must return data suitably aligned for std::max_align_t. In practice this means 16 bytes on 64 bit architectures, whereas PartitionAlloc only provides 8 there. This is problematic to use it as a malloc() replacement. This CL makes PartitionAlloc respect the alignment guarantees on 64 bit architectures. Bug: 787153,998048 Change-Id: I860f9d0439d59f8d494306452b8cdbff515c8300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219498 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#772662}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590652675-697ba00b1820dcc0607ade49043105c169de1a33.profdata to chrome-mac-master-1590666951-97e5506c192bc4f156540656aa3946ef3f3bcc93.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5ea8136281a054ede4e45afdb6a807eb00975918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219916Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/38e348e2b71e..4d9848cbcdb3 2020-05-28 dberris@chromium.org auto-triage: Make cc= take a list in NewBug 2020-05-28 dberris@chromium.org pinpoint: Fix layout of pin field If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1079183,chromium:1087315 Tbr: rmhasan@google.com Change-Id: I2673be666534c4960134940b83a4f5aa05b920c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219910Reviewed-by:
-
Alice Wang authored
This CL tears down AccountManagerFacade properly in SigninTestUtil. This will help us to refactor the SigninTestUtil into a TestRule with AccountManagerTestRule in the future. Bug: 1004418 Change-Id: Ic0a0ed7355b43eb608890bc33879d95b50decbe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181215 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#772659}
-
Jan Wilken Dörrie authored
TBR=vitalybuka Bug: 1087372 Change-Id: Ie4fce45671e166417f679b91ca9229968196983c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220005Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/872a24d0d0f9..696a03e075a6 2020-05-28 tvanderlippe@chromium.org Revert "Move rollup configuration to front_end/rollup.config.js" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1084578 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I96fb343deeefbb686ad1aac7145148c117d75747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219746Reviewed-by:
-
Charlie Hu authored
Previously there was a param |Vector<String>* messages| since the very first version of HTMLFrameOwnerElement::ConstructContainerPolicy. However, except the implementation in HTMLIFrameElement, other implementations all ignore this param. This CL moves output of console messages from caller of ConstructContainerPolicy, i.e. HTMLFrameOwnerElement::UpdateContainerPolicy, to HTMLIFrameElement::ConstructContainerPolicy so that parameter |messages| can be removed. Change-Id: Ib2732474d881a13b8fe507af6ba63a526df3900d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209378 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#772656}
-
Rushan Suleymanov authored
This patch changes only Sync protocol. It extends device info specifics to support sync invalidations with an invalidations token. Bug: 1082117 Change-Id: I861bf0d959932b7270c626f7b3445cf5a40ac543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214887 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#772655}
-
Balazs Engedy authored
This CL introduces no behavior changes, it just moves from a model with: (UiToUse + QuietUiReason) to: Decision = (QuietUiReason + WarningReason), where either being base::nullopt indicates that the normal UI should be used, or no warning should be printed, respectively. Bug: 1087005, 1081233 Change-Id: I90563d2fc245f2f25a132566f394d74dd22c2f70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218309 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#772654}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/73cea9cfd9c1..a5b927e19e44 2020-05-28 simonmacm@google.com Merge "Improve time-in-state UI some more." 2020-05-28 primiano@google.com trace_processor: fix IWYU includes 2020-05-27 primiano@google.com docs: Use absolute links 2020-05-27 treehugger-gerrit@google.com Merge "sdk: Update documentation to point to v4.1" 2020-05-27 lalitm@google.com Merge "tp: add metatracing" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I745d8c05b1ddbd9fb8285b3c26409da2b25b0490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219908Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0ee4ee85ddf2..a4d70a802cf7 2020-05-28 danilchap@webrtc.org Configure libaom encoder with scalability parameters 2020-05-28 handellm@webrtc.org Deprecate SignalThread. 2020-05-27 terelius@webrtc.org Replace inconsistent log_segments() function in RTC event log parser If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie7ea42324bc52c1ce6b5e9e7dc2ee1ad39525dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219907Reviewed-by:
-
Yuichiro Hanada authored
The interface allows classes outside of ash/ to observe any bounds changes of ARC IME window. This CL should not cause any behavior change. Bug: 1060272 Change-Id: I3b5b0652c89fd87ffe93de4903dae11523b30dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217827 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#772651}
-
pasthana authored
It should have been removed as part of https://chromium-review.googlesource.com/c/chromium/src/+/2210175 Bug: 1075586 Change-Id: I3ca290d7f4e7e1e4893eda2f6951d058d6794435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214806 Commit-Queue: Prakhar Asthana <pasthana@google.com> Auto-Submit: Prakhar Asthana <pasthana@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#772650}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6065820c58da..5aefbb372568 2020-05-28 reed@google.com Revert "prealloc space for a simple fRunsInVisualOrder" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Idb309c9a3786a2125d336dd7da6bce8b9fe32bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219744Reviewed-by:
-
Jan Wilken Dörrie authored
This reverts commit 978f825e. Reason for revert: Breaks Linux MSAN due to use-of-uninitialized-value: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/24094 Original change's description: > [omnibox] [rich-autocompletion] Add multi-sel & comp-text to OmniboxView > > *Rich autocompletion background* > > Currently, autocompletion is limited to when the user types a prefix of > the URL. E.g. 'wiki' can autocomplete 'wiki.org/thecookinglist - top > awesome recipes'. > > Rich autocompletion will allow autocompletion even when the input is > from the suggestion title or middle of the URL. E.g. 'thecoo' and > 'recip' will also autocomplete 'wiki.org/thecookinglist - top awesome > recipes'. > > Design doc with further details: go/richomniboxautocompletion > > Previous CLs: > - crrev.com/c/2107796 added chrome://flags flags > - crrev.com/c/2108780 supported multiselection in textfield views. > - crrev.com/c/2199859 Add complementary omnibox view. > > *This CL* > > This is the 4th CL for rich autocompletion. It wires in the omnibox view > to textfield's multiselection & location bar's complementary text. > > This CL has no user facing changes. Followup CLs will wire in rich > autocompletion to make use of these changes. > > Bug: 1062446 > Change-Id: I919965049837fd5421fd2b8f0dabc6d3489dabf4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204545 > Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> > Auto-Submit: manuk hovanesian <manukh@chromium.org> > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772612} TBR=tommycli@chromium.org,stkhapugin@chromium.org,manukh@chromium.org Change-Id: I0ee50606f616c59fe7233ada53518c3d01b3c2a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1062446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219891Reviewed-by:
-
Anton Bikineev authored
The objects_ member was always empty. Change-Id: I0350beede6215a61fd13089dcd80ffdd9d369e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218844Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#772647}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/641fcb8099d4..ffb43685b117 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jdoerrie@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jdoerrie@google.com Change-Id: I64909a90db57449593ed4bff7dc943461a4d272f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219732Reviewed-by:
-
Sara Kato authored
Bug: b/156999629 Test: tast run DUT_IP arc.AccessibilitySpeech.vm passes (approx 4/5 times) Change-Id: Id0d8116ed8ad95f9294e8d17f26fd167b62da852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217915Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#772645}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5762221cb271..38e348e2b71e 2020-05-28 dberris@chromium.org auto-bisect: Support priority in new job request If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1087315 Tbr: rmhasan@google.com Change-Id: I115d745946b2906eec073151ee9c77368095d233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219742Reviewed-by:
-
Alex Ilin authored
This CL adds Gaia reauth as a second step after the chrome://signin-reauth dialog. A new SigninReauthViewController class is created to manage the whole reauth flow. This class is responsible for: - opening and closing dialogs - loading the Gaia reauth in background, while the confirmation dialog is shown - presenting the Gaia reauth after the user clicks Next in the confirmation dialog either in the same dialog or in a new tab - calling the reauth callback after the flow is completed Bug: 1045515 Change-Id: I7504c860af600cd0dba37616af09c894ded82d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210464 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Mark Brand authored
This is a reland of 769719f1 Original change's description: > Adding mojolpm fuzzer generators. > > This adds code that generates libprotobuf-mutator based > structure-aware fuzzers as part of the mojom compilation process. > (changes in //mojo). > > This is a cherrypick/split from > https://chromium-review.googlesource.com/c/chromium/src/+/2108507 > > Pragmatic fixes for the remaining missing dependencies. > > Change-Id: I0e0d34a4b99b31f99ee872fb95be993043aef402 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170830 > Commit-Queue: Mark Brand <markbrand@google.com> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#771513} Change-Id: Ie477695c59001f51fb25e25b3c98291cb5cf0013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214883Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Mark Brand <markbrand@google.com> Cr-Commit-Position: refs/heads/master@{#772642}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I7e9b62abf2838bfff6bf11b4944253baa9d1cd00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219729Reviewed-by:
-
Jan Wilken Dörrie authored
TBR=bsheedy Bug: 1087097 Change-Id: I382a3c1e7bf93f7145f7fd4b2b68a6b43da85a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218841Reviewed-by:
-
Wez authored
This reverts commit 3c6e8cf6. Reason for revert: SDK roll appears to remove the "archive_manifest" output files, on which Chromium's runner scripts depend. See https://crbug.com/1087301 Original change's description: > Roll Fuchsia SDK from 0.20200520.3.1 to 0.20200527.2.1 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll > Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast > Tbr: cr-fuchsia+bot@chromium.org > Change-Id: If0eb3cf6c9a7c659b00269b77edf93116aa29990 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219230 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#772478} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,cr-fuchsia+bot@chromium.org Change-Id: Iffb91f585dcd589e6539f349c8296f3f8eb84b73 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218845Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#772639}
-
