GitLab

Because of a missing 's' the generated client API was always considered out of
date.

BUG=669077

Review-Url: https://codereview.chromium.org/2531363002
Cr-Commit-Position: refs/heads/master@{#434699}

Add a watch list definition for Generic Sensor API [1] implementation updates.

[1] ED specification: https://w3c.github.io/sensors/

NOTRY=True

Review-Url: https://codereview.chromium.org/2526253002
Cr-Commit-Position: refs/heads/master@{#434698}

BUG=542537

Review-Url: https://codereview.chromium.org/2536513002
Cr-Commit-Position: refs/heads/master@{#434697}

Chrome currently leaves the alert around which causes subsequent commands to fail.

https://buganizer.corp.google.com/u/0/issues/6507465#comment12
BUG=chromedriver:877

Review-Url: https://codereview.chromium.org/1827003004
Cr-Commit-Position: refs/heads/master@{#434696}

BUG=

Review-Url: https://codereview.chromium.org/2530373003
Cr-Commit-Position: refs/heads/master@{#434695}

The code is unused, will likely not come back in the same form, and
forces needless verbosity in forthcoming CLs.

BUG=631966

Review-Url: https://codereview.chromium.org/2532933002
Cr-Commit-Position: refs/heads/master@{#434694}

Chrome on iOS uses the deprecated User Action "MobileContextMenu..." as part of
the upstreaming, it should use the new histogram "ContextMenuOption".
This CL adds the histograms needed by Chrome on iOS.

BUG=669028

Review-Url: https://codereview.chromium.org/2537453002
Cr-Commit-Position: refs/heads/master@{#434693}

Create a ChromeTestExtensionLoader to load extensions during tests.
This class is designed to be used across browser tests and unit tests,
making it a (mostly) solution to needing to re-code the same
implementation in various different test classes, as well as an
alternative to the double-inheritance we sometimes see in order to get
extension-loading helper methods in addition to some other test
infrastructure.

The main class includes options to modify the behavior according to most
common flags set by existing (unit|browser) tests, such as error
handling, packing, creation flags, permissions, etc.

Additionally, hook the class up to the existing ExtensionBrowserTest
(browser test) and ExtensionServiceTestWithInstall (unit test) as a
proof of concept that it works in both unit and browser tests. Going
forward, we should continue to a) expand the test loader and b) replace
current duplicative code.

BUG=667587

Review-Url: https://codereview.chromium.org/2524553002
Cr-Commit-Position: refs/heads/master@{#434692}

Getting the underlying WebsiteSetting to find whether reading/setting
cookies is allowed is fairly expensive. The current cookie API requires
retrieving these settings twice if we want to know both values.

This patch updates the API to allow for querying reading and setting
policies with one call to GetWebsiteSettings. This is used in
net::NetworkDelegate::CanEnablePrivacyMode, which went from taking 18%
of the CPU time in net::URLRequestHttpJob::Start, to 12% after this
patch (Linux perf results).

BUG=664174

Review-Url: https://codereview.chromium.org/2502743003
Cr-Commit-Position: refs/heads/master@{#434691}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e9b2ab39..bced9de7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2532983003
Cr-Commit-Position: refs/heads/master@{#434690}

The SHUTDOWN_TIMEBOMB_ARM execution phase was not set on the quick exit path
(SessionEnding).

BUG=668542

Review-Url: https://codereview.chromium.org/2527373003
Cr-Commit-Position: refs/heads/master@{#434689}

ExtensionHostMsg_Request_Params includes a "source_tab_id", but this
shouldn't be necessary. The browser can determine the tab id from which
RFH sent the request. Remove the property.

BUG=667584

Review-Url: https://codereview.chromium.org/2522763005
Cr-Commit-Position: refs/heads/master@{#434688}

* Since all tests use a TokenBindingSSLConfigService, create one in
  SetUp(), instead of creating a TLS10SSLConfigService that is destroyed
  at the beginning of each test.
* Remove unused classes TLS1?SSLConfigService.
* Remove unused GetServerSSLConfig().
* In HttpNetworkTransaction, defriend HttpNetworkTransactionSSLTest and
  test cases that do not access private member.
* git cl format.

Review-Url: https://codereview.chromium.org/2532153002
Cr-Commit-Position: refs/heads/master@{#434687}

BUG=

Review-Url: https://codereview.chromium.org/2526993002
Cr-Commit-Position: refs/heads/master@{#434686}

Layout test expected results are changed for the following reasons:

- Some exception messages are formatted slightly differently
  (e.g. to convey the type of the object which failed to be cloned).

- blink::ScriptValueSerializer emitted frequent "object count validation"
  tags (the most frequently seen is 3f00) which are not required by
  either deserializer, but the new one does not.

- Excessive depth throws a RangeError, like JSON.stringify and other
  functions that internally reach excessive depth (this is consistent
  with Safari, and similar to how Edge also throws the same exception as
  for an ordinary stack overflow in script).

- Certain large numbers are encoded differently; specifically, V8 now
  chooses between signed-int and double representations depending on
  whether the value has a small-integer (SMI) encoding in memory (this
  value range varies by CPU architecture). The old implementation tried
  to fit in a signed-int, then tried to fit in an unsigned-int, and only
  used double representation if that failed. Both implementations can
  read all representations, so this is a compatible change. Tests that
  are sensitive to variation by CPU architecture are commented out; there
  are unit tests that ensure that this serialization works correctly.

BUG=148757

Review-Url: https://codereview.chromium.org/2517813002
Cr-Commit-Position: refs/heads/master@{#434685}

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaGFQ/edit#

This CL drops encoded_body_length field from ResourceMsg_DataReceived and
ResourceMsg_InlinedDataChunkReceived. This CL doesn't change the behavior.

BUG=666216

Review-Url: https://codereview.chromium.org/2506363005
Cr-Commit-Position: refs/heads/master@{#434684}

To enable OOPIF and Top Document Isolation for Android, we need to track
the text input state from multiple RenderWidgetHosts. To this end, the
TextInputStateChanged updates should be routed through TextInputManager
which keeps a map of all RenderWidgetHost(View) and their corresponding
TextInputState.

This CL will also enable some site-per-process tests on android.

BUG=578168,602723

Review-Url: https://codereview.chromium.org/2354793003
Cr-Commit-Position: refs/heads/master@{#434683}

We defined a set of sub-metrics to measure the latencies inside
Event.Latency.TouchToScrollUpdateSwapBegin to help us better understand
the time spent on each stage during scroll. Now we will add the same set
of sub-metrics to Event.Latency.TouchToFirstScrollUpdateSwapBegin.

The details are in this doc:
https://docs.google.com/document/d/1EPKT652e2PcO1ysA7LQosGyyr1xmxbtiiiivNU3lnpQ/edit#heading=h.r6af7ldx7kcw.

BUG=616482

Review-Url: https://codereview.chromium.org/2268163002
Cr-Commit-Position: refs/heads/master@{#434682}

MusGpuMemoryBufferManager needs to be used by both the window server (to
service gpu memory requests from clients), and the gpu process (for the
display compositor). So move it into a service_common that various server
components can use.

BUG=none

Review-Url: https://codereview.chromium.org/2534663002
Cr-Commit-Position: refs/heads/master@{#434681}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/76180b6b4e6d..6d2cfc95eb2f

$ git log 76180b6b4..6d2cfc95e --date=short --no-merges --format='%ad %ae %s'
2016-11-28 sullivan Update toplevel projects: remove perf_insights and add systrace
2016-11-28 hjd [dashboard] Fix use of () => {}

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2528353003
Cr-Commit-Position: refs/heads/master@{#434680}

Changes in overflow content size and clip should trigger a re-clamping of
the scroll offset even if the change is not layout inducing (e.g., transform)

BUG=652092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2524333003
Cr-Commit-Position: refs/heads/master@{#434679}

This CL reworks the current implementation of the "rules for parsing
dimension values" [1] (HTMLElement::addHTMLLengthToStyle) into a
separate function and moves it to HTMLDimension.{cpp,h}.
In general, behavior deviating from the specced version is kept with the
following exceptions:

 * Allow all of the "space characters" [2], rather than just U+0020.

 * Cases with multiple full stops (ex: "1.2.3") now parse the same as
   "1.2" rather than failing.

Comments are added where the implementation is known to deviate from the
spec.

This also makes it possible to avoid calling into the CSS parser for
actual parsing, which should reduce the amount of special-cases needed
there. This requires a mechanism for disallowing percentage values
though, to properly handle 'cellspacing' on <table>.

[1] https://html.spec.whatwg.org/multipage/infrastructure.html#rules-for-parsing-dimension-values
[2] https://html.spec.whatwg.org/multipage/infrastructure.html#space-character

BUG=668478

Review-Url: https://codereview.chromium.org/2528673003
Cr-Commit-Position: refs/heads/master@{#434678}

https://chromium.googlesource.com/angle/angle.git/+log/133a2ec..f1a2aef

BUG=chromium:660670,chromium:661857

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2536733002
Cr-Commit-Position: refs/heads/master@{#434677}

There are a couple timing issues in the previous
implementation of the code that enables/disables the print
activity that is accessible via share.

1.) Multiple calls to enablePrintShareOption could result
    in the second call having the callback run immediately
    without the component first being enabled (since it
    would have been triggered in an AsyncTask in the first
    call).
2.) Back to back enable/disable calls could result in
    unpredictable execution ordering as they run their
    tasks on the thread pool instead of in serial.  Because
    the initial UI is only shown after the first callback is
    run, this would require a show, followed by a hide, followed
    by a show where the task enqueued by the hide is run after
    the enabling call in the second show.

To work around this (and due to the expected usage pattern of
this class), just wait for the task to be run in either of these
states to avoid this being possible.  It would also be possible
to use the SERIAL executor, but that might end up slowing down
the default share flow where we don't expect this interleaving
issue.

BUG=649453,664486

Review-Url: https://codereview.chromium.org/2523873003
Cr-Commit-Position: refs/heads/master@{#434676}

This CL moves image_capture.mojom from media/mojo/interfaces/ to
media/capture/mojo/ where it belongs logically speaking, and
updates BUILD.gns and include paths.

image_capture.mojom was in media/mojo/interfaces because
when it landed, media/capture/mojo was not existing.

BUG=518807
TEST=No code touched, if compile passes, it works
(but there's also content_browsertests).

TBR=xhwang@chromium.org for the removal in media/mojo/interfaces/BUILD.gn

Review-Url: https://codereview.chromium.org/2526953002
Cr-Commit-Position: refs/heads/master@{#434675}

BUG=chromium:668848

Review-Url: https://codereview.chromium.org/2539433002
Cr-Commit-Position: refs/heads/master@{#434674}

By being public, it was too easy for an external class to
broadcast all sort of tab notifications.  By being protected,
it is restricted to the dependent classes within the tab package.

BUG=

Review-Url: https://codereview.chromium.org/2515313005
Cr-Commit-Position: refs/heads/master@{#434673}

Note that now our re-entry performance is worse than before, because we weren't recreating our WebContents before. We should look into either caching, pre-loading, or otherwise, to improve startup time.

BUG=669065

Review-Url: https://codereview.chromium.org/2535853002
Cr-Commit-Position: refs/heads/master@{#434672}

Committing selection can sometimes be slow; see the attached bug for an
example.

BUG=668122

Review-Url: https://codereview.chromium.org/2536733003
Cr-Commit-Position: refs/heads/master@{#434671}

This was a flag for testing purposes and
was added as part of crbug.com/640700. This
CL removes that flag which is no longer needed.

BUG=642776

TBR=avi@chromium.org

Review-Url: https://codereview.chromium.org/2525973002
Cr-Commit-Position: refs/heads/master@{#434670}

Functional:

* Send RST_STREAM if HEADERS do not contain ":status" on pushed stream.
* Log HTTP2_STREAM_ERROR if response is received before request is sent.
* Log HTTP2_STREAM_ERROR if trailers are received on a pushed stream.
* Log HTTP2_STREAM_ERROR if trailers are received after trailers.
* Log HTTP2_STREAM_ERROR if data are received after trailers.

Refactoring:

* Add plenty of unittests.
* Move all header block checks from SpdySession and from SpdyStream::Delegate to
  SpdyStream.
* Change SpdyStream::Delegate::OnResponseHeadersUpdated type to void.
* Make enum SpdyResponseHeaderStatus private to SpdyStream, rename entries.
* Rename SpdyStream::Delegate::OnResponseHeadersUpdated() to
  OnHeadersReceived(), since update is not allowed.
* Change SpdyHttpStream::response_headers_status_ type to bool, rename.
* Remove tests that rely on the net stack incorrectly accepting invalid
  responses.
* Remove SpdySession::ActiveStreamInfo::waiting_for_reply_headers_frame,
  inline now trivial SpdySession::ActiveStreamInfo struct.
* Rename SpdyStream::Delegate::OnRequestHeadersSent() to OnHeadersSent() to
  match OnData{Received,Sent} methods.
* Make TryCreatePushStream() void as return value was dropped on the floor
  anyway.
* Combine SpdyStream::OnInitialResponseHeadersReceived() and
  OnAdditionalResponseHeadersReceived() into a single OnHeadersReceived()
  method.
* Rename SpdyStream::MergeWithResponseHeaders() to SaveResponseHeaders() as no
  merging is done any more.

BUG=666383

Review-Url: https://codereview.chromium.org/2526003002
Cr-Commit-Position: refs/heads/master@{#434669}

Fix the bug which is login dialog won't close after the second sign-in to chrome with different account on the same profile.

This is the follow up of CLs:
1) https://chromium.googlesource.com/chromium/src/+/ff9fc46a4fdfb7c2975c867d8459e3cebe2e32fb
and
2) https://chromium.googlesource.com/chromium/src/+/5db87096a32b73bd2aaca04710152de495ba50ea

The javascript message that close sign in dialog will be sent regardless before. However, after the refactor in the second CL above, it's only sent once the profile_path is not empty. It didn't cause any issue because the JS message will be sent again in the OnClientOAuthSuccess()

However, the OnClientOAuthSuccess' JS message will only be sent while force sign in is enabled after the first CL landed which is used to solve crbug.com/667227. It means that if the profile_path is empty (second sign in with different account in the same profile), the sign in dialog will never be closed.

Moving the profile_path empty check into UnlockProfileAndHideLoginUI() so that the javascript message will be sent no matter the profile_path is empty or not.

BUG=668619

Review-Url: https://codereview.chromium.org/2528183002
Cr-Commit-Position: refs/heads/master@{#434668}

This is part of an experimental feature Embedding-CSP.

This patch introduces CSPDirectiveList subsumption.
We aggregate SourceListDirectives based on their directive
names (or default directives otherwise) to check if it subsumes
under the embedding csp.

Note: There is only one SourceListDirective for each directive
name type specified by Embedding CSP since it specifies only one
policy.
+ We only consider scheme source /host source expressions to this
point.

Separate patches will be devoted to consideration of
'unsafe-inline' etc.

BUG=647588

Review-Url: https://codereview.chromium.org/2474903002
Cr-Commit-Position: refs/heads/master@{#434667}

We aren't seeing any more crashes due to duplicate field trials, so
we can remove this debug code.

BUG=665129

Review-Url: https://codereview.chromium.org/2536723002
Cr-Commit-Position: refs/heads/master@{#434666}

Issue 618178 describes an example where a Burmese text run starts with a
leading punctuation character followed by a combining spacing mark. This
grapheme cannot be shaped with the default font, since Times for example
cannot display the combination of a left quote with a Burmese combining
mark. Our fallback code attempts to find a fallback font based on the
first character at the beginning of an extracted unshaped sub-run, which
does not lead to finding a font suitable for Myanmar text in this case.
So in a way it runs into a fallback trap, where no fallback hint helps
to find the right fallback font and the whole run ends up as notdef
glyphs.

This CL attempts to resolve this by looking for a better fallback hint
character, which is not script common or inherited, if such is
available. This improves the situation for the Burmese text from the
issue report.

In addition, as a better fix we should give higher importance to the
locale information in font fallback, filed as issue 668706.

BUG=618178
R=eae,kojii,behdad

Review-Url: https://codereview.chromium.org/2530153002
Cr-Commit-Position: refs/heads/master@{#434665}

There has not been a request to implement and ship this feature, so it
should be marked as experimental until such request has been sent out
and consequently approved.

BUG=648240

Review-Url: https://codereview.chromium.org/2530713002
Cr-Commit-Position: refs/heads/master@{#434664}

https://skia.googlesource.com/skia.git/+log/d1bd30515aaa..d5de01364378

$ git log d1bd30515..d5de01364 --date=short --no-merges --format='%ad %ae %s'
2016-11-28 mtklein Some simple pipeline refactoring.
2016-11-28 brianosman GrTextureProducer cleanup, phase one: Bitmap and Image makers
2016-11-28 reed don't rely on canvas being reference counted

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@google.com

Review-Url: https://codereview.chromium.org/2533823002
Cr-Commit-Position: refs/heads/master@{#434663}

ICU reports its memory allocation failure through UErrorCode, while
Blink would like to crash the renderer using OOM_CRASH()[1].

ICUError provides the unified way to handle ICU errors in Blink.

In this CL, all failures lead to the render crash, just differently by
the error type. We may add lighter methods, such as to crash only if
critical, or to ignore certain types, if needed in future.

[1] https://groups.google.com/a/chromium.org/d/msg/platform-architecture-dev/MP0k9WGnCjA/zIBiJtilBwAJ

Review-Url: https://codereview.chromium.org/2527183002
Cr-Commit-Position: refs/heads/master@{#434662}

Make DeviceActiveDirectoryPolicyStatusProvider observe CloudPolicyStore.

BUG=668652

Review-Url: https://codereview.chromium.org/2531793002
Cr-Commit-Position: refs/heads/master@{#434661}

Currently, we only report UMA statistics on receiving a pressure
change event from the system. This means that we could be missing
many ticks of "normal" pressure from sessions that never encounter
pressure, skewing our stats. Other platforms don't have this issue
since they poll.

This change piggybacks statistic reporting on GetCurrentPressureLevel()
which is called regularly by RendererFrameManager::GetMaxNumberOfSavedFrames()
This also allows us to enable reporting for Sierra.

To make this work, GetCurrentPressureLevel is now declared non-const.
There don't appear to be any const MemoryPressureMonitors in the codebase
at the moment, so this should be safe.

BUG=655304

Review-Url: https://codereview.chromium.org/2495003004
Cr-Commit-Position: refs/heads/master@{#434660}