GitLab

Current string: Signed in as [email]. Manage your synced data and devices on Google Dashboard.
New strings: Signed in as [email]. Manage your synced data and devices on chrome.com/sync

BUG=402615

Manual test:
launch chrome by chrome --force-fieldtrials="ChromeDashboard/Enabled/"
log in chrome, and then go to settings, on the top of settings, there should be the new string, click the "chrome.com/sync", it should bring you to new URL(chrome.com/sync).

Review URL: https://codereview.chromium.org/959343003

Cr-Commit-Position: refs/heads/master@{#319550}

All tab capture platforms have supported capture via event-driven
compositor updates for quite a while now.  The "notification of backing
store change" code path never triggers, except in certain edge cases
where extra frame captures will be started.  The extra frame captures
are bad for the user experience, since the extra frames reduce video
playback smoothness.  The extra frame captures were also throwing-off
the "out-of-order frame delivery" logic, causing wanted frames to be
dropped.

BUG=464475

Review URL: https://codereview.chromium.org/989683004

Cr-Commit-Position: refs/heads/master@{#319549}

And all the unused files under chrome/test/perf/.

BUG=None
TEST=everything still works + trybots
R=sky@chromium.org

Review URL: https://codereview.chromium.org/938603004

Cr-Commit-Position: refs/heads/master@{#319548}

1. Changes desktop tab load time from 100ms to 1500ms.
2. Doesn't preload tabs if network is down.

In my manual testing, the ChromeOS 1500ms timeout does not feel slow.
It actually feels "just right".

BUG=463567

Review URL: https://codereview.chromium.org/983223002

Cr-Commit-Position: refs/heads/master@{#319547}

The ScrollbarFadePinchZoomScrollbars test wasn't really testing any
pinch zoom functionality so it has been removed. There were no tests
for thinning scrollbar animations so those have been added.

Review URL: https://codereview.chromium.org/955233002

Cr-Commit-Position: refs/heads/master@{#319546}

BUG=454983

Review URL: https://codereview.chromium.org/990433003

Cr-Commit-Position: refs/heads/master@{#319545}

BUG=

Review URL: https://codereview.chromium.org/981343002

Cr-Commit-Position: refs/heads/master@{#319544}

A namespace foo should end with a comment "// namespace foo", this
corrects errors in base/.

BUG=464816

Review URL: https://codereview.chromium.org/981803003

Cr-Commit-Position: refs/heads/master@{#319543}

Don't allow empty labels in DNS names (".example.domain.com" or
"google..com").

BUG=456391

Review URL: https://codereview.chromium.org/919023003

Cr-Commit-Position: refs/heads/master@{#319542}

BUG=435632,464859

Review URL: https://codereview.chromium.org/982413003

Cr-Commit-Position: refs/heads/master@{#319541}

BUG=464850
TBR=groby@chromium.org

Review URL: https://codereview.chromium.org/986653003

Cr-Commit-Position: refs/heads/master@{#319540}

Before this patch, we had code to avoid showing duplicates, but it would not prevent showing subsets. For example, if you had profiles:

- Daisy Green, 123 Main, Littleton, CO
- Daisy Green, 123 Main, Littleton, CO, 80161

It would suggest both.

BUG=463305

Review URL: https://codereview.chromium.org/970403002

Cr-Commit-Position: refs/heads/master@{#319539}

Fully qualify std::make_pair, also format to converge to server code.

This CL lands server change 86268546 by sbenza.

BUG=

Review URL: https://codereview.chromium.org/986713002

Cr-Commit-Position: refs/heads/master@{#319538}

[Reland of https://codereview.chromium.org/940693004]

Previously they were more like integration tests that relied on
seccomp-bpf for installing the policies and executing them via live
system calls.

BUG=449357

Review URL: https://codereview.chromium.org/987603003

Cr-Commit-Position: refs/heads/master@{#319537}

Currently, any invocation of getToken() may result in consent UI being shown, which makes it hard to predict what UI changes may result when a token is requested. This CL simplifies the flow:

* Pre-authorize the app before calling the start() method.
* Only that first authorization will result in any in-app UI being shown.
* Subsequent calls to getToken() may cause the chrome.identity consent UI to be shown, but this should only happen in exceptional circumstances and since no DOM changes are involved, it's a more predictable flow.

Review URL: https://codereview.chromium.org/981723003

Cr-Commit-Position: refs/heads/master@{#319536}

These entries are not more necessary now that the componentization work
has been completed.

BUG=144783,383597
R=sky@chromium.org

Review URL: https://codereview.chromium.org/983183004

Cr-Commit-Position: refs/heads/master@{#319535}

This flag enables Clang's new control flow integrity mechanism for virtual table
calls, which is documented at:

http://clang.llvm.org/docs/ControlFlowIntegrity.html

BUG=464797
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/985713005

Cr-Commit-Position: refs/heads/master@{#319534}

For mac_views_browser we currently compile as if for Cocoa+toolkit_views then
remove both views files that are not ready, and cocoa files that conflict with
things already ported.

More of views compiles on Mac now than doesn't (but isn't ready to go into a
release build). This change moves those ready files back to non_mac_sources
for now. There are too many doubly defined functions that we risk linking
a Views one into the shipping Cocoa binary.

Then, for mac_views_browser, we add all the "non_mac" views files and just
remove the cocoa files that would conflict.

BUG=425229

Review URL: https://codereview.chromium.org/987483003

Cr-Commit-Position: refs/heads/master@{#319533}

WidgetTest.WidgetDeleted_InOnMousePressed was failing because
the test widget is initialized with a 0x0+0+0 bounds, which is then
resized with SetSize(). Since it's also a popup type, widget.cc does
not call either of SetInitialBounds{,ForFramelessWindow}. This resulted in
a window that was offscreen, so mouse events were not sent to it.

To fix, widgets with no initial bounds are put at the top left of the screen
rather than the bottom-left.

The test was also flaky because the event generator was not retaining
the NSWindow. The tests are specifically to cover the widget being destroyed.
Cocoa retains the window during event dispatch, so the event simulator
should as well.

BUG=378134

Review URL: https://codereview.chromium.org/987733002

Cr-Commit-Position: refs/heads/master@{#319532}

This hooks up unmasked server credit cards to the Chrome clear private data feature. When all data is cleared, all cards will be re-masked.

For time ranges, only cards unmasked in that time range will be re-masked. The use-case for re-masking cards unmasked in the past hour is very weak, but we just don't want to re-mask cards that you unmasked a long time ago, and this is how everything else works.

This adds a "phone number" column to the server address table. This will be hooked up in a future patch. Doing it here saves another database version bump.

Review URL: https://codereview.chromium.org/967453005

Cr-Commit-Position: refs/heads/master@{#319531}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a9baa65..9ce30e1

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/985793003

Cr-Commit-Position: refs/heads/master@{#319530}

This adds xdisplaycheck as a dependency of cc_unittests_run for gyp isolate
builds. xdisplaycheck is used by the isolate script to run cc_unittests so it
must be built when cc_unittests is built.

BUG=464062

Review URL: https://codereview.chromium.org/981683002

Cr-Commit-Position: refs/heads/master@{#319529}

Using aura::WindowTracker won't compile with MacViews. Replace it
with the cross-platform NativeWindowTracker.

BUG=425229

Review URL: https://codereview.chromium.org/965103005

Cr-Commit-Position: refs/heads/master@{#319528}

BUG=369661
TEST=no code changes; this adds new tests

Review URL: https://codereview.chromium.org/984063003

Cr-Commit-Position: refs/heads/master@{#319527}

Revert of Raster into an SkP before rendering a DisplayList. (patchset #2 id:20001 of https://codereview.chromium.org/966443003/revert)

Reason for revert:
This broke some layout tests, in particular the ones referred to in crbug.com/460198.

Original issue's description:
> Raster into an SkPicture before rendering a DisplayList.
>
> Rasterizing a display list is more than 2x slower than rasterizing in the existing architecture. This is due to recording more with a display list and we have no bounding hierarchy to cull content quickly.
>
> We can address this by creating an SkPicture from the list, with a bounding hierarchy, and rasterizing that instead. The result is slightly faster than the non-S.P. pipeline but uses 2x more memory.
>
> BUG=464738
>
> Committed: https://crrev.com/de765f47e9449420e46d968ec40bb6f41a193990
> Cr-Commit-Position: refs/heads/master@{#319519}

TBR=ajuma@chromium.org,enne@chromium.org,schenney@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464738

Review URL: https://codereview.chromium.org/980793007

Cr-Commit-Position: refs/heads/master@{#319526}

BUG=460512

Review URL: https://codereview.chromium.org/985763004

Cr-Commit-Position: refs/heads/master@{#319525}

Some answers in suggest results have an associated icon, for example the weather may show a sunny or cloudy-skies image.

This change will download the associated icon and display it in the answer suggested.

BUG=456339

Review URL: https://codereview.chromium.org/917333004

Cr-Commit-Position: refs/heads/master@{#319524}

The progress bar changes much more often than the contents of the toolbar, so
splitting the two will allow for cheaper updates to the toolbar texture.

BUG=461148

Review URL: https://codereview.chromium.org/986683002

Cr-Commit-Position: refs/heads/master@{#319523}

If consumer calls GetHttpStatusCode/GetHttpStatusText after
the request adapter has been destroyed, we will be in
trouble. The new APIs don't have this problem. This CL adds
null checks on the Java side to make sure we won't call into
the native adapter when it is destroyed.

BUG=460161

Review URL: https://codereview.chromium.org/945843003

Cr-Commit-Position: refs/heads/master@{#319522}

PageTest and user_story_runner.Run do not need to touch this method
because it only has to do with a profile creator case.

BUG=440101

Review URL: https://codereview.chromium.org/980073005

Cr-Commit-Position: refs/heads/master@{#319521}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1c354fc..5bd3ef0

TBR=tasak@chromium.org,jbroman@chromium.org

Review URL: https://codereview.chromium.org/984073004

Cr-Commit-Position: refs/heads/master@{#319520}

Rasterizing a display list is more than 2x slower than rasterizing in the existing architecture. This is due to recording more with a display list and we have no bounding hierarchy to cull content quickly.

We can address this by creating an SkPicture from the list, with a bounding hierarchy, and rasterizing that instead. The result is slightly faster than the non-S.P. pipeline but uses 2x more memory.

BUG=464738

Review URL: https://codereview.chromium.org/966443003

Cr-Commit-Position: refs/heads/master@{#319519}

This is a mechanical change to replace single- and multi-line:
  @type {type} @private
with single-line:
  @private {type}

No functional changes in this cl - just updating the jscompiler annotations to make the code easier to read.

BUG=

Review URL: https://codereview.chromium.org/983023002

Cr-Commit-Position: refs/heads/master@{#319518}

This will be used in Chrome to limit new callers and force root owners reviews for new uses of exec_script.

This deletes the CommonSetup and DependentSetup class. Only the Setup class is used now. This was added to support generating .gyp files where there were many similar builds, but this functionality hasn't been used for ~1 year.

Review URL: https://codereview.chromium.org/988563002

Cr-Commit-Position: refs/heads/master@{#319517}

BUG=464803

TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/988853002

Cr-Commit-Position: refs/heads/master@{#319516}

Revert of Reset the root layer on the compositor when recreating a root layer. (patchset #3 id:40001 of https://codereview.chromium.org/983933002/)

Reason for revert:
Unit test forgot to callTerminateContextFactoryForTests() and leaks memory.

Original issue's description:
> Reset the root layer on the compositor when recreating a root layer.
>
> This is going to be used by https://codereview.chromium.org/975943002/
>
> TEST=LayerOwnerTest.RecreateRootLayerWithNullCompositor
> TEST=LayerOwnerTest.RecreateRootLayerWithCompositor
>
> BUG=337596
>
> Committed: https://crrev.com/26d2ed6065c28b46c56a1266a6c7e28c9db55d45
> Cr-Commit-Position: refs/heads/master@{#319487}

TBR=sadrul@chromium.org,danakj@chromium.org,bruthig@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=337596

Review URL: https://codereview.chromium.org/984103003

Cr-Commit-Position: refs/heads/master@{#319515}

BUG=450268

Review URL: https://codereview.chromium.org/975903002

Cr-Commit-Position: refs/heads/master@{#319514}

Review URL: https://codereview.chromium.org/987473002

Cr-Commit-Position: refs/heads/master@{#319513}

BUG=

Review URL: https://codereview.chromium.org/985533002

Cr-Commit-Position: refs/heads/master@{#319512}

BUG=455262
TEST=Fixed unittest and manually tested various scenarios.

Review URL: https://codereview.chromium.org/979273003

Cr-Commit-Position: refs/heads/master@{#319511}