- 18 Oct, 2017 21 commits
-
-
Benjamin Pastene authored
Bug: 761806 Change-Id: I92f67e2ae97847d7484c53ba461d9f7f1a5b401a Reviewed-on: https://chromium-review.googlesource.com/710231 Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#509630}
-
Matt Wolenetz authored
Adds a LIMITED_MEDIA_LOG(INFO) entry that logs effective changes to WMPI's |playback_rate_|, capped at 10 logs per WMPI instance. These changes may come from users, web apps, or from algorithms in HTMLMediaElement. BUG=771002 Change-Id: Ic7bb5073f6980ebbcd41ad84a1fff693872443ae Reviewed-on: https://chromium-review.googlesource.com/723777 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#509629}
-
David Tseng authored
Bug: 775320 Test: manual. Change-Id: I763adcb2ff287cb4594984eec3d494ff93fb8f10 Reviewed-on: https://chromium-review.googlesource.com/723787Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#509628}
-
Justin TerAvest authored
This library shouldn't be needed, and after some build changes on the Chrome OS side, is no longer present. BUG=b:67860772 TEST=deploy_chrome, confirmed browser works fine. Change-Id: Id0be85f5f36da6435dcc605a2b73a7c5ac095e16 Reviewed-on: https://chromium-review.googlesource.com/722109Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Justin TerAvest <teravest@chromium.org> Cr-Commit-Position: refs/heads/master@{#509627}
-
Scott Graham authored
Referenced in some configs that we weren't trying to build before. Bug: 706592 Change-Id: Ieae810b39ef6c99a2aedbda8db12763e81ff692a Reviewed-on: https://chromium-review.googlesource.com/724422Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#509626}
-
Toni Barzic authored
The state is not used anymore. BUG=765039 Change-Id: I155134799c87614e4e8d8429b96aeef1f8bdf63a Reviewed-on: https://chromium-review.googlesource.com/693555Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#509625}
-
Artur Khachatryan authored
This test fails occasionally in test automation run for Android build. Bug: chromedriver:2081 Change-Id: I2a77764bd6d34e3c7bb0858a97c12916835648ce Reviewed-on: https://chromium-review.googlesource.com/724278Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#509624}
-
Henrik Boström authored
This makes the origin secure so that getUserMedia() doesn't fail. Updated expected file too. Bug: 771540 Change-Id: I2717e195d6fb52cd2dedf45dd5c48b05b1058823 Reviewed-on: https://chromium-review.googlesource.com/716719 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#509623}
-
Stefan Zager authored
R=qyearsley@chromium.org Bug: 658880 Change-Id: Ifd2ea784a589fba1e34cf2289eba488a25528ebd Reviewed-on: https://chromium-review.googlesource.com/724172 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#509622}
-
Nate Chapin authored
Bug: 774774 Test: http/tests/media/captureStream-on-detached-video.html Change-Id: I207edfd93d617862c270de8b9b14c06232e28271 Reviewed-on: https://chromium-review.googlesource.com/722063Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#509621}
-
Nathan Bruer authored
Adds new interfaces to manage bindings from outside persistence mappers. * Adds ignoreProject/removeIgnoredProject - This is used to ignore a project and automapping will not auto-map anything in these projects. * Added addBinding/removeBinding - These are used to manually bind two UISourceCodes together. R=lushnikov,pfeldman BUG=760316 Change-Id: Id86a368a1b5ec50c34ed38deee8714b190fb6869 Reviewed-on: https://chromium-review.googlesource.com/720244Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Blaise Bruer <allada@chromium.org> Cr-Commit-Position: refs/heads/master@{#509620}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1e0b7a5ad455..f6a588095f8a $ git log 1e0b7a5ad..f6a588095 --date=short --no-merges --format='%ad %ae %s' 2017-10-17 dpranke Update the CQ patch message. 2017-10-13 agrieve Fix CheckPatchFormatted() error message when using inherit-review-settings-ok 2017-10-17 dnj [vpython,led] Update to new version. Created with: roll-dep src/third_party/depot_tools BUG=773857 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=phajdan.jr@chromium.org Change-Id: I4d16dab1e01f2e19ff09194e4e199ab362d3192f Reviewed-on: https://chromium-review.googlesource.com/724225Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509619}
-
Igor Eremeev authored
Content-shell never calls WindowAndroid.onVisibilityChanged, which results in that some part of RWHVA's logic gets missed in shell, i.e. RenderWidgetHostViewAndroid::OnRootWindowVisibilityChanged call. This makes some things a bit harder to debug and creates differences in behavior between CompositorView-based apps and CVRV-based ones. Was introduced here: https://codereview.chromium.org/1243283002/ The problem that led me there is that RWHVA never hides its front buffer in HideInternal, if it hasn't got visibility info callback before that. R=jinsukkim@chromium.org Change-Id: I3c5fe4c5e27583a33048f549e6669eaad2a3614f Reviewed-on: https://chromium-review.googlesource.com/720800 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#509618}
-
Steven Holte authored
Bug: 764463,764465 Change-Id: I54e0d215152b705d2dc92a9ed258886db1339d33 Reviewed-on: https://chromium-review.googlesource.com/701933Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#509617}
-
Andrew Moylan authored
This CL changes the way embedders enable/disable network geolocation: Before: Disabled if GeolocationDelegate::CreateAccessTokenStore() returns null (the default). Now: Disabled if ContentBrowserClient::GetGeolocationRequestContext produces a nullptr URLRequestContextGetter (also the default). This change doesn't alter which embedders enable/disable network geolocation, because the only two embedders that currently return a non-null result from CreateAccessTokenStore() are also the only two embedders that produce a non-null result from GetGeolocationRequestContextGetter: Chrome and Chromecast. Embedders external to the Chromium repo will need to implement GetGeolocationRequestContext: https://groups.google.com/a/chromium.org/forum/#!topic/embedder-dev/0ln9lxrsBw8 With this change, LocationArbitrator no longer knows about AccessTokenStore at all, and AccessTokenStore becomes fully unused. It can be removed in a subsequent CL. This is a step in the removal of AccessTokenStore as detailed here: https://docs.google.com/document/d/1A-ZYMadJkwdQad_pC3MbpuCVNOOnRP_UZjGnXl-FOqE Bug: 748921 Change-Id: Id413a0cdb207fcec8fd25f381068c6c13ad4068c Reviewed-on: https://chromium-review.googlesource.com/676826 Commit-Queue: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#509616}
-
Frank Liberato authored
This is a WIP. Basic playback works, though EOS is ignored. There is quite a bit of thread-hopping, since the accelerator / decoder is run on the GPU main thread rather than the mojo thread. This will be eliminated in a later CL. Resource cleanup is of the "and the process will exit anyway" variety. It's based heavily on D3D11VideoDecodeAccelerator. Re-uses the H264 Accelerated Video Decoder for D3D11. The accelerator was written with the VDA in mind, so the VideoDecoder jumps through some minor hoops to use it also. It is intended that this will replace the VDA as soon as it reaches parity with it, and the accelerator can be modified for easier use with the VideoDecoder. Set "enable_d3d11_video_decoder=true" in gn config. This will enable the decoder, and: - enable MojoVideoDecoder - enable mojo CDM - set the media mojo host to be the GPU process. Also incorporates fixes to the d3d11_h264_accelerator from: https://chromium-review.googlesource.com/c/chromium/src/+/661237 by rkuroiwa@ . Bug: Change-Id: Ie5f2b651895bc812e5e6bba7c5eb302f2702a1b6 Reviewed-on: https://chromium-review.googlesource.com/693284 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#509615}
-
Eugene But authored
Before this CL RecordPageLoadStart was called from deprecated CRWWebDelegate callbacks: - webWillAddPendingURL:transition: - webDidUpdateSessionForLoadWithURL: RecordPageLoadStart is called for the following navigations: - typed navigation - link clicks - bookmark - form submission - switching user agent type RecordPageLoadStart is NOT called for the following navigations: - back forward navigation - client redirect - reload - opening NTP - opening a child window and loading URL there - preload tabs Bug: 674991 Change-Id: I70d53f7e18faf8da151ae1dde35037bad124eb09 Reviewed-on: https://chromium-review.googlesource.com/707659 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#509614}
-
Vlad Tsyrklevich authored
Group failing casts and vcalls separately. This ensures the release build disables CFI checking as narrowly as possible--currently only CFI-vcall is enabled for release but checking is also disabled for bad- cast blacklist entries as well. Bug: 772906 Change-Id: Id8a91d1b01cbf858cf6be4f2b91fe548a521ef83 Reviewed-on: https://chromium-review.googlesource.com/706145Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#509613}
-
Matt Reynolds authored
Chrome for Mac recognizes "Made for iOS" (MFi) gamepads enumerated by the GameController framework. When multiple such devices are connected at once, Chrome fails to properly distinguish them. GCController exposes a playerIndex field that defaults to the value GCControllerPlayerIndexUnset (-1). The application may set this field to a value between 0 and 3 to signal which LEDs should be lit on the gamepad. Chrome also uses this field to distinguish gamepads, but does not set the index to a unique value. This causes the first-connected gamepad to shadow any other connected gamepads. This CL ensures each connected MFi gamepad is assigned a unique player index up to the OS-defined limit of four. BUG=775270 Change-Id: Iaf038a910df8dc7eb2cee99d4d671a6c9ff6dba0 Reviewed-on: https://chromium-review.googlesource.com/724233 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#509612}
-
James Cook authored
crrev.com/c/723604 eliminated the only caller of this code from chrome. The remaining calls are from tests in ash_unittests. AshTestBase already installs a ui::ScopedAnimationDurationScaleMode::ZERO_DURATION so the animations were already being skipped in these tests. Bug: none Test: ash_unittests Change-Id: Ie95041cf03bee51b5d2786f03d3799241c75e513 Reviewed-on: https://chromium-review.googlesource.com/724221 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#509611}
-
Zhongyi Shi authored
to QuicChromiumClientSession::Migrate so that we can clean up further to move all migration logic to session. Bug: 775593 Change-Id: Id70c45fe7d0c05ce3fb34084c336e89d48c50500 Reviewed-on: https://chromium-review.googlesource.com/723782 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#509610}
-
- 17 Oct, 2017 19 commits
-
-
Fady Samuel authored
Now that OOPIFs work in Mus+Ash, we can re-enable a surface synchronization DCHECK in RenderWidget. Bug: 672962 Change-Id: Ie9918085a103bf31c98f292667e312b78feedf96 Reviewed-on: https://chromium-review.googlesource.com/721631 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509609}
-
Steven Holte authored
Splits decoder logic into a seperate generated file, and breaks logic into several templates with the same parameters. Bug: Change-Id: I8d6bf188ec73a475428cc49991bdace36458a468 Reviewed-on: https://chromium-review.googlesource.com/721849Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#509608}
-
Jon Napper authored
The option to "Never translate this site" is always shown on the translate dialog, even when the site cannot be blacklisted (for example a file:/// URL). This patch changes the translate options combon so "Never translate..." is only shown if it will have some effect. Note that the 2016Q2 experimental UI has not been patched as the currently plan is to not launch this UI. Bug: 663934 Change-Id: I64b80d830e124e9372906bd0c4711568c46ff636 Reviewed-on: https://chromium-review.googlesource.com/572475Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Jon Napper <napper@chromium.org> Cr-Commit-Position: refs/heads/master@{#509607}
-
Michael Thiessen authored
This CL is kept intentionally as simple as possible for merging back to M-63. Tests to prevent this regression in the future will be added in a followup CL. Bug: 775571 Change-Id: I78ea1e46efdb2b48bc61e1ab704b6b1526d2c171 Reviewed-on: https://chromium-review.googlesource.com/723770Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#509606}
-
Kyle Horimoto authored
This will be used to aid testing in a follow-up CL. Bug: 761532, 672263 Change-Id: Ifb7b81ab745126aed13abe92e46fe2c77c0bada0 Reviewed-on: https://chromium-review.googlesource.com/724228Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#509605}
-
Nate Chapin authored
delegate_->GetExecutionContext() can get confused for Element-root IntersectionObservers if the Element moves between Documents. If the original Document was detached, attempting to schedule a task for that context will crash. Bug: 763040 Test: intersection-observer/observer-shared-from-iframe.html Change-Id: I6315791b71bf1e3d02e0e6f7369992f2c6fe2a6c Reviewed-on: https://chromium-review.googlesource.com/716671Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#509604}
-
Xi Han authored
In M57, we adopted the same signature to sign WebAPKs generated by all of the Chrome channels, as well as checked in a fix to open WebAPKs in a tab if it doesn't pass the signature check. These fix weren't available on pre-M57. As a result, a latest WebAPK can't pass the signature check and fails to be launched on pre-M57. In this CL, we add a check for Chrome's version in WebAPKs itself, and launch the WebAPK in tab mode if the Chrome's version is old. Bug: 772398 Change-Id: I3cd71d5b72512623795796c827aa6881ed08d4b7 Reviewed-on: https://chromium-review.googlesource.com/706056 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#509603}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/1b4059e84f5f..6bf70d20daa9 $ git log 1b4059e84..6bf70d20d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I432dcae24606641f6d91f9287575673909b25027 Reviewed-on: https://chromium-review.googlesource.com/724170Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#509602}
-
Dale Curtis authored
Should help with fuzzing timeouts and seem like they should be invalid... We definitely have files that have a zero sized sample as the last sample, but none that I can find with contiguous zero sized samples. BUG=770577 TEST=fuzzer fails before allocated massive amounts of memory. Change-Id: Ie137d6f9ec69a1afd5c496c9f6f93706d670c5d9 Reviewed-on: https://chromium-review.googlesource.com/720206Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#509601}
-
Ken Rockot authored
For the sake of efficiency, we don't fully serialize handles in a message until we're ready to freeze the message contents for transmission. Unfortunately we were not properly closing these partially serialized handles in the event that the message was never fully serialized before destruction. This fixes that. R=jcivelli@chromium.org Bug: 775592 Change-Id: Idac3b11359dc2fcec0699cef779de809575ea163 Reviewed-on: https://chromium-review.googlesource.com/723771Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#509600}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/a0020f987e73..e148bf714e39 $ git log a0020f987..e148bf714 --date=short --no-merges --format='%ad %ae %s' 2017-10-06 ethannicholas fix for SkSL lexer crash on non-ASCII input 2017-10-17 liyuqian Add concise option to Calmbench bot Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I64882bc35167c1e38baf1c5088559c3e630e6c75 Reviewed-on: https://chromium-review.googlesource.com/724079Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509599}
-
Rohit Rao authored
The _isActive flag and |clearInternalState| are called indirectly when the stack view is closed through viewDidDisappear, but it is better to reset state explicitly when the animations are complete. This matches the workflow that is used when an existing Tab is opened from the stack view. A future CL will switch to VC presentation instead of containment, and that will result in viewDidDisappear no longer being called in the same way. BUG=768563 Change-Id: I0c0dd453ca4c49a7f34ff072dc9e52e9fc551c2a Reviewed-on: https://chromium-review.googlesource.com/723166Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#509598}
-
Aaron Leventhal authored
Standalone executable tool that helps developers view IAccessible2 object trees from any application. This tool is an alternative to AccProbe, which is buggy, and AViewer, which is not feature rich. The first version of ax_dump_tree is barebones and simply displays events on console, but has a lot of room for future expansion (e.g., serve info to a GUI, dump the tree structure etc.). The tool is similar is use to ax_dump_events. As an example of how this makes easier, when there is a bug with NVDA/JAWS in Chrome that doesn't occur with Firefox, we can look at the object tree emitted by Firefox for the same content. The ax_dump_tree tool shares code and formatting with the DumpAccessibilityTree browsertests. Use as follows: ax_dump_tree --pid=[processid] ax_dump_tree --window=[hwnd] (start with 0x to use hex value) TBR=nektar,dpranke Bug: 771747 Change-Id: Idfc17ca1a1d44006ad32dcca07303ce1d93f7669 Reviewed-on: https://chromium-review.googlesource.com/724239Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#509597}
-
James Cook authored
The eliminates non-public ash dependencies from the tests. * Convert the tests to use the mojo system tray test API * Clean up the test api, always use the same SystemTray*, remove some unnecessary RunLoop spins * Put the tests on the mojo FYI bot. I'll move them to the main waterfall when I'm confident they are stable. Bug: 775121 Test: browser_tests --mash --gtest_filter="SystemTrayClient*" Change-Id: Id790ca77aa179db499c45825a1466e18cc9f78d7 Reviewed-on: https://chromium-review.googlesource.com/723604Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#509596}
-
ccameron chromium authored
This reverts commit fd493b4b. Reason for revert: Causing compile failures, unresolved externals SkCodec::getPixels SkCodec::startIncrementalDecode SkCodec::startScanlineDecode Original change's description: > Stop building SkCodec > > Bug: 768878 > > Building SkCodec seems to have caused a paint regression on a webpage > without any images. This leads us to suspect "some minor compiler > optimization tickling". Stop building it to confirm. Two CLs rely on > SkCodec: > > "Use SkCodec internally in GIFImageDecoder" > 4fed3346. This introduced building > SkCodec. > > "Enable Skia's SkImageGenerator implementation" > f5eb27c2. This used SkCodec to fix > crbug.com/758459, but that seems to have been fixed in another way. > > In addition, this corrects some formatting in the old code (as > commanded by presubmit), and makes some other minor changes (no more > PassRefPtr, FrameDurationAtIndex now returns a TimeDelta). > > Change-Id: Ic2bdd87740da0232c9c07e27eed6049efc26d76c > Reviewed-on: https://chromium-review.googlesource.com/718918 > Commit-Queue: Leon Scroggins <scroggo@chromium.org> > Reviewed-by: Chris Blume <cblume@chromium.org> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Reviewed-by: Leon Scroggins <scroggo@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509570} TBR=scroggo@chromium.org,pdr@chromium.org,fs@opera.com,cblume@chromium.org Change-Id: I7871671628746680fd727708aed8736402d75ada No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 768878 Reviewed-on: https://chromium-review.googlesource.com/724381Reviewed-by:
ccameron chromium <ccameron@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#509595}
-
Ryan Sturm authored
There was a missing break statement in a switch statements, so this code was refactored to have a return in each case statment. Bug: 775595 Change-Id: Iec1671d5946804190d7d747bec9f17183586eff5 Reviewed-on: https://chromium-review.googlesource.com/723729 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#509594}
-
Jérôme Lebel authored
Removing switch user mode ProfileChooserController, with all strings and resources related. Linux/Windows cleanup done previously in: crrev.com/c/704937 User switch feature was added: crrev.com/435423005 Bug: 775110 Change-Id: I6de5e8d8875402d4aaa347f32213440c35f779c5 Reviewed-on: https://chromium-review.googlesource.com/706776Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509593}
-
Lei Tian authored
Move the Browser Actions tab merging function from ChromeTabbedActivity to the BrowserActionsTabModelSelector. And since the tab mergine removes tabs Synchronously, so there is no need to update TabPersistentStore for tabRemoved callback. Call saveState() after all tabs removed is enough. Bug: None Change-Id: I5b6dc8b9ed385212ae3f7bdc3fa33b9d030ff4aa Reviewed-on: https://chromium-review.googlesource.com/722175Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Lei Tian <ltian@google.com> Cr-Commit-Position: refs/heads/master@{#509592}
-
Robert Liao authored
This is a mostly automated refactor. BUG=638327 TBR=sky@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9da8b34dc748d427bcdbe446878461b00bdbda93 Reviewed-on: https://chromium-review.googlesource.com/723867 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#509591}
-