- 26 Jun, 2019 40 commits
-
-
Christy Chen authored
In previous change https://chromium-review.googlesource.com/c/chromium/src/+/1600375, some strings are wrapped inside placeholders ${} in string literals for localization purposes. However, rjsmin couldn't process nested string literals properly so the white-spaces after commas or periods would get trimmed off. It causes the issue where words cannot break to the next line when Audits page resized, and leaves unwanted extra space. This change works around the issue by pulling the string with comma out to a variable to prevent nested string literal. Before fix: https://imgur.com/uMjr5Bp After fix: https://imgur.com/a/X5wq6Xo More details on the rjsmin issue: https://bugs.chromium.org/p/chromium/issues/detail?id=973285 Bug: 972969 Change-Id: I4b4cf243df0ce74c400e488f6c6b98595cf4ecca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655913 Commit-Queue: Christy Chen <chrche@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#672610}
-
Alex Newcomer authored
This will make it easier to consolidate the logic when the components are split into different widgets. Change-Id: I367bee362632ad015f73c1da8637ac71942bdc9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674657 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#672609}
-
Robert Ogden authored
Adds retry functionality with * random guid on every URL * linear and exponential backoff Bug: 977603 Change-Id: I02ba45ea578e75a1a750b8f42d77959edb1fe187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677369Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#672608}
-
Daniel Nicoara authored
https://chromium-review.googlesource.com/c/chromium/src/+/1660794 https://chromium-review.googlesource.com/c/chromium/src/+/1641133 The above 2 changes updated the WMHelper interface without updating the Cast implementation. Bug: None Test: Compiled a Cast build Change-Id: If2c5b6092a301f24197114255ba72b593ab1f5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678779Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#672607}
-
Joel Einbinder authored
Adds a `Copy styles` menuitem to DOM elements, which copies all active user-authored styles of the element. Change-Id: Id78e94eecb506393dfd20f2da4771ece3a72eddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665428 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#672606}
-
Reilly Grant authored
The test is flaky. Bug: 978948 Change-Id: Ie875f58d995d2b0b4fa816bed47eeb9da86eb266 Tbr: thestig@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678849Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#672605}
-
Xianzhu Wang authored
This is a speculative fix. The crash reports seem to indicate that an embedded frame which needs tree_builder_context is walked in PrePaintTreeWalk while the ancestors didn't create tree_builder_context. Bug: 974639 Change-Id: Ia37c9b376c1d60b96dae14624cc0a5abf3c0b782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673838Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#672604}
-
Saman Sami authored
Tasks posted from the GPU thread might reference AcceleratedWidgets that don't exist yet because their registered via a different mojo pipe coming from the Browser's UI thread. When this happens, postpone running these tasks until the AcceleratedWidget is registered. Bug: 620927 Change-Id: I6f399d5a8069fa6a6333bece1d9fffea5eb2f0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664655 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#672603}
-
Simeon Anfinrud authored
Bug: None Test: base_unittests Test: Call base::debug::TaskTrace().Print() somewhere on Android Change-Id: I1a4bda16bfa11436efd277b941735d3610eaacd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666426Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#672602}
-
Travis Skare authored
Attemts the most narrow fix for this in case we want to merge. Bug: 976873 Change-Id: I633adc6413639f975dac9ab683713fbb3c594684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674753Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#672601}
-
Michael Liao (WPT) authored
Changes: Origin: - 'Origin' text is now a header 1 - 'Connection' text is now a header 2 - 'Certificate' text is now a header 2 - 'Certificate Transparency' text is now a header 2 - 'Show more/less' and 'Show full details' links are now marked as buttons and are keyboard accessible Overview: - 'Security overview' text is now a header 1 - page security description is now a header 2 - 'View x in network panel' link is now marked as a button and is keyboard accessible .devtools-link css changes: https://imgur.com/a/9FtpsU4 link elements to button element change: https://imgur.com/zSMcGVQ CR Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=962686 Change-Id: I3a62e898d7135ace1d8a9c76dfdbad382c928500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606195Reviewed-by:
-
Rayan Kanso authored
Background Fetch & Notifications use very similar logic to load icons. Content Indexing will also have to do roughly the same thing. This CL creates a utility class that can be shared by all of them, and migrates Background Fetch to it. Bug: 978020 Change-Id: If0d6d1d87123db0709bddca9d118e6884701cf1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670890Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#672599}
-
Jonah Ryan-Davis authored
Create the GpuProcessInfo struct to pass info from the GPU process to the browser upon GPU process creation. This saves using GpuInfo or GpuFeatureInfo which are passed to every renderer as well. This CL also moves the ANGLEFeatures list to this new struct to mitigate passing this large struct around. Bug: 977605 Bug: 973592 Change-Id: I69a1b57a3def4b802b506d559ecc1fa97ce35d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669913Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#672598}
-
Gil Dekel authored
This CL consolidates some of the error types in VaapiImageDecodeStatus in preperation for the implementation of VaapiWebPDecoder. This CL also moves the protected members from VaapiImageDecoder to the implementing subclasses. This is done to address a concern raised by andrescj@ on a future CL. See here: https://crrev.com/c/1672404/5/media/gpu/vaapi/vaapi_image_decoder.cc#20 Bug: 877694 Test: jpeg_decode_accelerator_unittest Change-Id: I2192ce81b3366a0e284a3f3c7bdac5c229bb0dff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673576 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#672597}
-
Lin Sun authored
For WebGL conformance test, we can specify some conditions to limit the test environment that one test case may fail. But these conditions don't include graphics driver information. By this patch, the WebGL test framework can generate driver tags based on the vendor and version of the graphics driver of current system for the expectations file. The format of driver tag is as below: crbug.com/123 [ linux mesa_lt_18.0.5 ] abc.html [ Failure ] When adding or removing driver tags in the expectatioins file, it's also necessary to modify the list of available driver tags in the header of webgl_conformance_integration_test.py. Bug: 957515 Change-Id: I29835cae0b042cd86eb4fa438f60803e371d8d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647464 Commit-Queue: Lin Sun <lin.sun@intel.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#672596}
-
Saman Sami authored
It causes a deadlock by delaying sending of CreateWindow. It might have been useful for launching with service manager but service manager is deprecated. Bug: 620927 Change-Id: I2b948e1873dc2b3e6a727d88070a93a1e51f9b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667608Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Ian Vollick authored
This is unsupported so it should be flagged as such in the manifest. Bug: 978851 Change-Id: I85055fb675195f3eafd6515aef831d052c5b11aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678280 Auto-Submit: Ian Vollick <vollick@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#672594}
-
Antonio Gomes authored
.. and move it to Blink exposed API, so it can be used by both content and blink code while audio_device_factory.cc|h is not Onion souped. Eventually, the enum can be either moved back to AudioDeviceFactory class, if it ends up being part of the Blink API, or left as is, given that there is not plans to Onion soup the chromecast/media/audio code. This is a preparation CL for execution phase 3.3.10 on the design document [1]. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I1b57f4b1493994fb1438df23a34cdb02c2d42208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677387Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#672593}
-
Reilly Grant authored
Mark virtual/fractional_scrolling/fast/scrolling/unscrollable-layer-subpixel-size-with-negative-overflow.html as flaky Another virtual test suite where this test flakes. Bug: 976045 Change-Id: Ia9dc1338e3e93ab88cb77c8fbc57e50afeaef3c2 Tbr: tschumann@google.com No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678845Reviewed-by:
-
Kyle Milka authored
Support parsing, caching, and encoding/decoding of an optional dark version of a logo. For Google Doodles parse the dark mode specific fields if they are present. Bug: 942810 Change-Id: Ib4ce0f7e35f2bc860f101b182dd8d3c0d955530d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669877 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#672591}
-
wutao authored
Bug: 963852 Test: manual Change-Id: Ib795a22b81286ab1a74fc668e11ee71c511758d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614152Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#672590}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e8df48220589..c57b0ee11c43 git log e8df48220589..c57b0ee11c43 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 srte@webrtc.org Fix for NACK retransmission in Scenario tests. 2019-06-26 ssilkin@webrtc.org Add resolution bitrate thresholds to EncoderInfo. 2019-06-26 danilchap@webrtc.org Delete rtc::TryCritScope as unused Created with: gclient setdep -r src/third_party/webrtc@c57b0ee11c43 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:none,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id1c562e34f09b1577e6837bb3dcbf2dd237a4df6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678699Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672589}
-
Kevin Marshall authored
* Removes CastChannel implementation (it's now provided by Agent). * Removes QueryableData implementation. * Removes CastChannel from CastRunner integration tests. * Add ApiBindings e2e test to CastRunner integration tests. * Cleans up "metrics" from not implemented stubs. * Cleans up some transitional code and makes the ApiBindings connection mandatory. Bug: 953958 Change-Id: I28a56131f896c46697369711d3c5e7d0aa72efd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656110 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#672588}
-
David Bertoni authored
This function has been returning "true" since 2016-05-17. Bug: 978657 Change-Id: I7b8e64accaf36f30cf30177b680851ecacda5546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677261Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#672587}
-
btolsch authored
This change simple wraps a std::unique_ptr around a raw new in some Cast MRP test code in order to re-enable the tests under lsan. Bug: 969812 Change-Id: I4405d701c4d305215d65e2ea420df6978aecbeca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677624Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#672586}
-
Tomasz Śniatowski authored
This CL was uploaded by git cl split. R=thestig@chromium.org Bug: 978036 Change-Id: Ia19099ec1f5760e2168af6402c075c6df085ca70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678366 Auto-Submit: Tomasz Śniatowski <tsniatowski@vewd.com> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#672585}
-
Lan Wei authored
Make ScrollableArea WeakPersistent so we do not need to worry about when we call "area->MarkHoverStateDirty()", ScrollableArea object "area" has been destructed. Bug: 978830 Change-Id: I0e0c11987e4d87e1c8718dbe582354d349771c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678257Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#672584}
-
Robert Sesek authored
The internal signing scripts will look for the presence of the sentinel (notarize_me.txt) as an indicator that the build should be submitted for notarization. Bug: 850199 Change-Id: I1c67a5c891b9d099510b1deaebce90378d134ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679056Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#672583}
-
Harley Li authored
Will modify the expectation and enable them later. Bug: 967927 Change-Id: I4f995f707c80a067a7039371fe8f779edf58d01a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677557 Commit-Queue: Harley Li <hhli@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#672582}
-
Gil Dekel authored
This CL makes CompareImages() API in vaapi_jpeg_decoder_unittest.cc more generic so it can be used to check the result of a hardware decode that is represented as a NativePixmapHandle. Bug: 974439 Test: jpeg_decode_accelerator_unittest Change-Id: Iee52e24deb6bb0eb696f39b5ea192ef1184d6a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663072 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
-
James Hawkins authored
R=stevenjb@chromium.org Bug: none Test: none Change-Id: I0b1c5af328ca54043f36a9e0145f6ccedbad5c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678163 Auto-Submit: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#672580}
-
Emily Stark authored
A previous CL (https://chromium-review.googlesource.com/c/chromium/src/+/1663586) converted FTP auth cancellations to net errors, for the purpose of converting them to committed interstitials. The plan was to observe these net errors with a NavigationThrottle and show a login prompt on top of them. However, it turns out to be much simpler to convert FTP auth cancellations to blank text/plain pages. They then follow the exact same code path as HTTP server auth; the login prompt is shown by LoginTabHelper on top of the blank text/plain page. This CL therefore partially reverts https://chromium-review.googlesource.com/c/chromium/src/+/1663586, converts FTP requests to text/plain on auth cancellation, and tweaks LoginTabHelper to observe these navigations. Bug: 972188 Change-Id: I719ef9db33a20823acb6c5c2bdc1ab95ba7d8995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671913 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#672579}
-
Tanya Gupta authored
Bug: 978699 Change-Id: I82b7d902a2ae7295832e0bccb969e80bbd9f18ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677563 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Auto-Submit: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#672578}
-
Rayan Kanso authored
Add two-way conversions between the WebIDL ContentDescription dictionary and the mojo struct representing the ContentDescription. Bug: 973844 Change-Id: If4da6be3a96f6a012f279b38d6ae2c0889c2703b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660345 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#672577}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/effb0bcb66db..7bf0ecb40e23 git log effb0bcb66db..7bf0ecb40e23 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 saklein@chromium.org ArtifactsService: Create replacement for BundlePinnedGuestImages. Created with: gclient setdep -r src/third_party/chromite@7bf0ecb40e23 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I5ceb2b6bb2dba91f440c659a025d85d89b9c5a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678698Reviewed-by:
-
Justin Cohen authored
A followup to http://crrev.com/c/1673566. Strip our restore and placeholder information out of the URL returned by GetCurrentURL(). Change-Id: I86075a81099fca5bc74f6fabcb44c4faad216f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677804 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#672575}
-
Patrick Noland authored
Bug: 978596 Change-Id: Iba3268d6f2a0c99b1c8f258bd081a85e6802cd8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676842 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#672574}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I39dbc97af18b0e4ac6474a8a1edfd4c770586027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678158Reviewed-by:
-
Hector Carmona authored
Bug: 956680 Change-Id: I447ded8b21d6ab151d01ffe5435471d78e7fbb01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661190 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#672572}
-
Jan Wilken Dörrie authored
This change introduces the convenience typedefs base::MockOnceCallback, base::MockRepeatingCallback, base::MockOnceClosure and base::MockRepeatingClosure to base/test/mock_callback.h Change-Id: I2db99b32e246b94da85805af666f9de93033ab33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674154Reviewed-by:
-
