- 18 Jun, 2020 40 commits
-
-
Abigail Klein authored
An EXCEPTION_ACCESS_VIOLATION_READ crash was reported in CaptionBubble::GetNumLinesInLabel. I believe the cause is that CaptionBubble::GetNumLinesInLabel calls Label::GetRequiredLines, which is a const function. To fix this, I mark CaptionBubble::GetNumLinesInLabel as const. While I am here, I am also performing a check that observer_ is not null in CaptionBubbleModel::CommitPartialText, which would cause a different crash. Bug: 1055150, 1096366 Change-Id: Ic039de789f4ce5dc34b3dff0ee11e38bcfabb4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252198 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#780003}
-
Lei Zhang authored
This is equivalent to the existing DeleteFile(path, false). It will help migrate the existing callers to the 2-parameter function incrementally, and remain after the 2-parameter function goes away. Also put this and DeleteFileRecursively() above the 2-parameter function, so readers will see them first and hopefully use them. Convert the unit tests to use this new version of DeleteFile(). Fix a few pieces of code that have trouble distinguishing between the two variations of DeleteFile(). Bug: 1009837 Change-Id: I8befdc95dc9ed4d9da501126bf545334011b048a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952387 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#780002}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592492320-3ab827aecaa4186da1d1047a6b75e711e06263db.profdata to chrome-win32-master-1592495797-0ce2a459124ac0074ced31c25e7b4057cfe18bea.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I37a330d56053d370e4490c5a5f72ae44dc90e833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252522Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780001}
-
Marc Treib authored
The actual flag was removed a while ago, but traces of it remained: - in flag_descriptions - in flag-metadata.json - in fieldtrial_testing_config.json This CL cleans them all up. Bug: 1010397 Change-Id: I300b7808788ff873249ec62935cc9870a91712f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250105Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#780000}
-
Yi Xu authored
Test fast/canvas/canvas-composite-text-alpha.html keep failing due to timeout. Add it to the slow test list. Bug: 1093836 Change-Id: I636b75378855af72869fbc5c1295fa0f8aafd3f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252683Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#779999}
-
Ben Pastene authored
This will help move its tests over to LMY48M from LMY48I, for consistency with the the release tester. Bug: 1091539 Change-Id: Icbf74b9c766e836f74cf61abafb92861a8e62871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252840Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#779998}
-
Mohsen Izadi authored
Ideally, if an event is associated with a compositor frame, it means that the event was created before the compositor frame is submitted to viz for presentation. So, the time stamp of the event should be smaller than the start time of viz stage in CompositorFrameReporter. However, it seems that it's not the case all the time (see the associated bug). For now, let's silently ignore such cases instead of a DCHECK. Hopefully, our work on investigating discrepancies between the new EventLatency and the old Event.Latency would reveal the cause of the issue. If not, we should reconsider this case. Bug: 1093698 Change-Id: I4ce943fe2c9ed69caba82b34b652fa14e027d549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252678Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779997}
-
Shengfa Lin authored
Bug: chromedriver:3376 Change-Id: I88f1ea001b600743be4f158a44cc4ac68652c257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250082 Auto-Submit: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779996}
-
Kyle Horimoto authored
Also add screenshots for these to aid translators. Bug: b/158618555 Change-Id: Ia41fcbc18b36f42b050c790fb9d71e1097245376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252651 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779995}
-
Kyle Horimoto authored
This will help translators come up with an appropriate localized string in their languages. Bug: b/158612775 Change-Id: I807363055ffe36d1416a9f92e0a12a1e28160612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252843Reviewed-by:
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I20c6b61c96f12319f1b81f19b16a94bd025993d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248220Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#779993}
-
Yuanyao Zhong authored
Remove reading from command line to obtain cast display rotation from CastDisplayConfigurator. The display rotation is now read from kernel for https://chromium-review.googlesource.com/c/chromium/src/+/2229725 Bug: b/77900197 Test: build and run on device. Change-Id: I8d1f4c49c4a0ae12ea01c982d72af7f2c8617f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252938Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Yuanyao Zhong <yyzhong@google.com> Cr-Commit-Position: refs/heads/master@{#779992}
-
Joshua Peraza authored
This allows LaCrOS crashes to be triaged separately from Chrome_Linux crashes. Change-Id: I1b441519dffb508593915a93d5ccbc44e83f0dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252625Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#779991}
-
Sky Malice authored
TBR: szager@chromium.org Bug: 1096612 Change-Id: Ia9d5df25ff3bcf59ac0fb1b169572e73b2436014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252648Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#779990}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I4a1e3c4bfe1e1bdf32f1dc9078aed46e5c885c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249838 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#779989}
-
Stephen McGruer authored
This reverts commit a4a3a1a6. Reason for revert: Suspected of failing dozens of CrSettings* tests in browser_tests and interactive_ui_tests, on multiple bots. See comment in https://chromium-review.googlesource.com/c/chromium/src/+/2246157 Original change's description: > [b4p/Settings] Display removal dialog > > This CL starts displaying the dialog from crrev.com/c/2248180. Moreover, > RemovePasswordBehavior is deprecated. The more elaborate logic of > removing different copies of a password can live directly in the dialog, > while PasswordsListHandler can use simple logic for the case when a > single copy must be removed. In particular, it felt strange that > PasswordListItem has this Polymer behavior but never used any of its > functionalities (it was PasswordsListHandler that used it instead). > > We also use the occasion to fix an aspect of crrev.com/c/2235850. If > the entry is moved, there's no element to reset the focus to, so the > focusWithoutInk() call is removed. The same is done for removal dialog. > > Bug: 1049141 > Change-Id: I06fe35b8bd14ee27873b6a56849e755c02cbc1bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246157 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779757} TBR=fhorschig@chromium.org,aee@chromium.org,victorvianna@google.com Bug: 1049141 Change-Id: I429f8f5507fbc5e2784d78b3bfd3bed897f59d89 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252612 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#779988}
-
Ioana Pandele authored
[Sheriff] Set expectations for flaky fast/canvas/OffscreenCanvas-MessageChannel-transfer.html on Linux TBR=smcgruer@chromium.org Bug: 1095969 Change-Id: I277858b1c557269874f1b2e338741674f411c313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249998Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#779987}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d438a6023a21..477818f5075f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC smcgruer@google.com,atotic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1052567,chromium:1093981,chromium:1093993 Tbr: smcgruer@google.com,atotic@google.com Change-Id: Icdfd087e279bc60db1fba122c0f3a21fe5264888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252520Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779986}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/81454dfaa92a..c950e05bafcd 2020-06-18 mtklein@google.com clean up old idea about nullptr/sRGB 2020-06-18 adlai@google.com Consolidate GrDrawingManager <-> GrRenderTask lifecycle 2020-06-18 egdaniel@google.com Revert "Don't release vk memory allocator until context is deleted." 2020-06-18 mtklein@google.com runtime shader children on skvm backend 2020-06-18 egdaniel@google.com Don't release vk memory allocator until context is deleted. 2020-06-18 nigeltao@google.com Reland "Allow building with Wuffs v0.3, not just v0.2" 2020-06-18 bsalomon@google.com Merge ShaderMode and FilterLogic enums in GrTextureEffect 2020-06-18 johnstiles@google.com Fix stack-buffer overrun in appendVAList. 2020-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 98d0f30c4393 to fa3d64bf72d6 (41 revisions) 2020-06-18 rmistry@google.com Change URL in skia_css3gradients_desktop.py 2020-06-18 bsalomon@google.com Make Clip test FP use texture effect child 2020-06-18 bsalomon@google.com Use child effects for LUTs in perline noise effects 2020-06-18 bsalomon@google.com Update generated file 2020-06-18 bsalomon@google.com GrRRectBlurEffect uses child for nine patch 2020-06-18 dmazzoni@chromium.org Get rid of deprecated API to add children to PDF tag nodes. 2020-06-18 egdaniel@google.com Fix perspective fragcoord value in d3d. 2020-06-18 brianosman@google.com Support sample() in ByteCodeGenerator (but not the interpreter) 2020-06-18 bsalomon@google.com Use child effect for integral in GrRectBlurEffect 2020-06-18 djsollen@google.com Manually update ANGLE DEPS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1078330,chromium:1081806,chromium:1085996,chromium:1091259,chromium:1092743,chromium:1094634,chromium:607777 Tbr: djsollen@google.com Test: Test: Test: Build/CQTest: Test: angle_end2end_testsTest: Test: angle_end2end_tests.exe --gtest_filter=ImageRespecificationTest*Test: Test: dEQP-GLES31.functional.image_load_store.*.format_reinterpret.* Change-Id: I5aecf7ec290346781fa50d5ddd3817088aa62326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252523Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9c7a8fbc5977..28c801fc37b8 2020-06-18 treehugger-gerrit@google.com Merge "Add an optional fake system tracing backend" 2020-06-18 chiur@google.com Merge "Move Specification to InternedData" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib781c457d05d63d74e7e1ba266912770c6e4e3d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252521Reviewed-by:
-
Alexander Surkov authored
Bug: 1094350 Change-Id: Id0f2d6318e5f34d9278a766d5f5cde736b16abd9 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243259 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
-
Patrick Monette authored
The ordering between the destruction of each WorkerTaskProvider and the ProfileManager/g_browser_process instance is not guaranteed. This means that it's necessary to check if the ProfileManager still exists before unregistering from it, which preclude us from using ScopedObserver. This is a common pattern for other ProfileManager observers instances. Bug: 1094235 Change-Id: I35369d8938c95dcc6ef5204ea15b5f4dfa4d000e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248073 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#779982}
-
Min Qin authored
Since this value is false on most platforms, only set the flag when true to reduce the stored UMA log size see https://chromium-review.googlesource.com/c/chromium/src/+/2245893 for changes to the OmniboxEvent. BUG=1090911 Change-Id: I766fc8d0f07eb4ff237b137b51806373005267f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250558Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779981}
-
Emily Stark authored
ScopedFeatureLists are supposed to be initialized in text fixture constructors to avoid data races. Bug: 1095832 Change-Id: Ifd4a290cd4cf49421df99c5c0338e0fa8633d2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250084 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#779980}
-
Nate Chapin authored
Change-Id: I95c2de6a9924eabaf149cb982a3e3e756a022f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238381 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Xiqi Ruan authored
In Child lock screen, set time to 24 hour clock format if the child user turn on "Use 24-hour clock" in preference. Bug: 945186 Change-Id: I760387e8e58041f23529c24641362eec5de6a9b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225864 Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#779978}
-
Xiaocheng Hu authored
This reverts commit 03df4919. Reason for reland: Found a way not to regress cc memory. This time we keep partial layout invalidation on LayoutText and LayoutInline only. In this way we still need to relayout everything else (blocks and etc) but at least we can reuse the old shape result, which should be still better than before. Original change's description: > Revert "Enable full testing of CSSReducedFontLoadingLayoutInvalidations" > > This reverts commit 5aba5002. > > Reason for revert: Causing crbug.com/1092431 > > Let's stop messing up the perf bots while debugging. > > Original change's description: > > Enable full testing of CSSReducedFontLoadingLayoutInvalidations > > > > This is preparation for enabling finch experiments of the feature on M85 > > > > Note: though M85 hasn't reached Beta, we'd like to have it covered by > > test bots first to catch any breakage. We'd also like it to be tested > > by perf bots, since this "feature" is a performance optimization. > > > > Bug: 441925 > > Change-Id: I3ef98ffcfa960381efd034cd1cd63e55fbda4b01 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231269 > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#775847} > > TBR=asvitkine@chromium.org,chrishtr@chromium.org,xiaochengh@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 441925, 1092431 > Change-Id: Ife4aa822dda70d88249306b63e30d3d39df7a560 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242383 > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#778044} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 441925, 1092431 Change-Id: Ib0986810a9c516f33a900dc91b91e2689f586f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245373 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#779977}
-
Arthur Wang authored
R=harringtond@chromium.org Bug: 1060399 Change-Id: Iff4a8b59a3f7ac1ec79a8adb9d16877a3fbbcbae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252460Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#779976}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I67be0e52108c7bbd69ab3fba06160c54c820a11c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252838Reviewed-by:
-
Francois Beaufort authored
This CL makes sure an OverConstrainedError is returned in getUserMedia if constraints require PTZ and system does not support PTZ. Bug: 934063 Change-Id: Ia17167bce8eac0d45f4c97d30edbebb032fa55d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247820Reviewed-by:
-
rbpotter authored
Move Print Preview specific PDF resources to a separate grd file from other resources for Print Preview. This is in preparation for adding an assert in unpack_pak.py to prevent unpacking any files in a pak file that are not under the root directory. Change-Id: I8145621439e5814383a33e837c6503d0f040eb4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251100Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#779973}
-
Andrew Grieve authored
Bug: 1095770 Change-Id: I467bb9c72885ea3c3bbe8576a7b4e22817bc7be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252690Reviewed-by:
benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#779972}
-
Stephanie Kim authored
This reverts commit 73bff5e4. Reason for revert: Missing compile targets for Mac Builder Original change's description: > Reland "Promote Mac10.15 Tests to main waterfall" > > This is a reland of f297bdfa > > Mac Builder's mb_config was updated to use that of Mac Builder Next's > so that nacl is disabled. > > build761-m9 and build769-m9 now has their xcode paths properly configured > > Original change's description: > > Promote Mac10.15 Tests to main waterfall > > > > Remove Mac Builder Next, switch OS of Mac Builder to 10.15 > > > > This CL copies what was done for Mac10.14: > > https://chromium-review.googlesource.com/c/chromium/src/+/2036769 > > > > Bug: 1066873 > > Change-Id: If227273be17c14547b16db1a68ff69f84fcc59eb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242162 > > Commit-Queue: Stephanie Kim <kimstephanie@google.com> > > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#779041} > > Bug: 1066873 > Change-Id: I26810565b9d00eab37ac67708845f8fb311c8e77 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250825 > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Commit-Queue: Stephanie Kim <kimstephanie@google.com> > Cr-Commit-Position: refs/heads/master@{#779924} TBR=gbeaty@chromium.org,kimstephanie@google.com Change-Id: If8936ab72aa50bf8af5dda8cfba527737a1dcfe6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1066873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252845Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#779971}
-
Victor Vasiliev authored
Also roll the feature flags https://quiche.googlesource.com/quiche.git/+log/c0dc4ceb325c..46d05bc682ff $ git log c0dc4ceb3..46d05bc68 --date=short --no-merges --format='%ad %ae %s' 2020-06-17 dschinazi Do not send max ack delay when it has the default value 2020-06-17 dschinazi Deprecate quic_negotiate_ack_delay_time 2020-06-17 quiche-dev Demotes a WARNING log to VLOG(1). 2020-06-17 dschinazi Introduce QuicDisableVersion and QuicVersionIsEnabled 2020-06-17 zhongyi Add a method in QuicConnection to be called when the client successfully migrate itself after probing. 2020-06-17 haoyuewang Internal QUICHE change Created with: roll-dep src/net/third_party/quiche/src R=dschinazi@chromium.org Change-Id: I638b47628092863e8bdbb6573eb08368dd4a7267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251307Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#779970}
-
Etienne Pierre-doray authored
Manual reland: Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2029609 Revert: https://chromium-review.googlesource.com/c/chromium/src/+/2109970 Reset for revert: flaky DCHECK in AssertExpectedConcurrency Fix: Avoid calling AssertExpectedConcurrency from ShouldYield. https://chromium-review.googlesource.com/c/chromium/src/+/2112235 Original Description: Note: This CL enables feature BlinkHeapConcurrentMarking to get the desired behavior. However, we should land enabling BlinkHeapConcurrentMarking on its own first. active_markers + GlobalPoolSize() is used to determine the desired number of workers. NotifyConcurrencyIncrease() is called periodically from ConcurrentMarkingStep() if GlobalPoolSize() > 0, to make sure enough workers are scheduled. Bug: 1046343 Change-Id: I4c36044686128b23fc25f45b99334c219a08cffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214908Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#779969}
-
Monica Basta authored
This CL does the following: 1- Adds 'cr-view-manager' to the profile picker. 2- Starts the implementation of the main profile picker screen. 3- Adds the 'Add Space' icon, which will be the entry point for the profile creation flow. Bug: 1063856 Change-Id: I626b3ecbc22129e0ad1478c2258812286efe5588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249781 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#779968}
-
Danila Kuzmin authored
Bug: 1007874 Change-Id: I501a90c677b05c87053a42920ed7eabdd9491752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230627 Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#779967}
-
Fredrik Söderqvist authored
This method has a single user - it also essentially a pure function. Fold it. Bug: 634143 Change-Id: I2c0f9cdc615dcd19f8b1a58ea43cd61066bf9cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252078 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#779966}
-
Sean Harrison authored
Add img width to settings/content style to properly scale banner Bug: 1096441 Change-Id: Ia364223860c88f3aab1dbd273037fb6bba49a274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252001Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#779965}
-
Saurabh Nijhara authored
This CL introduces the handling of showing in-session notifications when update is required as per the policy but the device is connected to a metered network or has reached end-of-life(EOL). In case of metered network - The notification is to be shown when the policy is received and on the last day of the deadline. Clicking on the notification button starts update process over metered connection. For end-of-life devices - The notification is to be shown when the policy is received, one week before deadline and on the last day of the deadline. Clicking on the notification button opens the enterprise/management info page which would contain details about the end-of-life of the device. This detail on the settings page will be implemented in subsequent CL. New browser and unit tests are also included to verify this behavior. Bug: 1048607 Change-Id: I4c09a00a50ff1673db1b15e4f05a4a29e825f043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245612 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#779964}
-
