- 30 Sep, 2020 40 commits
-
-
My Nguyen authored
http://crbug/1107917 update cr-action-menu focus background-color across webui. UX is considering having different behavior between hover and focus. For now keep this color to be consistent with other menus. Bug: 1113439 Change-Id: Idf5847f877b234ba082cc4c353082018a0328fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438343Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#812000}
-
Daniel Hosseinian authored
Allow keyboard focusing on thumbnails, and implement focused thumbnail styling. The thumbnail bar is "focusable", but it forwards focus to the thumbnail of the active page. Focus can be changed among thumbnails using arrow keys. Tabbing while focused on a thumbnail diverts focus out of the thumbnail bar. Allow changing page of the PDF content using the enter and space keys. Bug: 652400 Change-Id: Ie03a069d9feff2889723012810324803afad18b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434770 Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#811999}
-
Sergey Poromov authored
According to the mocks, Data Leak Protection toast should contain a "managed" "building" icon on the left. Adding this functionality to Toast as well as enforcing it for DLP notifications. See mocks: https://docs.google.com/presentation/d/1v0GM-lwHCznFJ6hnZlUH37eBOuAkJMw5Q6UnSkcKOgA/edit?hl=en#slide=id.g8f65759f6a_14_27 Bug: 1124651, 1096461 Change-Id: If815c55a3a9e011ea19f29b6cd95fb7aca2aeccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435390 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#811998}
-
Wei Lee authored
Since we have removed the legacy migration logic in: https://crrev.com/c/2407733, we don't need internal directory usage anymore. Note that we still need internal temporary directory to store temporary video file for intent purpose. Bug: 1127587 Test: Launch CCA and no error shows. Change-Id: I2d2a09328f328a0e6c675f85145f215fd140c1b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438082Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#811997}
-
Yunke Zhou authored
Bug: 1132228 Change-Id: I00c0c60ef117afd28aaf2cf10ed1324227552be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431425 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#811996}
-
Lei Zhang authored
The style guide says default arguments are banned on virtual functions. Change-Id: I4c53f436804a02600e843d5929d24536c3b67077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364010 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#811995}
-
Mirko Bonadei authored
This reverts commit f37a0083. Reason for revert: crbug.com/1128470 is back under control, let's re-enable AVFoundationCaptureV2 by default. Original change's description: > AVFoundationCaptureV2: disable by default. > > Reason: breaks post-commit testcase. > > Bug: 1128470 > Change-Id: I6a6745e9ba8150dcac2408af1b73186ac05a75d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421308 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Markus Handell <handellm@google.com> > Cr-Commit-Position: refs/heads/master@{#808818} TBR=hbos@chromium.org,guidou@chromium.org,jochen@chromium.org,handellm@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1128470 Change-Id: I81ee2900d9f3c0911211ee7fd83e1a335de707a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439070Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#811994}
-
Peter E Conn authored
This should allow all of org.chromium.chrome.browser.externalauth to be moved to a separate module. Change-Id: I0545fc8e1561b5f3c417e196e07893417c55f8ec Bug: 2400622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438253 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#811993}
-
Reda Tawfik authored
This CL disable the filling passwords across origins feature by not adding "Use other password" footer command if the current site scheme is not cryptographic. Bug: 1104132 Change-Id: I55039494325c81a5b263e734c0ba4783990d7195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431084 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#811992}
-
Trent Apted authored
These changes allow the file to be consumed by targets compiled with null checks and reportUnknownTypes. Bug: 1030935, 1132695 Change-Id: Ib898151aeecaeb0636e12b7d79ed4a2335ef8278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428274 Commit-Queue: Trent Apted <tapted@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#811991}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/184c9b9164b7..d6055cbe1f06 2020-09-30 nigi@chromium.org Add a pixel test for a link annotation that does not render. 2020-09-30 nigi@chromium.org Add a pixel test for a link annotation that does not render. 2020-09-29 tsepez@chromium.org Stop caching CXFA_FFWidgetHandler in CPDFSDK_Widget 2020-09-29 tsepez@chromium.org Bring XFA_RESOLVENODE_RS more in line with style guide. 2020-09-29 tsepez@chromium.org Avoid LSAN leak reports in XFA fuzzers 2020-09-29 thestig@chromium.org Fix nits with CPDF_CrossRefAvail member variables. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1131837,chromium:1132607,chromium:237527 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Iccae44a9660c5858739a8dcc8c2f7ed3a5a888ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436833Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811990}
-
Elizabeth Popova authored
The card expiration error is now announced the same way as errors in cr-input. Attributes such as role="alert" need to be added again every time for better a11y, see [1]. [1]https://chromium-review.googlesource.com/c/chromium/src/+/2429943 Bug: 1083550 Change-Id: I4dbf22eec455eef659e9aeb18b53f4fd28452474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435189Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
-
chrome://flagsVictor Hugo Vianna Silva authored
This CL makes it easier to test the auto-sync decoupling feature by adding a corresponding switch to chrome://flags. Bug: 1105795 Change-Id: I46f4e85aaace65e526fd2b8168b7bb62dc958495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438370 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#811988}
-
Mikel Astiz authored
Implementation is going through changes and these histograms help monitor regressions. Change-Id: I4902903f1bf434b346e2e0f930619bdd145d3be8 Fixed: 1125783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440057 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#811987}
-
Robbie Gibson authored
This allows the text zoom provider (and any other implementations of it) to decide using its own rules whether text zoom is allowed. Bug: 1061119 Change-Id: I76de0206d8b42da169d19475a6e263ac68a632e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437434 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#811986}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 87-4258.0-1601290734-benchmark-87.0.4275.0-r1 to 87-4258.0-1601290734-benchmark-87.0.4277.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If90a2121efdd60d968329ae154d367f3e00390e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439868Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c73bff39bd21..a87c5076a876 2020-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 44be0942f9a8 to b042f4e70879 (15 revisions) 2020-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from b2a4e87ad274 to ad421a248adb (2 revisions) 2020-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 339e4ec2 to cc47e0cd (351 revisions) 2020-09-30 johnstiles@google.com Allow more types of expressions to be directly inlined. 2020-09-30 ethannicholas@google.com Revert "Revert "moved SkSL Enum data into IRNode"" 2020-09-29 robertphillips@google.com Make GrRRectBlurEffect use the thread-safe uniquely-keyed view cache 2020-09-29 kjlubick@google.com [canvaskit] Add Initial Typescript definitions/types. 2020-09-29 ethannicholas@google.com moved SkSL ExpressionStatement's data into IRNode 2020-09-29 robertphillips@google.com Make the SW blurred mask path use the thread-safe uniquely-keyed view cache 2020-09-29 johnstiles@google.com Revert "moved SkSL Enum data into IRNode" 2020-09-29 ethannicholas@google.com moved SkSL Enum data into IRNode 2020-09-29 brianosman@google.com Fix swizzle-of-swizzle lvalues in ByteCodeGenerator 2020-09-29 brianosman@google.com Add a benchmark that measures SkSL::Compiler startup time 2020-09-29 jsimmons@google.com Add an API for clearing the SkParagraph font and paragraph caches 2020-09-29 ethannicholas@google.com moved SkSL Constructor's data into IRNode 2020-09-29 robertphillips@google.com Have GrCircleBlurFragmentProcessor make use of thread safe view cache 2020-09-29 bsalomon@google.com Add sample count to GrVkImageInfo. 2020-09-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2a09e89113af to ec42b1438fd2 (63 revisions) 2020-09-29 herb@google.com minimize includes and forwards for remote glyph cache 2020-09-29 ethannicholas@google.com moved SkSL FloatLiteral data into IRNode 2020-09-29 jvanverth@google.com Move MacOS 10.13 Metal jobs to 10.15. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1018739,chromium:1096746,chromium:1108408,chromium:1130678,chromium:1132366 Tbr: brianosman@google.com Test: Test: Test:Test: Test: CQTest: Test: ContextNoErrorTest31.DrawWithPPOTest: Test: Manual verification of Skia 'gn gen' on WindowsTest: Test: ProgramPipelineTest31.VerifyPpoLinkErrorSignalledCorrectlyTest: Test: angle_end2end_test --gtest_filter=*ETC1CompressedImageNPOT*Test: Test: angle_end2end_tests --gtest_filter=*ETC1CompressedImageDraws*Test: Test: dEQP.GLES31/functional_separate_shader_validation_es31_* Change-Id: I944383c547ca321da3fd774ca61e7e085537b6e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439391Reviewed-by:
-
Taylor Brandstetter authored
Note that this required making WebrtcPage inherit from PressStory. Bug: chromium:1033483 Change-Id: I98972369b9349c06203da27c6bfc0f62294cb006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148277Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#811983}
-
sandromaggi authored
Letting the backend know what data has been requested and is currently available. This helps debugging Autofill issues and can be used to control the field setting action (crrev/c/2435084) from the backend. Bug: b/169521597, b/167491545 Change-Id: I11b5e17906c162cb4ab51bc01f385c88695087bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435384 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#811982}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 87-4265.0-1601286022-benchmark-87.0.4275.0-r1 to 87-4265.0-1601286022-benchmark-87.0.4277.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I8a31dba993277c186e7da638b260d3202183f8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439865Reviewed-by:
-
Tomasz Tylenda authored
BUG=764795 TEST=build Change-Id: I8afa2fd87eb5cf5d9a8f7ecde9fad95d420c5399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434405Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org> Cr-Commit-Position: refs/heads/master@{#811980}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/991ead187c14..59d478038b9b 2020-09-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-09-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-09-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-09-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-09-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-09-29 ddoman@chromium.org [resultdb] move cipd pin for infra/tools/rdb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1099573 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I99f1493c100868e433487650475c2fdf783ea42f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439714Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c6ca885c0b4a..fcb22ecf0f7e 2020-09-29 afdx@google.com spirv-fuzz: Report fresh ids in transformations (#3856) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: Iaa12f7451c9ae07fdca67219488abf412a302fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437214Reviewed-by:
-
Sergey Poromov authored
Adding a feature flag that is disabled by default as the behavior even though it is anyway gated on the presence of the policy. For now we'll enable it via Finch flag configuration for all users. However, we need to have ability to turn the feature off on older builds later when the policy will be released to public - otherwise these devices with older build will have unwanted experience. Bug: 1131067 Test: New unit test added. Change-Id: Ia29f053f4128d67a2976e78a573f1ccda998f7c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428898Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
Don't provide the entire strut, since it was used incorrectly anyway. FinishFragmentation() sometimes calls IsNodeFullyGrown(), and used to pass the border_padding strut that was passed to it. This was wrong for fieldsets, because, internally, fieldset padding isn't part of the fieldset, but rather the anonymous wrapper child block. To fix this, get the actual border/padding from the fragment builder, which is what IsNodeFullyGrown() needs to use when calculating a block-size. This isn't fixing any known issue, but I was playing with some code, and stumbled into the DCHECK_GE() failure in IsNodeFullyGrown() when fieldset block-size was non-auto. Example: <fieldset style="height:100px; border:10px solid; padding:30px;"> The border-box size should be 180px. This is what would be passed as current_total_block_size (correct). The border_padding passed would be 10px on each side (just the border, no padding - WRONG!), and the call to ComputeBlockSizeForFragment() would only return 120px, triggering the DCHECK. No behavior changes intended. Change-Id: I9782f785e2b915b8a4784c443389ba9d434ec5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438061Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#811976}
-
Shakti Sahu authored
Bug: 1132709 Change-Id: I51b0823e590b158a97061894ed0b8bc9bbb7d143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434554 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#811975}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b2a4e87ad274..ad421a248adb 2020-09-29 enga@chromium.org Remove AMD test suppression in VulkanImageWrappingTests 2020-09-29 cwallez@chromium.org TextureFormatTests: Test more Snorm format corner cases. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I222d308dd4219f8ef93d2500c2740b675f48751e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439378Reviewed-by:
-
Henrik Boström authored
These were previously disabled in order to investigate device related failures on a post-CQ bot that have since been resolved. TBR=handellm@google.com, ccameron@chromium.org, mbonadei@chromium.org Bug: chromium:1128470, chromium:1129807 Change-Id: I357fa8c0122ce955a0ca16b83d704743011e470c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440355Reviewed-by:
-
Evan Liu authored
This CL defines the sandbox for the speech recognition process on MacOS that will be used by the Live Caption feature (go/chrome-live-caption). Bug: 1131611 Change-Id: I10a52fb6a2568ccbfce68d44a81b0c3b333e250f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426970 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#811972}
-
Ghazale Hosseinabadi authored
This CL adds test coverage for WINDOWS_CREATE and WINDOWS_GETALL APIs. Bug: 1093066 Change-Id: I750a4689af252e167bcedf419143deaca712269f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436410 Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#811971}
-
Tibor Goldschwendt authored
The hl param overrides the account language. By setting it to Chrome's application locale we ensure that the shopping tasks module's and Chrome's UI language will match. Fixed: 1133409 Change-Id: I195734b8dbb46b35cd69b6e250f6d559f640aa5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439022 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#811970}
-
Matthias Körber authored
This CL improves parsing of multi-line addresses. If the full street address cannot be parsed, try to parse only the first line into the street name and house number. Additionally, this CL adds assignment of the HOME_ADDRESS_STREET_AND_DEPENDENT_STREET_NAME token. Change-Id: I0e377095834a722a5f9971e77d67a41a43b5a398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438392 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
-
Roberto Moura authored
In order to allow the tab thumbnails to be up to date when the thumb strip is visible, the grid's collection view needs to be updated even when other view controllers are obscuring it. When selecting a new item from the collection view (blue highlight around the thumbnail), the item that is currently selected needs to be deselected to prevent multiple simultaneous selection. Bug: 1127604 Change-Id: Ice919b9b7c068d381d667b0ac0ad82c41abfed35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426590 Commit-Queue: Roberto Moura <mouraroberto@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#811968}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0d81cd72..f7bee82a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifc76c8d67b160491a504ea97b925c760ca333774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438635Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811967}
-
David Black authored
HoldingSpace.Downloads.Action.All - Records action taken on downloads button in holding space UI. HoldingSpace.Item.Action.All - Records action taken by user on items in holding space UI. HoldingSpace.Item.Action.Copy HoldingSpace.Item.Action.Drag HoldingSpace.Item.Action.Launch HoldingSpace.Item.Action.Pin HoldingSpace.Item.Action.ShowInFolder HoldingSpace.Item.Action.Unpin - Records type of item in holding space UI for which action was taken. HoldingSpace.Item.Count.All - Records count of all visible items in holding space UI at launch. HoldingSpace.Item.Count.Download HoldingSpace.Item.Count.PinnedFile HoldingSpace.Item.Count.Screenshot - Records count of all visible items of a given type in holding space UI at launch. HoldingSpace.Pod.Action.All - Records action taken on holding space pod in shelf. Bug: 1131266 Change-Id: Ib91e74b49ce131d718aa768f8eed3d6f31c39122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429978 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#811966}
-
Caitlin Fischer authored
The original CL for this change stored the value of the feature in VariationIdsProvider. However, the provider lives only in the browser process. Thus, when the renderer process checks the value of the feature via the provider in variations_http_headers.cc, the value is always seen as false. The fix is to check the FeatureList, which lives in both processes. I locally reproduced the failure using the failing builders gn args: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/91893? I confirm that the fix passes with these gn args, too. This is a reland of b622082c Original change's description: > Prevent deadlock by checking kRestrictGoogleWebVisibility sooner. > > More specifically, check the feature's state after field trials have > been created from the variations seed and before the variations > header is updated. > > Checking the state for the first time in > VariationsIdsProvider::GenerateBase64EncodedProto() could cause a > deadlock. > > Bug: 1094303 > Change-Id: I53fe3446e3a4567d4b9122b54642b5744eb8b46e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431556 > Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811566} Bug: 1094303 Change-Id: I7f73c1cb089635d4084b37646307561d235b6a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436766 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#811965}
-
Rob Buis authored
Support multi-keyword syntax for display but only for MathML. Specifically "inline math", "math inline" will be parsed and serialized as "math", and "block math", "math block" will be serialized as "block math". Existing support for "inline-math" is removed since instead the multi-keyword syntax was chosen [1]. [1] https://github.com/w3c/csswg-drafts/issues/5385#issuecomment-690462275 Bug: 6606, 1127222, 995106 Change-Id: Ibc9193dc8a2b09f4463f06c3de31e500ef45b1d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421598 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#811964}
-
Oleh Lamzin authored
iframeReady promise is needed to be sure that iframe is ready for incoming messages. Otherwise postMessage to the iframe will be failed. Bug: b:158566609 Change-Id: I65cdb7fb23bdda49b931500ab12d45eddba2ca65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424318Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#811963}
-
Fredrik Söderqvist authored
This functions is only used by the SVG layout tree dumper, so move it there as part of deconstructing SVGPaintServer and related classes. Make SVGPaintDescription strictly an implement detail now that it's not exposed. Bug: 109212 Change-Id: I924603534154de84e0726cb4b9164ad558b0f157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435191Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#811962}
-
Kent Tamura authored
Text field inputs in LayoutNG might not use a subclass of LayoutTextControlSingleLine. We should avoid operations on it. LayoutTextControlSingleLineTest doesn't need to use LayoutTextControlSingleLine, and LayoutBox is enough. This CL has no behavior changes. Bug: 1040826 Change-Id: Ica5a0acbf532b5a781b515d0ce9de1c4262abac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437721 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#811961}
-
