- 18 Nov, 2020 40 commits
-
-
Jan Krcal authored
This CL changes the logic to load the startup profile whenever the profile picker should be loaded. It instead loads the guest profile to indicate the picker should be open. This speeds up showing the picker when the last profile used is heavy to load. The CL also unifies the logic to decide whether to show the new picker (or the old user manager) into one function, GetStartupProfile(). There is one behavioral difference: the new code directly opens browser windows if the user had multiple profiles open last time. This is desired because having multiple profiles open simultaneously the last time is a strong signal the user wants to continue this way. Note that having multiple profiles open the last time happens only in limited situations, e.g. via chrome://restart or via session restore (when logging out / switching off the machine with multiple profiles' windows open). Bug: 1150330 Change-Id: Iae9744f44bc242e9aaaf8f287cc29e1089326786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532460 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#828665}
-
Alice Wang authored
This CL adds a test for the method AccountPickerDelegate#isIncognitoModeEnabled(). Bug: 1149866 Change-Id: I81518ee322d7942ff2482e85683c04a2acf216e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544943Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#828664}
-
Fergus Dall authored
CL:2374267 renames most crostini tests, so update the list of disabled tests to match. This CL retains both old and new versions to avoid breaking things while waiting for an LKGM uprev. Bug: 1128743 Change-Id: I168bfce067611be7ae8ac7b081c1cb347ff8d05f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462964 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#828663}
-
Omar Morsi authored
This cl records the number of times the arc usage flags update started as well as the number of times it succeeded and failed. Bug: 1140105 Change-Id: I01acabb9d34b3c643db5d63773ad268c9339db51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541522Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#828662}
-
Roman Sorokin authored
The function is not called. Bug: 1100910 Change-Id: Ib014f5bb88e542c0e5663c3fd01b34a7e34edddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546761 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#828661}
-
Kuo Jen Wei authored
To preload image assets used by css, this CL add new BUILD.gn target generating images into a js file under '/js/preload_images.js'. When launching camera app, wait until images are loaded to show camera view. Bug: b/172342439 Test: ./cca deploy <DUT> Test: pass closure compiler Test: Manually on DUT Change-Id: I9ee8f73d0eed56c0002180259951235b6d0e642e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531439 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#828660}
-
Xiaocheng Hu authored
The class will become more complicated with counter text generation algorithm included. Hence, this patch moves it into its own files for a better file structure. Bug: 687225 Change-Id: Id6bc85929bbf182c74e9eb9ceb85155b5e07fb52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545488 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#828659}
-
Swapnil authored
There are several browsertest related to browsing history and SSL error overriding policy. This CL splits these tests to new file. Bug: 1148745 Change-Id: I6d8eb679aa84289694cdcb534ebf836dbde4e7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544944Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#828658}
-
Jasmine Chen authored
Removes the DCHECK in CameraHalDispatcherImpl::RegisterClient. This is failing DCHECK because ArcCameraBridge would call RegisterClient on its own thread directly. Bug: b/173577612 Test: Build simplechrome Change-Id: I919a717765aef085b58552de5cf3f9dd167388d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546309 Commit-Queue: Jasmine Chen <lnishan@google.com> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Jasmine Chen <lnishan@google.com> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#828657}
-
Makoto Shimazu authored
The test sometimes fails due to timeout on Windows. This CL splits the test into two to mitigate the workload. Bug: 1002377, 1150000 Change-Id: I1cfb2198b304cc21e3aeb9dc00b4db66e7eeb4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546145 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828656}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aaee0317d442..c4892cc595ba 2020-11-18 szuend@chromium.org Properly export 'rangeOfWord' as a standalone function If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I028ca61c4c89762c8291494d33c5b7c4cce2721b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828655}
-
Alice Wang authored
This CL moves the incognito interstial instrumentation test to its own module. Bug: 1149867 Change-Id: If4b8bc80580c925d015e7ca896ce7eb070e74fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544683 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#828654}
-
Omar Morsi authored
Bug: 1129764 Change-Id: I72d681f60e666b8c53b1bc5b3e03737b0abb1891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544725Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#828653}
-
Roman Sorokin authored
Use ShowGaiaDialog instead. Bug: none Change-Id: I645e5b1d1c013dc1597a4f5291f10429a834c147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536633 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#828652}
-
Antonio Sartori authored
X-Frame-Options violations are logged via a console message in the parent frame. To avoid leaking sensitive data to the parent frame, let's report as "blocked url" just the origin of the blocked frame's url, as we are already doing for the frame-ancestors CSP directive. Bug: 1146651 Change-Id: If5e5ac62f7e44e714b109e6adc389f11999e0f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534851 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#828651}
-
Asami Doi authored
This CL adds a test case to the existing WPT to check if clients.claim() for a blob URL worker works well. Currently, the test fails when the PlzDedicatedWorker feature is enabled. It will be fixed in another CL. Bug: 1017034 Change-Id: I39adf7364f6f60ea50efa28b96b27b7e67bc2b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531805Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828650}
-
Robbie McElrath authored
This CL removes the fake FragmentActivity from SiteSettingsFragmentImpl and MediaRouteDialogFragmentImpl, replacing them with a Context that hosts the fragments instead. This is possible now that we've landed the bytecode rewriting that changes the return type of Fragment.getActivity() from FragmentActivity to Activity. Bug: 1123216 Change-Id: I98c2c07eb348d6833ca2e5d976110f7f29b5359e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523751 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#828649}
-
Roman Sorokin authored
Instead of triggerring Gaia IME on the Gaia async load - which might happen even if the dialog is hidden. Also fixed ExistingUserControllerAuthFailureTest.CryptohomeMissing test which had a wrong expectations. Should show Gaia reauth page for the missing cryptohome user. Bug: 1140239 Fixed: 1150142 Change-Id: Idc722bfbd4f5b6418f6f2751b32e4bd9cc8ebf60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536872Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828648}
-
Kim-Anh Tran authored
Bug: chromium:1110202 Change-Id: Iae6728a93d012704838306ff6824a41b399e24ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545306Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/master@{#828647}
-
Peter Boström authored
Adds a missing checkbox->SetChecked() call to set the initial state on the views side. Bug: 1150027 Change-Id: I2fcf4d26ccd5358efbd7247c9533877da6643853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546188 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#828646}
-
Dan McArdle authored
Currently, DnsHTTPAttempt does not set the accept-encoding header. URLRequestHttpJob::AddExtraHeaders() has been stepping in, typically choosing "gzip, deflate, br". If the DoH provider honored this request for compression, it would effectively strip padding from the DNS response, which is a privacy leak. To be clear, I have not observed any DoH providers compressing their response. It just seems prudent not to request compression that we do not want. Bug: 1051615 Change-Id: I0cad558f76298b7ed58de70b70b1954cd42b88f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546476Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#828645}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I6e353680e14310488251bd90249579e2d1a2d81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546263Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828644}
-
Robbie McElrath authored
This CL updates the bytecode modifications we perform on Fragment.getActivity() to have it call ContextUtils.activityFromContext( getContext()), and modifies compile_java.py to detect compilation errors related to this change and print a message pointing you to documentation about the bytecode modifications. A compilation error will now print: ../...../PasswordEntryEditor.java:144: error: cannot find symbol getActivity().getSupportFragmentManager(), ^ symbol: method getSupportFragmentManager() location: class Activity Expecting a FragmentActivity? See docs/.......md Bug: 1123216 Change-Id: I04016e30fba46c7d5c592e9ab2c5e5fa4c4cfde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508352 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#828643}
-
Matthias Körber authored
Change-Id: I9b1467d5f34d9381c8f944009b8f7511063fa30e Bug: 1150004, 1148749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544706 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#828642}
-
Hirokazu Honda authored
Original V4L2VideoEncodeAccelerator checks that the natural size of every VideoFrame with the dimension to be encoded. They must be the same in single cast case, but can be different in multicast case. The correct check is to compare it with the natural size of the first VideoFrame. In other words, the natural_size must be unchanged during encoding in the same VideoEncodeAccelerator instance. Bug: b:172223525 Test: meet.google.com on trogdor Change-Id: I3c21782b86cddaa788d4daf785793f73ec49db9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541942Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#828641}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605657601-ef8205b17022e19a0e2738465ae8904490a43974.profdata to chrome-linux-master-1605679120-9f3476b66a4fad3e32e51dc995f45ad61750f20a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib50c20fbe04914b339a8de85585ddab0f6263066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546640Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828640}
-
Maggie Cai authored
This CL updates the intent picker bubble view code to close and clear the existing intent picker bubble if the code trying to show another intent picker bubble. During testing, I found out that showing a new intent picker bubble when there is already a bubble showing will crash the browser. And there are suspected crash report that possibly relate to this. BUG=1148517, 853604 Change-Id: Ibf720342acf73602608278ca48f71435a9e61e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539808 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#828639}
-
Jaeyong Bae authored
This patch enables applying style to pseudo-elements when a property is defined on ::first-line. Currently, the properties on the ::after and ::before pseudo-elements are not applied on the first-line. So, we support kPseudoIdFirstLineInherited for the ::before/::after elements. Bug: 862423, 892983 Change-Id: I9474eece66921b8073091459cc254d5d1e27a9cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517339Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#828638}
-
Antonio Sartori authored
The Content Security Policies code under services/network and the relative mojo types still misses support for a few CSP directives. We need to support all CSP directives in order to use it as a replacement to the Blink types, and also if we want to add Content Security Policies to the Policy Container (see attached bugs). This CL implements support for the directive 'require-trusted-types-for'. Bug: 1021462,1149272 Change-Id: I32880e8b3e35f1db4acf92a40e5d167a5f76870a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539906Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#828637}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2981f64209b4..aaee0317d442 2020-11-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I98f14a012a2f04a5164beb8b20754b100d1c3480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545367Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828636}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I4496e16926e171cbaa4bc68b92d39490a07c1cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531811 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#828635}
-
Alice Wang authored
This CL extracts an interface for the AccountPickerDelegate implementation to facilitate the account_picker package modularization in the future. Bug: 1149858 Change-Id: I9ddd1504da50e7feb71289a88831f1128537a28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542788Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#828634}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605646753-b6e30e01e5beed347db34dbd1e74ff9cda422393.profdata to chrome-win64-master-1605657601-548324a0b0ab154da49d0cf44438a7e310772c46.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6719157e8e917c490d47b380d4cf4dfc2a446ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545051Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828633}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605625046-c4965d9d21c1b70d5de168d81c9caa876a4c61e1.profdata to chrome-win32-master-1605646753-d9430b027373a1a39dfc015bcf61461b4f7377b7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I12647a085f9a08f970825dbf22d3a5bc37734608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545436Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828632}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I47860f50a1428ebfe0b5276dc7ad58ad4512bc57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532482Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#828631}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6aeb414df947..a1112b326a79 2020-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from f2bc3b3edd6f to a0758a1aef12 (5 revisions) 2020-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 4f96bf19941b to 2ffff6d024c7 (21 revisions) 2020-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 04515da400d5 to bb96f79d0e15 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Test: Test: Test: ExternalBufferTestES31.*VulkanTest: Test: ProgramPipelineTest.GenerateProgramPipelineObjectEXT* Change-Id: I36b49c2a75e5baa93dc34137c02ddf22def9064b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546264Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828630}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ibe63a58f20c536f639c7d5af640df4f37ce460c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494280 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#828629}
-
Kimiyuki Onaka authored
This interface receives the content of /sys/fs/pstore/dmesg-ramoops-0 for crash reporting of kernel crashes of ARCVM. The CL to send the ramoops file is ag/12946959. Bug: 139650101 Test: tast run arc.KernelCrash.\* Change-Id: Ie38d4054f5a4c4d0cb4d45e53d825bb1be21dbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505708Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kimiyuki Onaka <kimiyuki@google.com> Cr-Commit-Position: refs/heads/master@{#828628}
-
Ramin Halavati authored
AnnouncementNotificationService unittest is updated to cover ephemeral Guest profile. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I319f7808365157108a984328bf65de586160c151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537692Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#828627}
-
Jiewei Qian authored
This reverts commit 38feda4d. Reason for revert: Observed test failure on Linux ChromiumOS MSAN build. use-of-uninitialized-value during CaptureModeController::Start() This CL makes significant changes to CaptureModeController. See https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21350 Original change's description: > capture_mode: Recording service lifetime and APIs > > This is a follow-up CL to handle requests made on the recording > service CL (https://crrev.com/c/2404145): > - The Record*() APIs of the service should provide the needed client, > video capturer, and audio stream factory, instead of exposing APIs > in the client so that anyone can bind to those capturers. > - The service is launched to handle video recording, and terminated > once recording ends, and all the chunks have been sent. > - A GPU crash is handled by ending the recording. > > BUG=1126586, 1147989, 1143411 > TEST=Manually, existing tests. > > Change-Id: I235cb1f9ee81dbbc42e21d0a222d32bcafa7a0fd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536030 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828574} TBR=jamescook@chromium.org,dcheng@chromium.org,afakhry@chromium.org Change-Id: I80c5b69f89fa4eb32d3cbd065729d314d076ae4d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126586 Bug: 1147989 Bug: 1143411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546348 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#828626}
-