- 24 Oct, 2018 40 commits
-
-
Dale Curtis authored
BUG=898642 TEST=none TBR=pfeldman Change-Id: I1d67c0cdc9da3444d2b28c4a0c1cb323cbc59f83 Reviewed-on: https://chromium-review.googlesource.com/c/1298413Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#602514}
-
Xianzhu Wang authored
TBR=wangxianzhu@chromium.org Change-Id: I15be67b385349af7da4c47d3763ba08c5141061d Reviewed-on: https://chromium-review.googlesource.com/c/1297986Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602513}
-
Katie D authored
This works by starting the drag on the first dwell and ending the drag on the second dwell, and rewriting mouse moved events to mouse dragged events in between. This is still hidden behind the accessibility flag. Bug: 894907 Change-Id: Ia2cd72053e3d1023711764e2b581caa686f2fb98 Reviewed-on: https://chromium-review.googlesource.com/c/1295250 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#602512}
-
Ted Choc authored
This internally introduces a property model to SuggestionView and moves some of the logic to it. It also splits out the init call to primarily be operating on the model. After this the init call should be moved entirely out of the view and the binder should be pulled out too. BUG=898522 Change-Id: I5db1bb30c45cb4e63d7bfee75b2457817cfb6864 Reviewed-on: https://chromium-review.googlesource.com/c/1298213 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#602511}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/00455e014868..bdcfce54a8d5 git log 00455e014868..bdcfce54a8d5 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 kbr@chromium.org Print Telemetry's help in run_browser_tests. 2018-10-24 kjharland@google.com Whitelist Fuchsia Global integration CI builder Created with: gclient setdep -r src/third_party/catapult@bdcfce54a8d5 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:898602 TBR=sullivan@chromium.org Change-Id: Ibcf2b7266600cb78dae90a2f90624eba5a72225d Reviewed-on: https://chromium-review.googlesource.com/c/1298167Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602510}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/334f03f88fc4..062e25f6a6b0 Created with: gclient setdep -r src-internal@062e25f6a6b0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If598b81c5623635fc409ab73be606b5b3632cf43 Reviewed-on: https://chromium-review.googlesource.com/c/1298166Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602509}
-
Matt Mueller authored
PKP persistence was removed as part of https://crrev.com/230996f183bc6eb2f8ec2a39f7d19f9d6267ec84 Bug: 779166 Change-Id: Ic8dcc6a983f08418465b301e99e0bd226521e073 Reviewed-on: https://chromium-review.googlesource.com/c/1297286Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#602508}
-
Hector Carmona authored
This is usually a sign that an include path is incorrect. R=scottchen@chromium.org Bug: NONE Change-Id: Id382b43eeeb967fe727a05e81b152091cbcc000e Reviewed-on: https://chromium-review.googlesource.com/c/1297278Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#602507}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/19603b9e7b20..c3ee7ec01dda git log 19603b9e7b20..c3ee7ec01dda --date=short --no-merges --format='%ad %ae %s' 2018-10-24 geofflang@chromium.org Implement EGL_ANDROID_image_native_buffer. Created with: gclient setdep -r src/third_party/angle@c3ee7ec01dda The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I79406ba81a46c9d863ac22f6b092d1df7a5335de Reviewed-on: https://chromium-review.googlesource.com/c/1298259Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602506}
-
Krishna Govind authored
R=cmasso@chromium.org Change-Id: I2f41fe40066107c51b3054b05a084f50e0a0213e Reviewed-on: https://chromium-review.googlesource.com/c/1298200Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#602505}
-
Daniel Cheng authored
since the set only contains string constants, using base::StringPiece is more efficient. base: :flat_set is typically more efficient than std::set. In addition, Change-Id: Id92f2e6008415f3091a08fc407303c0705c69d20 Reviewed-on: https://chromium-review.googlesource.com/c/1298073Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#602504}
-
Joshua Bell authored
A few cases noted in storage API backends. Change-Id: I8282bdead392b970bf3d34d20921fbe02aa80572 Reviewed-on: https://chromium-review.googlesource.com/c/1298248 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#602503}
-
Scott Graham authored
This happens to fail on Fuchsia, but is just generally not IWYU. Bug: 808287 Change-Id: I46c8527f0becf79d10c4e960a083e4b9e8eb8bc7 Reviewed-on: https://chromium-review.googlesource.com/c/1298241Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602502}
-
Darren Shen authored
Full width virtual keyboard on multiple displays was broken because we made an assumption that we only attach the virtual keyboard to a root window at initialization. Actually, it can be called whenever the keyboard changes displays. So we should actually be maintaining the same bounds whenever we attach to a new root window. Unfortunately, floating keyboard on multiple displays looks utterly broken...but that's a separate issue. Bug: 897007 Change-Id: I6392a790cd172cd3899c2c0b3cfd41f31a096fbc Reviewed-on: https://chromium-review.googlesource.com/c/1296948Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#602501}
-
Maks Orlovich authored
Bug: 893971 Change-Id: I9340eef7af2d6c414dcc3d9ce2d3829f2a5cfaaf Reviewed-on: https://chromium-review.googlesource.com/c/1298296 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#602500}
-
Paul Meyer authored
attribute. Change-Id: I32c8821aec5a32b5dfdeb44db4a48e719ec0205b Reviewed-on: https://chromium-review.googlesource.com/c/1236493Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#602499}
-
Scott Graham authored
Bug: 808287 Change-Id: I412c47c632f3dc3042e324939e9a241522cb7a33 Reviewed-on: https://chromium-review.googlesource.com/c/1297277Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602498}
-
Sadrul Chowdhury authored
This reverts commit 5c2e137d. Reason for revert: crbug.com/898127 Original change's description: > viz: Throttle begin-frames when gpu is busy. > > Throttle begin-frames to clients until gpu is done processing the > earlier swaps. This helps with reducing work when the gpu has a high > load, by not sending begin-frames to clients. > > The clients always keep receiving the compositor-frame-ack messages > when a surface becomes activated (or replaces an older pending frame), > even if the gpu is busy doing work from earlier frames. So this change > introduces the back pressure by way of withholding begin-frames so > clients have to do less work. > > BUG=877906 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: If34eb5c5af03961e17932c8f57caf352d0362bab > Reviewed-on: https://chromium-review.googlesource.com/c/1282219 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601383} TBR=sadrul@chromium.org,fsamuel@chromium.org,sunnyps@chromium.org,piman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 877906, 898127 Change-Id: I3a21b59feacaa5152e187bc4483336abd5254b5e Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1298333Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#602497}
-
Xi Cheng authored
Previously, a pointer to the NotificationImageRetainer object is stored in NotificationTemplateBuilder. This is unnecessary as this object is only used by two private methods called within Build() and never used again. This CL changed to pass the pointer into those functions directly. Separately, a GetCleanupTask() method is added for NotificationImageRetainer so that it doesn't need to expose AsWeakPtr() to the public. Bug: 888276 Change-Id: I4a7fa2a39e30c739f9adb7021b4809a4b56062fa Reviewed-on: https://chromium-review.googlesource.com/c/1292712 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#602496}
-
Scott Graham authored
Bug: 808287 Change-Id: Id50a9e5e45428fe155d0de4059486b14ee71f11b Reviewed-on: https://chromium-review.googlesource.com/c/1298414 Commit-Queue: Scott Graham <scottmg@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#602495}
-
rbpotter authored
In Polymer 2, shouldExpandSettings_ is called when the computed property shouldShowMoreSettings_ is undefined, and returns true in this case, resulting in a flash of the expanded settings. Return false unless shouldShowMoreSettings_ is set to the boolean value of false. Bug: 898100 Change-Id: I7154772921c59ba24ba1c80901da4b962305eeac Reviewed-on: https://chromium-review.googlesource.com/c/1297605Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#602494}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b6c3804254e9..7100fff13dd0 git log b6c3804254e9..7100fff13dd0 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 dgarrett@google.com cros_mark_as_stable: Force list type. Created with: gclient setdep -r src/third_party/chromite@7100fff13dd0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I88bafc5322a1faa8602f2ab5e48158bb879a366d Reviewed-on: https://chromium-review.googlesource.com/c/1298165Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602493}
-
Tim Volodine authored
Recent patch by boliu@ [1] introduced delayed onPageStarted callback and now requires |is_renderer_initiated| member to be set in AwContentsClientBridge.onReceivedError [2]. The following tests are impacted and are currently crashing because of that: - org.chromium.android_webview.test.ClientOnReceivedErrorTest.testNonExistentAssetUrl - org.chromium.android_webview.test.ClientOnReceivedErrorTest.testNonExistentResourceUrl - org.chromium.android_webview.test.ClientOnReceivedErrorTest.testOnReceivedErrorOnInvalidUrl - org.chromium.android_webview.test.ClientOnReceivedError2Test.testNotCalledOnStopLoading - org.chromium.android_webview.test.ClientOnReceivedError2Test.testOnNonExistentAssetUrl - org.chromium.android_webview.test.ClientOnReceivedError2Test.testOnNonExistentResourceUrl - org.chromium.android_webview.test.ClientOnPageStartedTest.testOnPageStartedCalledOnceOnError This patch fixes the issue. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1270096 [2] https://cs.chromium.org/chromium/src/android_webview/browser/aw_contents_client_bridge.cc?l=440 BUG=897750,841556 Change-Id: I3e20e5317a86a0cfe479cef270cc7f9ae933b066 Reviewed-on: https://chromium-review.googlesource.com/c/1293581Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#602492}
-
Robert Liao authored
AnimatedImageViews that never receive an animated image and are never started should not DCHECK(animated_image_) at AnimatedImageView::Stop. BUG=890221 Change-Id: I519e826861870a3c7cee623667dc7e1b92369dbd Reviewed-on: https://chromium-review.googlesource.com/c/1298228Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#602491}
-
Collin Baker authored
Bug: 887991 Change-Id: I30849f971071d73b42970927abc12a4259fc73c2 Reviewed-on: https://chromium-review.googlesource.com/c/1295187Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#602490}
-
Oystein Eftevaag authored
R=chiniforooshan@chromium.org Change-Id: I4ddf86ca1ac051593689806a2282ad24b2e694c8 Reviewed-on: https://chromium-review.googlesource.com/c/1298229 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602489}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2d123ad73f85..4f598e8c829a git log 2d123ad73f85..4f598e8c829a --date=short --no-merges --format='%ad %ae %s' 2018-10-24 brianosman@google.com GrColor4s, a fixed-point signed short type for wide color vertices 2018-10-24 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-24 reed@google.com more setters for SkFont 2018-10-24 brianosman@google.com Align trace event allocations to avoid alignment issues on 32-bit ARM Created with: gclient setdep -r src/third_party/skia@4f598e8c829a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@chromium.org Change-Id: I695951301f2fd847800928a224b1552998259176 Reviewed-on: https://chromium-review.googlesource.com/c/1298164Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602488}
-
Eugene But authored
This is the only file where ForceViewRendering is used. Bug: None Change-Id: I0091cb7182bde45ebb2d3b22c63a366bab0afc56 Reviewed-on: https://chromium-review.googlesource.com/c/1294399 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#602487}
-
Matt Menke authored
It was only being used in one test (Which no longer needs it) and internally in net, so it's no longer needed. Net internally now uses a bool taken from the HTTP session, which it can also assume to be constant for the lifetime of the network stack. Also switches the |load_flags| parameter for SSLSocketParams to an |ignore_certificate_errors| bool, since the only flag that mattered at that layer was the now removed LOAD_IGNORE_ALL_CERT_ERRORS. Bug: 533571 Change-Id: Ie2562ba2e82086b6478a343680f9094e95fe365d Reviewed-on: https://chromium-review.googlesource.com/c/1297470 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#602486}
-
rbpotter authored
In Polymer 2, setting background-color for paper-fab directly overrides the value applied when the paper-fab has keyboard focus, as well as the normal value. paper-fab provides a mixin for setting the background color. Using this mixin sets the default background color correctly, and allows the background-color styling that overrode the styling for :host(.keyboard-focus) to be removed. Bug: 897595 Change-Id: I7332d57b822286c884ef6ca7a32d6b890130a5e3 Reviewed-on: https://chromium-review.googlesource.com/c/1297629Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#602485}
-
Sam Maier authored
Bug: 898251 Change-Id: Iad2680ad461007baa99aff5da0b0b6cabcaf88e6 Reviewed-on: https://chromium-review.googlesource.com/c/1298357Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#602484}
-
mrefaat authored
This was replaced by the view inside PagePlaceHolderTabHelper. Bug: 898544 Change-Id: I077b13abcf0220100d1bb0fec4d39672b8a4fdc6 Reviewed-on: https://chromium-review.googlesource.com/c/1297459Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#602483}
-
Tom Tan authored
Chromium task manager static_asserts on Windows structure SYSTEM_THREAD_INFORMATION and SYSTEM_PROCESS_INFORMATION, but it assumes non-x64 is x86. Fix this for Windows ARM64. Bug: 893460 Change-Id: I1face62bdb617c1d62fcdc3d1e2540eecaa45878 Reviewed-on: https://chromium-review.googlesource.com/c/1297394Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#602482}
-
Jeremy Roman authored
Narrow the scope of blocking observation in ThreadConditionTest to the single Wait call of interest. Bug: 897550 Change-Id: Id34dc044bb6c5bd5e177d405015fdd909827ce18 Reviewed-on: https://chromium-review.googlesource.com/c/1298346 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#602481}
-
Wenzhao Zang authored
Bug: 812085 Change-Id: Ia2bf565c0ff5e5cd43e94079ae41b7a0be614430 Reviewed-on: https://chromium-review.googlesource.com/c/1297356Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#602480}
-
Kenneth Russell authored
conformance/rendering/canvas-alpha-bug.html is failing on this configuration on 10.13 and later. Rather than specialize the suppression for multiple OS versions, suppress it on this GPU type. Tbr: jdarpinian@chromium.org No-Try: True Bug: 886970 Change-Id: Ifeeaa59aca1c232b3d3eda6b2a82b35451c8a2bc Reviewed-on: https://chromium-review.googlesource.com/c/1298199 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602479}
-
edchin authored
Enable the experiment to return to regular tabs when closing last tab. Bug: 891396 Change-Id: I0a0784c901fc0f19508fdf5db612c350ed8d38ef Reviewed-on: https://chromium-review.googlesource.com/c/1297177Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#602478}
-
Malay Keshav authored
When initializing a RecordPaintCanvas, the size set should be in pixels. Right now we are setting the DIP size which is resulting in PaintOps that are outside the clip bounds to be rejected all together. This patch also adds a DCHECK to ensure that the clip bounds set on the canvas matches the expected pixel size of the rasterized image. Bug: 896203 Change-Id: I10cf95bc656950c217d3ae464f277a0cb7140063 Component: CanvasImageSource Reviewed-on: https://chromium-review.googlesource.com/c/1296687 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#602477}
-
Ken Buchanan authored
Dragging the frame dividers of a frameset should cause that RenderWidget to receive all mouse input until a MouseUp is received, otherwise the mouse moving over cross-process content, such as a PDF or an OOPIF, will cause the resize to stop. This CL triggers mouse capture in that case. Bug: 878007 Change-Id: I96c4855954799c5f03d7dfc697ad399a31a561dd Reviewed-on: https://chromium-review.googlesource.com/c/1298222 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#602476}
-
Scott Graham authored
I'm not sure if this will be correct until these tests can run, but this will at least compile, as opposed to using the Windows version. Bug: 808287 Change-Id: I2f112f9ab2575abc88d1495ba324cdcc15cde4a7 Reviewed-on: https://chromium-review.googlesource.com/c/1298299Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602475}
-