GitLab

Implement the new design of SSL certificate dialog. Remove underline in hyperlink textview and add paddings around textviews. Refer to https://drive.google.com/a/google.com/file/d/0B6x6iYCtKinEUElmYWRWVlh5RlE/view for design specification.

BUG=394564

Review URL: https://codereview.chromium.org/409003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285181 0039d316-1c4b-4281-b951-d872f2087c98

Server-side throttling is sufficient to avoid abuse of the bookmarks API.

BUG=307982

Review URL: https://codereview.chromium.org/411053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285180 0039d316-1c4b-4281-b951-d872f2087c98

Use the OS-specific range for packed relocation extension DT_ tags.
Name throughout as DT_ANDROID_REL_ rather than DT_ANDROID_ARM_REL_.
Change test data to match.

BUG=385553

Review URL: https://codereview.chromium.org/407093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285179 0039d316-1c4b-4281-b951-d872f2087c98

Currently when an extension/app requests "*://*.google.com/*" permission they get the following install-time warning ".. your data on *.google.com". This CL will change the message to: ".. your data on all google.com sites"

BUG=362360
R=jww, meacer

Review URL: https://codereview.chromium.org/404823009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285178 0039d316-1c4b-4281-b951-d872f2087c98

The hid module defines functions for encoding HID descriptors. These
descriptors are much more free-form than USB descriptors so a different
approach was taken in this module.

BUG=396682
R=rockot@chromium.org,rpaquay@chromium.org,kalman@chromium.org

Review URL: https://codereview.chromium.org/410813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285177 0039d316-1c4b-4281-b951-d872f2087c98

BUG=177419
TEST=browser_tests
R=estade@chromium.org, vadimb@chromium.org

Review URL: https://codereview.chromium.org/407083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285176 0039d316-1c4b-4281-b951-d872f2087c98

If the WebSocket handshake was cancelled immediately after the connect
succeeded before the ClientSocketHandle was fully initialised, then the
socket would not be released back to the pool, and as a result the
endpoint would not be unlocked.

Fix by actively reclaiming the socket in
WebSocketTransportClientSocketPool::CancelRequest().

Also add a test for this condition.

BUG=394268, 389084
TEST=net_unittests

Review URL: https://codereview.chromium.org/394113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285175 0039d316-1c4b-4281-b951-d872f2087c98

Fixes regression that happened when moving to the new AXTree code.
Improves on it by only sending location changes when there's an
AXLayoutChanged event, since that will always be fired when there's a
layout and objects might have moved.

To make it testable, adds a new feature to DumpAccessibilityTree tests
where you can make it wait until a certain magic string appears in the
dump before the dump is diffed with the expectation. In this test, we
start a CSS transition that animates changing a button's size, and make
sure the final dump reflects the final size.

BUG=268296

Review URL: https://codereview.chromium.org/401643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285174 0039d316-1c4b-4281-b951-d872f2087c98

Changed all instances of superfluous InProcessBrowserTest::CleanUpOnMainThread()
API to use BrowserTestBase::TearDownOnMainThread() instead.

BUG=381181
TBR=rockot@chromium.org,sky@chromium.org,nkostylev@chromium.org

Review URL: https://codereview.chromium.org/366813007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285173 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves the method implementations out of the WindowManagerImpl class
declaration.

BUG=None
R=flackr
TBR=oshima

Review URL: https://codereview.chromium.org/406393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285172 0039d316-1c4b-4281-b951-d872f2087c98

HistoryService no longer use CancelableRequest{Consumer,Producer} but
CancelableTaskTracker instead so remove the code that supported the
old API.

Fix the DCHECK in the methods of HistoryService that use thread_.

BUG=371818
TBR=sky

Review URL: https://codereview.chromium.org/369503007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285171 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds the feature to controls a video on Chromecast using CastVideoElement and Cast Extension.

BUG=305511
TEST=List of casts is shown
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/412813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285170 0039d316-1c4b-4281-b951-d872f2087c98

Create TtsControllerImpl so that TtsController can serve
as TTS interface once it is moved to content in future.
The approach is similar to SpeechRecognitionManager.
This is part of an effort to move TTS to content.

BUG=347045

Review URL: https://codereview.chromium.org/412783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285169 0039d316-1c4b-4281-b951-d872f2087c98

regressed in r279316

BUG=391316

Review URL: https://codereview.chromium.org/397293005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285168 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/405483005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285167 0039d316-1c4b-4281-b951-d872f2087c98

Implementing the BezelController class responsible for detecting bezel gestures.
Adding the bare skeleton of the SplitViewController class which is going to be
responsible for the split view mode.

BUG=383421

Review URL: https://codereview.chromium.org/394833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285166 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285163 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178778:178800&mode=html
TBR=pkasting@chromium.org,haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/418713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285162 0039d316-1c4b-4281-b951-d872f2087c98

As per UI review, moved the version in the App Info Dialog from the
header section to its own Details area. Also cleaned up and
simplified a lot of the code that laid out the name and version in
the header since, now that there's no version displayed there, its
no longer needed.

BUG=386871

Review URL: https://codereview.chromium.org/383953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285160 0039d316-1c4b-4281-b951-d872f2087c98

This patch introduces structure that should be filled with all
print preset options that we need to get from PDF and set in print
preview.

Before this patch one message was being sent to browser to set PrintScaling
property but going forward, more properties will be supported and so
it is better to send only one message with all properties set in one structure.

BUG=169120

Review URL: https://codereview.chromium.org/388783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285159 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285158 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:

Need to fix components_unittests on iOS simulator (try was green, but test actually failed)

Original issue's description:
> android tests: don't override DIR_MODULE
> 
> BUG=
> R=brettw@chromium.org, nyquist@chromium.org, phajdan.jr@chromium.org, sky@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285096

TBR=nyquist@chromium.org,brettw@chromium.org,sky@chromium.org,phajdan.jr@chromium.org,jamesr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/417943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285157 0039d316-1c4b-4281-b951-d872f2087c98

This object is owned by the MojoWebUIController, not bound to the pipe.

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/419433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285156 0039d316-1c4b-4281-b951-d872f2087c98

Likely failure is due to http://crbug.com/396300. Disable until I can
investigate more thoroughly.

TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/414893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285155 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/415773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285152 0039d316-1c4b-4281-b951-d872f2087c98

BUG=363047
TEST=Open a browser in guest mode on Mac. Open Preferences, chrome://settings should open in the same browser.

Review URL: https://codereview.chromium.org/411573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285151 0039d316-1c4b-4281-b951-d872f2087c98

Now AppSyncUIState has ExtensionRegistry to listen extesnions's notification
To make sure ExtesnionRegistry is destroyed after AppSyncUIState.
AppSyncUIStateFactory should depends on ExtensionRegistryFactory.

BUG=354046

Review URL: https://codereview.chromium.org/411093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285150 0039d316-1c4b-4281-b951-d872f2087c98

The user can control settings that might be normally changed using sliders by sliding along the edge of the screen when ChromeVox is on. For example, the user can slide along the right edge of the screen and adjust the volume.

If the user enters this mode and leaves the boundaries without releasing their touch, they will stop adjusting the setting, however, they will not enter touch exploration. If they return to the given boundaries, they will be able to modify the setting again. If the user does not touch a "hot edge" of the screen, they will not enter this state if they move to the an of the screen. 

BUG=393326

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284819

Review URL: https://codereview.chromium.org/385073009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285149 0039d316-1c4b-4281-b951-d872f2087c98

This is a pre-requisite for http server refactoring,
https://codereview.chromium.org/296053012/.

1) Define UnixDomainClientSocket and UnixDomainServerSocket utilizing
   SocketLibevent.
2) Rename UnixDomainSocket to UnixDomainListenSocket to reduce confusion.
3) unittests

BUG=371906

Review URL: https://codereview.chromium.org/376323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285148 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/415793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285147 0039d316-1c4b-4281-b951-d872f2087c98

This will allow us to control the versions of the w3c test repos we
depend on through a file in Blink rather than a file in Chromium; this
makes sense since the tests affect Blink, and it makes it far easier
for us to roll in new versions of the w3c repos.

We also merge in the existing test failures from Blink's TestExpectations
files; as part of this change we are moving the test repos from
LayoutTests/w3c to LayoutTests/third_party, and in order to do this move
we need to move the failures for the old location from a blink-controlled file
to a chromium-controlled file.

This is patch 2 of 4 in the process to move things. This patch depends on https://codereview.chromium.org/410803002 .
R=eseidel@chromium.org
BUG=395862

Review URL: https://codereview.chromium.org/412703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285146 0039d316-1c4b-4281-b951-d872f2087c98

Make the RendererPreferences message struct use enums from
gfx::FontRenderParams instead of defining its own.

This also drops the SYSTEM_DEFAULT values for hinting and
subpixel rendering. They weren't getting used anywhere.

BUG=393243

Review URL: https://codereview.chromium.org/413523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285145 0039d316-1c4b-4281-b951-d872f2087c98

This does:
- Move files
- Fix up all namespaces in these files to be extensions, not apps
- Clean up DEPS files

This does not:
- Change the name of the build targets (app_shell, app_shell_browsertests)

BUG=394987
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/412713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285144 0039d316-1c4b-4281-b951-d872f2087c98

The hid_gadget.HidGadget class implements the basic USB control requests
required by the HID 1.11 specification. It is then extended by
subclasses of hid_gadget.HidFeature which implement the logic behind the
HID report IDs supported by the device.

BUG=396682
R=rockot@chromium.org,rpaquay@chromium.org,kalman@chromium.org

Review URL: https://codereview.chromium.org/410743006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285143 0039d316-1c4b-4281-b951-d872f2087c98

Enable dragging from the main container to the overflow container by opening the
wrench menu when hovering over the button while dragging a browser action. This
also requires keeping the menu open while the drag is happening.

Note: this doesn't fix drag calculations for the overflow menu.
In an effort to keep these patches small, that will come later.

BUG=393038

Review URL: https://codereview.chromium.org/399143004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285142 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395190

Review URL: https://codereview.chromium.org/405083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285140 0039d316-1c4b-4281-b951-d872f2087c98

This adds an InterfaceFactory<Interface> type and allows registering a
service through its provider. Using an InterfaceFactory allows the app
to be in control of the lifetime of the implementation of the interface
and hides all of the implementation details of the interface from the
application library code (i.e. no subclassing impl classes or anything
like that).  The default binding behavior is to bind the lifetime of
the impl to the lifetime of the pipe, but the application
can also weakly bind to a service in cases where it needs to manage
the lifetime explicitly.

Review URL: https://codereview.chromium.org/380413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285139 0039d316-1c4b-4281-b951-d872f2087c98

R=tbreisacher@chromium.org
BUG=395905
TEST=chrome/browser/test_presubmit.py
NOTRY=true

Review URL: https://codereview.chromium.org/410603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285138 0039d316-1c4b-4281-b951-d872f2087c98

Extracted LoginEventRecorder from BootTimesLoader to loose dependecies.

BUG=387613
R=nkostylev@chromium.org
TBR=bauerb@chromium.org
TBR=stevenjb@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284682

Review URL: https://codereview.chromium.org/391373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285137 0039d316-1c4b-4281-b951-d872f2087c98

Its visual style is not really in keeping with the rest of the v2 app,
and the form-factor is not conducive to an easily extensible UI. For now,
a menu will suffice; if we need anything more complex, it can easily be
replaced with an options dialog.

This CL also simplifies the MenuButton class to use stopPropagation instead of timers to prevent the close handler being triggered by the same click that opens the menu.

BUG=134213

Review URL: https://codereview.chromium.org/339613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285136 0039d316-1c4b-4281-b951-d872f2087c98