GitLab

See go/unified-accessibility-component-extensions for additional details.

This creates a new suite, AccessibilityExtension*.*, for common tests for accessibility extensions.

Test: browser_tests --gtest_filter=AccessibilityExtension*.*
Change-Id: I578068985da3793b2bf4ce1c795a4a016b9f4c9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076420
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#747057}

A better fix would require rearchitecting that is beyond me at the moment.

Bug: none
Change-Id: I85ac54cd1cd031035bbe69cc596fc63bf59c5e8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071384
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747056}

This reverts commit ae3270a7.

Reason for revert: Breaks compile on  Android Release (Nexus 5X)

Original change's description:
> Decompose some Blink public mojom targets
> 
> This picks some low-hanging fruit in the effort to decompose Blink mojom
> into smaller targets.
> 
> Bug: 1058621
> Change-Id: Iaf1a8efffa43f64ea7e618555262b929235ca2eb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088677
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#747044}

TBR=rockot@google.com,haraken@chromium.org

Change-Id: Ie248057ff8168c230b347c2eeeb8ba3c8a520d3a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1058621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088646Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747055}

This CL moves chromeOS strings for devices page  from
settings_strings.grdp to os_settings_strings.grdp. It continues
the process of moving all chromeOS specific strings.

Bug: 967883
Change-Id: I903af5b573f9773edefba354a82b93c826c2de11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067390
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747054}

It's suspected that there could be another request coming to the
completion callback, between the final navigation request and the final
assertion. Checking the URL in the completion callback to make sure we
are checking the cache status of the navigation request.

Bug: 1024033
Change-Id: I200f5c44ba72e6abcff7468f0e037a97cdf4fc53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087736Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747053}

https://chromium.googlesource.com/openscreen.git/+log/783d9f6c614f..6ffd816ce45b

git log 783d9f6c614f..6ffd816ce45b --date=short --first-parent --format='%ad %ae %s'
2020-03-04 rwkeane@google.com mDNS: MdnsQuierier Refactor

Created with:
  gclient setdep -r src/third_party/openscreen/src@6ffd816ce45b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: Idb4106f1b942130ec822e341f4edb689004e15d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088465Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747052}

This reverts commit 2f702ab1.

Reason for revert: https://crbug.com/1058627 https://crbug.com/1058583

Original change's description:
> Enable H.264 hardware MFT encoder on Windows
> 
> Currently Microsoft H.264 encoder MFT is always used as WebRTC external
> encoder without hardware acceleration. This change enables H.264
> hardware MFT encoder on Windows.
> 
> Bug: 982799
> Change-Id: Ia33812508034daa99dd3dc1fb64b83cb1d7c8465
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777521
> Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Tommi <tommi@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745539}

TBR=tommi@chromium.org,dalecurtis@chromium.org,sprang@chromium.org,chunbo.hua@intel.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 982799
Change-Id: Iab66c1936f27901889e371901642b72f80eff733
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088733Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747051}

TBR=omerkatz@chromium.org

Bug: 1058622, 986235
Change-Id: I962cffbac427973f05d62251949e743aabf8c2bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087957Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747050}

There seems some cases where ServiceWorkerNewScriptLoader doesn't
call CommitCompleted() and hitting DCHECK that checks if ResourceRecord
has a valid byte size (see comments on the linked bug for details).
This CL addresses such cases by calling CommitCompleted() in the
destructor.

Without this CL I was repeatedly able to reproduce test flakiness
but the flakiness is gone with this CL on my testing environment.

Bug: 946719
Change-Id: I542bb1b66d6ac742cf2b253d757b761989fa0d85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078521
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747049}

Bug: 1055647
Change-Id: I4840e626bcb2882ada6524416849bc7c1c6a8657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077318Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Jason Lin <lxj@google.com>
Cr-Commit-Position: refs/heads/master@{#747048}

After a network is successfully added or updated by Chrome Sync
ensure that the IsAddedBySync bit is appropriately set in the
metadata store.

Bug: 966270
Change-Id: I3eec02cf6390cf42f160136714c74b385f5640ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088175Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747047}

Using wpt-import in Chromium 903f2858.
With Chromium commits locally applied on WPT:
d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching"
acf33020 "Add testing for the scrolling attribute"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=smcgruer

No-Export: true
Change-Id: Id870cda9db514e7d130d0aa21d38cfdd6dd5baa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087479Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747046}

Bug: 981964
Change-Id: I7953289c8aa2aacb5e7886990de243a2b29e131e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951975
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747045}

This picks some low-hanging fruit in the effort to decompose Blink mojom
into smaller targets.

Bug: 1058621
Change-Id: Iaf1a8efffa43f64ea7e618555262b929235ca2eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088677Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#747044}

In cross-thread messaging, the associated execution context can be
already gone when a posted task is performed sometime later in the task
runner's queue.

By using WeakPtr, the task runner will not perform a scheduled task
in the queue when the target object is invalid.

Bug: 1057735
Change-Id: I3f218ad073ff5f6dcb08aba176d722c5c729316b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086051Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747043}

https://skia.googlesource.com/skia.git/+log/93d75eff08b0..628f3e70ee01

git log 93d75eff08b0..628f3e70ee01 --date=short --first-parent --format='%ad %ae %s'
2020-03-04 nifong@google.com Remove experimental from name of skm44 canvas methods
2020-03-04 robertphillips@google.com Surface GrFillRectOp programs on DDLs
2020-03-04 dmazzoni@chromium.org Tiny fix to two attributes of PDF tags
2020-03-04 robertphillips@google.com Surface GrDashOp programs on the DDL
2020-03-04 robertphillips@google.com Surface programs at record time for the oval ops

Created with:
  gclient setdep -r src/third_party/skia@628f3e70ee01

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC herb@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:607777
Tbr: herb@google.com
Change-Id: I8d4bc9614ea8ce62ab660c37e0218745ea50035a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088457Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747042}

Now that we have confirmed that 10000 is the correct limit here,
remove the histogram and add a comment with the relevant data.

Bug: 1053079
Change-Id: Idd767fb995295419f8b97c04960acadf445d56f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083993
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747041}

https://android.googlesource.com/platform/external/perfetto.git/+log/d68f43bd4d5f..97a3ce0918a0

git log d68f43bd4d5f..97a3ce0918a0 --date=short --first-parent --format='%ad %ae %s'
2020-03-04 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "Add convenience script for java heap profiles." am: f82ee37c27

Created with:
  gclient setdep -r src/third_party/perfetto@97a3ce0918a0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I9277bf153d684d34c5da56b341a549bd46b02555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088456Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747040}

TEST: tested with a test device.
Bug: 1042084
Change-Id: I5f7cd1b382b34f62eae6642a719c1123df66133f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083772
Commit-Queue: Jing Wang <jiwan@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747039}

Follow up:
Modify the app block dialog to use the kite icon for the child profile.

BUG=1056488

Change-Id: I53791120a93cffb4f67e90f7a75a934607db51c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081725Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747038}

Adds a generic chrome-untrusted://new-tab-page/image?<image url> page
that creates an iframe displaying the image at |image url|. Uses this
URL to create iframes showing background collection and preview images.

Additionally, add a ntp-untrusted-iframe element that abstracts away
the actual iframe so that we can prevent iframe loading in tests.

Change-Id: I5d3c9c5144382c748615e33960d16b36810e852b
Bug: 1032328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079793Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747037}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Ic3c7eee2d5bd675ce19165918068da5fe2054ad1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088466Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747036}

Adds a custom element implementation courtesy of noel@chromium.org
that handles layout of a set of navigation buttons that elide when
there are more than 4 sub-path entries, and presents a drop-down
menu containing the elided sub-paths.

Hook this custom element into the existing location line code for
files-ng. Add its source file to the BUILD and to closure compile
build dependencies.

Bug: 1035691
Change-Id: I85f7cf3c552320775dd34bbf5cf96a422b355f67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079773
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747035}

This also adds a one-arg Widget constructor as sugar for creating
the widget and then immediately calling Init().  Making more use of
that will happen in a followup patch.

Bug: none
Change-Id: I8de0e64d5d094f99e2365505fde4088a64104b19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076551
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747034}

This change implements the passwordsPrivate.removeCompromisedCredential
extension API. This allows callers to remove a specific compromised
credential from the password store. The caller is informed whether the
remove operation succeeded via a callback.

Bug: 1047726
Change-Id: I9b39fa2350d6d87d551bde06e2baab9ec82bdb3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082384
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747033}

This required moving a few of the other permissions java files as well.
A PermissionsClient.java class was added to call into embedder specific
logic in AndroidPermissionRequester.

We may not need to support infobars in WebLayer, so the bulk of the
infobar logic has been kept in //chrome.

The xtb files for the android strings were generated from the same
script that was used in http://crrev.com/c/1966700.

Bug: 1025609
Change-Id: I6ea6f7380cee4de6590b9a906852fa4b2ce8f89f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083714
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747032}

This is a once callback because it is run whe the EncodeVideoFrame
method completes, as documented in:
* https://cs.chromium.org/chromium/src/media/cast/sender/video_encoder.h?l=27&gsn=FrameEncodedCallback
* https://cs.chromium.org/chromium/src/media/cast/sender/video_encoder.h?rcl=d00d2b00c0d2b47044ea1816d51ad559d2bdcfd3&l=48

This is part of the base::Callback migration.

Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40

Bug: 714018
Change-Id: I3e62ce9a72e632b0aa87dd2d3f839e862b63af6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074503
Auto-Submit: Jose Lopes <jabolopes@google.com>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747031}

The files
- pwa_confirmation_bubble_view*
- web_app_confirmation_view*
- web_app_info_image_source*
do not use extensions, and now appear in
chrome/browser/ui/views/web_apps/

Bug: 953540
Change-Id: I6f496edc3d522d6059f82f46af7f88ba716875d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086464
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747030}

This is to allow us to store information about particular networks
that is not needed by Shill.  To start, this will contain the
timestamp of the last successful connection to Wi-Fi networks.

Bug: 966270
Change-Id: I288d8b990670cd8b541849d762ef0248af4d7152
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085676Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747029}

There are 2 warnings can be displayed on the login screen for the managed
guest session based on the force-install extensions list. Currently the
message is selected based on a static list of white-listed extensions IDs.
This behaviour is extended to decide the warning message based on the
extensions permissions if the extensions ID is not white-listed. The
local state file is updated accordingly, and the default value for the
first time is to display the complete warning message.

The current behaviour for displaying the login screen warnings won't be
switched now to this new behaviour. This will be made in a separate cl.

Bug: 1015378
Change-Id: Ic339e5480794e3c3d084f4290f6faa3ac6e3045e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960281
Commit-Queue: Aya Elsayed <ayaelattar@google.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747028}

Move Clear Browsing Data settings alongside other Browsing Data code,
and update associated OWNERS files.

Bug: 1047357
Change-Id: Idcb8a642beb9ca221b9ad0a56aa523c0b02b580f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075049
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747027}

Based on the UX design linked on Monorail.

Test: All/SplitViewOverviewSession*SquareBracket*
Change-Id: I1a486481f938183b330f65c9b3951767f56937f2
Fixed: 1045990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068895
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747026}

The prefix native_ does not add any meaning here.

Bug: 1040499
Change-Id: If4893a27a178784c1464cd21347a774e15736559
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081421
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747025}

Landing a field trial testing config to change the default referrer
policy led to a number of pings from perf "regressions". Erik Chen
suggested that this might be due to Web Page Replay not acting well when
page JS starts following new code paths (which latter might very
plausibly have happened because the change in question sometimes alters
the return value of a commonly-used JS API). The plan is to reland the
field trial testing config---which re-enables the change in tests---and
re-baseline the perf stories that recorded large (positive or negative)
metric changes: see crbug.com/1056329.

== Begin original commit message

We're going to 50% beta on this feature
(changing the default referrer policy to
strict-origin-when-cross-origin) so it's time to add a field trial
testing config.

Also updates the following tests, which were failing with
the testing config enabled:
- ContextMenuBrowserTest.OpenInNewTabReferrer
- DownloadReferrerPolicyTest.DownloadCrossDomainReferrerPolicy

Bug: 1014207, 1056329
Change-Id: I6fb0006e1f89fd7f2943f102f72caf54fb389716
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044713
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747024}

This CL moves chromeOS strings for settings search page from
settings_strings.grdp to os_settings_strings.grdp. It continues
the process of moving all chromeOS specific strings.

Bug: 967883
Change-Id: Ie04f612f36480376dde981a8d475bb806eb0c44a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070540Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Cr-Commit-Position: refs/heads/master@{#747023}

TBR=haraken@chromium.org, omerkatz@chromium.org

Bug: 1058608
Change-Id: I03330f4aecf276cf994cb34362e3605b616e3886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088637Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747022}

In files-ng, the tool bar info button has a different id #info-button,
than the id #metadata-button used for non-files-ng.

Fix button toggle test: switch on the button name for files-ng. Rename
the test to openQuickViewToggleInfoButtonKeyboard to match the rest of
the test names. Add a openQuickViewToggleInfoButtonClick test to cover
that case while here.

These tests pass in files-ng and not. CL:2082227 deals with the files-
ng case on the bots.

Test: browser_tests --gtest_filter="*QuickViewToogleInfoButton*"
Bug: 992824, 992818
Change-Id: I7b90a70731b2b21d765785930c99e7c5c3f4f0c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087296Reviewed-by: Alex Danilo <adanilo@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747021}

https://webrtc.googlesource.com/src.git/+log/fbc7ed0d7116..43d8e93fa7bf

git log fbc7ed0d7116..43d8e93fa7bf --date=short --first-parent --format='%ad %ae %s'
2020-03-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8d9e658d..2d9b6439 (746798:746902)

Created with:
  gclient setdep -r src/third_party/webrtc@43d8e93fa7bf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I3abe5b8233e0f9fba7e7c1bfe9cba8cd217f0615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088458Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747020}

We should open offline pages in incognito mode when opening from download
home. This CL adds support to OfflineContentProvider::openItem to
propagate this information from the UI layer, through backend and
finally to custom tab.

Remaining issues :
1 - Open downloads in incognito as well. This will require passing the param
through DownloadItem::OpenDownload and the chain of delegates to java layer.
2 - There is still an issue where NTP incognito when opened first time
doesn't set the incognito value correctly.
3 - Determine whether we need the same from desktop download shelf.
4 - Tests aren't updated yet for the API change.

Bug: 651995
Change-Id: I939204a9108807bd89cc1b51d5891fa8aa8a07f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082019
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747019}

When an excluded credential is found, the spec says InvalidStateError
should be returned. The test was expecting a NotAllowedError, fix that.

Bug: 875444
Change-Id: I034ea2c270909895f8935a5c5a4d659b6c7327dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088000
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747018}