- 29 Jul, 2016 40 commits
-
-
qyearsley authored
Many test methods in unit tests have names much longer than 30 characters. I think this is fine for test method names, since they're meant to be descriptive, but not necessarily short and memorable. Review-Url: https://codereview.chromium.org/2192213002 Cr-Commit-Position: refs/heads/master@{#408786}
-
dewittj authored
This is an inefficient intermediate step to support multiple client IDs in a single API call. TODO: update native backend to support multiple Client ID search. BUG= Review-Url: https://codereview.chromium.org/2187033002 Cr-Commit-Position: refs/heads/master@{#408785}
-
brettw authored
Revert of Simplify landmines code a bit now that all branches of all platforms are on ninja (patchset #2 id:20001 of https://codereview.chromium.org/2071463002/ ) Reason for revert: I just synced on Windows and this is giving me: ________ running 'D:\depot_tools\python276_bin\python.exe src/build/landmines.py ' in 'D:\src\src1' Traceback (most recent call last): File "D:\src\src1\src\build\get_landmines.py", line 16, in <module> builder = landmine_utils.builder AttributeError: 'module' object has no attribute 'builder' Clobbering due to: --- old_landmines Tue Aug 12 16:34:51 2014 +++ new_landmines Fri Jul 29 15:16:56 2016 @@ -1,17 +0,0 @@ -Compile on cc_unittests fails due to symbols removed in r185063. -Improper dependency for create_nmf.py broke in r240802, fixed in r240860. -Switch to VS2015 Update 2 -Need to clobber everything due to an IDL change in r154579 (blink) -Need to clobber everything due to gen file moves in r175513 (Blink) -Clobber to get rid of obselete test plugin after r248358 -Clobber to rebuild GN files for V8 -Clobber to get rid of stale generated mojom.h files -Need to clobber everything due to build_nexe change in nacl r13424 -[chromium-dev] PSA: clobber build needed for IDR_INSPECTOR_* compil... -blink_resources.grd changed: crbug.com/400860 -ninja dependency cycle: crbug.com/408192 -Clobber to fix missing NaCl gyp dependencies (crbug.com/427427). -Another clobber for missing NaCl gyp deps (crbug.com/427427). -Clobber to fix GN not picking up increased ID range (crbug.com/444902) -Remove NaCl toolchains from the output dir (crbug.com/456902) -Clobber to delete stale generated files (crbug.com/510086) Original issue's description: > Simplify landmines code a bit now that all branches of all platforms are on ninja > > BUG=none > > Committed: https://crrev.com/7491d14275670fad399837445b6c1e76ff498a50 > Cr-Commit-Position: refs/heads/master@{#408739} TBR=iannucci@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review-Url: https://codereview.chromium.org/2198583002 Cr-Commit-Position: refs/heads/master@{#408784}
-
wkorman authored
Review-Url: https://codereview.chromium.org/2193073004 Cr-Commit-Position: refs/heads/master@{#408783}
-
dpranke authored
TBR=brettw@chromium.org NOTRY=true BUG=623659 Review-Url: https://codereview.chromium.org/2192303002 Cr-Commit-Position: refs/heads/master@{#408782}
-
mfoltz authored
This converts presentation.mojom to use the new (std::) Mojo wrapper types: mojo::String => std::string mojo::Array => std::vector No behavior changes should ensue. Optional values are represented as base::Optional<Foo> with the new wrapper types requiring some additional changes. This work will simplify further changes for crbug.com/627655. BUG=627655 Review-Url: https://codereview.chromium.org/2181163003 Cr-Commit-Position: refs/heads/master@{#408781}
-
dpapad authored
BUG=632761 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2198443003 Cr-Commit-Position: refs/heads/master@{#408780}
-
jsbell authored
Better name and it matches the concept in the spec. Review-Url: https://codereview.chromium.org/2170043004 Cr-Commit-Position: refs/heads/master@{#408779}
-
ben authored
R=rockot@chromium.org BUG= Review-Url: https://codereview.chromium.org/2192263002 Cr-Commit-Position: refs/heads/master@{#408778}
-
rch authored
Review-Url: https://codereview.chromium.org/2193073003 Cr-Commit-Position: refs/heads/master@{#408777}
-
einbinder authored
BUG= Review-Url: https://codereview.chromium.org/2163393002 Cr-Commit-Position: refs/heads/master@{#408776}
-
kenobi authored
Unqualified page transitions are treated as link-clicks, which can get sent to android via the arc intent mechanism. This can result in infinite-looping if the URL that is being opened originated from android in the first place. Marking this as an API-generated page transition ensures that the arc intent code does not forward this URL back to android. BUG=632360 Review-Url: https://codereview.chromium.org/2189063002 Cr-Commit-Position: refs/heads/master@{#408775}
-
thomasanderson authored
The linux kernel stores and prints the data associated with /proc/vmstat as unsigned longs, so increase Chrome's storage of these fields accordingly. https://github.com/torvalds/linux/blob/e4fba88d00d21f50239eac7d653027bfaf844296/include/linux/vmstat.h#L25 Review-Url: https://codereview.chromium.org/2188043003 Cr-Commit-Position: refs/heads/master@{#408774}
-
rnephew authored
BUG=632809 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2198523003 Cr-Commit-Position: refs/heads/master@{#408773}
-
sievers authored
This removes some native references to ContentViewCore from the embedder, which were mostly unnecessary indirections and can use WebContents directly. BUG=626764 Review-Url: https://codereview.chromium.org/2179563003 Cr-Commit-Position: refs/heads/master@{#408772}
-
ssid authored
On Android the exit status is always marked as EXIT_CRASHED. So, the background traces are never uploaded. Since the check is useful only for preemptive mode, this CL removes this check for REACTIVE triggers on Android and adds extra check for preemptive trigger in that place. BUG=613198 Review-Url: https://codereview.chromium.org/2192093002 Cr-Commit-Position: refs/heads/master@{#408771}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/5db44aa2aa4a..848904e5b356 $ git log 5db44aa2a..848904e5b --date=short --no-merges --format='%ad %ae %s' 2016-07-29 egdaniel Fix vulkan build 2016-07-29 dvonbeck Added distance vector support for CircleGeometryProcessor 2016-07-29 mtklein Tidy up SkNx_neon. 2016-07-29 jcgregorio perf: Upload results to gs://skia-perf, not gs://chromium-skia-gm. 2016-07-29 bungeman Conditionally define SK_SUPPORT_LEGACY_DATA_FACTORIES. 2016-07-29 egdaniel Properly recycle uniform buffers in vulkan 2016-07-29 mtklein Add some GN builders to the CQ. 2016-07-29 halcanary SkPDF: PDFStream has-a not is-a PDFDict 2016-07-29 mtklein SkNx: add Sk4u 2016-07-29 dvonbeck GrFP can express distance vector field req., program builder declares variable for it CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=tomhudson@google.com Review-Url: https://codereview.chromium.org/2199433002 Cr-Commit-Position: refs/heads/master@{#408770}
-
hanxi authored
This updates the ManifestUpdateDetector after CL (https://codereview.chromium.org/2193683003/) landed. BUG=631063 Review-Url: https://codereview.chromium.org/2189413002 Cr-Commit-Position: refs/heads/master@{#408769}
-
robliao authored
BUG=553459 Review-Url: https://codereview.chromium.org/2195813002 Cr-Commit-Position: refs/heads/master@{#408768}
-
vakh authored
The comment states that although the field is marked as repeated, in practice it can only contain 0 or 1 values. BUG=543161 Review-Url: https://codereview.chromium.org/2195043002 Cr-Commit-Position: refs/heads/master@{#408767}
-
bmcquade authored
BUG=627607 Review-Url: https://codereview.chromium.org/2194893003 Cr-Commit-Position: refs/heads/master@{#408766}
-
brettw authored
In order to roll GN 15e0e74f..da21696c (r407852:r408676) and pick up the following changes: da21696c GN: only write targets that should be generated. 1c27131e [GN] Prefer explicit pool to automatic link_pool for link targets. 8293c354 GN: don't write separate files for non-binary targets TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2193873002 Cr-Commit-Position: refs/heads/master@{#408765}
-
junov authored
Revert of Disabled smoothness.tough_canvas_cases benchmark on Win and Mac perf bots. (patchset #1 id:1 of https://codereview.chromium.org/2097923002/ ) Reason for revert: Regression was reverted, so tests can be re-enabled Original issue's description: > Disabled smoothness.tough_canvas_cases benchmark on Win and Mac perf bots. > > BUG=623105 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq > > Committed: https://crrev.com/582209c397ef25fb75bd8fdf58ff74c291172247 > Cr-Commit-Position: refs/heads/master@{#402060} TBR=eakuefner@chromium.org,sullivan@chromium.org,prasadv@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=623105 Review-Url: https://codereview.chromium.org/2191413002 Cr-Commit-Position: refs/heads/master@{#408764}
-
varkha authored
Previously to this CL the code was only considering the focused window when calculating scale for the overview mode transform. It needs to consider the bounding rectangle of the whole transient parent's tree. BUG=632694 Review-Url: https://codereview.chromium.org/2197773002 Cr-Commit-Position: refs/heads/master@{#408763}
-
rob.buis authored
BUG=402536 Review-Url: https://codereview.chromium.org/2188523005 Cr-Commit-Position: refs/heads/master@{#408762}
-
vmpstr authored
This patch updates the code to prevent auto deducing to a raw pointer. R=asvitkine@chromium.org BUG=554600 Review-Url: https://codereview.chromium.org/2195503002 Cr-Commit-Position: refs/heads/master@{#408761}
-
tedchoc authored
BUG=630475 Review-Url: https://codereview.chromium.org/2193933002 Cr-Commit-Position: refs/heads/master@{#408760}
-
ericrk authored
Skia histograms are generating invalid data. Disable them until we have time to debug further. Review-Url: https://codereview.chromium.org/2185263002 Cr-Commit-Position: refs/heads/master@{#408759}
-
flandy authored
This fixes an issue with the source color picker where undo-ing the color text did not always remove the color swatch. CodeMirror findMarks() is not inclusive, so we also need to check the line endpoints. The additional newline added to the string in _updateColorSwatches allows color text to be matched when it is located at the start of a line. R=lushnikov Review-Url: https://codereview.chromium.org/2187173002 Cr-Commit-Position: refs/heads/master@{#408758}
-
mcasas authored
This CL addresses the problem in the bug, i.e. android webview not finding the Geolocation classes after moving to //device. BUG=632777 Review-Url: https://codereview.chromium.org/2195783002 Cr-Commit-Position: refs/heads/master@{#408757}
-
thomasanderson authored
It appears we lost support for --class when we stopped using gtk for our windowing. This CL adds that feature back. BUG=118613 Committed: https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520 Review-Url: https://codereview.chromium.org/2186813002 Cr-Original-Commit-Position: refs/heads/master@{#408709} Cr-Commit-Position: refs/heads/master@{#408756}
-
hcarmona authored
BUG=NONE Review-Url: https://codereview.chromium.org/2195003002 Cr-Commit-Position: refs/heads/master@{#408755}
-
mgersh authored
Now that RequestFinishedListener doesn't depend on NQE's executor, the rest of this API can go away. BUG=618034 Review-Url: https://codereview.chromium.org/2188553002 Cr-Commit-Position: refs/heads/master@{#408754}
-
dbeam authored
R=tommycli@chromium.org BUG=629604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2195793003 Cr-Commit-Position: refs/heads/master@{#408753}
-
cbiesinger authored
NOTRY=true Review-Url: https://codereview.chromium.org/2193373002 Cr-Commit-Position: refs/heads/master@{#408752}
-
pkotwicz authored
WebAPK process is not guaranteed to terminate when Chrome gets updated. The WebAPK code assumes that it is always using the latest version of runtime library. In order to guarantee this, the ClassLoader must be re-created if Chrome is updated but the WebAPK is still running. BUG=627950 TEST=HostBrowserLauncherTest.* TBR=hanxi (TBR for DEP on testing/ by JUnit test) Review-Url: https://codereview.chromium.org/2179163002 Cr-Commit-Position: refs/heads/master@{#408751}
-
warx authored
Not sure why it is missing. Probably related to this CL: https://codereview.chromium.org/2007133006 This fix is to add a style to .remove-warning-button. BUG=631975 Review-Url: https://codereview.chromium.org/2197653003 Cr-Commit-Position: refs/heads/master@{#408750}
-
dpapad authored
Credit goes to @dbeam. BUG=632674 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2194823004 Cr-Commit-Position: refs/heads/master@{#408749}
-
varkha authored
This CL only changes the default for the --ash-max-previews-to-use-mask runtime flag to 0 (from 10). Not using masks seems to improve animation. BUG=632825 TEST=None Review-Url: https://codereview.chromium.org/2193403002 Cr-Commit-Position: refs/heads/master@{#408748}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/317e984a87db..28aad26a05ee $ git log 317e984a8..28aad26a0 --date=short --no-merges --format='%ad %ae %s' TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2191383003 Cr-Commit-Position: refs/heads/master@{#408747}
-