- 07 Nov, 2018 40 commits
- 
- 
Findit authoredThis reverts commit ed0f2f84. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 605980 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2VkMGYyZjg0ZmExNzFhYjQzNDNjMmVjYTkzYjg2MDg1YjQ3MDM0OWUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/15725 Sample Failed Step: browser_tests Original change's description: > [VK] Automatically notify when test keyboard UI is loaded. > > Previously, test implementations of KeyboardUI did not call > KeyboardController::NotifyKeyboardWindowLoaded. KeyboardController > requires that function to be called in order to proceed to show the > virtual keyboard. Thus, individual test files had to manually call > NotifyKeyboardWindowLoaded. > > We change the test implementations to automatically call > NotifyKeyboardWindowLoaded (through a callback) and move the function > to be private. We use PostTask to simulate asynchronity. > > Bug: 849995 > Change-Id: I1eae9a94c785622ed645c2437a0457f5516fed47 > Reviewed-on: https://chromium-review.googlesource.com/c/1277129 > Commit-Queue: Darren Shen <shend@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605980} Change-Id: I959fb6eede97135d784019240760184563de0b16 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 849995 Reviewed-on: https://chromium-review.googlesource.com/c/1322609 Cr-Commit-Position: refs/heads/master@{#605988} 
- 
Sergei Datsenko authoredNow it requests ridiculously excessive number of results. Tune it down to just excessive. BUG=chromium:902600 Change-Id: I300c345284d06a15f3375286ae32cd1de1e30645 Reviewed-on: https://chromium-review.googlesource.com/c/1322329Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#605987} 
- 
Jun Choi authoredAccording to the CTAP spec, it is valid for external authenticators to return response to GetAssertion request with an empty credential when only one credential is listed in the allowed list section of the corresponding GetAssertion request. In this case, manually set credential id before returning the response to the relying party. Bug: 900577 Change-Id: I9ea65eea1c1dc83d6f5312839c0d5db81b0febed Reviewed-on: https://chromium-review.googlesource.com/c/1318973Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605986} 
- 
Anand K. Mistry authoredBUG=902227,901782 Change-Id: I130aedf1d2085089f7385ee13347894819f68e05 Reviewed-on: https://chromium-review.googlesource.com/c/1322181Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#605985} 
- 
Niels Möller authoredNeeded to add constructor and make use of it in webrtc, see cl https://webrtc-review.googlesource.com/c/src/+/109500. Bug: webrtc:9962 Change-Id: I1437a25db26ed5fa5440f5aa22daa2bdd786b73d Reviewed-on: https://chromium-review.googlesource.com/c/1318892Reviewed-by: Henrik Grunell <grunell@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#605984} 
- 
Takuto Ikuta authoredTo speed up build time on windows component build, I will enable newly added /Zc:dllexportInlines- flag. The flag is similar to -fvisibility-inlines-hidden in gcc/clang. This flag makes inline member function is not exported if it does not have static local variables. But in few classes of chromium, we need to add additional EXPORT specifier to prevent link failure. This is a part of effort adding EXPORT speicifer to enable the flag. Master CL is https://chromium-review.googlesource.com/c/chromium/src/+/1317069 This CL was uploaded by git cl split. R=futhark@chromium.org Bug: 901709 Change-Id: I5adf66b516a0d07c9f58e195a1d0a2b7cb3e95ee Reviewed-on: https://chromium-review.googlesource.com/c/1322176Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#605983} 
- 
Matt Falkenhagen authoredSince adding the long timeout in https://github.com/web-platform-tests/wpt/pull/13684, it doesn't timeout. However, it still has recently started timing out on Mac for oob-cors. Bug: 868225, 870173 Change-Id: I3b460ae75d0e25916ed2d836e0e5d75d29f2124b Reviewed-on: https://chromium-review.googlesource.com/c/1322335Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#605982} 
- 
chromium-internal-autoroll authoredhttps://chrome-internal.googlesource.com/chrome/src-internal.git/+log/29c1a01acebc..0ecee6235c38 Created with: gclient setdep -r src-internal@0ecee6235c38 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9093f5ff34082d615dd94bfe2ec45a429900af9f Reviewed-on: https://chromium-review.googlesource.com/c/1322370Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605981} 
- 
Darren Shen authoredPreviously, test implementations of KeyboardUI did not call KeyboardController::NotifyKeyboardWindowLoaded. KeyboardController requires that function to be called in order to proceed to show the virtual keyboard. Thus, individual test files had to manually call NotifyKeyboardWindowLoaded. We change the test implementations to automatically call NotifyKeyboardWindowLoaded (through a callback) and move the function to be private. We use PostTask to simulate asynchronity. Bug: 849995 Change-Id: I1eae9a94c785622ed645c2437a0457f5516fed47 Reviewed-on: https://chromium-review.googlesource.com/c/1277129 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#605980} 
- 
Justin Cohen authoredWhen using the non-CRWNativeContent NTP the title may be incorrectly nilled out. Instead, don't update the navigation item title if there is a loading error page. BUG: 826369 Change-Id: I6d7d45982afbc94d13d73a26b1f8c9784a3ea7dc Reviewed-on: https://chromium-review.googlesource.com/c/1316752 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#605979} 
- 
chromium-autoroll authoredhttps://webrtc.googlesource.com/src.git/+log/dc98b9b975fa..8770ce70746a git log dc98b9b975fa..8770ce70746a --date=short --no-merges --format='%ad %ae %s' 2018-11-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 03cf97f6..38dcb5ed (605818:605924) 2018-11-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 793c8566..03cf97f6 (605715:605818) 2018-11-06 srte@webrtc.org Fixing bug in SimulatedNetwork where packets stop. 2018-11-06 srte@webrtc.org Removes deprecated GetSentPacket from PacketResult. Created with: gclient setdep -r src/third_party/webrtc@8770ce70746a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I90753b7885fcda76beab425300c99eddc0c7abf0 Reviewed-on: https://chromium-review.googlesource.com/c/1322210Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605978} 
- 
v8-ci-autoroll-builder authoredSummary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ef413aaa..b563adf6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If2655d0aecb32b21bcf60ebab11a1c23d38e9bb5 Reviewed-on: https://chromium-review.googlesource.com/c/1322349Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605977} 
- 
Hayato Ito authoredTBR=tkent@chromium.org Change-Id: I7ac71397fab24f23ee8e860f8cf476a1ad4cd332 Reviewed-on: https://chromium-review.googlesource.com/c/1322179Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#605976} 
- 
Kush Sinha authoredBug: 871690 Change-Id: I892c016bbcfcaaaba0e580b1b7783f916be2e469 Reviewed-on: https://chromium-review.googlesource.com/c/1276649 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Mattias Nissler <mnissler@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#605975} 
- 
Alexey Baskakov authoredFor now we try to reuse as much USS code as possible. It has limitations and drawbacks (see the code). We will rethink our persistence code later when we start to design WebAppSyncBridge (an implementation for syncer::ModelTypeSyncBridge interface). Bug: 896150 Change-Id: Ia898b905f39869a6b1c3f79751358425449a617a Reviewed-on: https://chromium-review.googlesource.com/c/1295529Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#605974} 
- 
Takuto Ikuta authoredTo speed up build time on windows component build, I will enable newly added /Zc:dllexportInlines- flag. The flag is similar to -fvisibility-inlines-hidden in gcc/clang. This flag makes inline member function is not exported if it does not have static local variables. But in few classes of chromium, we need to add additional EXPORT specifier to prevent link failure. This is a part of effort adding EXPORT speicifer to enable the flag. Master CL is https://chromium-review.googlesource.com/c/chromium/src/+/1317069 This CL was uploaded by git cl split. R=tkent@chromium.org Bug: 901709 Change-Id: I21a5a8b9a53058ec6b777af846757c6b6377805a Reviewed-on: https://chromium-review.googlesource.com/c/1322253Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#605973} 
- 
Kent Tamura authoredBefore this CL, an entry in event_interface_names.json5 looked like: "third_party/blink/renderer/core/dom/events/CustomEvent", This was confusing because this looked a path name, but its actual path name is "third_party/.../events/custom_event.{cc,h,idl}". generate_event_interfaces.py concatenated a directory information and an interface names, and make_event_factory.py split it. This CL changes it to: { name: "CustomEvent", interfaceHeaderDir: "third_party/blink/renderer/core/dom/events", }, 'interfaceHeaderDir' is same as one in json5 for tag names. * bindings/scripts/generate_event_interfaces.py: Don't concatenate directory information and an interface name. Produce interfaceHeaderDir field. * build/scripts/make_event_factory.py: - Build header paths with interfaceHeaderDir instead of os.path.dirname(entry['name']). - Don't use name_utilities.script_name(). entry['name'].original is enough because entry['name'] doesn't contain directory information. * build/scripts/templates/event_factory.cc.tmpl: Use 'name' filter to get the name as is. * build/scripts/make_names.py: Remove unnecessary os.path.basename(). Add template for interfaceHeaderDir. * build/scripts/name_utilities.py: Remove script_name(). This CL has no behavior changes. Change-Id: I960ad48d23c05e2b327864123a9ba3cb0caf9241 Reviewed-on: https://chromium-review.googlesource.com/c/1322012 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#605972} 
- 
Alexey Baskakov authoredHandle WebContents lifetime and errors properly (in the future). Bug: 901226 Change-Id: Ifc587e01a32362a89943a1a985a4893262a7154a Reviewed-on: https://chromium-review.googlesource.com/c/1322170 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#605971} 
- 
Yoshifumi Inoue authoredThis patch marks point-mapping/3d-point-mapping-{3,origins}.html flaky on Mac10.13 NOTRY=true TBR=yosin@chromium.org Bug: 902645 Change-Id: Ib23c6ddd21b0739317141cf78f26ea482bc920d5 Reviewed-on: https://chromium-review.googlesource.com/c/1322334Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605970} 
- 
Takuto Ikuta authoredTo speed up build time on windows component build, I will enable newly added /Zc:dllexportInlines- flag. The flag is similar to -fvisibility-inlines-hidden in gcc/clang. This flag makes inline member function is not exported if it does not have static local variables. But in few classes of chromium, we need to add additional EXPORT specifier to prevent link failure. This is a part of effort adding EXPORT speicifer to enable the flag. Master CL is https://chromium-review.googlesource.com/c/chromium/src/+/1317069 This CL was uploaded by git cl split. R=atotic@chromium.org Bug: 901709 Change-Id: I0facb6e5743e74f65730a2a24179d5e83c71715f Reviewed-on: https://chromium-review.googlesource.com/c/1322330Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#605969} 
- 
chromium-internal-autoroll authoredhttps://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b076c5fff9c9..29c1a01acebc Created with: gclient setdep -r src-internal@29c1a01acebc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ifbd11777c81da1e9738f41e27dcf345f436e7636 Reviewed-on: https://chromium-review.googlesource.com/c/1322309Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605968} 
- 
Hiroki Nakagawa authoredBug: 902201 Change-Id: I18e4dc822a5440bbe4b3c01092da7c137984a9a3 Reviewed-on: https://chromium-review.googlesource.com/c/1319216 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#605967} 
- 
Gabriel Charette authoredThis helps identify sections of a trace event that were blocked on external dependencies and shed some light on the "descheduled" portion of an event. This CL is non-trivial for 3 reasons: 1) This new TRACE_EVENT kicks off tracing earlier than before in some configurations. This means that main() of basic utilities all of a sudden needed AtExitManagers (first patch set of this CL). But that then spread out to many main()'s and was painful. Since the Singleton is only required in tracing to know whether it's enabled : this CL specializes Singleton/TraceEventETWExport to avoid instantiating the instance only to notice it's not enabled (guaranteed default state). 2) We do not want tracing events while a thread is idle (i.e. when it's sleeping on its own WaitableEvent/ConditionVariable while waiting for more tasks). Ideally we simply wouldn't record the trace event when it's not nested within another event but tracing doesn't have a notion of "current event depth". As such this CL opts for a declarative model where owners of the few WaitableEvents/ConditionVariables used to sleep-while-idle can flag those as irrelevant for tracing. 3) Possibility of reentrancy if the trace event macros perform a blocking call themselves. Added DCHECKs to confirm this doesn't occur (was initial suspected cause of CrOS+amd64 only failures but it kept failing despite that and this feature had to be disabled there..) Bonus: * Singleton::GetIfExists() avoids instantiating TraceEventETWExport when switches::kTraceExportEventsToETW isn't present. * The declarative model brought forth by (2) also enables not instantiating debug::ScopedEventWaitActivity objects while a thread is merely sleeping. This will avoid polluting crash metadata with wait-acitvity for sleeping threads. * In a follow-up CL we will be able to remove base::internal::ScopedClearBlockingObserverForTesting which was previously necessary specifically to avoid a situation in TaskScheduler unit tests where WaitableEvents used for the test logic would instantiate ScopedBlockingCalls and interfere with the very logic under test. (not done in this one as it's large enough on its own) Bug: 899897, 902514 Change-Id: I93b63e83ac6bd9e5e9d4e29a9b86c62c73738835 Reviewed-on: https://chromium-review.googlesource.com/c/1305891 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:danakj <danakj@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#605966} 
- 
Koji Ishii authoredWhen in quirks mode and there are no text siblings; e.g.: <div><img><span>text</span></div> and 'vertical-align: text-top' applied to <img> hits DCHECK failure and results in incorrect position. The test ensures that results are the same with the standard mode. Bug: 901123 Change-Id: I30564c66d5847f09caf3672ba3d456c0eb798d3e Reviewed-on: https://chromium-review.googlesource.com/c/1320529 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#605965} 
- 
tzik authoredThis CL replaces all usage of v8::Isolate::GetEnteredContext in Blink with GetEnteredOrMicrotaskContext. GetEnteredOrMicrotaskContext should be the better fit here as the EnteredContext may be unrelated to the currently running script's context when it's in the microtask queue. chromium: 887920 Change-Id: I9da9777fb3b365fa181d2d9660c36a071734acf3 Reviewed-on: https://chromium-review.googlesource.com/c/1319220Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#605964} 
- 
chromium-autoroll authoredhttps://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6d6e0a8009f2..52a091f41950 git log 6d6e0a8009f2..52a091f41950 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 jbudorick@chromium.org Add android_internal fetch spec. Created with: gclient setdep -r src/third_party/depot_tools@52a091f41950 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:856278 TBR=agable@chromium.org Change-Id: I2400a341ad58d48e71ed2d088d17e3aed5db282b Reviewed-on: https://chromium-review.googlesource.com/c/1321951Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605963} 
- 
Koji Ishii authoredFollowing bot results are included. 11477 11478 11487 11492 11495 11499 11504 11505 11513 11525 11531 11536 3 lines were removed and 1 lines were deflaked by consecutive results since 11477. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I6147002491e6cfd011b6b5a121625db5181fec6a Reviewed-on: https://chromium-review.googlesource.com/c/1318509 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#605962} 
- 
Ingvar Stepanyan authoredSwitches custom string splitting to URLSearchParams, which both makes code simpler and fixes parsing of percent-encoded URL params. Change-Id: I839689382cf6b3a7f55be3b08e03f35c8f81c520 Reviewed-on: https://chromium-review.googlesource.com/c/1318533 Commit-Queue: Ingvar Stepanyan <ingvar@cloudflare.com> Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#605961} 
- 
Hajime Hoshi authoredV8 should not be executed on per-thread task runner. Use per-frame task runner instead. Bug: 870606 Change-Id: I29754c8a085dfe0ec7b4d9e9f6b57ecdf75e1dae Reviewed-on: https://chromium-review.googlesource.com/c/1319406Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605960} 
- 
Yoshifumi Inoue authoredThis patch marks middleClickAutoscroll-{drag,event-fired}.html on Windows: * fast/events/middleClickAutoscroll-event-fired.html * virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-drag.html * virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-event-fired.html * virtual/scroll_customization/fast/events/touch/gesture/gesture-scrollbar-touchpad-fling.html * virtual/user-activation-v2/fast/events/middleClickAutoscroll-nested-divs-forbidden.html NOTRY=true TBR=sahel@chromium.org Bug: 891155 Change-Id: Iaa6d1054921f3298af37a5023992826b541c82f5 Reviewed-on: https://chromium-review.googlesource.com/c/1322250Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605959} 
- 
chromium-internal-autoroll authoredhttps://chrome-internal.googlesource.com/chrome/src-internal.git/+log/48e9f6ccddbf..b076c5fff9c9 Created with: gclient setdep -r src-internal@b076c5fff9c9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I88f8dc2dd243cd6b60be9d5dcef87c13893d6eea Reviewed-on: https://chromium-review.googlesource.com/c/1321932Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605958} 
- 
chrome-release-bot authored# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: Id965ae49f617e6c0ec25428b28cde7e3a68ffdb8 Reviewed-on: https://chromium-review.googlesource.com/c/1321780Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#605957} 
- 
Justin Cohen authoredWhen navigating back to an error page -loadErrorPageForNavigationItem will immediately begin loading and _documentURL may not match the lastCommittedURL. Instead, set this in -didFailProvisionalNavigation. Bug: 898339 Change-Id: I32bff4cce27c97adde395a3e64ddb58b18bd0593 Reviewed-on: https://chromium-review.googlesource.com/c/1319173 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#605956} 
- 
v8-ci-autoroll-builder authoredSummary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5597b278..ef413aaa Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I80fe69f95cc675f18408ab7294e00d0d7bb1e257 Reviewed-on: https://chromium-review.googlesource.com/c/1319930Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605955} 
- 
Yoshifumi Inoue authoredThis patch marks xmlhttprequest-recursive-sync-event.html as [ Crash Pass] on Windows debug build. NOTRY=true TBR=yhirano@chromium.org Bug: 902632 Change-Id: I47494bad3b9314edef8a4043cc2ae2711b6f7e7b Reviewed-on: https://chromium-review.googlesource.com/c/1322173 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605954} 
- 
Hiroki Nakagawa authoredblink::mojom::ScriptType was introduced for ES Modules on Service Workers. To avoid duplicate enums, this CL replaces blink::ScriptType with blink::mojom::ScriptType. In addition to replacement, this CL adds a new directory and a mojom file blink/public/mojom/script/script_type.mojom, and moves blink::mojom::ScriptType from service_worker_registration.mojom to script_type.mojom. Bug: n/a Change-Id: I5b4a17b0b1ff15112c2675219cd69a6be6a2b051 Reviewed-on: https://chromium-review.googlesource.com/c/1321710Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#605953} 
- 
Stuart Langley authoredThis brings across the changes made inside chromeos to the mojom that is defined in chromium. Bug: 884020 Change-Id: Iab4d789cf153fabbf8d243fd346e2188e9c4153b Reviewed-on: https://chromium-review.googlesource.com/c/1321652Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#605952} 
- 
Giovanni Ortuño Urquidi authoredChanges UnifiedBluetoothDetailedViewController to update the device list every 500ms while a scan is active. Also adds a new observer method specifically for when Bluetooth State changes and changes UnifiedBluetoothDetailedViewController to use this method to update the list of devices as well. Bug: 882346 Change-Id: I13ef2555e6c4c451213afb5d405f707d5f4f19a7 Reviewed-on: https://chromium-review.googlesource.com/c/1314069Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#605951} 
- 
Danan S authoredThe previous (now reverted) version of this CL failed to build in debug mode (and therefore broke the continuous build), because apparently static constexpr class members, which must be initialized in the class definition, are then not available at link time when is_debug=true. I didn't catch this before landing the CL because I was building with is_debug=false. The fix involved declaring the members as static const (not constexpr), and defining them in demo_mode_detector.cc. Revert "Revert "Disable Demo app launch when device is in Dev mode"" This reverts commit 225590d4. Bug: 877655 Change-Id: Id8c15012e4bfa33230feda38ec8a94ea5c809741 Reviewed-on: https://chromium-review.googlesource.com/c/1318741 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#605950} 
- 
Anand K. Mistry authoredBUG=900749 Change-Id: Id2da44c92c3e53aa08c60e7ae7de6eac6cd32b44 Reviewed-on: https://chromium-review.googlesource.com/c/1322169Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#605949} 
 
-