- 24 Jul, 2018 40 commits
-
-
Clemens Hammacher authored
In V8, we still have an ordering problem with processing flags. In this case, the "--wasm-tier-up" flag implies "--liftoff", and since "--wasm-tier-up" is enabled by default, also "--liftoff" is enabled by default. If we now set "--no-wasm-tier-up" (via {SetFlagsFromString}), this does not disable "--liftoff". Hence, disable it explicitly. R=jochen@chromium.org, titzer@chromium.org Bug: chromium:866924, chromium:787421 Change-Id: I298792bda07ef02a8f039c72be165ec815baa46f Reviewed-on: https://chromium-review.googlesource.com/1148386Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#577571}
-
Mikel Astiz authored
No actual implementation included, just the basic skeleton files and classes, the required plumbing and the associated feature toggle. Follow-up patches will introduce the actual implementation, to ultimately replace AutofillWalletSyncableService. Bug: 853688 Change-Id: Ia0963fbad2d3e046686e93aea6468283bad186fd Reviewed-on: https://chromium-review.googlesource.com/1147223Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577570}
-
chrome://ukmMoe Ahmadi authored
- Modifies iOS implementation of chrome://ukm to use WebUI. - Refactors HTML/JS resources to be used in iOS. - Removes method in ukm::UkmDebugDataExtractor that returns HTML debug data. - Adds helper methods to resolve/reject Promises to WebUIIOS. Bug: 843181 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I008ce1beb8d35dd9d4a7fc482990f06e3095f16a Reviewed-on: https://chromium-review.googlesource.com/1147241 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#577569}
-
Kurt Horimoto authored
Since the OmniboxFocuser dispatcher is owned by the BVC and the tab switcher coordinator doesn't know about BVC details, this logic needs to be pushed up to MainController. Bug: 805106 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4c1e78de8eebb104f597651d9e81f79e292eb079 Reviewed-on: https://chromium-review.googlesource.com/1142540Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#577568}
-
Danyao Wang authored
I missed this suggestion in http://crrev.com/c/1145725 Bug: 865985 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie656457f7acf0acb5da81cfc267a7962acb62cc3 Reviewed-on: https://chromium-review.googlesource.com/1146902Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#577567}
-
Justin Novosad authored
This is a reland of 5c4bc1ff Original change's description: > Add a single buffered mode to CanvasResourceProvider > > This CL completes the initial implementation of Low Latency mode for 2d > canvases > > Bug: 788439 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I58fcd3fe4ab19fa10f2876f3da4f078fd4fbc2a9 > Reviewed-on: https://chromium-review.googlesource.com/1145235 > Commit-Queue: Justin Novosad <junov@chromium.org> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576962} TBR=fserb@chromium.org Bug: 788439 Change-Id: Ie18018ef0ebcff92beb31fcdebbc0ac2e077053e Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1147952 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#577566}
-
Helen Li authored
This reverts commit 494108ab. Reason for revert: Reland it in M70. Original change's description: > Revert "Convert Extensions TCP & TLS Socket APIs to mojo sockets" > > This reverts commit 41066e83. > > Reason for revert: This CL broke an internal app. See crbug.com/865958 > > Original change's description: > > Convert Extensions TCP & TLS Socket APIs to mojo sockets > > > > This CL converts extensions TCP and TLS socket apis to network service's mojo > > socket. > > > > - Remove combined_socket_unittest.cc because the test cases no longer apply. I > > tried to write equivalent ones in tcp_socket_unittest.cc and > > tls_socket_unittest.cc > > - Add a ContentUtilityClient implementation for extensions_browsertests, so we > > can inject a NetworkServiceTestHelper to the utility process in which network > > service runs. > > > > Bug: 721401 > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_mojo > > Change-Id: I333a3021a5c66eb94618be6830ba0ff68c442eba > > Reviewed-on: https://chromium-review.googlesource.com/1070434 > > Commit-Queue: Helen Li <xunjieli@chromium.org> > > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#563390} > > TBR=jam@chromium.org,reillyg@chromium.org,xunjieli@chromium.org,morlovich@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 721401, 865958 > Change-Id: I9e9408f31887ab45d0bd967e2f17f91c465836c6 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;luci.chromium.try:linux_mojo > Reviewed-on: https://chromium-review.googlesource.com/1145340 > Commit-Queue: Helen Li <xunjieli@chromium.org> > Reviewed-by: Helen Li <xunjieli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576982} TBR=jam@chromium.org,reillyg@chromium.org,xunjieli@chromium.org,morlovich@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 721401, 865958 Change-Id: I9748ea1d6c04f26429508da9358ca16ff01ff90d Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1148480Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#577565}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2bc1ba83. With Chromium commits locally applied on WPT: 1736c657 "Rename a WPT which has a duplicate basename" 4bd63c29 "webrtc wpt: close RTCPeerConnection in generateAnswer helper" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21663 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: Ib1cfdee63c7a97d40221e092ecdeef485b5c7235 Reviewed-on: https://chromium-review.googlesource.com/1148235 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#577564}
-
Moe Ahmadi authored
This reverts commit 5e8f9218. Reason for revert: These tests failed due to a change to the Autofill predictions server in which it started sending UNKNOWN_TYPE for unknown fields (which signals Autofill not to fill and save form data) rather than NO_SERVER_DATA ( which signals Autofill to fall back to the local heuristics). Since these tests rely on saving a profile in order to populate the settings page and that the test form wasn't known to the predictions server, they started to fail. crbug.com/866922 is filed to eliminate that dependency. Original change's description: > [ios] Disable failing autofill tests. > > TBR: sczs@chromium.org > Bug: 866730 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: Ibc3828d336d5f6247f2a656d747e35847f86fd70 > Reviewed-on: https://chromium-review.googlesource.com/1147701 > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577384} TBR=rohitrao@chromium.org,justincohen@chromium.org,kkhorimoto@chromium.org,sczs@chromium.org Change-Id: Iba5ecab647a979cebf6d4b32894c665b356037b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866730 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1148502Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577563}
-
Luis Hector Chavez authored
This change also lets the unhandled exception handler take a first attempt at handling errors that occur when handling connection errors. yo dawg! Bug: 810087 Test: Intentionally threw an exception from a connection error handler Change-Id: I432055b33443208a352d272c7f7fcb1dbeb2a43f Reviewed-on: https://chromium-review.googlesource.com/1147516Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#577562}
-
Bill Budge authored
- Modifies partition allocator, adding a TryRealloc method that returns nullptr on failure, rather than OOM crashing. - Modifies the single call site in Blink for buffer resizing during serialization. Bug: chromium:857387 Change-Id: I9bf8d3ced837a9dd4f96a953bb52ccad3078dfa1 Reviewed-on: https://chromium-review.googlesource.com/1138859Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#577561}
-
Peter Kasting authored
Bug: none Change-Id: Ib5d1fbac1ccc7aec39cbaad56edc36c7f9fcea11 Reviewed-on: https://chromium-review.googlesource.com/1147091Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#577560}
-
Findit authored
This reverts commit 9311d412. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 577500 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzkzMTFkNDEyNTNmYzc0ZDQ5NTI3ZmIyZWU2OWUwMzYzMzM0Yjk2OWQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/41118 Sample Failed Step: viz_content_unittests Original change's description: > Reland "[Background Fetch] Move all updatable UI options to their own proto." > > This is a reland of d3981964 > > TBR=avi@chromium.org > > Original change's description: > > [Background Fetch] Move all updatable UI options to their own proto. > > > > Bundle up the icon and the title since they will be accessed/modified > > together in the updateUI call. > > > > It also makes sense to move the icon from the metadata proto since that > > will speed up getting the registration info. > > > > TBR=avi@chromium.org > > > > Bug: 865063 > > Change-Id: I661062f19fddfa6b9c3bf11b5e146d5289a02593 > > Reviewed-on: https://chromium-review.googlesource.com/1146650 > > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Peter Beverloo <peter@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#577272} > > Bug: 865063 > Change-Id: I77567e8e2e0ea59ede514c77b40326e7ece48a25 > Reviewed-on: https://chromium-review.googlesource.com/1148261 > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577500} Change-Id: I60aa46070806c053cc60d77b32456d192de378c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 865063 Reviewed-on: https://chromium-review.googlesource.com/1148500 Cr-Commit-Position: refs/heads/master@{#577559}
-
Peter Kasting authored
Things still look wrong even with this patch, because the Y coordinate is also wrong; that's a deeper issue tracked in bug 866671. Bug: 866665 Change-Id: I6a5f8fb159b3a70d71d1d17c904d2bd2d6d4fc6f Reviewed-on: https://chromium-review.googlesource.com/1147085Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#577558}
-
Etienne Pierre-doray authored
Elf reloc code will go in reloc_elf. Change-Id: Ibc93aef1cbf03a1df7b29ddf088498a70c4d3722 Reviewed-on: https://chromium-review.googlesource.com/1145688Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#577557}
-
Clark DuVall authored
TBR=stevenjb@chromium.org Bug: 866904 Change-Id: Iec0f3ffc77048afa1947605e9488860c7bcc08df Reviewed-on: https://chromium-review.googlesource.com/1148548Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#577556}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2a64e6b6d554..ca2b32c84463 git log 2a64e6b6d554..ca2b32c84463 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 mythria@chromium.org Adds v8_tools directory in experimental branch Created with: gclient setdep -r src/third_party/catapult@ca2b32c84463 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: Ia266121b72045f2def4532bc76b1cb1c85b968b5 Reviewed-on: https://chromium-review.googlesource.com/1147908Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577555}
-
Javier Ernesto Flores Robles authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8c06b38fa0133336f1a85f73a29b54a44a148505 Reviewed-on: https://chromium-review.googlesource.com/1141953Reviewed-by:
-
Gabriel Charette authored
Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1142589 Reverted for test flakiness on Fuchsia. Implementation is fine (this is a diagnostic metric -- this change definitely doesn't make it worse). The test was only added to ensure proper logging on UI thread only. Made the test more robust in this reland (see diff vs PS1). If it flakes again, please disable it on flaky platforms instead of reverting. Original change's description: Addresses crbug.com/860801 in time for the M69 branch while keeping the diagnosis signals which will be used to assess future improvements (MessageLoop.DelayedTaskQueueForUI.PendingTasksCountOnIdle that is). Removed MessageLoop.DelayedTaskQueue.PostedDelay as we've learnt everything we needed from this one, that is : We now know that while 99% of tasks are posted with a delay under 30s, 95% of users post at least one task in every portion of the 0ms-3hours range at least once per day: https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.DelayedTaskQueue.PostedDelay&fixupData=true&uniqueUsers=true&showMax=true&filters=platform%2Ceq%2CW%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial Removed MessageLoop.ScheduledSleep.* metrics as we've also learnt what we wanted from it, that is : The maximum sleep a MessageLoop ever completes is 1 hour (and even then 99% of completed sleeps are under 1 second), all longer delays are reliably always interrupted. Win : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CM%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial Mac : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CM%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial Android : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CA%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial Added a test for MessageLoop.DelayedTaskQueueForUI.PendingTasksCountOnIdle but it appears to be broken on MacOSX (prior to this CL). Added a note to investigate on the metric but it shouldn't block this CL which doesn't make it worse. TBR=wez@chromium.org Bug: 860801, 850450, 786597, 866299 Change-Id: Ic0fb2b58780cd595e47b36f97a9ae440bb988225 Reviewed-on: https://chromium-review.googlesource.com/1147400 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#577553}
-
Justin Cohen authored
Bug: 865818 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4523754e637f1fa9f0cb1c729717e0eeecf334d6 Reviewed-on: https://chromium-review.googlesource.com/1148016Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577552}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/903bd4145f5a..e09e6ef947d7 git log 903bd4145f5a..e09e6ef947d7 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 sakal@webrtc.org Reorder sdk/android/BUILD.gn. 2018-07-24 terelius@webrtc.org Plot RTCP SR and RR contents in event_log_visualizer. 2018-07-24 buildbot@webrtc.org Roll chromium_revision bc855194..83a1a9ed (577382:577482) 2018-07-24 titovartem@webrtc.org Move portaudio to proper third_party directory Created with: gclient setdep -r src/third_party/webrtc@e09e6ef947d7 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I121869ebb1f9623f0c848b70631753bbe933acaa Reviewed-on: https://chromium-review.googlesource.com/1147907Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577551}
-
Sam Maier authored
This is step 1 in an API shrinking effort for AsyncTask. There is no reason for Params to exist instead of just using constructor arguments, so we are changing the few usages over. Step 2 will be the removal of the Params argument. Bug: 843745 Change-Id: I36a03dd91b7af10763587fb5048e9f8d775f203e Reviewed-on: https://chromium-review.googlesource.com/1136730Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#577550}
-
Peng Huang authored
Modify the filter to use gl_vendor and gl_renderer. Bug: 811661 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2e1b31abf95c3bd82018fd740c75191c31052682 Reviewed-on: https://chromium-review.googlesource.com/1146760Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#577549}
-
Rayan Kanso authored
Bug: 865063 Change-Id: I8d9cc10e56189099c278d63012dee1d32f0728de Reviewed-on: https://chromium-review.googlesource.com/1143306 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#577548}
-
Tiger Oakes authored
Since all the logic outside of the data.ndjson file is self-contained in the client, we can make the client run offline and support add to shelf. Bug: 847599 Change-Id: Ic29237e994fd07f75006d1f2ef4402b835511341 Reviewed-on: https://chromium-review.googlesource.com/1145595Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
-
Marc Treib authored
This deprecated method was already implemented in terms of the new GetDisableReasons. This CL moves the remaining callers over to use GetDisableReasons directly, and removes IsSyncAllowed. Bug: 839834 Change-Id: I41d1a59aff323f0752431a281a432118d437df44 Reviewed-on: https://chromium-review.googlesource.com/1138250 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577546}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/522095f7d7fe..06235df9ff91 git log 522095f7d7fe..06235df9ff91 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 oetuaho@nvidia.com Make HLSL shaders use only one main function Created with: gclient setdep -r src/third_party/angle@06235df9ff91 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I8d1f93ae32280b1a4aa5d9f8a009aa826f6719f3 Reviewed-on: https://chromium-review.googlesource.com/1147944Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577545}
-
Fady Samuel authored
Prior to this CL, SurfaceDependencyTracker read activation_dependencies from the pending CompositorFrame's CompositorFrameMetadata. This meant that it had to look up already resolved dependencies. It's more efficient to use the remaining dependencies set tracked in Surface directly. The code is also more compact and easier to read. Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I97acf5637fd92eaa6485f15601582dc75dd69c35 Reviewed-on: https://chromium-review.googlesource.com/1148226Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#577544}
-
Leszek Swirski authored
Add a new feature flag, ScheduledScriptStreaming, which makes the script streamer use the task scheduler for streaming tasks, rather than using a dedicated ScriptStreamerThread. Bug: chromium:865098 Bug: chromium:866868 Change-Id: I05ca411d8d5187c4b5180011ebce2a603e3944fe Reviewed-on: https://chromium-review.googlesource.com/1145386 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#577543}
-
Michael Spang authored
Bug: none Test: compile ozone_demo with is_component_build=true Change-Id: Icf24cfcb5c3737d9f51136da73a9bc593937f813 Reviewed-on: https://chromium-review.googlesource.com/1146981 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
-
Torne (Richard Coles) authored
Use IMMEDIATE_CRASH on official builds instead of BreakDebugger in LOG(CRASH), to try to increase the likelihood that stack unwinding will work correctly. BreakDebugger isn't guaranteed to have a stack frame and thus can thwart CFI unwinding. This matches the behaviour of CHECK() so should be pretty safe. Bug: 851851 Change-Id: I7bcf8669ee90aa3fe42769e4e4cc841bf1df1b57 Reviewed-on: https://chromium-review.googlesource.com/1147474Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#577541}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/18dc0c00..4ac42e42 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I78797ba6840fe9c144ea3d3fb2ac21cac12f1fcd Reviewed-on: https://chromium-review.googlesource.com/1148230Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577540}
-
Kurt Horimoto authored
Previously, |-continueTrackingWithTouch:withEvent:| returned NO when UIControl.touchInside became NO to short-circuit the tracking event. However, if the touches continued after this, |-endTrackingWithTouch: withEvent:| was not called, and the page control can be stuck in an intermediary state. This CL updates to continue tracking the pan after the touch leaves the page control's bounds so that the cleanup tracking callbacks can be properly received. Bug: 853634 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0bfdedabceab824dd6ec4c687e3773fb0f4bcf63 Reviewed-on: https://chromium-review.googlesource.com/1147862 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Yannic Bonenberger authored
Bug: 805496 Change-Id: Idb1cc63960409eeb8117d74267f5df33f401eb08 Reviewed-on: https://chromium-review.googlesource.com/932101 Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#577538}
-
Matthew Cary authored
This performs the per-process phased offset processing used for the orderfile. Bug: 758566 Change-Id: I5cbdb69c4834d95a52f2e43ad3f72e4845413883 Reviewed-on: https://chromium-review.googlesource.com/1144935 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#577537}
-
Reza.Zakerinasab authored
NOTRY=TRUE TBR=fserb@chromium.org Bug: 866850 Change-Id: I78fd73f7dafadac914938b14338d482cc4ab97ca Reviewed-on: https://chromium-review.googlesource.com/1148542Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#577536}
-
Mirko Bonadei authored
Gn check can enforce dependencies only if the header is included with an absolute path (from the root of the project) or if "include_dirs" is used. It ignores -isystem and -imsvc since they are part of cflags (and similar variants). Since //third_party/abseil-cpp/absl:absl_include_config was using -isystem and -imsvc only to sidestep compiler warnings in absl code, it is good to try to switch back to include_dirs instead of adding -isystem/-imsvc support to "gn check". Bug: 862521 Change-Id: I9c2d01abad75023918a88f852e3080486dcafead Reviewed-on: https://chromium-review.googlesource.com/1124478 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
-
Danyao Wang authored
Native content is typically presented after its placeholder navigation to ensure correct ordering of WebStateObserver callbacks. However, for UI smoothness when opening a new tab, native content is presented before its placeholder navigation as well (http://crbug.com/819606). This CL removes the duplicate presentation of native content after its placeholder navigation, by storing a flag in NavigationContextImpl that the native content is already presented. Bug: 865422 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I71dc25f6a3284c34cf946800dee9bb4581506370 Reviewed-on: https://chromium-review.googlesource.com/1146777 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
-
Charlie Andrews authored
Based on a try job in the linked bug, it looks like these stories are no longer failing. TBR=sullivan@chromium.org Bug: 798536 Change-Id: I44a6d819fa0fea6dc71b76d0189933b9009d3c78 Reviewed-on: https://chromium-review.googlesource.com/1143450Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#577533}
-
Andreas Haas authored
That prevents the linker from dead-stripping the function, as it is not called directly, it is resolved in the runtime via dlsym(). I copied the change from https://crrev.com/c/833995 R=mmoroz@chromium.org Bug: 837098 Change-Id: I998517ebab623e67d275fe656643a8ee5fd1e951 Reviewed-on: https://chromium-review.googlesource.com/1148391Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#577532}
-
