GitLab

BUG=398888

Review URL: https://codereview.chromium.org/448443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288094 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky

Review URL: https://codereview.chromium.org/445373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288093 0039d316-1c4b-4281-b951-d872f2087c98

> Reland r285211: "Debugging RawChannelWin: replace DCHECK with CHECK and record write stats."
> 
> But clang-formatted (and after the changed files were clang-formatted).
> This should be reverted on the same schedule as the original change (no
> later than August 1, 2014).
> 
> > Debugging RawChannelWin: replace DCHECK with CHECK and record write stats.
> >
> > This is a temp change for debugging purpose. It should be reverted once
> > we fix the issue or find out the change doesn't reveal anything. (No later than Aug 1, 2014.)
> >
> > BUG=385795
> > TEST=None
> 
> BUG=385795
> TBR=yzshen@chromium.org
> 
> Review URL: https://codereview.chromium.org/430473004

TBR=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/449063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288092 0039d316-1c4b-4281-b951-d872f2087c98

See VLOG(1) and VLOG(2) logging:
TEST=adb shell setprop log.tag.ChromiumNetwork VERBOSE

See VLOG(1) logging:
TEST=adb shell setprop log.tag.ChromiumNetwork DEBUG

See NO (only FATAL) logging:
TEST=adb shell setprop log.tag.ChromiumNetwork NONE

BUG=400956

Review URL: https://codereview.chromium.org/447653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288088 0039d316-1c4b-4281-b951-d872f2087c98

There is only one user of this class. The new implementation is in
base/files/scoped_file.h

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/444083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288087 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/448013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288086 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky

Review URL: https://codereview.chromium.org/448853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288085 0039d316-1c4b-4281-b951-d872f2087c98

These were only used by one test file, so I moved the implementation there. I
considered updating the test, but the way the test uses wstrings seems
reasonable.

R=rvargas@chromium.org, rvargas

Review URL: https://codereview.chromium.org/448763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288084 0039d316-1c4b-4281-b951-d872f2087c98

This CL includes following changes.
- Use system default header, rather than customized Maximize/Minimize/Close buttons.
- Current location is displayed on the left side of toolbar.
- Only the selected file's information is displayed on the preview panel.
- Change-view button is moved from gear menu to the right side of toolbar.
- Search button is placed on toolbar as a button. It expands on click.

BUG=397222,308445
TEST=run browser_tests, manually tested

Review URL: https://codereview.chromium.org/443333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288082 0039d316-1c4b-4281-b951-d872f2087c98

Stop honoring the Finch enable/disable groups, but still honor explicit flips
of the flags in chrome://flags.

BUG=383169

Review URL: https://codereview.chromium.org/442913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288081 0039d316-1c4b-4281-b951-d872f2087c98

There is a "FIXME: Remove once calls on the Chromium-side have been
removed" for volume() in WebMediaPlayerClient.h. preload() is
similarly strange layering-wise, so get rid of that as well.

Simply store the values when they cannot immediately be forwarded to
the internal object.

In the case of WebMediaPlayerImpl::setVolume(), the value can always
be used immediately, so the setVolume() in DoLoad() appears to simply
have been unnecessary.

BUG=401415

Review URL: https://codereview.chromium.org/443393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288080 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401501

Review URL: https://codereview.chromium.org/448153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288079 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/449053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288078 0039d316-1c4b-4281-b951-d872f2087c98

This should prevent problems such as described in

  [chromium-dev] PSA: clobber build needed for IDR_INSPECTOR_*
                 compile errors in blink_platform_impl.cc

Depends on https://codereview.chromium.org/431883002

BUG=400860
TBR=brettw

Review URL: https://codereview.chromium.org/430083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288077 0039d316-1c4b-4281-b951-d872f2087c98

ChromeUserSelectionScreen::Init() used to access the |users_| member of
its parent class even though it already knows the user list. This CL
removes the unnecessary access and marks |users_| as private.

BUG=398511
TEST=No compilation errors

Review URL: https://codereview.chromium.org/446383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288076 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333201

Review URL: https://codereview.chromium.org/450543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288075 0039d316-1c4b-4281-b951-d872f2087c98

The Intent.getClipData() method is only available in JellyBean MR2 and
higher. The code does a correct version check, but the lint checker is
not satisfied with this check.

BUG=401333,348912

Review URL: https://codereview.chromium.org/447253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288074 0039d316-1c4b-4281-b951-d872f2087c98

This code is no longer needed as process priority is no longer being changed in-process as this was causing tab switching latency.

BUG=398103,381820

Review URL: https://codereview.chromium.org/441003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288073 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes tombstones.py architecture detection in two ways:
 - If the tombstone contains an ABI line, use this in preference to the devices
   default ABI, since some devices support multiple ABIs (e.g., 'arm' and 'arm64').
 - Map the abi to an arch which the stack tool accepts, e.g., armeabi-v7a -> arm, arm64-v8a -> arm64.

NOTRY=true

Review URL: https://codereview.chromium.org/446273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288072 0039d316-1c4b-4281-b951-d872f2087c98

This patch exposes a method to kill a child process service of a given
pid, allowing regression integration test for http://crbug.com/399521 on
the embedder side.

BUG=399521

Review URL: https://codereview.chromium.org/441363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288071 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288070 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/444423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288069 0039d316-1c4b-4281-b951-d872f2087c98

During login, GAIA sends the "Google-Accounts-SAML=Start" and
"Google-Accounts-SAML=End" headers to indicate when a redirect to a SAML
IdP starts and ends. This CL uses these headers to distinguish between
cookies set by GAIA and the IdP:
* Any cookies set between the start and the end of the redirect were
  created by the IdP.
* Any cookies set before the start or after the end of the redirect
  were created by GAIA.

This allows cookies set by the IdP to be copied to the user's session
while ensuring that GAIA cookies are not copied (these need to be
transferred to the session via GAIA's /MergeSession API).

BUG=381123
TEST=Extended browser test; also manual

Review URL: https://codereview.chromium.org/447013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288068 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400734

Review URL: https://codereview.chromium.org/451523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288067 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288066 0039d316-1c4b-4281-b951-d872f2087c98

The new list does not have the leading "net::ERR_", to slightly reduce
the size of net when compiled.  This reduces the size of libcronet.so
by about 8k, with symbols stripped.

Also add a function to get network error strings without the leading,
"net::" as a number of consumers were removing it with duplicated code.

This CL slight breaks NetLog loading functionality - loading old logs
in new versions  will result in error codes missing the leading "ERR_",
and the other direction results in error codes having an extra leading
"ERR_".

BUG=399025

Review URL: https://codereview.chromium.org/432553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288065 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179693:179699&mode=html
TBR=jbroman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/447223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288064 0039d316-1c4b-4281-b951-d872f2087c98

Add a new method SetUserPermission() to set the user's permission for a file.
Check the permission in DeleteResource(), TrashResource(), UpdateResource() and InitiateUploadExistingFile().

This change doesn't cover:
- Permission check for the parent when adding/removing entries to a directory.
- Cases where the permission is changed while upload is in progress. (even not sure what happens in the production)

BUG=340933
TEST=unit_tests --gtest_filter="FakeDriveServiceTest.*"

Review URL: https://codereview.chromium.org/445793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288062 0039d316-1c4b-4281-b951-d872f2087c98

It was confusing to figure a TrackerIDSets did not have active trackers
- DB had an entry with kInvalidTrackerID in value.
- DB did not have entries to figure out an active tracker.

This CL drops the first situation.


BUG=None
TEST=./unit_tests --gtest_filter="Metadata*"

Review URL: https://codereview.chromium.org/442713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288061 0039d316-1c4b-4281-b951-d872f2087c98

It doesn't do anything fancy but allows Blink to stop supporting the
previous API.

BUG=400158

Review URL: https://codereview.chromium.org/421293010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288060 0039d316-1c4b-4281-b951-d872f2087c98

Since we now correctly report display rotations (ie. non 0 values), this
caused a regression. The Ozone backend might not require this too.

BUG=399571

Review URL: https://codereview.chromium.org/437593007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288059 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/443303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288058 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288057 0039d316-1c4b-4281-b951-d872f2087c98

DevTools: remove unused resizing strategy code paths, make it solely bounds-based; support hidden inspected contents case.

TBR=tsepez (removing method from devtools dispatcher)
NOTRY=true

Review URL: https://codereview.chromium.org/440663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288056 0039d316-1c4b-4281-b951-d872f2087c98

BUG=398337

Review URL: https://codereview.chromium.org/419033012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288055 0039d316-1c4b-4281-b951-d872f2087c98

Turning off AVFoundation by default on ToT, Canary, and in field trials
in preparation for M38 branch cut.

BUG=396810,394315,356106

Review URL: https://codereview.chromium.org/443783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288054 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288053 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288052 0039d316-1c4b-4281-b951-d872f2087c98

Update manually triggered try jobs to use swarming for ChromeOS and Mac since they're switched by CQ already.

TBR=ben

Review URL: https://codereview.chromium.org/450583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288050 0039d316-1c4b-4281-b951-d872f2087c98

Old code was too restrictive, and did not properly select the correct quad.
New code chooses the topmost overlayable plane that does not intersect any
rects above it.

Review URL: https://codereview.chromium.org/440193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288049 0039d316-1c4b-4281-b951-d872f2087c98