- 03 May, 2019 40 commits
-
-
Donn Denman authored
BUG=958954 Change-Id: Id4fa46cc7d1f7a87dafb7ba4f71ed443933db696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592700Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#656467}
-
Dave Tapuska authored
The PR has been merged into the fetch spec. https://github.com/whatwg/fetch/pull/853 BUG=348877 Change-Id: I5e06ebee3b968e569453df51a441338fb93df72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566154Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#656466}
-
Erik Luo authored
Fixes a crash while highlighting nodes. Some nodes do not have font properties calculated, so this CL adds a check. Bug: 958958 Change-Id: I5b8c56ce378aa2b545c237674ca8ba81d61c2273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592231Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#656465}
-
Andrey Kosyakov authored
This reverts commit d88313dc. Reason for revert: broke build on chromeos bots: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8914459008811246352/+/steps/compile/0/stdout Original change's description: > cros: Move OobeScreen entries into the respective handlers. > > TBR=yusukes@chromium.org > TBR=xiyuan@chromium.org > TBR=antrim@chromium.org > > Bug: 928555 > Change-Id: I058355af1b411eb7bb4b68b9cfc1aa2c61d7cad0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584992 > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656457} TBR=tbarzic@chromium.org,jdufault@chromium.org Change-Id: Idaee1caf8d136f42239dcb2664a2441eaed93cd4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 928555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594340Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#656464}
-
Saman Sami authored
SkiaRenderer already works on Windows when direct composition is disabled (with some minor quirks during resize) so don't automatically fail to create an output surface on Windows. Change-Id: I420d8a288c1e11d1f68ef9f339019545a35f2aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594833Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#656463}
-
Chris Hamilton authored
This moves the WeakPtr to be an internal member of the proxy class, hiding it as an implementation detail. This will allow the future RenderProcessHostProxy and RenderFrameHostProxy to have parallel interfaces. Change-Id: Ic8215257373fdf3b515f54eecbcadb493240f01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591962 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#656462}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4fe8eb31e4a4..dcc9fd7958e7 git log 4fe8eb31e4a4..dcc9fd7958e7 --date=short --no-merges --format='%ad %ae %s' 2019-05-03 chrisforbes@google.com Add input attachment support for VK_FORMAT_A2B10G10R10_UINT_PACK32 2019-05-03 chrisforbes@google.com Add support for VK_FORMAT_A2B10G10R10_UINT_PACK32 render targets 2019-05-03 chrisforbes@google.com Fix blitter clears of 2D views of 3D textures Created with: gclient setdep -r src/third_party/swiftshader@dcc9fd7958e7 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/131171141,chromium:b/131896622,chromium:b/nnn TBR=swiftshader-team+autoroll@chromium.org Change-Id: I73a1d0ea26407ee5818364a8bd71c969bbbb1482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594815Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#656461}
-
Jeffrey Cohen authored
This is the most reliable way to make sure send tab to self information is not tracked for syncing purposes while sync is paused (DICe signout). Bug: 950642 Change-Id: I4998ea2bcfeb651590c4914249d12e170da13f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593401Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#656460}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/86c72c9486a9..c0640dabfddd git log 86c72c9486a9..c0640dabfddd --date=short --no-merges --format='%ad %ae %s' 2019-05-03 johnkslang@users.noreply.github.com Merge pull request #1758 from jeffbolznv/convertonly 2019-05-03 cepheus@frii.com Fix #1759: Check for specialization constants when literals required. Created with: gclient setdep -r src/third_party/glslang/src@c0640dabfddd The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org,jmadill@chromium.org Change-Id: Ic8cddb5aa707993aa0b8dcec4a89ca66aece4dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594102Reviewed-by:
-
Dan Beam authored
R=kristipark@chromium.org BUG=none Change-Id: Iaf5f7f5d0c5cefd4e6aec0fd5b1b415c95376043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592865 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#656458}
-
Jacob Dufault authored
TBR=yusukes@chromium.org TBR=xiyuan@chromium.org TBR=antrim@chromium.org Bug: 928555 Change-Id: I058355af1b411eb7bb4b68b9cfc1aa2c61d7cad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584992 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#656457}
-
Jacob Dufault authored
TBR=antrim@chromium.org Bug: 912704 Change-Id: I998eb80102e9887872bd528098e93364836cf1e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1407080 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
-
Chris Harrelson authored
Previously, we skipped a render surface for a rotated clip (rounded or not) when the FastBorderMask runtime feature was enabled. Also, made the unittests in paint_artifact_compositor_test work with FastBorderRadius mode. Bug: 947715 Change-Id: Ib5d0afd645c10cf219e2db7cb9c19a7155be97e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594333 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#656455}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8b263bbf..8482f451 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iad58155d9af992d911a4ebfbbe7995677ace3af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594795Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#656454}
-
Darwin Huang authored
Bug: 954777, 956851 Change-Id: I68aece116d9de89e446186ca49393daa179390c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592638Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#656453}
-
Vincent Boisselle authored
This is a reland of c6677df1 Original change's description: > Added handling of large requests to Autofill API. > > Increased the limit of Query GET requests, added a POST Query fallback, and > added UMA metrics to keep track of URL length and associated events. > > This change might be needed when metadata is enabled. > > Bug: 948862 > Change-Id: If0934a685758ab8999ceea6ce22a27499e4f772f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549615 > Commit-Queue: Vincent Boisselle <vincb@google.com> > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656080} Bug: 948862 Change-Id: I29eee8f16ae6c3775eb31e8e95d4a289c31f1485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594618Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#656452}
-
Anthony Vallee-Dubois authored
This removes a few functions that were only related to logging translate events in EventLogger, which isn't happening anymore as of r650268. Bug: 911781 Change-Id: I5e78edb77c9723ed331e23a58a6d960ffbc15cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584422Reviewed-by:
Alexandre Frechette <frechette@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#656451}
-
Huanzhong Huang authored
In normal mode, a table view has such default behavior that a table view cell's selectedBackgroundView hides its separator. In order to conform to the new interface design and keeps separators appearing (when cell in selected state), we discard the default behavior and resort to manually maintain the backgroundColor of a cell in the new Clear Browsing Data dialog. Bug: 935346 Change-Id: Ia9decf2be993c2c61a53166e6892397dc0e5f5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591531Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#656450}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f27057bbc6ff..cca9447f6282 git log f27057bbc6ff..cca9447f6282 --date=short --no-merges --format='%ad %ae %s' 2019-05-03 dberris@chromium.org Python3: Remove references to xrange Created with: gclient setdep -r src/third_party/catapult@cca9447f6282 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@chromium.org Change-Id: Ib23a9418d172222be3f1f9af01de381db4aec7d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594814Reviewed-by:
-
Dan Harrington authored
This reduces the number of methods for deleting pages, and re-uses query code from get_pages_task within delete_pages_task. Bug: 949162 Change-Id: I84c0a8de090af5bfe84b0642875f8593aa0d5e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544197Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#656448}
-
Robert Ma authored
* Background: One test file in WPT can generate multiple tests, so WPT tools generate MANIFEST.json to cache the mapping, along with some other info. Previously, WPTManifest.ensure_manifest needs to be explicitly called in various places where MANIFEST.json might be needed. This leads to duplication of code and even bugs: e.g. run_web_tests.py (specifically, blinkpy.web_tests.controllers.manager) would not generate manifests when running only virtual suites because the code uses an incorrect condition (whether WPT is in the specified paths) to decide whether to generate manifests. * Changes: This CL moves the manifest generation into the base Port where all code paths (except test_importer.py) that need to load the manifests would eventually end up, which not only simplifies the code but also fixes the bug described above. One caveat is that multiprocess workers now need to explicitly disable manifest update to avoid race conditions. In addition, WPTManifest.ensure_manifest now takes a Port instead of Host because ports may override the path to web tests (e.g. TestPort). A few mechanical changes are added by the way to make pylint happier (indentation, line wrapping, etc.). Bug: 953474 Change-Id: I70da9e80ab1d506319df24b246d88cd949a92fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589266Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#656447}
-
Robert Ogden authored
Move this flag before checking if hints are loaded so that we can still do testing when they aren't. Bug: 959210 Change-Id: I8ea430ca3d30108705ac20511bbc1c4623c41a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594793Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#656446}
-
Kevin Marshall authored
LoadUrlAndExpectResponse's use of InterfacePtr is unnecessarily restrictive given that the function body doesn't interact with channel- level details directly. Using an Interface raw pointer is a better fit, and allows callers to pass in NavigationControllers when a NavigationControllerPtr isn't available. Change-Id: Ib1a1fbbc3e9373219971d4290deecf3f33904908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590959 Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#656445}
-
Xiaocheng Hu authored
The virtual test suite was added to test visual left/right caret movements under BidiCaretAffinity runtime flag. However, due to the decision of chaning left/right movements from visual to logical, the virtual test suite no longer serves its purpose, but blocks the behavior changea instead. Hence, this patch removes the virtual test suite for now. Bug: 958831, 894651 Change-Id: I0c62ab22d272c04d5dbb825a08a1060506f9a885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594806 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#656444}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b670120619c..caf7bdf789eb Created with: gclient setdep -r src-internal@caf7bdf789eb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=gogerald@chromium.org,caseq@chromium.org,ksakamoto@chromium.org,drott@chromium.org Change-Id: I5ec0cc335dc83ab244467cbad489a6ee3a70a3c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594812Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#656443}
-
Seth Hampson authored
This is a reland of 1aaab3f0 Original change's description: > Disallows reusing RTCIceTransport. > > Currently if an RTCIceTransport that comes from an RTCPeerConnection is > reused to create and RTCQuicTransport there is a crash. This disallows > this from happening by throwing an exception if the client attempts to > do this. > > Bug: 10589 > Change-Id: Idcf538972516825fef3b275d062a19d0bd7a68c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593872 > Commit-Queue: Seth Hampson <shampson@chromium.org> > Reviewed-by: Steve Anton <steveanton@chromium.org> > Auto-Submit: Seth Hampson <shampson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656241} Bug: webrtc:10589 Change-Id: I879d3149e3fd3585e1efa395f63917bc94970efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594691Reviewed-by:
Steve Anton <steveanton@chromium.org> Commit-Queue: Seth Hampson <shampson@chromium.org> Cr-Commit-Position: refs/heads/master@{#656442}
-
Eric Willigers authored
We were incorrectly accepting "ellipse(10px at 20px 30px)" as an ellipse. Retire use count BasicShapeEllipseOneRadius 0.00002% https://chromestatus.com/metrics/feature/timeline/popularity/2327 We were incorrectly serializing "ellipse(10px closest-side at 20px 30px)" as "ellipse(10px at 20px 30px)" BUG=899150 Change-Id: I6594ff990f659be2497acb336afbb138b5d91ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593882 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9c0620120980..5b1f4aaf31d8 git log 9c0620120980..5b1f4aaf31d8 --date=short --no-merges --format='%ad %ae %s' 2019-05-03 oprypin@chromium.org Revert "Reland "bot_update: Pass target-ref to gclient."" Created with: gclient setdep -r src/third_party/depot_tools@5b1f4aaf31d8 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:956807 TBR=agable@chromium.org Change-Id: Ib5b1081c897f580b793ca4652f960567ba02811d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594107Reviewed-by:
-
Jordan Werthman authored
Much like dynamic_annotations, Chromium's //base contains a copy of base/thread_annotations.h which causes macro classes and ODR violations when compiling a target with both //base and Abseil. In order to prevent these issues, the ./rename_dynamic_annotations.sh script has been generalized to also rename base/thread_annotations.h macros and symbols. Verified that WebRTC uses its own custom thread_annotations.h with "namespaced" macros and GoogleTest does not include thread_annotations.h so this change should be a no-op for all targets currently depending on Abseil. Bug: None Change-Id: I1b0115128aa22f4a3982082ede437ae8f0324bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592684Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Jordan Werthman <jordanjtw@google.com> Cr-Commit-Position: refs/heads/master@{#656439}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6ad5289ea4b3..09db9d21756e git log 6ad5289ea4b3..09db9d21756e --date=short --no-merges --format='%ad %ae %s' 2019-05-03 herb@google.com Reland "SkShaper JSON output with cluster visualization" 2019-05-03 jvanverth@google.com Move GrMtlBufferManager functionality to better places 2019-05-03 halcanary@google.com Shaper : new unit test 2019-05-03 halcanary@google.com SkShaper: new benchmarks Created with: gclient setdep -r src/third_party/skia@09db9d21756e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I72cf891fec46fcea148d42568a0435a258af8ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594108Reviewed-by:
-
Sean Risser authored
We removed the definition a while ago, but forgot to remove the declaration in the header. BUG=959231 Change-Id: I6e58af7a4337df8957bb4f8c5b6b670fd9233252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594892Reviewed-by:
Joe Mason <joenotcharles@google.com> Commit-Queue: Sean Risser <srisser@google.com> Cr-Commit-Position: refs/heads/master@{#656437}
-
Anastasia Helfinstein authored
Bug: None Change-Id: I6dd41369875d445a90598e01c4c31f59094e267e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592681Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
Removes some public methods from NGPhysicalBoxFragment, and NGPhysicalContainerFragment. There should be no behaviour change. Change-Id: Icf7612405b756b44121e223be8ecf24ca47d7151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591882Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#656435}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9e3af8d9. With Chromium commits locally applied on WPT: e28269b6 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." aff3c8fe "Add tests for crbug.com/363609 and crbug.com/954591" c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" 25e7f8dd "Reland "Reland "bluetooth: FakeBluetoothChooser impl.""" 501ae8c7 "Use testdriver Action API in WPT pointerevent tests - Part 4" 1aaab3f0 "Disallows reusing RTCIceTransport." b7c13214 "Revert "Disallows reusing RTCIceTransport."" ccb097db "Revert "Use testdriver Action API in WPT pointerevent tests - Part 4"" 7e454669 "[EventTiming] Increase threshold to dispatch entries" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I918cf8e081424a5780d089ff995aee5c7656e022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592390Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#656434}
-
Nicolas Ouellet-Payeur authored
This CL splits //headless:headless into 2 components: - :headless_renderer - :headless_non_renderer :headless_renderer is intended for child processes, and has a smaller footprint than :headless_non_renderer. For release builds, this reduces the size of chrome_child.dll by about 9.7MB. Bug: 929408 Change-Id: I514a1bb5604f8ab8d6c6031970b5c7a965a8393d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570654Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/29afe3e4c351..14fc5d16ccf4 git log 29afe3e4c351..14fc5d16ccf4 --date=short --no-merges --format='%ad %ae %s' 2019-05-03 saklein@chromium.org SdkService/Create: Fix chroot version fetch for non-default chroot paths Created with: gclient setdep -r src/third_party/chromite@14fc5d16ccf4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I04ce599206ee14c1b5de1ad81e06060b97f5a2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594813Reviewed-by:
-
Wei Li authored
View's subclasses use quite a few base::string16 type properties. We need to add support for such type in MetaData. Also, this CL added support to a general setter type for a complex property whose setter should take a constant reference. This CL also added a string16 property -- Combobox's AccessibleName as an example. TBR=pkasting@chromium.org BUG=938501,957271 Change-Id: I9a06cf411871450b85d9ccf273776966cf182977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592194 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#656431}
-
Becky Zhou authored
+ Change download storage permission icon to primary icon color + Unify download stroage permission dialog text style + Update icon and text color on text bubble for dark mode Bug: 958489, 958501 Change-Id: I8a8003191a3ec28a01fd6d905997fbb0182361ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592620Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#656430}
-
Gaofeng Huang authored
The existing code of GetProcessType() never works, because it's always running in browser process. Bug: internal b/128680778 Change-Id: I8ad7b2ccfdef036c05cbb4aeaf791b334c41d3ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589010Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Gaofeng Huang <gfhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#656429}
-
Kenneth Russell authored
This format is exposed via a WebGL 1.0 extension and was missed when adding validation of texture and sampler types. The passthrough command decoder and ANGLE don't have the same bug. Bug: 957371 Change-Id: I3c73bbeda61f25515181dff5a1fc5d0bd27821ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594238 Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#656428}
-
