GitLab

Originally this was reverted since crrev.com/c/1685909 needed to be
reverted. crrev.com/c/1685909 now relanded.

After crrev.com/c/1685909 we won't be reading from a buffer
while scanning it out. We can re-enable partial swap on Mali.

Bug: 457511
Change-Id: I6b41161925d0d4bb65eb19250ad5747af5493184
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830084Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702193}

This reverts commit 16cbcb68.

Reason for revert: Broke https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/3254; see bug for details.

Original change's description:
> Add content_nocompile_tests to be run by some builders.
> 
> Bug: 878706
> Change-Id: I5c3bd7d4393fe6c002171ff9937ad70d2b1ba191
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833297
> Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#702132}

TBR=martiniss@chromium.org,gbeaty@chromium.org

Change-Id: Iacc49c8ad3330977d0779baa7815ebae7e807753
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 878706
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835262Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702192}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I2fc703395a92ebcc813ac8f3c6cb6a6d681e52cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836351Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702191}

crrev.com/700518 incorrectly assumed
PreviewModeClient::ProposeDocumentLayout() could not be reached. In
fact, the PreviewModeClient is used only when previewing non-PDF
documents with more than 1 page.

This change also adds a browser test to check the behavior of the print
preview dialog when printing multiple pages: Current print preview tests
only generate a single page, which fails to exercise this issue.

The crash occurs after the print preview is "ready" (all pages have been
rendered), but before the print preview dialog has "loaded" completely.
Current tests only wait for the "ready" condition, but the new test must
wait for the "loaded" condition. Since fully loading is slow, most tests
continue waiting only for the "ready" condition.

Bug: 885110
Change-Id: I20316fd658d5a125a13f08d07ced4dd79884fac7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835211
Auto-Submit: K Moon <kmoon@chromium.org>
Commit-Queue: K Moon <kmoon@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702190}

Bug: 1009831
Change-Id: I9afd34546b9520f34a206a4d026761ab130162bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835705Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702189}

Similar to https://chromium-review.googlesource.com/c/chromium/src/+/1836031
this patch disables another very flaky test causing failures
on the bots.

Example bot:
https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-arm64-rel/17969

Flakes:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=PasswordGenerationIntegrationTest

TBR: vasilii@chromium.org, fhorschig@chromium.org
Bug: 1010540
Change-Id: I684f794a971dc1b44a98e54184c8b0b475578d6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835167Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702188}

Adds a new PLMObserver, SubresourceLoading, to track these metrics.

Bug: 995437
Change-Id: I049d96eafd93b089b06131fb8ad35eb30d0c3a6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829881
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702187}

Bug: 978172
Change-Id: I5ef4a0d189fc1e17bfa235f2aecef2853d89c006
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834888Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702186}

Cleaned up the TraceController public API a little bit by removing
the metadata DictionaryValue which is now inlined in the JSON rather
than treated as separate data, and hold the tracing data in
a std::unique_ptr<std::string> rather than a RefCountedString
as the data only has one owner at any time.

Split out from and already LGTM'd (the tracing bits) in
https://chromium-review.googlesource.com/c/chromium/src/+/1817207/28

TBR=ssid@chromium.org,zork@chromium.org,erikchen@chromium.org,boliu@chromium.org

Bug: 839086
Change-Id: I84a717e7c6915a81348d7e91fbd6fe2ba00a4d46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834576
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702185}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4c982147..bbb8c722

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I4d510151989360ca6ea1c461801ac55178320cb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835712Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702184}

Follow-up to commits 4ba0b61c ("Convert ShareService client to use
BrowserInterfaceBroker"), 1dec3c1c ("Convert WakeLockService client to use
BrowserInterfaceBroker") and e676be1f ("Convert PermissionService client
to use BrowserInterfaceBroker").

Essentially, the BrowserInterfaceBroker conversion introduced flakiness to
some unit tests, and this CL fixes the ones I have noticed. The flakiness is
caused by the fact that we after the first test case we end up trying to
rebind an already bound object, which often leads to DCHECKs and other
crashes.

Follow what is done in commits 567040bd ("[mojo] Convert
CredentialManagerProxy to use BrowserInterfaceBroker") and
b5630d76 ("Convert NFC client to use BrowserInterfaceBroker") and explicitly
remove the test binders between test cases.

Bug: 936482, 1010116
Change-Id: If31d8f3dfb95c69651265a6e8cdcebdfb3816728
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835360
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#702183}

https://chromium.googlesource.com/angle/angle.git/+log/514d5e281c03..d46e2fb1e341

git log 514d5e281c03..d46e2fb1e341 --date=short --no-merges --format='%ad %ae %s'
2019-10-02 jmadill@chromium.org GN: Componentize vulkan back-end build.
2019-10-02 geofflang@chromium.org GL: Temporarily disable GPU copy paths for rectangle texture sources.
2019-10-02 jonahr@google.com Ensure Features* descriptions stay up to date

Created with:
  gclient setdep -r src/third_party/angle@d46e2fb1e341

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@google.com

Bug: chromium:990368
Change-Id: I4dd6c32438de4eecc7786354704827a752ac7157
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836271Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702182}

This CL was partially created by
//base/android/jni_generator/jni_refactorer.py.

The conversion also required converting unit tests to use the new JNI
mocking approach provided by JniMocker.

Bug: 929661
Change-Id: Iadd97ce4a911792b922cff8803143d0d8c847f43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832297Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702181}

The notification will be shown, when that accessibility
feature is being managed by a policy, and is being disabled.

Bug: 552439
Change-Id: I7d9d9332f64df992291939a620afcb0e736b8904
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829354
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702180}

Bug: 785493,959368
Change-Id: Id9aad4c62b617f2c0cd2b2269624dd1f211edb7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829951Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702179}

Bug: 1006965
Change-Id: I31e9b1c617f4718b08cea3e3d62e4c5ce429ec87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834567Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702178}

was introduced without sufficient testing.

We may have added monitoring selection-move requests for Smart
Text Selection integration, but it's way too noisy, and still
seems to work.

BUG=956277, 1006676

Change-Id: Ia750c04070c5b214a0c63d52e1ce8bd97373f865
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835173
Commit-Queue: Donn Denman <donnd@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702177}

BUG=762641
TBR=xiyuan@chromium.org

Change-Id: If60a409571190b5fa88535a41cd31108b2909291
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835214Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702176}

After recent CLs (r699929, r700322), there are no more overrides of
ContentBrowserClient::ShouldAllowOpenURL.  This CL takes advantage of
that, and removes the ContentBrowserClient::ShouldAllowOpenURL method
entirely.  Removing callers of this method is straightforward - we just
observe that the default implementation of the method always returns
true.

The CL is careful to preserve test coverage in tests that used to rely
on ShouldAllowOpenURL overrides:

1. After the CL, the TestContentBrowserClient in
   //chrome/browser/prerender/prerender_browsertest.cc still "cancels
   all prerenders on OpenURL" (doing this from an overload of
   OverrideNavigationParams instead of from an overload of
   ShouldAllowOpenURL;  OverrideNavigationParams is called from
   NavigatorImpl::RequestOpenURL exactly once during the test).

2. The CL refactors and moves service worker tests as follows:
   2a. ServiceWorkerClientsApiBrowserTest.NavigateDisallowedUrl
       moves from //content to //chrome layer and becomes
       ExtensionResourceRequestPolicyTest.
       WebNavigationToNonWebAccessibleResource_ViaServiceWorkerNavigate
   2b. ServiceWorkerClientsApiBrowserTest.OpenWindowDisallowedUrl
       moves from //content to //chrome layer and becomes
       ExtensionResourceRequestPolicyTest.
       WebNavigationToNonWebAccessibleResource_ViaServiceWorkerOpenWindow
   2c. ServiceWorkerClientsApiBrowserTest.OpenWindow is refactored to
       use exiting testing helpers which are more detached from
       implementation details (using OpenURL is an example of an
       implementation detail) and more focused on end-to-end
       verification (e.g. that a new window is actually opened;  not all
       calls to OpenURL end up opening a new window).
2a and 2b preserves the essence of the existing test coverage, since
ShouldAllowOpenURL was mostly replaced by ExtensionNavigationThrottle -
see r699929.

To support the move in #2, the CL performs the following additional
changes:

- Moving the code to simulate dispatching of a service worker
  notification click from ServiceWorkerClientsApiBrowserTest to
  DispatchServiceWorkerNotificationClick - a standalone helper function
  in //content/public/test/service_worker_test_helpers.cc

- Tweaking client_api_worker.js to support calling openWindow with
  a custom URL, provided by a test via notification body.

Bug: 1003957
Change-Id: I486d153ca03a10a30a39204cfe6dc88e726f854d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829539
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702175}

This reverts commit 0e20fdf5.

This reverts a fix that will be reintroduced later on once we add
the WillReadFrequently to the creation of canvases.

Bug: 1001845, 983642, 1008179
Change-Id: I4e5aa58af69e1b202962eee37177e5cd0401c9a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829794
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702174}

Bug: b:141990654
Change-Id: I249a7bf9fb124877a540760d4e547f9f0d4b9a7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836138Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#702173}

Each ANGLE feature also has a 'condition' that can be queried and
displayed to the user.

Bug: angleproject:3947
Change-Id: Iff466f9861d96346bb5602cbd92e93303a0746b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830281Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Cr-Commit-Position: refs/heads/master@{#702172}

The |is_legacy_tls_control_site| member wasn't initialized in the
VisibleSecurityState constructor. This was causing an MSAN bot crash.

See activity on the previous CLs:
- https://crrev.com/c/1829462
- https://crrev.com/c/1832665
- https://crrev.com/c/1833172 (revert of 1829462)
- https://crrev.com/c/1833173 (revert of revert)

Bug: 989607
Change-Id: I1ee8627bbfec4839184ce041ce375d96855a4d88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836133Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Auto-Submit: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702171}

This CL is for adding UMA metrics for clipboard text suggestion and
removing clipboard suggestions. There are 6 set of metrics.

MobileOmnibox.LongPressPasteAge
MobileOmnibox.PressedClipboardSuggestionAge
Omnibox.ClipboardSuggestionShownAge
Omnibox.ClipboardSuggestionShownNumTimes
Omnibox.ClipboardSuggestionShownWithCurrentURL
Omnibox.ClipboardSuggestionRemovedAge

And each of metrics also has two sub categories, URL and TEXT.
The Age metrics can help us to understand if we should reduce
suggestion age. For example, now, we suggestion content in
clipboard to omnibox if the content in clipboard is less than
60 minutes in Android. Age related metrics can help us to understand
user's behavior, so we can make 60 minutes longer or shorter.
Usage related metrics can help us to understand user's interesting
and what we can improve.

More detail about this metrics, please
refer to metrics section in the design Document in crbug.com/977402.



Bug: 998932
Change-Id: I9cbf3e71bb5240ae3d41fd900a85d858829bfbf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825492
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702170}

This change adds a base::Feature which can be enabled via command line
for integration tests to lower the age threshold for Lax-allow-unsafe
cookies from 2 minutes to 10 seconds, to avoid having tests that run
for 2 minutes in order to test behavior after Lax-allow-unsafe expires.

Bug: 1007489
Change-Id: I7ecc29f1ad970e391a8cf8abae220fed292877a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833705Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702169}

This reverts commit 4fd8200f.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 702040 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRmZDgyMDBmODk4MDE5ZjJhZTg5MmM1NDVhNzBkMDdmYThmODA3MjkM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/19673

Sample Failed Step: interactive_ui_tests

Original change's description:
> Clarify ScrollView scrollbar ownership.
> 
> Change-Id: I93162b75b817fdf8488b33009e13775da3a890df
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825620
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Auto-Submit: Allen Bauer <kylixrd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#702040}


Change-Id: Ic4a23e9e4bd7960f205d170ba1273e3bc588372e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835169
Cr-Commit-Position: refs/heads/master@{#702168}

Ran `./tools/clang/scripts/upload_revision.py 64a362e7216a43e3ad44e50a89265e72aeb14294`.

...and fix one last Chrome OS-only new -Wtautological-compare warning.

Bug: 1006756,1007367
Change-Id: Id87271c20d8ca66a9a498de8fb716d818d279b48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835192
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702167}

This CL does two things:

1) exposes if Vulkan is enabled on chrome://gpu

2) adds vulkan feature which can be disabled by
gpu/config/software_rendering_list.json file based on environment.

Bug: 1002166,887018
Change-Id: Iee4b4e38e5e3761aeba1530a0d64d128f5aa9ae8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832293Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702166}

The intrinsic dependencies encountered along the way made it difficult
(less effective) to break up this CL into multiple smaller CLs
(apologies to the reviewers in advance).

To simplify its understanding, please refer to the following doc:
https://docs.google.com/document/d/1ClZglFQroV53zSYEGIZ7yca8KIsPHGBmzMCbtreu5lg

The following are the major points to review:
- refactoring of the infra into builder, installer, logger, observer, util
- new design (IoC driven) for installers to enable for easy testability
- new design for emitted modules (cross-package communication)

Out-of-scope (following CLs):
- removal of bytecode processing for third-party activities (no longer needed)
- move code from ModuleInstallerConfig.java into BuildConfig.java
- unit tests for the remaining module_installer classes

Testing: this change was verified with vr, ar, autofill_assistant, dev_ui,
and test_dummy modules. It was tested with both -m and -f command line args.

Bug: 1005802
Change-Id: Icf357c06c4b71a96ed9fa0584f6322d6dc6143d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813520Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Fred Mello <fredmello@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702165}

base::Bind/base::Callback are deprecated in favor of either
base::BindOnce/base::OnceCallback or base::BindRepeating/
base::RepeatingCallback (depending on whether the callback
is invoked once or multiple time).

Convert all uses of base::Bind/base::Callback in sandbox/{win,linux}
to the recommended methods/types.

Bug: 1007829, 1007830
Change-Id: I5a6e03e2b823f1c2b3f48317b0451911f192b99f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835581
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702164}

This makes it easier to grep for TestDummyImpl results without requiring
physical access to the test device.

Bug: None
Change-Id: I35efca8d54a7fec9385262ca4bc6908b8692115d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835706
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702163}

WrapReverse is implemented in LayoutFlexibleBox instead of
FlexLayoutAlgorithm. This CL implements those parts for LayoutNG.

Bug: 845235
Change-Id: I53245d2c7bb4680d846dc5ef4b8b4a3002d95126
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808496
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702162}

Bug: 1005217
Change-Id: Ia30a45781b719dd53fee3736982b63114ee191dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835163
Auto-Submit: Lily Chen <chlily@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702161}

Remove call to SetShouldDoFullPaintInvalidation()
in LayoutBlockFlow::DetermineStartPosition() that was done just after
SetNeedsLayoutAndFullPaintInvalidation(), as this is already called
at the end of that method.

Change-Id: If53e4e3e5aba9a6f3c424d3f5b805151fd9223b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834084Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#702160}

This adds an X close button on removable suggestions, assuming the
user has the kOmniboxSuggestionTransparencyOptions flag enabled.

A followup CL will remove the context menu, so there will be no code
duplication.

Bug: 1205, 929477
Change-Id: I7c921c6051dc4f53fc55e9bd5922d827968735da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834247
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702159}

This object is never null so a reference is more appropriate.

Change-Id: Ib3129973c6b6c226ca4e7ba8df0b14baab26bdea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829795Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702158}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2458b31208f8..6b4c2a88f36e

git log 2458b31208f8..6b4c2a88f36e --date=short --no-merges --format='%ad %ae %s'
2019-10-02 mmoss@google.com Run git_cl commands as a python step.

Created with:
  gclient setdep -r src/third_party/depot_tools@6b4c2a88f36e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: chromium:726111
Change-Id: I4dcda75155e4617243c37676b667a7cdf81255c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835702Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702157}

Bug: 1010561
Change-Id: Ic6b0d656af1944d9dbb16f5fb96d70fe1ad90f14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835157
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702156}

No change to logic.

This adds two header files which this C++ file was depending on
transitively (for base::TimeDelta and OS_ANDROID/OS_IOS).

Bug: 1010369
Test: N/A
Change-Id: I16ceb2d05beaca66ea254f1e1c7ddd541b8ff05c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835132Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702155}

The --force-enable-metrics-reporting switch was previously implemented
to override sampling, but didn't correctly override user consent. This
fixes that, and modifies the unittests to verify correct behavior by
checking the metrics service actual starts up.

To accommodate privacy concerns, this flag does not override app
consent. We separate user and app consent to plumb both values down, and
we add a test case to verify the flag respects app consent.

This also splits the previous test case into multiple cases, which is
necessary in order to initialize the client under two different sets of
conditions.

Bug: 994418
Test: run_android_webview_unittests --gtest_filter=AwMetricsServiceClientTest.*
Test: Opt-out of metrics in settings, AwMetricsLogUploader is called
Test: Opt-out WebView shell in manifest, AwMetricsLogUploader is not called
Change-Id: I1e177bd5e3a5622c694e2275f18408d946b69397
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815545Reviewed-by: Tao Bai <michaelbai@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702154}