GitLab

Previously, creating a TraceValue would store the associated trace_data in
memory and defer serialization until needed. In this CL, the trace_data is
serialized right away into a temporary file to prevent it from being stored in
memory.

BUG=457385

Review URL: https://codereview.chromium.org/920523002

Cr-Commit-Position: refs/heads/master@{#317106}

Revert of Add Autofill to the <webview> chrome://chrome-signin page (patchset #12 id:340001 of https://codereview.chromium.org/866523002/)

Reason for revert:
Introduced crashes in ManagePasswordsUIController::OnPasswordSubmitted:(

https://crash.corp.google.com/browse?q=product.name%3D%27Chrome%27%20AND%20product.version%3D%2742.0.2309.0%27%20AND%20custom_data.ChromeCrashProto.channel%3D%27canary%27%20AND%20custom_data.ChromeCrashProto.ptype%3D%27browser%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27ManagePasswordsUIController%3A%3AOnPasswordSubmitted%27

Original issue's description:
> Add Autofill to the <webview> chrome://chrome-signin page
>
> The change in the chrome_autofill_client.cc is needed to enable the autofill popup on
> Mac.
>
> BUG=447938
> TEST=Start Chrome. Navigate to chrome://chrome-signin. Enter a correct username
> with an incorrect password. After the password error appears, you should be able
> to autofill that username.
>
> Committed: https://crrev.com/4a1e13b16b5ef2cb6f7c800ad3c08f1f44bef285
> Cr-Commit-Position: refs/heads/master@{#314889}
>
> Committed: https://crrev.com/e6d3ca36ec225b0e13e385318c6c4f35fad4ca47
> Cr-Commit-Position: refs/heads/master@{#316899}

TBR=estade@chromium.org,fsamuel@chromium.org,lazyboy@chromium.org,vabr@chromium.org,engedy@chromium.org,jww@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=447938

Review URL: https://codereview.chromium.org/944513002

Cr-Commit-Position: refs/heads/master@{#317105}

Summary of changes available at:
https://chromium.googlesource.com/chromium/third_party/ffmpeg/+log/2e38ab8..d4b1674

BUG=459114

Review URL: https://codereview.chromium.org/919663003

Cr-Commit-Position: refs/heads/master@{#317104}

two_button_menu_item was added in https://codereview.chromium.org/608283004
but it is not used anymore due to menu button removal from the menu popup.

four_button_menu_item was also added to support menu button inside the menu
popup.

BUG=None

Review URL: https://codereview.chromium.org/934353003

Cr-Commit-Position: refs/heads/master@{#317103}

In enhanced bookmark UI, we still showed the partner bookmark node
in the side drawer even if it's deleted.

BUG=460122

Review URL: https://codereview.chromium.org/941733002

Cr-Commit-Position: refs/heads/master@{#317102}

BUG=460137
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/936603005

Cr-Commit-Position: refs/heads/master@{#317101}

Just a small update to the baked-in config for mail.google.com.

BUG=

Review URL: https://codereview.chromium.org/945443002

Cr-Commit-Position: refs/heads/master@{#317100}

Revert of Fix Presentation API mocks: do not eagerly drop clients. (patchset #2 id:20001 of https://codereview.chromium.org/938033002/)

Reason for revert:
This change appears to be causing failures in running layout tests ('webkit_tests' step) of Windows 7 and Linux debug builds. See http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/1363 or http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/9658 .

Original issue's description:
> Fix Presentation API mocks: do not drop eagerly drop clients.
>
> BUG=412331
>
> Committed: https://crrev.com/4ff204b8d2637af0abd8a05485e5941af8ef4271
> Cr-Commit-Position: refs/heads/master@{#317057}

TBR=mkwst@chromium.org,avayvod@chromium.org,mlamouri@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=412331

Review URL: https://codereview.chromium.org/940783003

Cr-Commit-Position: refs/heads/master@{#317099}

This causes Chrome to show a scary infobar when either of these flags is used,
in order to discourage their use in production. They are intended for Chromium
development only.

BUG=454504

Review URL: https://codereview.chromium.org/928593004

Cr-Commit-Position: refs/heads/master@{#317098}

Key IDs and keys used in JSON data should be encoded base64url,
not just base64 with trailing = removed.

BUG=459834
TEST=new tests pass

Review URL: https://codereview.chromium.org/934423002

Cr-Commit-Position: refs/heads/master@{#317097}

bookmark_index.cc, bookmark_model.cc and bookmark_utils.cc all uses
functions from base_i18n.

Review URL: https://codereview.chromium.org/938003002

Cr-Commit-Position: refs/heads/master@{#317096}

Disable now notifications extension in component loader if launcher field trial is running (ChromeOS only)

BUG=460164

Review URL: https://codereview.chromium.org/936203002

Cr-Commit-Position: refs/heads/master@{#317095}

This updates to the following revision: bad2a08db205 (2015-02-17 17:53 +0000)

It includes changes from revision 97c40a737bda (2014-11-21 04:28 +0100) to
revision bad2a08db205 (2015-02-17 17:53 +0000), listed at
http://hg.mozilla.org/mozilla-central/log/bad2a08db205/netwerk/dns/effective_tld_names.dat

R=pkasting@chromium.org
BUG=37436

Review URL: https://codereview.chromium.org/923713005

Cr-Commit-Position: refs/heads/master@{#317094}

Icon and rating view were missing accessibility strings.

BUG=453170

Review URL: https://codereview.chromium.org/926593006

Cr-Commit-Position: refs/heads/master@{#317093}

Revert of Clean up perftesthelper.js style (patchset #2 id:20001 of https://codereview.chromium.org/927583005/)

Reason for revert:
Tough animation cases are failing due to a few missed files in the refactor.

Original issue's description:
> Clean up perftesthelper.js style
>
> This change makes tools/perf/page_sets/tough_animation_cases/resources/perftesthelper.js
> consistent with the Chromium Javascript style guide:
>  - Fixed indentation
>  - Added missing semicolon
>  - Renamed file to be underscore separated
>
> Committed: https://crrev.com/30a1e4bc96550502e8607ac0f0a246eb42a61852
> Cr-Commit-Position: refs/heads/master@{#316965}

TBR=qyearsley@chromium.org,alancutter@google.com,alancutter@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/941773002

Cr-Commit-Position: refs/heads/master@{#317092}

This change adds a new constructor for ui::MouseEvent that takes an accurate
event time for use by the ozone evdev backend. For ui::MouseWheelEvent the
existing constructor was extended to include the timestamp and the existing
users updated.

For mouse moves in the generic handler the time of the EV_SYN message is
used as the time for the event. In events from the gesture library the end time
of the gesture is used. For purely synthetic events EventTimeForNow() is used
which uses the same time source (CLOCK_MONOTONIC) as evdev.

BUG=450341
TEST=Interactive testing on link_freon.
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_chromeos_ozone_rel_ng

Review URL: https://codereview.chromium.org/889673004

Cr-Commit-Position: refs/heads/master@{#317091}

The chromium base policy is to not inline code but since automatically
generated code and templates easily become inlined it can happen
anyway. This explicitly outlines destructors, copy constructors and
assignment operators in the IndexedDB code for a win of
11 KB of x64 machine code. Most of it (maybe 8 KB) from IndexedDBKey.

clang x64 numbers:
Total change: -11795 bytes
==========================
  42 added, totalling +3270 bytes across 13 sources
  25 removed, totalling -5883 bytes across 14 sources
  9 grown, for a net change of +1556 bytes (7936 bytes before, 9492 bytes after) across 6 sources
  60 shrunk, for a net change of -10738 bytes (54277 bytes before, 43539 bytes after) across 17 sources

BUG=

Review URL: https://codereview.chromium.org/933823002

Cr-Commit-Position: refs/heads/master@{#317090}

We shouldn't be asking for native pointers from java. All that was
needed was a WebContents, so use that directly.

getNativePtr isn't called anymore but can't be removed until the downstream
override is gone which needs this patch to roll down.

Review URL: https://codereview.chromium.org/941633003

Cr-Commit-Position: refs/heads/master@{#317089}

Gaia takes full window
Show guest button on gaia screen
Show more settings button for creation supervised users
Hide enterprise container

BUG=451959
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/930953002

Cr-Commit-Position: refs/heads/master@{#317088}

It's possible that this could move to BookmarksBridge but it would
require some more refactoring so start with just upstreaming.

BUG=443773

Review URL: https://codereview.chromium.org/943643002

Cr-Commit-Position: refs/heads/master@{#317087}

This upstreams the privacy screen in settings, which includes navigation
error suggestions, omnibox suggestions, prefetching, crash report
uploading, do not track, and clearing data.

BUG=428869

Review URL: https://codereview.chromium.org/935903002

Cr-Commit-Position: refs/heads/master@{#317086}

BUG=none

Review URL: https://codereview.chromium.org/940033004

Cr-Commit-Position: refs/heads/master@{#317085}

This behavior was updated in https://crrev.com/299939, but the comment
didn't explain why the method might return null.

BUG=none
TEST=No behavior change.

Review URL: https://codereview.chromium.org/938073002

Cr-Commit-Position: refs/heads/master@{#317084}

Now the navigation cancellation logic should conform to what has been described
in the "PlzNavigate: Navigation cancellation" design document [1]. Added some
new tests to exercise the cancellation cases described in the document.

Note: This is being developed on top of http://crrev.com/912833002.

[1] https://docs.google.com/a/chromium.org/document/d/1lO7_fgppFTDd8PSQfIb888z7vODcw2Sc8r7h5Rbiwcg/edit#

BUG=376014

Review URL: https://codereview.chromium.org/914223002

Cr-Commit-Position: refs/heads/master@{#317083}

Review URL: https://codereview.chromium.org/944453002

Cr-Commit-Position: refs/heads/master@{#317082}

This is prep for tooltip improvement: https://codereview.chromium.org/924433002/ (WIP)

* Consolidated GetMaxWidth
* Eliminate screen type argument. This can be obtained from tooltip window.
* Move tooltip truncate code from TooltipManager to TooltipController

BUG=None
TEST=no functional change. all test should pass.

Review URL: https://codereview.chromium.org/916423002

Cr-Commit-Position: refs/heads/master@{#317081}

The BMM PNaCl toolchain doesn't currently support waitid.  Arguably it
should because it's in POSIX, but the userland/Linux signal ABI
mismatch makes it non-trivial because of the siginfo_t.  Since we
don't need the siginfo_t anyway, we can just use waitpid instead.

While here, use WIFEXITED and WEXITSTATUS for interpreting status
instead of directly comparing it to the expected exit code.

Review URL: https://codereview.chromium.org/928963003

Cr-Commit-Position: refs/heads/master@{#317080}

* Fix null pointer access when a shortcut is added via
  a manifest.  It was relying on the WebContents() being
  accessible immediately after stopping the observation of
  the WebContents.

* When adding a shortcut on the homescreen through web app
  banners, stop firing Intents to send the user to the
  home. Instead show a toast to indicate that a shortcut is
  being added to their homescreen.  The string was chosen by UI
  and is described on the bug.

* Hopefully fix the ShortcutHelperTests.

BUG=457424,303486
TEST=ShortcutHelperTest

Review URL: https://codereview.chromium.org/934183002

Cr-Commit-Position: refs/heads/master@{#317079}

I've replaced measuring GetProfile() (which includes cached profiles) with SetupProfile() which is more useful to track. I've added metrics to track the expensive components under SetupProfile(), which are
-chrome::RegisterProfilePrefs
-chrome_prefs::CreateProfilePrefs
-ProfileImpl::OnPrefsLoaded.

There currently are UMA histograms called Startup.SlowStartupPreferenceLoading, but I'm setting up different versions of these. They are tracking almost but not exactly the same things, but the current ones are only triggered for slow startups.
I considered modifying these to add a control version, but I thought adding new ones was better because:
-The histograms I'm adding have better names since they are called what they are actually checking
-I'm measuring at what I think is a better place (inside the method itself instead of near the caller.
-The new histograms are easily comparable for the work I'm doing since they are for all data (can just check percentile data).

Also changed the TRACE argument from path.value().c_str() to path.MaybeAsASCII() since the former was only giving the address inside the trace (I'm guessing it never worked).

If someone wants to have themselves also be added as an owner to any of the new histograms let me know.

BUG=454789

Review URL: https://codereview.chromium.org/937713003

Cr-Commit-Position: refs/heads/master@{#317078}

We add tests that verify that VisualStateCallbacks are
delivered correctly during fullscreen transitions.

BUG=459044

Review URL: https://codereview.chromium.org/941713002

Cr-Commit-Position: refs/heads/master@{#317077}

1) Report total errors while reporting import task statistics.
2) Report addView when volume changes.
3) Send hit when history file changes.

BUG=420680
TEST=browser_test: FileManagerJsTest.*

Review URL: https://codereview.chromium.org/933553003

Cr-Commit-Position: refs/heads/master@{#317076}

This CL adds a regression test for CL 897113003, ensuring that
consumers are notified that the device-global invalidation service
is no longer to be used before it gets destroyed.

BUG=455504
TEST=New unit test

Review URL: https://codereview.chromium.org/941633002

Cr-Commit-Position: refs/heads/master@{#317075}

This behavior is introduced by a772ed62.
It makes ExternalPrefLoader not being ready when user sign in to Chromebook for
the first time and accidentally blocks all installation of external extensions
if Chrome Sync is turned off, including force installed extensions by policy.

BUG=457539
TEST=manual

Review URL: https://codereview.chromium.org/931663007

Cr-Commit-Position: refs/heads/master@{#317074}

BUG=none

Review URL: https://codereview.chromium.org/933413002

Cr-Commit-Position: refs/heads/master@{#317073}

Previously, in RenderWidgetHostViewAura, upon receipt of a touch ack,
we would convert the WebTouchEvent associated with the ack into
ui::TouchEvents.

With the eager GR, this is no longer necessary.

BUG=407645
TEST=GestureRecognizerTest.*

Review URL: https://codereview.chromium.org/503883004

Cr-Commit-Position: refs/heads/master@{#317072}

It was using a single global worker thread pool in a non-threadsafe
manner.

This imposed the restriction that all instances of SimpleCache must be
initialized on a single thread, or weird things may, in very rare and
unlikely cases, occur.

BUG=442321

Review URL: https://codereview.chromium.org/851013003

Cr-Commit-Position: refs/heads/master@{#317071}

Revert of Handle RenderProcessHostImpl::SetBackgrounded on Windows (patchset #4 id:60001 of https://codereview.chromium.org/926663002/)

Reason for revert:
This patch set re-enabled ChromeRenderProcessHostTest.Backgrounding, which is now failing on XP bots.

Example logs:
https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/35740/steps/browser_tests%20on%20Windows-XP-SP3/logs/ChromeRenderProcessHostTest.Backgrounding
https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/35740/steps/browser_tests%20on%20Windows-XP-SP3/logs/ChromeRenderProcessHostTest.Backgrounding

Original issue's description:
> Handle RenderProcessHostImpl::SetBackgrounded on Windows
>
> This was disabled on Windows because:
>
>  - http://crrev.com/274071 made it such that it was asynchronous via the renderer (as only
> the process itself can set itself in background mode on Windows).
>
>  - And then this was removed for Windows as part of issue 381820 as true background mode on
> Windows was achieved by having the renderer itself change its process priority (which
> doesn't work as the unbackgrounding request can be stuck behind other priority tasks
> running in background mode).
>
> Also, the test for this was disabled in between (see issue 394368) -- the asynchronicity
> introduced in r274071 probably causing the flakes.
>
> Overall there is no need to have the renderer enter PROCESS_MODE_BACKGROUND_BEGIN itself,
> IDLE_PRIORITY_CLASS should be sufficient as its the same as far as CPU priority is
> concerned and IO is irrelevant in the renderers.
>
> Thus we can get background mode for hidden renderers without running into issue 381820.
>
> Experiment with IDLE_PRIORITY_CLASS/BELOW_NORMAL_PRIORITY_CLASS vs the status quo.
>
> Watching the relevant perf bots (tab_switching.top_10 -> MPArch.RWH_TabSwitchPaintDuration)
> and UMA metrics MPArch.RWH_TabSwitchPaintDuration which shouldn't regress.
> And others (e.g., SessionRestore related) which will hopefully improve.
>
> Enable the experiment by default in the absence of Finch to get perf waterfall coverage.
>
> The experiment will be called "BackgroundRendererProcesses" and have 4 groups:
>  ["Disallow", "AllowBelowNormalFromBrowser",
>   "AllowIdleFromBrowser", "AllowBackgroundModeFromRenderer"]
>
> It will be a per-session (rather than per-profile) experiment, randomly assigning a user
> to a group every new Chrome session.
>
> BUG=394368, 458594
>
> Committed: https://crrev.com/aaf738a2cce69ce952386b48e3bc252bd307ef43
> Cr-Commit-Position: refs/heads/master@{#317042}

TBR=wfh@chromium.org,jam@chromium.org,gab@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=394368, 458594

Review URL: https://codereview.chromium.org/940993002

Cr-Commit-Position: refs/heads/master@{#317070}

BUG=459672

Review URL: https://codereview.chromium.org/930373006

Cr-Commit-Position: refs/heads/master@{#317069}

This CL uses @NativeClassQualifiedName in CronetUrlRequestContext.java to reduce
JNI code. After the refactoring, cronet_url_request_context.cc is merged
with cronet_url_request_context_adapter.cc, since the former mostly contains
JNI code that will be generated by @NativeClassQualifiedName.

BUG=458276

Review URL: https://codereview.chromium.org/922283002

Cr-Commit-Position: refs/heads/master@{#317068}

This CL performs a DEPS roll of cros_system_api package.

BUG=459609

Review URL: https://codereview.chromium.org/939173002

Cr-Commit-Position: refs/heads/master@{#317067}