- 30 Nov, 2017 40 commits
-
-
Leo Zhang authored
Add turn on/off translate switch. Read accept_langauges from native and show them in the languages page. For each language item, add a fake option memu. Screenshot: https://screenshot.googleplex.com/0HOVztouukP Bug: 783049 Change-Id: If420d76fe12ecbff277bcd6e4ab7a3a7a3419f63 Reviewed-on: https://chromium-review.googlesource.com/762540 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#520715}
-
Hector Carmona authored
Bug: 789718 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifd5d6153a4ea4e835c9187c8dab0ede871a052c1 Reviewed-on: https://chromium-review.googlesource.com/799031 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#520714}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/0ee7aab89cf2..c3fc7aa9c6bf $ git log 0ee7aab89..c3fc7aa9c --date=short --no-merges --format='%ad %ae %s' 2017-11-30 eakuefner [TBMv2] Deduplicate all diagnostics 2017-11-30 nednguyen Move cache flushing logic out of Browser constructor into PossibleBrowser classes 2017-11-29 eakuefner [TBMv2] Port DeduplicateDiagnostics to Python Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I13b530124363be50acf0c35f52a9fbbcfe6eeaee Reviewed-on: https://chromium-review.googlesource.com/801356 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520713}
-
Ted Choc authored
Lint warning: warning: [JdkObsolete] Vector performs synchronization that is usually unnecessary; prefer ArrayList. None of the usages are used outside of a single function, so no need for any synchronization. BUG= Change-Id: Ic54e896451415531ee4195d4868a55f1bb936df2 Reviewed-on: https://chromium-review.googlesource.com/801262Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#520712}
-
Eric Karl authored
Adds an ImageTransferCacheEntry which transfers raw (SW) image bytes to the GPU process via the TransferCache. Once received by the GPU proc, the image is uploaded and cached. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iec8d1c24c4f7cb2ace1ebcf216812d009d79d732 Reviewed-on: https://chromium-review.googlesource.com/779962 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#520711}
-
Brett Wilson authored
Convert to overloaded variant base::NumberToString Add SECURITY_OWNERS owner for components/network_hints/common/network_hints_messages.cc Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I1bae6619c1da5c1cf32cbbdc2fe82946e355d74f Reviewed-on: https://chromium-review.googlesource.com/799550 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#520710}
-
Khushal authored
The binding of the mojo interface used for recording UKMs by the compositor is incorrect, the interface needs to be bound to a service using the service connector to start the connection. Clone the Connector and pass it to the factory used on the compositor thread to do the binding. Its necessary to clone it for the connector access to be thread-safe. R=piman@chromium.org Change-Id: I1e20e64a6a6500e9c548599f4893d70a028574a7 Reviewed-on: https://chromium-review.googlesource.com/798538Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#520709}
-
Robert Sesek authored
This is a reland of 5bf2df67 Original change's description: > Provide a new //base-level API for crash keys v2. > > The new, preferred crash key API is located at > //components/crash/core/common:crash_key, but not all clients of the > crash key system can have a direct dependency on that. > > In this CL, a new base/debug/crash_logging.h API is created to indirect > to the new v2 API. It is less featured and flexible than the crash > component API. This will fully replace the existing API still located > in that file. > > Bug: 598854 > Change-Id: Ifabd12f80d1a858ff61b999eba956d6cd5113784 > Reviewed-on: https://chromium-review.googlesource.com/795230 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520333} Bug: 598854 Change-Id: Ic2f82fdb887b9950c52f3fb768b0e12498ba792f Reviewed-on: https://chromium-review.googlesource.com/801070 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#520708}
-
Doug Turner authored
On Android WebView, when a cancellation from a navigation throttle occurs we need to broadcast the error so that OnReceivedError can receive them. Bug: None Change-Id: I7c65fe070a702134283b48fc7a57170776111267 Reviewed-on: https://chromium-review.googlesource.com/797995Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#520707}
-
Peiyong Lin authored
PageSignalReceiver dispatches page signals to every PageSignalObserver with WebContents, thus, TabLoader will be notified with WebContents that is not managed by TabLoader, causing crash when TabLoader tries to remove it from notification registrar. This patch adds check inside OnPageAlmostIdle to ignore WebContents that is not managed by TabLoader, as well as a unit test. BUG=788744 Change-Id: If19d3b3ee9d73b932644c0574dc3b381eba3f232 Reviewed-on: https://chromium-review.googlesource.com/801655 Commit-Queue: lpy <lpy@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Cr-Commit-Position: refs/heads/master@{#520706}
-
Matthew Jones authored
This change adds a finch feature that allows the Chrome Home promo dialog to act as an information-only dialog that provides no option to opt out -- it will only display on 'ok' button. This flag acts independently of the other promo flags. The "ChromeHomePromo" flag does not need to be enabled for "ChromeHomePromoInfoOnly" to trigger the promo. This version of the dialog will show on startup if: - Chrome Home is enabled. - Chrome Home has been enabled for < 60 seconds. - The normal promo has not been seen before. Outcome metrics are not recorded in this case. BUG=789685 Change-Id: Ib8378ed86867275519aa78deb4240bd255a57939 Reviewed-on: https://chromium-review.googlesource.com/798122Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#520705}
-
dpapad authored
In other WebUIs the toolbar collapses when the window width fallows below 900px. In MD Extensions, because there is more content on the right of the toolbar, it needs to collapse sooner. Bug: 788979 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I69617f871918ffcc462834827b116aef8f7ca0bf Reviewed-on: https://chromium-review.googlesource.com/801796Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#520704}
-
Dale Curtis authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/18c815f81428..23e0b491fa58 $ git log 18c815f81..23e0b491f --date=short --no-merges --format='%ad %ae %s' 2017-11-30 dalecurtis Fix another 1 << 31 > int32_t::max() with 1u. Created with: roll-dep src/third_party/ffmpeg BUG=788343 TEST=no more ubsan issue. TBR=sandersd Change-Id: I3511f4b657a56251812fec25a4c792578598e676 Reviewed-on: https://chromium-review.googlesource.com/801352Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#520703}
-
Katie Dektar authored
Bug: 790045 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I438b266980762eff52a81968ae9fb53d8acc4f04 Reviewed-on: https://chromium-review.googlesource.com/801335Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Katie D <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#520702}
-
Olivier Robin authored
These fields belong to a form having a action="/search" attribute. This case is explicitely blacklisted from parsing and these fields should not appear in the output. Mark these tests as failing on desktop because pages are loaded via a dataURL and the form action field is not accessible (crbug.com/789944). Bug: 789949 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I925f67e68400700c83114c1487fcc00130209f44 Reviewed-on: https://chromium-review.googlesource.com/800512 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#520701}
-
Nathan Bruer authored
Disbles overrides by default. TBR=pfeldman BUG=754371 Change-Id: Icd88688a94842bd6ff96566d41e07f6615caae32 Reviewed-on: https://chromium-review.googlesource.com/801574 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by:
Blaise Bruer <allada@chromium.org> Cr-Commit-Position: refs/heads/master@{#520700}
-
Will Chen authored
Bug: 667560 Change-Id: Ic335a8364393e85de100e5b82f2d03dd6983ff84 Reviewed-on: https://chromium-review.googlesource.com/801258Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#520699}
-
Hiroshige Hayashizaki authored
Instead, use ScriptSourceLocationType::kExternalFile, Bug: 788828 Change-Id: Ibc69d49e372ff08fd5817163e157503f3e45d1ae Reviewed-on: https://chromium-review.googlesource.com/786094 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#520698}
-
Yixin Wang authored
spdy_servers_map_, alternative_service_map_, server_network_stats_map_, quic_server_info_map_, and broken_alternative_services_.recently_broken_alternative_services_ can no longer take up arbitrary amounts of memory. Bug: 709340 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iaab61d8d982caf83eec0a62f312d6616f0ef0469 Reviewed-on: https://chromium-review.googlesource.com/798397Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Yixin Wang <wangyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#520697}
-
Misha Efimov authored
Notable files: c/c/native/cronet.idl - Cronet API defined as Mojo IDL. c/c/native/generated/cronet.idl_c.h - Cronet C API generated from cronet.idl c/c/native/generated/cronet.idl_impl_interface.* - Abstract interfaces to implement C API generated from cronet.idl c/c/native/generated/cronet.idl_impl_interface_unittest.* - Simple unit tests to cover interfaces in C API generated from cronet.idl c/c/native/generated/cronet.idl_impl_struct.* - Structs to implement C API generated from cronet.idl c/c/native/generated/cronet.idl_impl_struct_unittest.* - Simple unit tests to cover structs in C API generated from cronet.idl c/c/tools/generate_idl_bindings.py - wrapper script to manually generate C API files above. c/c/tools/generators/cronet_bindings_generator.py - Cronet bindings generator script forked from mojo/public/tools/bindings/mojom_bindings_generator.py c/c/tools/generators/cronet_c_generator.py - C API generator script forked from mojo/public/tools/bindings/generators/mojom_cpp_generator.py c/c/tools/generators/c_templates/*.tmpl - C API templates based on mojo/public/tools/bindings/generators/cpp_templates/*.tmpl Bug: 786559 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibf276fffce22021a1153dfdd473983e1e552603d Reviewed-on: https://chromium-review.googlesource.com/590274 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#520696}
-
Maria Khomenko authored
BUG=674712 Change-Id: Iffa6c82bcfbfdec6b27e7340db768997f8b5fbc7 Reviewed-on: https://chromium-review.googlesource.com/755115Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#520695}
-
Victor Costan authored
This CL replaces Blob usage in the value wrapping code with direct construction of the underlying BlobData and BlobDataHandle structures, and removes a SSV data buffer copy. Change-Id: I0c107cd649c60614f6464e4b7587226cfa387893 Reviewed-on: https://chromium-review.googlesource.com/712555 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#520694}
-
Devlin Cronin authored
The extension inline install dialog contains a section for the webstore ratings. This is rendered as a star rating (n / 5 filled stars) and a user count displayed in parentheses. For example, ***** (345) Unfortunately, the accessible text for this is lacking - each star (filled or not) simply says "graphic", followed by the number. So the content read by a screen reader would be: "graphic graphic graphic graphic graphic 345" which is very unhelpful. Introduce a custom view for the ratings section, which hides the star graphics and the user label from the accessibility tree. Instead, provide custom accessible text to give meaning. Now, the screen reader will read: "Rated 5.0 by 345 users" Bug: 747624 Change-Id: I96d829efd098cc6795389b3190f0c2a901f55a93 Reviewed-on: https://chromium-review.googlesource.com/782711 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#520693}
-
Bruce Dawson authored
base::debug::Alias is normally used to force the compiler to retain local variables by making it think that some external data structure contains a pointer to them. Passing an arbitrary pointer to Alias has no effect on the optimizer. Removing this use of Alias will help minimize confusion. Bug: 756589 Change-Id: Iab183c96748f555e1b364a0ea714e5b84c0b6829 Reviewed-on: https://chromium-review.googlesource.com/794553Reviewed-by:
Randy Smith <rdsmith@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#520692}
-
Qiang Xu authored
changes: Add test coverage for multi window resizer dragging to change bounds of two snapped windows. Also in file cleanup. Bug: 783589 Test: covered by tests. Change-Id: I1ce5e5d4aa762c55a5a5933be452ce3fb4c7b1fa Reviewed-on: https://chromium-review.googlesource.com/799810Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#520691}
-
Vlad Tsyrklevich authored
Change-Id: Ie1c21fe556f6e73bb5ab643e56c967fe96f870d0 Reviewed-on: https://chromium-review.googlesource.com/801538Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#520690}
-
Robert Hogan authored
Bug: 784793 Change-Id: Ib41a9a940acddf8737c261c3d14b39bf683aece4 Reviewed-on: https://chromium-review.googlesource.com/789930 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#520689}
-
EhsanK authored
This CL moves some editing methods from WebWidget to WebLocalFrame. The immediate benefit of this move is deduping the code in between WebViewImpl and WebFrameWidgetImpl. Furthermore, most other editing methods are already defined per frame. The logic inside the methods moved in this CL also act on the focused frame inside a widget. Bug: 629721 Change-Id: Iad9c291268aeab65965b016cf50b8863e3a0729f Reviewed-on: https://chromium-review.googlesource.com/789530Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#520688}
-
Scott Graham authored
Also, make --dump-tree work with --stdin by sending the tree to stderr. Bug: 790003 Change-Id: Ie9fde86826cb28b873f726543c034f5c9992cd84 Reviewed-on: https://chromium-review.googlesource.com/801092Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#520687}
-
Jinsuk Kim authored
GesatureStateListener has no concrete implementation for any interface methods but declared as class just to avoid having to add many empty methods in the implementation. Now it can take advantage of default interface method and be declared as interface. Bug: 789000 Change-Id: Id0f7515a073ced947cf88bc1e6ded5cd69dc4868 Reviewed-on: https://chromium-review.googlesource.com/798870Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#520686}
-
Dave Tapuska authored
The callsites were updated in https://chromium-review.googlesource.com/c/chromium/src/+/793971 however I left the DCHECK still in and didn't allow nullptr as the return value. This caused the clusterfuzz failures. BUG=789926,789906 Change-Id: I950f4ea72225faa0f9be3afbe022e0152079aa92 Reviewed-on: https://chromium-review.googlesource.com/801637Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#520685}
-
Eugene But authored
Implementors of DownloadTaskObserver::OnDownloadUpdated should be able to call RemoveObserver on a ppased task, if the download is complete. Bug: 780646 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I86f2058e35e9caeb09e32505ef05486f855646eb Reviewed-on: https://chromium-review.googlesource.com/798312Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#520684}
-
David Dorwin authored
These histograms were just added so this should not affect data. Bug: 788013 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1937fe84f49212b53cff9e0f5cd6a0af195a9d52 Reviewed-on: https://chromium-review.googlesource.com/795034 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#520683}
-
Yash Malik authored
In this CL, if we detect that a VR intent requires a VR core update, we simply ignore it. This is needed because we may enter Chrome in VR mode but can't do anything else (such as show a toast in VR), because we don't have the correct version of gvr. The long term solution here is to have VrCore itself prompt the user to upgrade. Bug: 772514 Change-Id: I18b5a0ec11f4f68edfb408a71ce54c724e50cc3a Reviewed-on: https://chromium-review.googlesource.com/797734 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#520682}
-
David Tseng authored
1. the initial value change on sliders sometimes did not get dispatched because a client user of the Slider class can and does set the initial slider value before attaching it to a widget and making that widget visible. Fire the value change when visibility changes for the slider if needed. An example of where this occurs is the Chrome OS volume slider which changes without it actually receiving focus. The system tray briefly shows the volume control. 2. ChromeVox specific: make ChromeVox output the entire node including role and any states when it first encounters the node. Note that these nodes are transient so disappear quickly. We don't reset the value of |lastValueChangedTarget_ as a result. Test: manual. Bug: 755392 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I86da8d1f5aed933dcc36a460202402f576a8a5f9 Reviewed-on: https://chromium-review.googlesource.com/777599 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#520681}
-
Avi Drissman authored
This reverts commit 9e4a1523. Reason for revert: fast/dom/MutationObserver/weak-callback-gc-crash-case2.html fairly consistently fails on Win7 Tests (dbg)(1) . See https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/64920 as an example. Original change's description: > MutationObserver: Do nothing when its execution context is no longer available. > > MutationObserver::DeliverMutations is a static function and > registered to the microtask queue. It maintains active > observers and also makes active observers alive, but nothing > else (the underlying callback function nor execution context). > > So, when DeliverMutations invokes each active observer, > DeliverMutations must make sure that each active observer's > execution context is still available. > > This patch adds the check of the execution context. > > Bug: 788495, 789862 > Change-Id: Ic350603cc8a7b13275adf042e731fdd9605373aa > Reviewed-on: https://chromium-review.googlesource.com/799653 > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520509} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org Change-Id: I00ea0349a3f441f6d2fb356d179b5e301c253df3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 788495, 789862 Reviewed-on: https://chromium-review.googlesource.com/801222Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#520680}
-
Oskar Sundbom authored
The setting does not seem to be documented, but was easily found by tracking property changes to a device and playing around in settings. This implementation keeps a suppression count and re-enables ambient noise reduction, if it was initially enabled, once all streams requesting this behavior have stopped. Bug: chromium:789152 Change-Id: I1672a44bf185beedef2caaff8f66f5c50a9aad95 Reviewed-on: https://chromium-review.googlesource.com/737873 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#520679}
-
Wei-Yin Chen (陳威尹) authored
Log whether the bookmark entry is a user bookmark or a partner bookmark when it is opened. Bug: 787132 Change-Id: Ia42d88125e60ba0fb1710ea9b3eef6c7d63a0b5d Reviewed-on: https://chromium-review.googlesource.com/799030Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#520678}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/646257d65c65..fee910e6f81f $ git log 646257d65..fee910e6f --date=short --no-merges --format='%ad %ae %s' 2017-11-30 npm Prevent integer overflow in CJBig2_HuffmanTable::ParseFromCodedBuffer Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I55e3ea4fbc1ff2a6f36d7f624a99e80da558b5ff Reviewed-on: https://chromium-review.googlesource.com/801255 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520677}
-
Robert Hogan authored
Bug: 789653 Change-Id: I5ea9761a687b4c9a64437df032af27d1a96080fb Reviewed-on: https://chromium-review.googlesource.com/797454 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#520676}
-