- 25 Sep, 2020 40 commits
-
-
Karandeep Bhatia authored
Prevent the extension background page from undergoing a navigation away from its initial url since this effectively makes the extension non-functional. Note this doesn't prevent navigations for which the NavigationThrottles are skipped (e.g. crbug.com/1036603). BUG=1130083 Change-Id: Ieba83f16520d8631662969c07402e0a49c2bce0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419659 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#810565}
-
Fredrik Söderqvist authored
Check if the container has a filter effect property (with a reference filter) before ensuring a paint chunk. This both robust against paint-from-prepaint (crbug.com/848056) as well as achieving the goal of the SelfWillPaint() check. This also eliminates the last user of SelfWillPaint() so it and SVGLayoutSupport::HasFilterResource() which it uses can be removed. Bug: 109224, 848056, 1131498 Change-Id: Ic3da600c011d0a48bf562d9fea013e258d436e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424187 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#810564}
-
Mikel Astiz authored
This scenario verifies that, if a user ends up with corrupt data consisting of tabs without their corresponding header entity, nevertheless those tabs will eventually be subject to garbage collection. Change-Id: I50cec71a46e02731580b2c1ddb2a448533a0757c Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431024 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#810563}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I66416d90a4e228cf06bca9903699a2700808536c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430860Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810562}
-
Koji Ishii authored
|CurrentFragment| is known to return |nullptr| if |IsSingleUse|, which is set in multicol, and that it does not recalculate ink overflow at all. This patch fixes |LayoutBlockFlow::RecalcInlineChildrenVisualOverflow| by replacing it with |PhysicalFragments|. Note, all other callers have the same risk, but replacing all of them failed many tests. We need to look into each of them. This fix is required not to regress ~600 tests in `virtual/layout_ng_block_frag` for <crrev.com/c/2428530>. Bug: 1061423, 829028, 1130856, 1128199 Change-Id: I78149f0dde7fe8bcf532fc6a335109b97daef789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428516 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#810561}
-
David Bertoni authored
Bug: 1093066 Change-Id: I678072e496d37812aad610fdef4772e7bb5621db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408212Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#810560}
-
Victor Hugo Vianna Silva authored
Bug: None Change-Id: I989bed9f38ab5528d92cb9196026d6b2c2b4e544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431104 Commit-Queue: Victor Vianna <victorvianna@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600905490-fdb2e7b3449a423d26d1d15a08c032508e6d13fa.profdata to chrome-mac-master-1601013503-1a040f21faaa1854749ef6dccdae69339bbb905f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic6f1eed11bb093bdcffd1f124867b24e842e2b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430863Reviewed-by:
-
Chong Gu authored
If port is not defined, don't use it when running ssh commands. Bug: 1113300 Change-Id: I14681d2b7576f20bc66362cd37cec8cb1dae5137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417464 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#810557}
-
Ehimare Okoyomon authored
Update the description in order to provide context for translators on how to handle the case with languages with adjective gender agreements. Bug: 1077766 Change-Id: Ib6721105f2192e46167ece437d69822326501b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428890 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#810556}
-
harrisonsean authored
Cancel reverts to previous state, for unfinished checks, instead of blank state. Bug: 1078782 Change-Id: Ia643389a6e1844d62d22be145b6ddeb9a53d7ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401164 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#810555}
-
Findit authored
This reverts commit adc862b0. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 810545 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2FkYzg2MmIwOTRjMmQ5MTg5YjE3NWFiM2Q1ZjlkNmJiNDQ1NzNiMTgM Sample Failed Build: https://ci.chromium.org/b/8868191608621476032 Sample Failed Step: compile Original change's description: > [Android] Show signed in account in sync promo > > Sync promo always shows the first account returned by AccountManagerFacade > which might not be signed in. This cl makes sure that the account that > is shown is the first signed in account. > > This cl also refactors some of the tests regrading sync promos. The > behavior of the tests are not changed. > > Bug: 1131465 > Change-Id: I46f2e607494c68d3b0608543095da4b22471f710 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426485 > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > Reviewed-by: Alice Wang <aliceywang@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810545} Change-Id: I5fc911e9f5175b65d10ff045dfd48103ed08b099 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430974 Cr-Commit-Position: refs/heads/master@{#810554}
-
Renato Silva authored
The marketing opt-in screen does not show an option to subscribe to enterprise and supervised users. Since it does not provide any value and requires the user to click on 'Get Started' there was a request to skip it altogether. Bug: 1128918 Change-Id: Iaf40322824b8d75d738e3f58b9a8cce0316c8349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414228 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#810553}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600991906-4a92707280f1746bc65f64969bacfc1c677580e0.profdata to chrome-linux-master-1601013503-f7b4ef4ea11cbf75355e6e56711fd1614dd080c3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I3ae3142b139adec7e4ca40820482f86d065f90c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430663Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e11be3c4ad04..d4499bd576da 2020-09-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If9d4abe09c005149a31d2ad5fb367cbb1c8ac45a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430353Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f0759378. With Chromium commits locally applied on WPT: 8f02a380 "Use allow attribute for delegation in web serial WPT" c1a7d15a "[LayoutNG] Multicol baseline propagation support." f30daabb "[COOP] access reporting: test with redirects." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org, guidou@chromium.org, philipp.hancke@googlemail.com: external/wpt/webrtc iclelland@chromium.org: external/wpt/feature-policy jsbell@chromium.org: external/wpt/resources lanwei@chromium.org: external/wpt/infrastructure/testdriver/actions nzolghadr@chromium.org: external/wpt/pointerlock NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I568c48ca68952a65c16500d747e4ab973ba04fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429591Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810550}
-
Ehimare Okoyomon authored
Screenshot: https://crbug.com/1077766#c54 Bug: 1077766 Change-Id: I623a2b2e206b5b9471ed11c46af811c7786ba4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428895Reviewed-by:
-
Clemens Arbesser authored
This is done in preparation for an upcoming new UKM where we need to know not just when the UI was shown, but also when the lite script started. I opted to rename the existing callback instead of introducing a new one. This is a refactoring only and should have no user-facing changes. Bug: b/169052568 Change-Id: I44d4033e20a8c7dfd4cca96be5a3c36388c8b1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424319 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#810548}
-
Jan Wilken Dörrie authored
This reverts commit 404b7cc4. Reason for revert: Breaks tests on Win 7 Builder: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/108048 Original change's description: > FontAccess: Sort fonts in lexicographical order > > This change ensures fonts are sorted before being cached. This change is > due to a concern about fingerprinting: > https://github.com/w3ctag/design-reviews/issues/399#issuecomment-530679815 > > This change ensures that fonts are sorted in lexicographical order. > > Bug: 1043306 > Change-Id: Ia3acf2a45cb473124df4e489683bdc7bac15dde4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427040 > Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810519} TBR=jsbell@chromium.org,oyiptong@chromium.org Change-Id: I75926b99ebb7e663875e0eae3d89d877f623a6ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1043306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431025Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#810547}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ic882d1902635a141a73ea1d2248842ef70dc8ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429649Reviewed-by:
-
Tanmoy Mollik authored
Sync promo always shows the first account returned by AccountManagerFacade which might not be signed in. This cl makes sure that the account that is shown is the first signed in account. This cl also refactors some of the tests regrading sync promos. The behavior of the tests are not changed. Bug: 1131465 Change-Id: I46f2e607494c68d3b0608543095da4b22471f710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426485 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#810545}
-
Ravjit Singh Uppal authored
Add metrics that will record - Elapsed time between grant and permission use - Elapsed time between grant and revoke Only for Geolocation, mic and camera permission Bug: 1119738 Change-Id: Ia01cee7921b246844e90d789761f3beebebb98de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367832 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#810544}
-
David Schinazi authored
This CL exists to work around an issue where some users are being configured with an outdated Finch config. It will ensure that we cannot accidentally configure Chrome to use these old obsolete versions. This CL includes an escape-hatch, it will be possible to add the obsolete_versions_allowed flag in Finch in case we want to intentionally enable obsolete versions for some future reason. This CL also applies to cronet, though with the exception that cronet currently allows Q043 as some cronet applications currently rely on it. R=renjietang@chromium.org Change-Id: I275e1797c3cab1e0ddd411520e113cb957365896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429868 Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#810543}
-
Jit Yao Yap authored
Sync server-side changes from cl/331193690. Change-Id: I52afbafc55b5dc3804034acaaea08a31aa9cfd23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418660 Auto-Submit: Jit Yao Yap <jityao@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#810542}
-
Taylor Bergquist authored
Previously, this calculation used LayoutManager::GetAvailableSize, which relied on cached information that was cleared during layout. An extra layout was added to fill this cache, which caused no end of complexities in tabstrip layout. This is totally unnecessary, as all of the siblings of TabStrip are simple fixed-width controls - NTB, grab handle, tab search button, and scroll controls. A wee bit of arithmetic suffices. Bug: 1093972 Change-Id: I7758bd80ba37b31d5efeeafd208e093094ef5e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426978Reviewed-by:
Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810541}
-
Richard Knoll authored
This test passes on local machines that have a real display attached to them but fail on bots without. Disable them for now until we find a way to run them without needing a display. The tests seem to be happy on Linux at least so keeping them for coverage. TBR=peter Bug: 1132058 Change-Id: I0b54d975957c4bc2ff3186a512f04f8f01135768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428899 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#810540}
-
Josiah K authored
(Fixing accessibilityPrivate.on* names to only be used for events 3/3) No functional changes - should be mechanical only. Also rename onAutoclickScrollableBoundsFound to handleAutoclickScrollableBoundsFound. AX-Relnotes: N/A Change-Id: I12806a694a94e58fa6fdb48280cc4cc3a4d44b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422677 Commit-Queue: Josiah Krutz <josiahk@google.com> Auto-Submit: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810539}
-
tby authored
Bug: 1034842 Change-Id: I49d8f211495f1ff3a95563ac184ed5ed69a511b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427606 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#810538}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d59bccb5df72..962e347302d7 2020-09-25 jmadill@chromium.org Fix return code of restricted trace tests. 2020-09-25 lehoangq@gmail.com Metal: Use shared memory for small dynamic buffers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I54128f0d1ad06d05cf543846aea083e14259a941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430654Reviewed-by:
-
Jan Wilken Dörrie authored
This reverts commit 64875586. Reason for revert: Speculatively reverting due to https://crbug.com/1132229. Original change's description: > Add Crash Restoration support for multi-window > > After a crash info bar will be presented on all foreground scenes > if the user choose to restore all foreground windows will be restored. > if not all windows tabs for all windows which were opened on the last > run will be added to the recent closed tabs. > > Bug: 1126311, 1114179 > Change-Id: I80623012dc132e2702004d2dbc0bbcb410a7d91c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415929 > Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810406} TBR=marq@chromium.org,mrefaat@chromium.org Change-Id: I4045617e7eb138e0212f8b1d1062df7ce0b45f74 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126311 Bug: 1114179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428972Reviewed-by:
-
Benoit Lize authored
When PartitionAlloc is malloc(), stats reporting cannot allocate memory. Make sure this is the case. Bug: 998048 Change-Id: If5198de1586de814844c1ca2d86abd65516e6716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428595 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#810535}
-
minch authored
Color of the ripple is no longer the opposite color of the background color, but either WHITE or BLACK based on the current color mode now. - Update AshColorProvider::GetRippleAttributes with default value to simplify most of the call sites. The default background color is GetBackgroundColor() for Shield and Base layer. - Hard code the logic of notification related, which will not going to support dark mode at the first stage. - Clean up. Removed some unnecessary functions and arguments. Bug: 1107056 Change-Id: I1adb4232f66c5433eb52920ac5b48c329ade35f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427623 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
-
Lingqi Chi authored
https://chromium-review.googlesource.com/c/chromium/src/+/821796 stopped using Net.ResourceLoader.ResponseStartToEnd..*. This CL adds the <obsolete> tag to remove these histograms. Bug: 686984 Change-Id: I30890e37016a6a30a5bfd8955aaed681f51f6011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423676 Commit-Queue: Lingqi Chi <lingqi@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#810533}
-
harrisonsean authored
Safety Check on iOS has an update check, to support this we are adding the ability to do one off checks to Omaha for iOS. If there is an ongoing scheduled ping, or one is scheduled during the one off check, it is taken by the one off check. Otherwise it will send its own ping. The one off check updates all user defaults for update status, and makes Chrome think that it has just shown an update infobar (if an update is available) so that users triggering an update check aren't shown an update infobar soon after being told they are out of date by the update check. Adds another user default to track if the device is up to date as of the last check (scheduled or one off). A device that is unable to update is considered up to date in this user default. Bug: 1078782 Change-Id: I2e4a1982dd0b34258c78c85ecf23e2f199630f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398725 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#810532}
-
Alice Wang authored
This CL renames the sign-in methods in AccountManagerTestRule to signinAndEnableSync to be consistent with the new sign-in API. Bug: 1131936 Change-Id: I6507712ad38b37c987507bea549b4c9371946a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429065 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#810531}
-
Ben Mason authored
Change-Id: I8ee6fc5e097c47b53fa8fd576ff60e97cbeca06c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429343 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#810530}
-
Dom Schulz authored
Change-Id: I402355cc184d62341cdb6d2604113c6f7642d104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426369 Auto-Submit: Dominic Schulz <dominicschulz@google.com> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#810529}
-
Nick Harper authored
Change-Id: I960a85c72784e1cce26c69455fe28dd51d97cd35 Bug: 1127947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428536 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810528}
-
Kramer Ge authored
Using a 4x4 sized opaque background will not regress performance in underlay cases because the root surface is still opaque. The background will be stretched out by wayland viewporter extension. This is 6/? CL for overlay forwarding using wl_subsurface. Change-Id: I59b0d4cdbfbb6727d578e286c9d19cf69a9bff32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352523 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#810527}
-
Rune Lillesveen authored
We have a DCHECK that ensures we start with initial style as the parent style if the element is the document root element, or if we are computing styles outside the flat tree, in which case we start at unassigned host children. A similar case is for fallback children of slots which are not part of the flat tree because the slot has assigned nodes from the host. Add that condition to the DCHECK along with a test. Bug: 1131767 Change-Id: Ic8a44f52273cc10a3a6936bf80b3b25ac0cb85d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426450Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#810526}
-
