- 22 Feb, 2019 21 commits
-
-
Joel Hockey authored
We can't be sure at any given time that the VM has not restarted and that a non-persistent share is still shared. So we will not register them as shared. If we happen to take an action on the file more than once, there is little harm to (re)attempt to share the path. Bug: 925973 Change-Id: Ie3a4b4a3009c5846cd31754c2b642f2a369cebb4 Reviewed-on: https://chromium-review.googlesource.com/c/1481183 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#634441}
-
Hector Carmona authored
Bug: 934440 Change-Id: I3242df2f77fb92e289942e4967a4cb5c06092e19 Reviewed-on: https://chromium-review.googlesource.com/c/1481855Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#634440}
-
Boris Sazonov authored
This CL fixes a crash on older Android devices that occurs when SyncAndServicesPreferences settings page is shown. This was introduced in https://crrev.com/c/1459616 by specifying a vector drawable as an icon for a Preference row. As vector resources on older Android versions require Support Library to work, the drawable has to be set in the code. Bug: 934363 Change-Id: I7113e383b94ab911ad2f4da46c6b2f81a71a428c Reviewed-on: https://chromium-review.googlesource.com/c/1481324 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#634439}
-
Daniel Rubery authored
This reverts commit 8010592e. This CL explicitly initializes the file and directory count, so that we don't have undefined behavior when sending the results by IPC. Bug: 926586 Change-Id: Ic6ac4da2741de0085191536049cf4a543667dbfe TBR: meacer@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1481892 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#634438}
-
Zhenyao Mo authored
Whether we run built-in pages or run with URL of external sites, after this CL, tests go down the same path. 1) For built-in pages and crosvideo site, we run requestFullscreen on the parent node of the video. 2) For other sites, we try to locate a fullscreen button and click it. Both option 1) and 2) require user_gesture bit to be set to work. BUG=867155 TEST=bots, manual R=magchen@chromium.org Change-Id: I17ff6f8b425a74a0639085ea2051d6a0851804dc Reviewed-on: https://chromium-review.googlesource.com/c/1480973 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#634437}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/42800babca08..45d4beab9980 git log 42800babca08..45d4beab9980 --date=short --no-merges --format='%ad %ae %s' 2019-02-21 crouleau@chromium.org Use the correct path for zipping. 2019-02-21 pasko@chromium.org android_platform_backend: use crashpad_stackwalk 2019-02-21 crouleau@chromium.org Remove Keystone from Telemetry reference build binaries before upload. 2019-02-21 benjhayden@chromium.org Hide empty tag-filter. 2019-02-21 benjhayden@chromium.org Add missing import in spa/timeseries-descriptor.html 2019-02-21 benjhayden@chromium.org Add missing import to spa/cp-loading.html. 2019-02-21 sadrul@chromium.org speed: Use gzip compression for trace data. 2019-02-21 skyostil@chromium.org android_startup_metric: Add more diagnostic measurements 2019-02-21 sadrul@chromium.org speed: Look only for the appropriate devices/browsers. Created with: gclient setdep -r src/third_party/catapult@45d4beab9980 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:932615,chromium:925453,chromium:932615,chromium:918193,chromium:918193,chromium:918193,chromium:932409,chromium:863341,chromium:932409 TBR=sullivan@chromium.org Change-Id: I0bd463804070b70b882580ccaedd288de280a4bc Reviewed-on: https://chromium-review.googlesource.com/c/1481069Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634436}
-
Fabrice de Gans-Riberi authored
This creates chromium.web.CreateContextParams2 and chromium.web.LoadUrlParams2 as FIDL tables, which are extensible. All the call sites for the previous APIs are also updated. The original APIs will be removed in a future CL when all out-of-tree callers for them will have been updated. Bug: 931831 Change-Id: I15ba10012734daa57cdb6034bbaade1253715e0c Reviewed-on: https://chromium-review.googlesource.com/c/1476184 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#634435}
-
Chris Lu authored
Creates FindInPageManagerTest to test FindInPageManager and FindInPageManagerDelegate. Bug: 919685 Change-Id: Ia9b680582677f984dd9b775155f8f21b0285b768 Reviewed-on: https://chromium-review.googlesource.com/c/1448912 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#634434}
-
Johannes Henkel authored
In |step5|, |text| ends with a UTF16 low surrogate, so text is invalid Unicode, and this is as designed, since the Javascript console must be able to deal with invalid Unicode as Javascript allows unbalanced surrogate characters. Unfortunately, the test only asserted the number of UTF16 characters, not the actual characters preserved. Now we assert that |text| ends with a particular character, '\uD835' which is a low surrogate, the exact same one that was second to last in the original input |str| in TestRunner.evaluateInPagePromise(...) above. The test will thus fail if somehow this invalid UTF16 payload runs through a UTF8 transcoder and back, as such transcoders have no way to preserve unbalanced surrogate pairs - they will typically replace them with a mark for "invalid character", so then what comes back in |text| is valid UTF16, which won't have a hanging low surrogate. Change-Id: I0efedc84f6eb4f6570714e67e49ee44ffa309a7f Reviewed-on: https://chromium-review.googlesource.com/c/1481952 Auto-Submit: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#634433}
-
Lukasz Anforowicz authored
This is a reland of https://crrev.com/c/1441277 that - Trims the test down in a speculative attempt to avoid test flakiness (I verified that the test still fails without the corresponding changes in TranslateHelper::Translate) - Adds logging statements to the test, to help in case trimming of the test doesn't address the flakiness. The original CL description follows below. Google Translate executes its scripts inside "isolated worlds". This is quite similar to how extension content scripts execute and has a consequence of using |request_initiator| set to the origin of the isolated world (rather than to the origin of the page where the script was injected). This is problematic for 2 reasons: 1. It leads to renderer kills, when an AppCache verifies |request_initiator| using CPSPI::CanAccessDataForOrigin. 2. It leads to incompatibility between |request_initiator| and |request_initiator_site_lock| which can also cause wrong/harsh security decisions (e.g. CORB blocking of otherwise benign requests). This CL addresses the problems above, by making sure that requests initiated by the Translate's "isolated worls" will use a separate URLLoaderFactory. - For injecting and selecting the factory on the renderer side, the same mechanism is used as for extension content scripts (i.e. URLLoaderFactoryBundleInfo::initiator_specific_factory_infos is populated for the origin associated with the "isolated world"). - For simplicity and to avoid races, the separate URLLoaderFactory is sent from the browser to the renderer process in the same, single IPC that triggers script injection into an isolated world (i.e. in translate::mojom::Page::Translate method). As a side effect, this CL also causes Translate's requests to go directly to the NetworkService (rather than to the AppCache's AppCacheSubresourceURLFactory). This seems desirable. Bug: 925457 Tbr: John Abd-El-Malek <jam@chromium.org> Tbr: Daniel Cheng <dcheng@chromium.org> Change-Id: If03198d98a3c78031718eecb21ec1ae39db5530f Reviewed-on: https://chromium-review.googlesource.com/c/1481535Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#634432}
-
Jimmy Gong authored
- Implements Net::NetworkChangeNotifier::NetworkChangeObserver to SmbService. - Optimizes the workflow of host name resolution by calling on host discovery whenever a network change is discovered, rather than only running host discovery on an error returned by StartReadDirectory. Bug: 922273 Test: manual end to end Change-Id: I6544c169fb1aa91ebd7d19fe22d854930ae4a928 Reviewed-on: https://chromium-review.googlesource.com/c/1464651 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#634431}
-
Tatiana Buldina authored
Change-Id: I85c051d9d71ae9eb1cd6a3d6d64de9017239bb9b Reviewed-on: https://chromium-review.googlesource.com/c/1479305Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#634430}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/962c222aa3be..ee4fa0785090 git log 962c222aa3be..ee4fa0785090 --date=short --no-merges --format='%ad %ae %s' 2019-02-21 timvp@google.com Reland "Create Container ANGLE APK" Created with: gclient setdep -r src/third_party/angle@ee4fa0785090 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I71ef244c526a9b8bae430e72b7467b1c0b7ee111 Reviewed-on: https://chromium-review.googlesource.com/c/1481000Reviewed-by:
-
tby authored
See here for context: https://docs.google.com/document/d/1GTQ3vvrszK4I1pDzmTFb6krmUzAXox0V9ZIqIi_GH1E/edit?usp=sharing We are expanding Roselle to re-rank the results returned when the user enters a query. However, these results include Arc app shortcuts as well as apps themselves, so they need to be ranked. This CL gives the shortcut search provider access to the Roselle model, for future use in training/ranking. Bug: 931149 Change-Id: I826be986a98d870de21ecd9c88f5a266c5d0308e Reviewed-on: https://chromium-review.googlesource.com/c/1478570 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#634428}
-
Xianda Sun authored
Bug: 874919 Change-Id: Ie4f550e1dcc98e5f8375ab13ade31de4143dc0ab Reviewed-on: https://chromium-review.googlesource.com/c/1474331Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#634427}
-
Giovanni Ortuño Urquidi authored
Install events are recorded regardless of the install result so move the call to record them before the FinalizeInstall call. Bug: 915043 Change-Id: I5b43e697137471a195fa9909706ce567ac43e56f Reviewed-on: https://chromium-review.googlesource.com/c/1481148Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#634426}
-
Kevin McNee authored
When the SyntheticGestureController finishes sending events, it checks whether the main frame has any pending input before running completion callbacks. However, in the presence of OOPIFs the input events could still be waiting for an async hit test or being processed in a child frame. In either case, the SyntheticGestureController considers the gesture to have completed even though input events are still being processed. We now check whether such pending input events exist before considering the synthetic gesture complete. Also, for tests that were relying on the SyntheticGestureController to immediately complete a gesture while input is still being processed, we introduce an explicit mechanism in the SyntheticGestureController to do this. Bug: 931723 Change-Id: I6615d81d636e13bf9119024e0427b92e53cc32ec Reviewed-on: https://chromium-review.googlesource.com/c/1471021Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#634425}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a5230e24c600..d6b7287745c6 git log a5230e24c600..d6b7287745c6 --date=short --no-merges --format='%ad %ae %s' 2019-02-21 thestig@chromium.org Remove unused parameters in CFFL_FormFiller methods. 2019-02-21 thestig@chromium.org Fix nits in CFX_DIBBase and CFX_DIBitmap. 2019-02-21 thestig@chromium.org Use GetCompsFromFormat() in more places. 2019-02-21 thestig@chromium.org Add GetIsCmykFromFormat() and use where appropriate. 2019-02-21 thestig@chromium.org Add GetIsAlphaFromFormat() and use where appropriate. 2019-02-21 thestig@chromium.org Remove |alpha_flag| parameter to CFX_ScanlineCompositor::Init(). 2019-02-21 thestig@chromium.org Remove |alpha_flag| parameter to CFX_DIBitmap::CompositeMask(). 2019-02-21 thestig@chromium.org Remove |CFX_BitmapComposer::m_AlphaFlag|. 2019-02-21 thestig@chromium.org Remove |CFX_ImageRenderer::m_AlphaFlag|. 2019-02-21 rycsmith@google.com Add Opt array functions to to fpdf_annot.h. 2019-02-21 thestig@chromium.org Check node types in CXFA_LayoutPageMgr::ProcessBreakBeforeOrAfter(). 2019-02-21 thestig@chromium.org Fix nits in CXFA_Document::DataMerge_CopyContainer(). 2019-02-21 thestig@chromium.org Use early return in CXFA_LayoutPageMgr::ProcessBreakBeforeOrAfter(). Created with: gclient setdep -r src/third_party/pdfium@d6b7287745c6 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/124252477 TBR=dsinclair@chromium.org Change-Id: I79eda4d4ca275290e70bc9ddcdba8b3d05eaacf7 Reviewed-on: https://chromium-review.googlesource.com/c/1481068Reviewed-by:
-
Nektarios Paisios authored
The AXTableInfo class is not needed for Views because we assume that controls are written to expose the appropriate table attributes in AXNodeData correctly. This patch exposes these table attributes via AXPlatformNodeDelegateBase and its subclass ViewsAXPlatformNodeDelegate. AXTableInfo was for correcting and potentially complementing missing or incorrect table infromation that comes from the renderer, as well as reducing the complexity of the table related code in the renderer. However, in Views, using AXTableInfo would increase complexity. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I056828b1cd1897cfb32b4b44240c264a8e897fbc Bug: 101762 Reviewed-on: https://chromium-review.googlesource.com/c/1444232 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#634423}
-
Jimmy Gong authored
- Simplified logic of handling HostDiscovery callbacks and shares callbacks in SmbShareFinder::GatherSharesInNetwork. - SmbShareFinder::DiscoverHostsInNetwork now follows the same logic as SmbShareFinder::GatherShareInNetwork in how it determines when to run HostDiscovery. - This change prevents SmbShareFinder::DiscoverHostsInNetwork from running multiple HostDiscovery's concurrently. Bug: 922273 Test: Browser unit test Change-Id: Ia0bba61c4cdce6629a42f29d5326161478dca168 Reviewed-on: https://chromium-review.googlesource.com/c/1474384Reviewed-by:
-
Sandra Sun authored
As specified in the spec, when the snap-area has scroll-snap-stop: always, we should not pass its snap position when scrolling with an intended direction. This patch implements this feature by adding another round of search for the IntendedEndAndDirectionStrategy. This second round searches for the snap position with scroll-snap-stop: always that's closest to the scroll's start position. It then compares with the result from the first round of search, which is the snap position closest to the scroll's target position. The comparison selects the area closest to the scroll's start position ensuring a an area with snap stop is never bypassed. Bug: 823998 Change-Id: Ic40f82263ced85f8a72c8f5a82d4fb76e403398f Reviewed-on: https://chromium-review.googlesource.com/c/1460875Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#634421}
-
- 21 Feb, 2019 19 commits
-
-
Kristi Park authored
This reverts commit 1f82384a. Reason for revert: SurfaceSynchronizationTest.ChildNotThrottledWhenParentBlocked1 failing on multiple builders Original change's description: > Fix deadlock due to child throttling > > A child should not be throttled if the parent is blocked on it. > Otherwise the parent is guaranteed to hit the deadline, causing jank. > > Bug: 933610 > Change-Id: Id4cc7bcf6d942a2413a63986e9f10377543fb089 > Reviewed-on: https://chromium-review.googlesource.com/c/1479427 > Reviewed-by: kylechar <kylechar@chromium.org> > Commit-Queue: Saman Sami <samans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634329} TBR=kylechar@chromium.org,samans@chromium.org Change-Id: I285c1fd9deaa65ae584df5ab67c17b747f8a5e25 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 933610,934536 Reviewed-on: https://chromium-review.googlesource.com/c/1481958Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634420}
-
Sadrul Habib Chowdhury authored
Fix running smoke tests after changes in catapult: https://chromium-review.googlesource.com/c/catapult/+/1474597 After that change, it is necessary to update the target platforms for the browser from the benchmark's supported platforms. BUG=932409 Change-Id: I7cddec057d987e342890d180485f54f927c61f7a Reviewed-on: https://chromium-review.googlesource.com/c/1481742 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#634419}
-
Michael Lippautz authored
GetExecutionContext is used for iterating roots during unified heap. Ternary operator results in using a copy constructor which invokes the write barrier, effectively making the object strong. Bug: 928781,843903 Change-Id: Ie6a4cb52a01ac347d6654c760601f254cdc48d65 Reviewed-on: https://chromium-review.googlesource.com/c/1480006 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#634418}
-
Greg Kerr authored
This adds XPC services to the GPU sandbox profile: - com.apple.coremedia.videodecoder - com.apple.coremedia.videoencoder - *apple-extension-service* Bug: 915934 Change-Id: Ibdbf903497af00af4a0b241e65b49cc646b10937 Reviewed-on: https://chromium-review.googlesource.com/c/1481903Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#634417}
-
Yann Dago authored
Bug: 934021 Change-Id: Ia514689aeb8ded0108150841fb5ac55f766d5e57 Reviewed-on: https://chromium-review.googlesource.com/c/1479937 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#634416}
-
Kyle Williams authored
This CL allows the Flare touch device to be recognized as a primary touch device on during the OOBE screen, by white-listing it for OOBE use and blacklisting additional unused interfaces. Bug: b/124839645 Test: manually Signed-off-by:
Kyle Williams <kdgwill@chromium.org> Change-Id: I5f088c27b43eb2a3a3efb69c2ea2b4bb42800b81 Reviewed-on: https://chromium-review.googlesource.com/c/1479635Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#634415}
-
Yi Gu authored
Currently AnimationWorkletProxyClient only mutates the stateful global scope. This patch adds the support of mutating both global scopes with appropriate predicates. Bug: 914918 Change-Id: I0a204f4857ed866511eab2bf03d4f2189a1428dc Reviewed-on: https://chromium-review.googlesource.com/c/1474685 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
-
Robert Sesek authored
It's created on the IO thread, and the FdWatchController it creates should be deleted on the IO thread as well. Bug: 932175 Change-Id: Icaa2af08846e33de94dacf31f03d64cd7496c4d0 Reviewed-on: https://chromium-review.googlesource.com/c/1481474Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#634413}
-
James Lissiak authored
- Test that both DomContentLoaded and Load events fire correctly on page navigations Change-Id: I4c2e04b49ca76c31e1202584eaa63aa1c57c2696 Reviewed-on: https://chromium-review.googlesource.com/c/1479639Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: James Lissiak <jalissia@microsoft.com> Cr-Commit-Position: refs/heads/master@{#634412}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/84d35339f3bf..4022be40d9f1 git log 84d35339f3bf..4022be40d9f1 --date=short --no-merges --format='%ad %ae %s' 2019-02-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@4022be40d9f1 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Icf4ce1e879fed3e9af826143b19e4d043d3bac6c Reviewed-on: https://chromium-review.googlesource.com/c/1481871Reviewed-by:
-
Céline O'Neil authored
Tests the SubmitCompositorFrame IPC interface of CompositorFrameSink by submitting a CompositorFrame constructed from a fuzzed protobuf. This frame is embedded in a CompositorFrame displayed by a mock browser. The CompositorFrame contains exactly one DrawQuad of the type SolidColorDrawQuad. This CL sets up the framework needed for further, more thorough fuzzing of the SubmitCompositorFrame interface, and isn't expected to have thorough coverage just yet. R=kylechar Bug: 923088 Change-Id: Ie6ecc0526c6e524c8e1e54e76fa32ec7dd410211 Reviewed-on: https://chromium-review.googlesource.com/c/1456864 Commit-Queue: Céline O'Neil <celineo@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#634410}
-
Ethan Jimenez authored
1. Completing `ISelectionProvider` methods `GetSelection`, which was previously partially implemented, and `get_IsSelectionRequired`. 2. Adding unit tests for the `ISelectionProvider` methods. 3. Removing unnecessary `AddRef` call before `SafeArrayPutElement` in `AXPlatformNodeWin::CreateUIAElementsArrayFromIdVector`. Bug: 847971 Change-Id: Ic2d2b458812baffeb2777a259fe10369670b0f92 Reviewed-on: https://chromium-review.googlesource.com/c/1479852 Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#634409}
-
Mike Wittman authored
Changes ModuleCache::Module from a value type to a reference type, with ModuleCache maintaining ownership of the Module. ModuleCache needs to own its Modules to properly support Windows, which reference counts its modules. ModuleCache is retained as a struct to minimize the size of this change, but will be changed to a class in a later CL. Bug: 931418 Change-Id: Ifa5bb0e763de14d91c1663ba01aeb3bab09447be Reviewed-on: https://chromium-review.googlesource.com/c/1477817Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#634408}
-
Aga Wronska authored
Bug: 934303 Test: ParentAccessViewTest Change-Id: Ia073de5cd123a3babbd058d3326a02a95e582d57 Reviewed-on: https://chromium-review.googlesource.com/c/1481577Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
-
Charlie Harrison authored
Bug: 926235 Change-Id: I7af92cb206981a1585c601633431e57f3266b50c Reviewed-on: https://chromium-review.googlesource.com/c/1481910 Auto-Submit: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#634406}
-
Yue Li authored
No longer need to wait for Assistant restart when toggle Hotword. Bug: b/123363474 Test: Manual Test Change-Id: Ibc89f44e52c4dab2b18a95cf53c2d7d8b4b1109b Reviewed-on: https://chromium-review.googlesource.com/c/1480815Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Yi Gu authored
wpt/web-animations/timing-model/animations/set-the-animation-start-time.html was renamed in [1] but the name change was not reflected elsewhere. In addition, the expectation file for the test on Android seems unnecessary. [1] https://chromium.googlesource.com/chromium/src/+/bf6c3b061813db88ca12c59690cece60d0b672f7 Change-Id: I6a640c3d56203380ad19ca3b1bb1278cc6971bd8 Reviewed-on: https://chromium-review.googlesource.com/c/1477938Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634404}
-
tby authored
The previous CL [0], implementing an adaptive ranker for search results, was reverted due to an uninitialised member in a test class. This CL fixes the error, and is identical except for the following diff: --- a/chrome/browser/ui/app_list/search/tests/mixer_unittest.cc +++ b/chrome/browser/ui/app_list/search/tests/mixer_unittest.cc @@ -68,6 +68,7 @@ class TestSearchProvider : public SearchProvider { : prefix_(prefix), count_(0), bad_relevance_range_(false), + small_relevance_range_(false), display_type_(ash::SearchResultDisplayType::kList [0] https://chromium-review.googlesource.com/c/chromium/src/+/1474966 Bug: 931149 Change-Id: Id079f664b2eba64f88108b8133be7bf1f8087d2d Reviewed-on: https://chromium-review.googlesource.com/c/1481138Reviewed-by: -
Aga Wronska authored
Ignore 'Parent access' shelf button click if parent access view is already shown. Bug: 934301 Test: Manually Change-Id: I42d8e032f4f076ee352393aced342e153222e005 Reviewed-on: https://chromium-review.googlesource.com/c/1481572 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
-
