- 31 May, 2019 40 commits
-
-
Rohan Pavone authored
Follows the W3C for ExecuteScript endpoint by implementing promise-handling steps, causing ALL JavaScript executions to return promises, unless an exception occurs before the script completes. This is facilitated by Runtime.evaluate's awaitPromise argument, which will wait for a promise if it is returned, and the return value directly if there is no promise (if an error is uncaught, it returns unknown error). Bug: chromedriver:2925 Change-Id: I72c3a15d70842165bdce4019c6886e54f6c057e5 Tested: run_py_tests, call_function_test, execute_script_test, WPTs (except json_windowproxy_serialize.py) for execute_script. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628267 Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665297}
-
manuk authored
Before the classification deduping changes, some providers limited the texts to 200 characters when classifying. When either the suggestion or input texts were longer, truncated versions would be used instead. With the classification deduping changes, all providers follow this behavior. This can look slightly awkward; e.g. for an input of 220 characters, the search-what-you-typed suggestion will be un-bolded for the first 200 characters, but bolded for the last 20. This CL increases the truncation length from 200 to 2000. This should be large enough to cover most use cases; on a 3840 resolution screen, with default English fonts, approximately 1100 '|'s fit in the omnibox. Bug: 366623, 968911 Change-Id: Ic4648c3fa000c09563fe0afae0d4883cefe3d156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639105Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#665296}
-
Michael Spang authored
No functional change. Change-Id: I98bb99a0df8e7eecec323252c17cfbfd46861bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637228 Auto-Submit: Michael Spang <spang@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#665295}
-
John Emau authored
Marked the console settings checkboxes container as a group so screen readers will announce entering and exiting the collection of settings. Screenshot: https://i.imgur.com/4Vp5Ypn.png Bug: 963183 Change-Id: I017121ecd0826dcd9bd067b30d749ba41b0a1858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628223Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: John Emau <johnemau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#665294}
-
Yuchen Liu authored
Due to the recent change of https://chromium-review.googlesource.com/c/chromium/src/+/1612248 Android specific logic inside of ContentMain is removed. Instead, MainDelegate::RunProcess should return non negative number to avoid BrowserMain to be called for Android. Bug: None Test: internal CQ Change-Id: Iedb9f6940cc2f6b7e4cba563c52a6eb6e39e741d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637739Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#665293}
-
Daniel Murphy authored
This change removes all of the non-onion-soup code in the renderer, but leaves the feature flag still intact, as the browser-side code still uses it. R=mek@chromium.org Bug: 918910 Change-Id: I490cb42497757c318067b1125765fe9c4b94ecc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629707Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#665292}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c92b6ad29083..261cefc6693a Created with: gclient setdep -r src-internal@261cefc6693a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: I692ebb389f24855162edaa6195457b1b17fc1b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639103Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665291}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7919b877c3c1..699e167d78ee git log 7919b877c3c1..699e167d78ee --date=short --no-merges --format='%ad %ae %s' 2019-05-31 zoddicus@users.noreply.github.com Remove asserts from GetUnderlyingType (#2646) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@699e167d78ee The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: If764ba8e2b138c087032f8e1ead38d208f3ae7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638562Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665290}
-
Peter Kotwicz authored
BUG=817263 Change-Id: Ief0b71fa401066bb7d95d2a8f02596cf60068367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637695 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#665289}
-
Khushal authored
Address a bunch of issues for enabling shared images with canvas2d. The change only includes fixes but doesn't enable the code path yet. One remaining change required for enabling it is a skia API to notify skia when the params for a texture it is using are modified externally. R=piman@chromium.org, fserb@chromium.org Bug: 900706 Change-Id: I8b009a8e021f318e353dfb4ed5167e28c4b358a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616222 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#665288}
-
Martin Kreichgauer authored
This renames the UserEntity struct to Credential Metadata and adds an |is_resident| bool field to track whether a credential in the macOS keychain was created by a WebAuthn create() request with requireResidentKey set to true. The credential ID format is evolved accordingly and legacy credentials created before the introduction of this field will default to is_resident=false. The calling code in the MakeCredential operation still refuses to create resident credentials, so this change still does not enable creation of resident credentials. Bug: 1631393 Change-Id: I602195c9d240343eca330c8ddedec61133961bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631371 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#665287}
-
Antoine Labour authored
In places where we use CommandBufferDirect, it needs to outlive the GLES2DecoderImpl, as it's the DecoderClient. Bug: None Change-Id: I05669a49ca870cadecb37f28498187ded35e8236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639357 Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#665286}
-
Chris Harrelson authored
This was missed in an earlier patch. TBR=wangxianzhu@chromium.org Bug: 969161 Change-Id: Ia9e1d1619ddc105c7d36a79cb23ed30a016737b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639140Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#665285}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8b079d6881fc..09fad2edc825 git log 8b079d6881fc..09fad2edc825 --date=short --no-merges --format='%ad %ae %s' 2019-05-31 brunoad@chromium.org Enable Kiosk Next for flapjack board. 2019-05-31 saklein@chromium.org run_tests: Add missing INSIDE tests. Created with: gclient setdep -r src/third_party/chromite@09fad2edc825 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I1d3f9811a5fe62a53ed310e636c2dfbba7243c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638350Reviewed-by:
-
Ovidio Henriquez authored
This change moves the WebBluetoothDeviceId typemapping into //third_party/blink/common. This will allow the web_bluetooth.mojom file to be imported into permissions.mojom to use some of the Web Bluetooth mojo structs in the BluetoothPermissionDescriptor. Change-Id: I735b6e82f181fb4c712bf3e09945e9b9f660a16f Bug: 577953 Change-Id: I735b6e82f181fb4c712bf3e09945e9b9f660a16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614471 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#665283}
-
Alison Maher authored
This change adds browser tests for out of process Iframes to AXPlatformNodeTextRangeProviderWinBrowserTest. Bug: 928948 Change-Id: I9bb111c05ae1bc52b7b48e0d9cd86cc9ac90331e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600673 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#665282}
-
James Cook authored
TEST_F('FooTest', ...) requires 'FooTest' to be a variable on the global object. Instead of using implicit globals, use 'var' and explicitly suppress the presubmit eslint check that bans 'var'. Note that accessibility tests are also declared with 'var' because the AccessibilityTest base class uses TEST_F internally. Bug: none Change-Id: Id299de761a47506664e6d4650b5c5a079531f8f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638738 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#665281}
-
Michael Giuffrida authored
Message handlers should call AllowJavascript() and shouldn't used deprecated base::Value methods. Bug: None Change-Id: I88ededca440d800bff6ded8bc3f1078c7c83f78f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637647 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
This CL tweaks so that PDFiumEngine::StartFind doesn't *silently* drop the find-in-page request when the PDF has not loaded yet. Instead, after the CL, the find-in-page client will be notified that the search has completed with 0 results. Bug: 964364, 965254 Change-Id: Ib528d407d1be34179aca2f04a792c582925f90a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629709 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#665279}
-
Brandon Wylie authored
* Periodically queries the history service and refreshes the last tab button. * Responds to tab events to refresh the last tab button. Bug: 959860 Change-Id: Ib4f039c377211e8471267991442ff81318068867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627895 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#665278}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=chcunningham@chromium.org Change-Id: I78fc74ba3ed1e3441c130d8426c557b18a470fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635619 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#665277}
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/64e5d7..9f0f47b Includes 9f0f47b Fix Undefined-shift in ubidi_getRuns by Frank Tang f5d1dcc Fix embedded icu data on Windows by Yang Guo bede826 Move all the filter logic of cast & flutter by Frank Tang cf4eb55 Simplify (android|android_small|ios) filters by Frank Tang Bug: chromium:966377, chromium:938223, chromium:951636 Change-Id: I4d318b7ddb64d61670419da47e2abf59eadd6af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637316 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665276}
-
Dan Sanders authored
When using advanced edit lists, FFmpegDemuxer can output the same frame multiple times. For the case described in the bug, the first time will be marked for discard while the second time will not. Rewriting discarded timestamps makes it less likely that a repeated frame will lose its association to its discard data in decoder_stream_traits. Bug: 967892 Change-Id: Ib84b71f7d43edcf4ae4246abffdbf9e8d99a9904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637674Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#665275}
-
Ender authored
This reverts commit a751329d. Reason for revert: RoundedCornerImageView is missing a lot of functionality, including scaleType, support for bitmaps with custom shaders or tinted drawables. Original change's description: > Use rounded image view for Answer and Entity suggestions > > This change updates the looks of the Answer- and Entity suggestions to > match the design: > > http://docs/presentation/d/1uB8QFlhYqQetxNgJxucpKn-Eolx7CiqL88jGES_sjFk?pli=1#slide=id.g45b058cd36_0_146 > http://docs/presentation/d/1uB8QFlhYqQetxNgJxucpKn-Eolx7CiqL88jGES_sjFk?pli=1#slide=id.g3ce78ec162_0_50 > > Bug: 930349 > Change-Id: I7fa62d6349ee7b30b44a4c28a4a0dfd82e1f33ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632902 > Commit-Queue: Ender <ender@google.com> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664510} TBR=mdjones@chromium.org,ender@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 930349 Change-Id: Ia0c3bbc04fabaf3bbac21b73504e90a3e85798ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638921 Commit-Queue: Ender <ender@google.com> Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#665274}
-
Findit authored
This reverts commit ef0975b0. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 665239 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZWYwOTc1YjA4NjQ1MjM5MDYzODQ5ZjA2MTMzYzRlYTk4ZmQ2YjY3MQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/25189 Sample Failed Step: viz_content_browsertests on Ubuntu-16.04 Sample Flaky Test: WebContentsViewAuraTest.DragDropOnOopif Original change's description: > Use async targeting to find drag and drop targets > > Add callback supports to the RenderWidgetTargeter > and use the async targetting in drag and drop code > and register a callback to send drag events using > the callback. Note that since drag and drop events > aren't WebInputEvent it is not possible to use > FindTargetAndDispatch function of RenderWidgetTargeter > at this time. > > Bug: 804633 > Change-Id: I2ecea2b70d7ea619169685a3a7b531355ddc0d59 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596840 > Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665239} Change-Id: If8c8aaef72622e61d9b8bd0b68082a4f5ee7a73c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 804633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639083 Cr-Commit-Position: refs/heads/master@{#665273}
-
Theresa authored
The CL that introduce an ObservableSupplier for OverviewModeBehavior contained a faulty check for whether an observer should be registered for the supplier, resulting in AppMenuHandlerImpl never receiving the OverviewModeBehavior. This CL fixes the bug and adds a test to prevent future similar regressions. It also adds checks to prevent the app menu from showing while entering/exiting overview mode is animating to prevent users from triggering the app menu while in transition which has undefined behavior. BUG=968052,968048 Change-Id: Id95e4824bfc92c62cacddc74e932669a07ed3fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636149 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#665272}
-
Maggie Chen authored
ui/display/mac is the right place for display_link_mac.cc and .h Bug: 964095 Change-Id: I83d929d27b3884bd3a24eb621717ffea9af9c889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638681 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 967793 Change-Id: I8f4f5a05235f748f1a6360bc50f9ca1e4a052953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639078Reviewed-by:
-
Piotr Bialecki authored
Bug: 969023 Change-Id: Ibdb78ffc2bc4357be6ba059618e37e323d05fa56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638006Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#665269}
-
Luum Habtemariam authored
DDoc: go/cups-plugin This internal manager of the CupsProxyService takes IPP requests, identifies any printers referenced by them, and installs them into the CUPS daemon. When printing normally on ChromeOS, Chrome installs printers into CUPS as necessary; this manager allows us to do the same. Bug: chromium:945409 Test: accompanying unit tests pass Change-Id: I33fb20b3024a6e7bd498eda7eb7fcc778bfeede7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621199 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#665268}
-
Victor Costan authored
Bug: 968179 Change-Id: Ib07f23f14102e9bfed5f54c9ccf9a35fffceb258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636266Reviewed-by:
-
Kristi Park authored
Add selection styling for the shortcut options in the richer picker. Screenshots: https://screenshot.googleplex.com/Xhq71uw82du.png https://screenshot.googleplex.com/EMCRoFfhnrf.png Bug: 953822 Change-Id: I5c66cd678d99f6a4e47076705c0f59e73424c212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638124 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#665266}
-
dpapad authored
Specifically removing: - callGlobalWithSavedArgs() and CallGlobalAction class - makeAndRegisterMockGlobals(), makeAndRegisterMockApis() - registerMockGlobal() and registerMockGlobals() - registerMockApi() and registerMockApis() - overrideGlobal(), globalOverrides and mockGlobals variables Also removing an export for registerMockMessageCallbacks, since this function is only used within test_api.js Bug: 844820 Change-Id: I958123de5077fc408c3ddab687fbe31a37de0d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637984 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#665265}
-
John Abd-El-Malek authored
Since Android WebView is still shipping the non-network-service path on stable, we should run these two test suites to ensure we have test coverage for what our users are still running. This is now needed because all the other platforms don't run network service on stable, so they've removed these tests from their bots. This is only running on the waterfall and not trybots because failures should be rare. android_mojo trybot can be used to run it before commit. Bug: 841556 Change-Id: I56c756a8d17ae5a0000edeb3e88d926182c1e6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637589 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#665264}
-
siyua authored
Currently it overrides the function in IconLabelBubbleViews(), but the base class method is called in constructor, so the derived class method is never called in this case. Calling virtual method in constructor should be avoided. Therefore change the function simply to a private function. Bug: 932818 Change-Id: I790ade09db63bb4c90843722cc3a23ee5525c434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636288Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#665263}
-
Ned Williamson authored
The UnaryOp message has been added and the BinaryOp extended to support those mentioned in the GLSL specification. This CL also adds support for variable declarations and improves the quality of some of the scaffolding code to reduce logging when run on ClusterFuzz. We now target ES300 to cover more language features. We can later improve this to support multiple language versions. Bug: 900487 Change-Id: I5ed569f9659c494a1ad1d3952ce6fc96cd1386a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635770 Commit-Queue: Ned Williamson <nedwill@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#665262}
-
Robert Liao authored
No code appears to reference these. BUG=522168 Change-Id: I0f632a7678319c08b5d0a3e9896bcef5fcc8ac21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629695 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#665261}
-
Juanmi Huertas authored
Registering the factory on OffscreenCanvas in modules, adding ImageBitmapRenderer to the union type for OffscreenCanvas. Adding new functionality to bitmaprenderer to let it be used in offscreencanvas. Changing IDL and some tests to validate new functionality. Adding a new virtual test to guarantee testing validation of trasnsfertooffscreencanvas for bitmaprenderer. Added bug: 969151 for the two missing tests. TBR=chrishtr Bug: 907141 Change-Id: I7c611952686aabdf2eb3df8ffe5ca73a69ae97f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638919Reviewed-by:
-
Zhenyao Mo authored
This reverts commit ca612692. Reason for revert: doesn't explain why YUY2 swap chain creation failed on Win10/AMD GPU, so this CL is unnecessary. Original change's description: > Add pixel format support flags on Windows. > > The flags are queried through ID3D11Device::CheckFormatSupport(). > > Hopefully they can be used to bypass YUY2 related tests on AMD > where creating a YUY2 swap chain fails. > > Also, they can be useful diagnosing swap chain related issues > from user machines, i.e., whether we assumed certain capabilities > without checking. > > BUG=967860 > TEST=bots > R=sunnyps@chromium.org,piman@chromium.org > > Change-Id: I5dff9069b2fc53851cbffc5263bd4a2e0e03582f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637195 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: Zhenyao Mo <zmo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665218} TBR=dcheng@chromium.org,zmo@chromium.org,sunnyps@chromium.org,piman@chromium.org Change-Id: Ic93530b90006c41da694a2bc7ae65d13d541b998 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 967860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639360Reviewed-by:
-
Peter Kotwicz authored
This CL: 1) Renames the blink::Manifest::ShareTarget::EncTypes enum values to make them easier to understand and to match EncodedFormData::EncodingType 2) Makes ShareTarget in shortcut_info.* use the enum type defined in blink::Manifest BUG=None Change-Id: I642a1bae9aff3bf463390683323ca0575673a505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629871 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
