- 06 Jul, 2020 39 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium f0765c37. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I69d78cab8f8b31558028eebc29b2b2d9befc6065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282102Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785282}
-
Jing Wang authored
Bug: 1099498 Change-Id: I7ca8fdfbb145332bdb6cda54dbf59c86f7f86104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279344 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#785281}
-
Zufeng Wang authored
Follow the same pattern as cros settings. Bug: b/160103160 Change-Id: Ia07f7c595dae4b8696a91cc1a8a6e0a7e3cb121a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280766 Commit-Queue: Zufeng Wang <zufeng@google.com> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#785280}
-
Quang Minh Tuan Nguyen authored
This seems not to be used anywhere Bug: 1007686 Change-Id: I760479dc9d150246a8d9cc33fd568fb60dbcd3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280974Reviewed-by:
Daichi Hirono <hirono@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Quang Minh Tuan Nguyen <nqmtuan@google.com> Cr-Commit-Position: refs/heads/master@{#785279}
-
Nnamdi Theodore Johnson-Kanu authored
- Migrate multidevice page tests to Polymer3 - Add missing chromeos resources - Move constant from multidevice_smartlock_subpage to multidevice_constants file Bug: 1045266 Change-Id: I8e4412e0bd181f97b2f57901e0042aa1e735ce3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232811 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#785278}
-
Hiroki Sato authored
http://ag/12064837 makes more window events being sent to chrome. It became possible to send an event with a window source, so this change makes FromContentChangeTypesToAXEvent correctly handle such an event. AX-Relnotes: N/a. Bug: none Test: unit_tests Change-Id: I064f7fe648a9f864e2c72f4b08354f35b9802c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279265 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#785277}
-
Jia authored
Bug: 1090132 Change-Id: I10a0fc0ad6f7c94a0accd982eb4d1f4f8f0e348c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279264 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
-
Noel Gordon authored
Do not process dragenter events on the directory tree unless they have an event.relatedTarget. If there is no event.relatedTarget, ignore the dragenter event (consider it spurious). This avoids re-styling a directory-tree tab for drag-drop style, based on spurious dragenter events, since that causes the directory-tree tab color to "flicker" in files-ng after crrev.com/781857 (see bug). In avoiding these events, we must still set the drag cursor effect and event.preventDefault, or else the browser will flicker the drag cursor with an equally annoying 'no-drop' cursor effect when starting a drag. Use a 'move' cursor effect to eliminate drag cursor "flicker". Bug: 1099128 Change-Id: I316af660ca6a4811bbe5a92efd812f3162ea5f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269828Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#785275}
-
Jecelyn Yeen authored
Bug: 1101779 Change-Id: I00214f6ff55b260b9cabad80ae9bc5ad93d0886b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280967 Auto-Submit: Jecelyn Yeen <jec@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#785274}
-
Bartek Nowierski authored
Bug: 1092288 Change-Id: Icd10cab67ac970d4569049ccaaf63bcc69b781ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281769Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#785273}
-
My Nguyen authored
Bug: 1099498 Change-Id: Ic162dcb8312657b9b7f59597ca660a6054cf3d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279300 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
-
Yuki Shiino authored
This reverts commit 2c5f2493. Reason for revert: Suspicious about the test failures: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/16356 Original change's description: > Move ownership of SpellCheckClient to TestRunnerBindings > > There is one per frame, and WebFrameTestProxy doesn't actually need > access to it. So simplify the ownership/pointer graph by moving it > entirely inside TestRunnerBindings. > > R=avi@chromium.org > > Bug: 866140 > Change-Id: I091c1aa899c70db0ac1bafabf19707ea3245e88e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281284 > Commit-Queue: Avi Drissman <avi@chromium.org> > Auto-Submit: danakj <danakj@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#785236} TBR=avi@chromium.org,danakj@chromium.org Change-Id: I64bcfec65efea9650d509cffc5f54b75c2bc1d63 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280975Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#785271}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: Ic0ac34132e7e9491b4f528b5f2723ed4ebb0dc6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256848 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#785270}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I1c171d87550c8b3b5a2e4b1b0bfb354a8fad6d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258335Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#785269}
-
Yoshifumi Inoue authored
This patch changes EditingNG runtime enabled feature to imply NGFragmentItem. When we invoke content_shell with --enable-blink-features=EditingNG, NGFragmentItem is also enabled. Change-Id: I66ada34cd5a6c80d1d495dd2a9ea0627d3fd5b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276127 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#785268}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1593979239-b3cdbe0a0e1ab5854749cceb4966c42dca8c5cdb.profdata to chrome-win32-master-1593993254-590c1c6949804f5c7fc0a1e827a031b5cd1d9e34.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I25093851976c57d6260e834ab93595222fc1350b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282044Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785267}
-
My Nguyen authored
Current view: http://screen/CMsrUW1NA6N See mock in bug. Bug: 1101195 Change-Id: I1bfeca082848550b1d48fd20f9c9dd1a08a84f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275159 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#785266}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: Ie67eeb489bca3a41c9556c66f693c64eff0c79a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257409Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#785265}
-
Kent Tamura authored
ComputeAnnotationOverflow() does - Apply em-height for text fragments - Apply ScrollableOverflow(kEmHeight) for LayoutNGRubyRuns in order to compute annotation space based on em-height. ComputeAnnotationOverflow() kept track of annotation_over/under values. However now ScrollableOverflow(kEmHeight) provides annotation overflow offset too. Now content_over/under values represent over/under limits of annotation overflow too. * Extract some parts of AdjustTextRectForEmHeight() to AdjustTextOverUnderOffsetsForEmHeight() so that ComputeAnnotationOverflow() use it easily. * Fix NGPhysicalBoxFragment::ScrollableOverflowFromChildren(). We didn't merge rectangles over block_offset=0. It can happen for <rt> in ComputeAnnotationOverflow(). Bug: 1082087 Change-Id: Id97ad4ce0bff265c627620c121fc5e33e157bf94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280742Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I4b1b780da04a195eac96041d468117027300d1ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256854Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ad621f799f37..08485d8c2154 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yukishiino@google.com Change-Id: If4ab00b3c83538bf2f5bbf6cac926dd6083889f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282049Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785262}
-
My Nguyen authored
This allows for UX requirement of users able to select this view. Bug: 1099498 Change-Id: Ic34d366db0a8a44c1ea64e3799e90794d66faa54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279292Reviewed-by:
-
Aleks Totic authored
Investigation into how cells with colspan > 1 redistribute their min/max/% widths. Browsers often disagree, and spec allows for variations. Bug: 958381 Change-Id: I588053d1392e00e9d199cdd1095b93a148101fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219093Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#785260}
-
Noel Gordon authored
CL:2279301 added specific tests for USB drives so convert DragAndHover to a hover test that checks that drag hover navigates the file list. Bug: 1002394 Change-Id: Ic236d9e9255503553379d5995127e4ff453836f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279266Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I1bfef0ea99f3696d4457a85d4807124c0edaa9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281667Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785258}
-
Hazim Mohamed authored
In order to improve code readability, all NativeFS code using a boolean value to distinguish between files and directories has been updated to use an enum located in content::NativeFileSystemPermissionContext. Bug: 1046545 Change-Id: I251e43f0226934e3e7991c0f3b9d1e7eb8f96bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255338Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Hazim Mohamed <hazimmohamed@google.com> Cr-Commit-Position: refs/heads/master@{#785257}
-
Noel Gordon authored
Update comments, variable names and so on to match the other drag drop transfer tests. Bug: 1002394 Change-Id: Ib7dd624d649be19ef4043358ea8939e14f3106a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280757Reviewed-by:
-
My Nguyen authored
Current View: http://screen/6xC9K1fruqH Specs: http://screen/qgE7xnf2LhN Bug: 1099454 Change-Id: I7b1084aaaae671448c7e0d20b80616cdd0e60602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281789Reviewed-by:
-
Dirk Pranke authored
//chrome/test defined a wrapper target for dawn_perf_tests that wasn't necessary. This CL removes the target and changes the test infrastructure to reference the dawn target directly, in order to unblock the wrapper script work I'm doing in bug 816629. Bug: 816629 Change-Id: Id67d574208038fb1af804029a0401b62c186170b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280339 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#785254}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1593970160-f7066753a952a48c78b0fb2e9059702caa57a936.profdata to chrome-win32-master-1593979239-b3cdbe0a0e1ab5854749cceb4966c42dca8c5cdb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I19e01b34278767129c79e2b185f985424c2f57fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280457Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f9595b73acb..ad621f799f37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yukishiino@google.com Change-Id: Ie1b734f31497871a8993676295d9b840ec5aa865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281917Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic7b6744a510c71d3f2f1f041a54efe59eff614c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281918Reviewed-by:
-
My Nguyen authored
Current view: http://screen/tLKNjpaEsCe Specs: http://screen/nbDgNJ3gdRZ Bug: 1102211 Fixes: 1102211 Change-Id: Id7ccb823db88f778d560719f5b0a83edc357f193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280754Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593970160-b2af72cfc559b638a3eb48f1ea64ffcb1eedd5eb.profdata to chrome-mac-master-1593993254-dbbaa6aa1e1e0b6f79ccb648844aec2deeff08b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic5a3280a800fcc3afdb0fe8e614f3ad8d666b4c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281919Reviewed-by:
-
My Nguyen authored
This is in preparation for testing of Learn More Button in emoji suggestion. Bug: 1101195 Change-Id: I2cffeef7a34290f328e85ed790c00509218d3004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281766 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
-
Noel Gordon authored
Improve drag events in testCrostiniMountOnDrag test: use new DragEvent to create the event. Add an event.relatedTarget for 'dragenter' events to better simulate a real browser (fake it with document.body). Tbr: adanilo Bug: 1099128 Change-Id: I9ef4b86a0b2a784b0c65558ccebd134a053de6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280970Reviewed-by:
-
Dirk Pranke authored
//chrome/test defined two targets (angle_perftests and standalone_angle_unittests) that were simply wrappers around the corresponding targets in ANGLE that added some data dependencies. By moving those data dependencies into ANGLE, we no longer need the Chrome-side targets, and removing them unblocks the wrapper script work I'm doing in bug 816629. Bug: 816629, angleproject:3162 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 hange-Id: I792ad08ed931117307f772c453bade77e0a1d454 Change-Id: I792ad08ed931117307f772c453bade77e0a1d454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280384 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#785246}
-
Nidhi Jaju authored
The purpose of exposing this method is to remove GetAllOriginsInfo() call from //components/browsing_data. GetAllOriginsInfo() does not work well when there are many registrations (see [1] for details). //components/browsing_data only needs a list of origins that have service worker registrations (doesn't need storage usage). GetInstalledRegistrationOrigins() can be used to get these origins. ServiceWorkerContextWrapper implements GetInstalledRegistrationOrigins() without disk access and it's much faster than GetAllOriginsInfo(). [1] https://docs.google.com/document/d/1iaQGQzovFVL3LxDiyIvVgEUFWMhzrXpdf_6TmuwIICA Bug: 1099570 Change-Id: I9f206c7eb7de216b410d1e318309db61f60e5d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278795Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#785245}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I29f73c4e2a1b9e8cc966675a2fc21c2aeda23412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276662 Commit-Queue: Raymes Khoury <raymes@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#785244}
-
- 05 Jul, 2020 1 commit
-
-
Noel Gordon authored
Dragging a file list item should select that file list row. Add a test for this case: drag the item entry-name and check the file row becomes selected. Bug: 1002394 Change-Id: I34838bd7380ce82b65661d8ae86d6d490c246ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280968Reviewed-by:
-
