- 28 Apr, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/03fcfdd74f97..1e6581c46ce7 git log 03fcfdd74f97..1e6581c46ce7 --date=short --first-parent --format='%ad %ae %s' 2020-04-28 fmayer@google.com Fix heap_profile for Python 3.x. 2020-04-28 treehugger-gerrit@google.com Merge "gn: Disable new GCC redundant move warning" Created with: gclient setdep -r src/third_party/perfetto@1e6581c46ce7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icd7759672aa128b29d9eb680389d406a585703ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170296Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763403}
-
Evan Stade authored
- move ChromeNotificationBuilder interface, PendingIntentProvider - split out Chrome specific bits (UMA) from NotificationBuilder and NotificationCompatBuilder into subclasses. The base classes are componentized. A few Android version conditionals are removed since we're no longer supporting KitKat. Bug: 1069894 Change-Id: Ibef6e2d1d8f82d6182a4e3430aa71d4c61608ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161420 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#763402}
-
Finnur Thorarinsson authored
Bug: None Change-Id: I4fe754df508807cec90a8b39a4abb53f097d050e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169997Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#763401}
-
sandromaggi authored
Set padding to info box and change ordering. Screenshots: Info text + Checkbox + Box: https://screenshot.googleplex.com/rAw40YXUW3P Info text + Box: https://screenshot.googleplex.com/uY0TWkYLv5D Info text: https://screenshot.googleplex.com/tNNzQUqchPb Checkbox + Box: https://screenshot.googleplex.com/1tHHc1XVg1b Info text (centered): https://screenshot.googleplex.com/FTtKYbWzUC8 Bug: b/154798286 Change-Id: Iac4f8f663107a39bde35e9105c7d44d78b50fb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162887 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#763400}
-
Kevin Babbitt authored
Apply page scale factor when passing values from CachingAsyncHitTest to HitTest for the background asynchronous hit test. Add a test covering the scenario and rename a few existing tests for consistency and clarity. Bug: 2140198 Change-Id: I2a2b592a76b9ffc96a174668e93ce0cc6fbc0400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146536Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#763399}
-
Akihiro Ota authored
Follows recommendations given by UI designer. Bug: 684762 Change-Id: I05613ba4039420ccbf603c82b1372a9cef81c16e Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168532 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
edchin authored
Many circular buttons require the same pointerStyleProvider, which gives a lift effect and is a circular shape. This CL introduces ios/chrome/common/ui/pointer_interaction_util.h/mm which provides reusable pointer interaction utilities. This CL intentionally spans across multiple folders and owners to demonstrate the usefulness of a reusable utility. Test: iPad-only. Enable pointer support flag. Check pointer hover effect on 1) omnibox voice search button in NTP 2) omnibox voice search button when omnibox is in top of screen 3) omnibox clear text (X) button 4) new tab (+) button in tab grid 5) new tab (+) button in toolbar in multitasking mode. Bug: 1073961 Change-Id: I013940946a72227ca8076ed7d4e5f1031be0e2cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167004Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#763397}
-
Pavel Feldman authored
Without this change, Emulation.setFocusEmulationEnabled(true) leads to a state where page is focused, but is considered background and hence throttled. Change-Id: I474fa4c3291db4a3b1f66a3e0f938ac6f50d96fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169573Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#763396}
-
Travis Skare authored
Bug: 1072871 Change-Id: Id2dd5d796140df35110834c3ac66b9a7da45a15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158039Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#763395}
-
Nate Fischer authored
This deprecates the WebView Log Verbosifier app in favor of the Dev UI flag. This app is incompatible with Android R, but the developer UI switch will be maintained going forward. Bug: 988200 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ibe0eb729f786a69b29ebedd051512341d3977ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169484Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#763394}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3623f72383d9..c9bb56813821 Created with: gclient setdep -r src-internal@c9bb56813821 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com,hendrich@google.com,tommycli@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yukishiino@google.com,hendrich@google.com,tommycli@google.com Change-Id: Ib7129a3c67bee30713a312285b23730c33b859fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170297Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763393}
-
Akihiro Ota authored
Bug: 923068 Change-Id: Ic5a86144e3eee3d0f7314d308bcb01ff087cfe31 Relnotes: Launch ChromeVox voice switching feature. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165662Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#763392}
-
Ben Joyce authored
This removes the last double group edits to the android_deps/build.gn file which were made for the androidx update. Still need to remove a few jar_excluded_pattern edits. This downstream CL must land first. https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2926879 Bug: 1067050 Change-Id: I64fcfc688ab145c68dd02689f0b3d24bfc29e0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166636Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#763391}
-
Victor Hugo Vianna Silva authored
The CL removes an unnecessary function call for desktop in the client and a duplicated forward declaration in the generation controller. Bug: None Change-Id: Ic1b805741722da112073f4a0b9001967c01b7000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162755Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#763390}
-
rajendrant authored
Once test file got removed in https://crrev.com/c/2166638/ This CL adds the test back TBR=sclittle@chromium.org Bug: 1074608 Change-Id: I2fca32d1e06c75c9be278838d6abd981578c2515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169012 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#763389}
-
Bruce Dawson authored
chrome.exe.manifest is unreferenced so this change deletes it. The manifest was added in this change in 2013: https://chromiumcodereview.appspot.com/19275010 Over time its functionality was split into separate manifest files and at some point it stopped being used, perhaps around the change to gn. Deleting it just finishes the transition. The separate manifest files which supply the common controls and requested execution levels which this (unused) file still contains are referenced from chrome_exe_manifest in chrome/app/version_assembly/BUILD.gn Change-Id: I263f4e7aca97c231c846cf264886d3745b22cb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163751 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#763388}
-
ckitagawa authored
This is a reland of 621c283e Looks like activities were being preemptively killed on test-n-tablet. This caused a failure with the way CallbackHelper was used. Reverted due to failing on test-n-tablet. > Reason for revert: > testAreMultipleChromeInstancesRunningFirstInstanceKilledFirst > failing on test-n-tablet > https://ci.chromium.org/p/chrome/builders/ci/test-n-tablet Original change's description: > [Multi-Instance] Add method to detect Multi-Instance > > This change provides a simple method to detect if Chrome is in > multi-instance mode. > > Bug: 1071925 > Change-Id: I3b82e5fe7a97e923f67f0ca49735c724f9ed4f17 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155017 > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762344} Bug: 1071925 Change-Id: Ifcfc192011b0ddf4fdb7b9cc5ecae90b63ae4fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167992Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#763387}
-
Ioana Pandele authored
Bug: 1044930 Change-Id: Iabfaa5603aa6de5007a66fa53a3d01cd9df8436c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166172Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#763386}
-
edchin authored
iOS 13.4 introduces new APIs for mouse cursor support on iPad. Buttons should react to pointer hover. This CL enables the default hover effect on the Chrome signin screen. Test: iPad only. Enable pointer support flag. Ensure buttons respond to hover in Chrome signin screen in FRE. Bug: 1073961 Change-Id: I8d23f8e9ee5f33443781a75fb62c852a909210a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168637Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#763385}
-
Xiaocheng Hu authored
FontFaceSetDocument::lcp_limit_timer_ can be fired after document shutdown, in which case GetDocument() returns a nullptr. This patch handles that to fix a crash. Bug: 1074714 Change-Id: I9895716b8694b25ec22f93016c349a8bd6018f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168759 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#763384}
-
Alexander Hendrich authored
Test is flaky on Mac ASan bot. TBR=reillyg@chromium.org Bug: 1076005 Change-Id: Ic388e304272708900d0952f329fb6c54e26dd4dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170350Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#763383}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0736ebd3. With Chromium commits locally applied on WPT: 86131ac4 "Add a test for ReplaceTrack that verifies video track content." c317bae5 "[IntersectionObserver] Fix handling of remote parent frame intersection" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I2b331c1902b92bdea9dcbc3db25fd12250d39961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170188Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763382}
-
Friedrich Horschig authored
After a successful login, trigger a prompt to move the used credential to the user's account store. In rare cases, this could conflict with Chrome's auto-signin feature. Therefore, only show one prompt at a time and prefer showing the auto- signin over the move to not annoy the user with too many popups. Additionally, this CL adds some general tests for the auto-signin. Bug: 1060128 Change-Id: I32dfe8964cb23223e78f14d27ee9d5e343bbb129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164631 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#763381}
-
Henrique Ferreiro authored
Targets depending on //ui/base/x need to use "linux:xrandr" config and the ones depending on //ui/gfx/x, "linux:x11". This CL makes those configs public in targets where they are used, so that they can be omitted everywhere else. Change-Id: Ied1f5cc85e9af4172b1472a75d53a71526d491f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162864 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#763380}
-
Samuel Huang authored
In SuperSize-archive, SectionSizeKnobs was originally added to store tuneable constant parameters. However, over time the class has gained additional fields that are derived from |args|. To enable Trichrome support, SuperSize-archive will need to process multiple "containers" (e.g., APK files). Each of these containers effectively has its own |args|. This challenges SectionSizeKnob's status as a singleton. This CL splits |args|-dependent fields in SectionSizeKnobs into a new class ContainerArchiveOptions. This class is instantiated for each container's |sub_args|. Bug: 1040645 Change-Id: I0ce2f6eb21a23cc2495d5924ab2e28bc5301d7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169758Reviewed-by:
-
Trent Begin authored
This test ensures that device_status_collector can properly handle responses from cros_healthd that are partially populated. Bug: chromium:1071668 Change-Id: Iad83aef1df75726d6bb9b323889fc5c7642b79da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163746 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#763378}
-
Sebastien Lalancette authored
This will be used by QRGeneratorCoordinator to generate a UIImage to share the QR code via the Activity View. Bug: 1064990 Change-Id: I434ed84959d8534ac1a64b341aa84cfadc79faad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167156 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#763377}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f5132a05c893..7676f4ecf3ec git log f5132a05c893..7676f4ecf3ec --date=short --first-parent --format='%ad %ae %s' 2020-04-28 scroggo@google.com Remove SkFrontBufferedStream 2020-04-28 kjlubick@google.com [infra] Add POC task driver Created with: gclient setdep -r src/third_party/skia@7676f4ecf3ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: I7d0fd3cabb07677cffb808f236586f217e3d89bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170295Reviewed-by:
-
Yutaka Hirano authored
Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s9npIUKHkMA Bug: 1072283 Change-Id: I8045d2f2906a26cf64897ee445209c50f88b2493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154352Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#763375}
-
Ovidio Henriquez authored
This change updates the bluetooth-test.js and bluetooth-helpers.js file to use async/await to improve readability. Bug: 1070816 Change-Id: I26b3f66f971f73860e6f2e89ef63709b0da6d164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160087Reviewed-by:
James Hollyer <jameshollyer@google.com> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#763374}
-
Mehran Mahmoudi authored
This implements the logic for pre-fetching adjacent tiles to the viewport in the player. It also removes references to previously saved bitmaps that are not close to the viewport anymore. Bug: 1021111 Change-Id: Ie3520ae88ebd3230133af71c24ccc7b691de04ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165909Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#763373}
-
Nazerke authored
This CL removes BrowserViewController's dependence on TabModel in |setPrimary|. Bug: 1045575, 1049842 Change-Id: I82aebf6ed8eee23e1a48043090a8b6164e281ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170266Reviewed-by:
-
Domenic Denicola authored
It turns out that we automatically origin-isolate web-platform.test domains. This makes the web platform tests under external/wpt/origin-isolation, for the opt-in origin isolation feature (https://crbug.com/1042415), useless, since the opt-in does nothing. This CL introduces a new virtual test suite, which toggles a new command line flag to disable this automatic origin isolation of WPT domains. When running this virtual test suite, then, the WPT domains will only be origin-isolated when they are explicitly opted in by the test files, by setting the Origin-Isolation header. The tests are run exclusively in this virtual test suite, by adding their default configuration to NeverFixTests. Fixed: 1073181 Change-Id: I9db3285f1ac3a0e5b04e8d63694649d2dbe6419e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159536 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#763371}
-
Kurt Horimoto authored
When SafeBrowsingTabHelper cancels a navigation for an UnsafeResource, it will create a CancelAndDisplayError PolicyDecision using an NSError with kSafeBrowsingErrorDomain and kUnsafeResourceErrorCode, which can then be used by ChromeWebClient's PrepareErrorPage() implementation as a signal to display a safe browsing blocking page. Bug: 1064803 Change-Id: Ic7bee74881ab8fd83158ebef2df95bf8a317e503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168523Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#763370}
-
Fergus Dall authored
In crrev.com/c/2142699 AppIconFactory was refactored to use a new pipeline for all the icon loading flows. This caused LoadIconFromFileWithFallback to no longer call the fallback callback passed by the caller. This happens for two reasons. First, the pipeline is not aware of the fallback because it's wrapped inside the result callback. Because of this the pipeline prioritizes all other fallbacks over the callback, including the default icon set when no icon can be found. Second, the pipeline creates a new non-null image if loading that resource fails, but the wrapper decides whether or not to call the fallback by checking if the image pointer is null. Fix both of these cases by making the pipeline function that attempts the fallback aware of the fallback callback. This callback will now be tried before trying to load the default icon resource. The callback will indicate a failure by passing a null pointer instead of a valid image to its result callback. Bug: 1075445 Change-Id: Ia1eb5a1655760405e71b24cc282fb6388936d836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167798 Commit-Queue: Fergus Dall <sidereal@google.com> Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#763369}
-
Devlin Cronin authored
//chrome/browser/extensions/extension_action.h and extension_action.cc have no //chrome dependencies. Move them to //extensions. This is a pure move; there are no functional changes. Bug: 1073590 Change-Id: Iedf4fcbaf871470e727046dce0976270a239b035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162140Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#763368}
-
Ben Pastene authored
This will let folks check out multiple board SDKs at once without having to modify their .gclient file each time. Needs to land after crrev.com/c/2163589. Bug: 937821 Change-Id: I191985b4d5044c84009b8a7d05e33785b6e81e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163849Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#763367}
-
Nate Chapin authored
This means DeviceOrientationController and DeviceMotionController become Supplements of LocalDOMWindow instead of Document, too. Bug: 1029822 Change-Id: I16511f45f1ac1eb343e466217b324b1217f14a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166586Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#763366}
-
Pavol Marko authored
This CL makes TestNavigationObserver track state per-WebContents instead of globally: (*) Whether a navigation is in progress (in |navigation_started|) (*) Whether the last navigation that finished matched the |target_url| / |target_error| filter (in |last_navigation_matches_filter|). When TestNavigationObserver is configured with matching against a target_url, only set last_* member variables if the target_url actually matches. This solves a race condition that TestNavigationObserver suffered from previously when receiving events from multiple WebContents: TestNavigationObserver with target_url_ == A, and default wait_event_ == WaitEvent::kNavigationFinished. (1) OnDidFinishNavigation for URL A Set last_navigation_url_ == A (2) OnDidFinishNavigation for URL B Set last_navigation_url_ == B (3) OnDidStopLoading (probably matching (1)) Does not trigger EventTriggered() because (target_url_ == A) != (last_navigation_url_ == B) (4) OnDidStopLoading (probably matching (2)) Same as above. Also, use base::Optional to make it obvious if |target_url| / |target_error| filters are active. Bug: 830337 Change-Id: Id1d47a0e4ed20d6df38ac222e5eb3eed97bcbc63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161032 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#763365}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I43dfde446232343dabb16ab223396199251d0524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170136Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763364}
-
