- 28 Jun, 2018 40 commits
-
-
Matt Menke authored
The experiment expired a year ago, so we presumably don't need to keep it around. Bug: None Change-Id: Ie8ad4237aea5e4dadbaf9b9a1b7a8439829645d9 Reviewed-on: https://chromium-review.googlesource.com/1117024Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#571119}
-
Colin Blundell authored
Noticed while preparing https://chromium-review.googlesource.com/c/chromium/src/+/1113548: this test currently does not test what it is intended to. It is intended to test that when an ongoing access token request is fulfilled with an expired token, GCMAccountTracker notices that the token is no longer valid and marks the account as needing a token request. However, the current structure of the test prevents any access token request ever being made for the newly-added account: the account is added when the driver isn't connected, in which case GCMAccountTracker doesn't make access token requests. Hence, the test passes even if the call to IssueExpiredAccessToken() is replaced by a call to IssueAccessToken(). This CL changes the test to match its intention: we add the account with the driver connected and check that the request was started, then disconnect the driver before fulfilling the request (so that another token request isn't made immediately), and *then* check that a new token request is now marked as being needed. In particular, the test now fails if the replacement mentioned in the previous paragraph is made. Bug: 809923 Change-Id: Idc2458d4a0d8e9e702ac8a61cdff9ad138e16fa3 Reviewed-on: https://chromium-review.googlesource.com/1113677 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#571118}
-
John Abd-El-Malek authored
This is a reland of 30184c71 Original change's description: > Add a test helper method in services/network to get the body from a ResourceRequest. > > Also remove the custom URLLoaderFactory in content_hash_fetcher_unittest. This isn't needed anymore as TestURLLoaderFactory now supports Clone. > > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Id70ec605886a6b0f2cb9bf7392fac4eff85fc1b3 > Reviewed-on: https://chromium-review.googlesource.com/1115346 > Reviewed-by: Doug Turner <dougt@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570813} Change-Id: If27653a4cc7e94d7f44b02f9eb790e2a46949cc4 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1118438Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#571117}
-
Ehsan Karamad authored
The test has been previously disabled (skipped) on Windows due to recurrent timeouts. Running the test locally leads to an average of ~ 3.7 sec runtime on a high-performance Windows 10 rig (Z840). The test is not skipped on Linux right now, but since its runtime exceeds the 2 sec rule of thumb (from the comments in SlowTests), this CL will make it slow on Linux as well. Bug: 850964 Change-Id: Ib478c0f59313da4302325578d9b768e1070bdcb6 Reviewed-on: https://chromium-review.googlesource.com/1115214Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#571116}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0ce5ab9d3122..385804514edf git log 0ce5ab9d3122..385804514edf --date=short --no-merges --format='%ad %ae %s' 2018-06-28 robertphillips@google.com Revert "Remove drawTextBlob from device use drawGlyphRunList" 2018-06-28 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-06-28 herb@google.com Remove drawTextBlob from device use drawGlyphRunList Created with: gclient setdep -r src/third_party/skia@385804514edf The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I3fdc9150792c2f951218ab3332f70c627254e283 Reviewed-on: https://chromium-review.googlesource.com/1117945Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571115}
-
Jeremy Roman authored
Many of the uses are of page allocator, which can just be used directly. partition_alloc.h previously included wtf.h but did not use it; removing this required adding it to various source files which were using IsMainThread but not including the appropriate header. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9ee136ed2396b83639b99224e6aaf0622ef12e3a Reviewed-on: https://chromium-review.googlesource.com/1115500Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571114}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/26581113047a..a26de2500503 git log 26581113047a..a26de2500503 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 lucferron@chromium.org Vulkan: Enable dEQP a passing test in buffer.write 2018-06-28 lucferron@chromium.org Vulkan: Enable the remaining dEQP fbo.render tests Created with: gclient setdep -r src/third_party/angle@a26de2500503 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I8ee418f33f09f274cb4267c8e533ae51f09ea00e Reviewed-on: https://chromium-review.googlesource.com/1117947Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571113}
-
Bence Béky authored
Bug: 807724 Change-Id: I51a758649dc72cc4835311264d883e0acac98a42 Reviewed-on: https://chromium-review.googlesource.com/1117035Reviewed-by:
-
Gauthier Ambard authored
This CL adds accessibility traits to the toolbars such as they are acting as VoiceOver "container". If the user sets the accessibility rotor to "containers", the user is able to go navigate quickly between the toolbars and the webpage. Bug: 856212 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I309a1308bb200bf9f90aaa4b164a3798c93c0f31 Reviewed-on: https://chromium-review.googlesource.com/1118275Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#571111}
-
Marc Treib authored
The new State encompasses (and should eventually largely replace) the following state getters: - CanSyncStart - IsEngineInitialized - GetAuthError - IsFirstSetupComplete - HasUnrecoverableError - IsSyncActive - ConfigurationDone Other SyncService state that it *not* packed into the enum: - Setup in progress - Encryption - Anything that's per-ModelType - Local Sync Bug: 839834 Change-Id: Iec1c3d744ffcb33fceccfe0bb0d028cc17203655 Reviewed-on: https://chromium-review.googlesource.com/1102331 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#571110}
-
Elodie Banel authored
The URL and security state are read first. The next accessible element is the share button. Bug: 821808 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0416aae221309f3202b2e1644b55b6755e88fbfd Reviewed-on: https://chromium-review.googlesource.com/1112010 Commit-Queue: Elodie Banel <lod@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571109}
-
Theresa authored
Prior to a refactoring in crbug.com/827334, NewTabPageView#onAttachedToWindow used to update the search box scroll position which is used by ToolbarPhone to determine location bar properties. In the refactoring, this logic moved to NewTabPageLayout#onAttachedToWindow. This method, however, is not always guaranteed to be called when the NTP is refocused because the NTPLayout may be scrolled off screen and not immediately bound to a RecyclerView ViewHolder. This CL re-introduces NewTabPageView#onAttachedToWindow, ensuring ToolbarPhone is properly notified of the current NTP scroll position when the NTP is refocused. BUG=856936 Change-Id: Iefa82aff60cd1e60a2787734c93793e5e50a65f4 Reviewed-on: https://chromium-review.googlesource.com/1117860Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#571108}
-
Hitoshi Yoshida authored
Each v8::Context is wired with a ScriptState, and it clears the self-reference of ScriptState at its termination. In worker threads, it means that ScriptState is kept alive until terminating v8::Isolate, although ScriptState is not used after disposing global scope. This CL explicitly does tasks in weak callback registered in v8::Context at disposing global scope. Actual tasks are (1)to clear self-persistent of ScriptState and (2)to drop a weak reference from ScriptState to v8::Context. This change makes it possible to release ScriptState at anytime before v8::Isolate termination. Bug: 773605 Change-Id: I9da5052c035a0b56dd47a6305df89809b05408a7 Reviewed-on: https://chromium-review.googlesource.com/1117976 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 7278 7285 0 lines were removed and 0 lines were deflaked by consecutive results since 7194. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If4116f789a84eab78272c231cad0c3aff7166569 Reviewed-on: https://chromium-review.googlesource.com/1118095 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#571106}
-
Mike Dougherty authored
This reverts commit 0c2015e1. Reason for revert: This CL isn't actually disabling the test. Original change's description: > Disable WebStateTest.MessageFromIFrame test. > > TBR=eugenebut@chromium.org > > Bug: 857129 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I407a6464e71296cc15eef43bf7ed2a8ca8181909 > Reviewed-on: https://chromium-review.googlesource.com/1117300 > Commit-Queue: Mike Dougherty <michaeldo@chromium.org> > Reviewed-by: Mike Dougherty <michaeldo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570882} TBR=eugenebut@chromium.org,michaeldo@chromium.org Change-Id: I444e4e1b224685b63cee4f2a672066bfeca8983f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 857129 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1118319Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#571105}
-
manuk authored
Decreased top inset from 5 to 4 px. With 5 px, the top of the omnibox was 1 pixel higher than the top of the location bar. Bug: 857068 Change-Id: Id1ea4601aed65f62fffccd05deac5dcbeab8d0d5 Reviewed-on: https://chromium-review.googlesource.com/1117642 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#571104}
-
Farah Charab authored
Set priority of ad frames to low or best effort depending on the feature list enabled. Bug: 856150 Change-Id: Ia76d55e1fc4b8617d5db9bca26b79ac25b5856c9 Reviewed-on: https://chromium-review.googlesource.com/1112251Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Farah Charab <farahcharab@chromium.org> Cr-Commit-Position: refs/heads/master@{#571103}
-
Greg Kraynov authored
Depot tools download the GN here now. Bug: 855791 Change-Id: Id2d60230331b90ff97018493892189deed5bbb77 Reviewed-on: https://chromium-review.googlesource.com/1118269Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#571102}
-
Elad Alon authored
Some functions ended up having more overloaded versions than is reasonable; templates to the rescue. 1. Move MaybeReply from .h to .cc, made it into a template, and used it in a few additional cases. 2. Made MaybeReply take a base::Location&, rather than hard-code the location of the helper function itself. 3. Created a template for Reply and ReplyClosure in the unit test suite. Bug: 775415 Change-Id: Ie2c9e31defd045535845d198c658f0859ef99228 Reviewed-on: https://chromium-review.googlesource.com/1114615 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571101}
-
Yi Gu authored
This reverts commit 30184c71. Reason for revert: <suspecting that this patch caused unit test SSLErrorHandlerDateInvalidTest.TimeQueryHangs flaky, crbug.com/857446> Original change's description: > Add a test helper method in services/network to get the body from a ResourceRequest. > > Also remove the custom URLLoaderFactory in content_hash_fetcher_unittest. This isn't needed anymore as TestURLLoaderFactory now supports Clone. > > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Id70ec605886a6b0f2cb9bf7392fac4eff85fc1b3 > Reviewed-on: https://chromium-review.googlesource.com/1115346 > Reviewed-by: Doug Turner <dougt@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570813} TBR=jam@chromium.org,dougt@chromium.org Change-Id: I2bd852fbf746203e325e6a859ad2b5cc2919b7e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1117521Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571100}
-
Fredrik Söderquist authored
While the underlying SVGResource should be unique (or nullptr - for invalid cases), the StyleSVGResource wrapper usually isn't. Hence we need to use DataEquivalent(...) to properly determine equality. Bug: 769774, 855914 Change-Id: I333bc7a737d0635aabe35e39bb066edbc4282790 Reviewed-on: https://chromium-review.googlesource.com/1118219Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#571099}
-
Jeremy Roman authored
Whitelist the one place which wants to query malloc usage, which is a memory reduction histogram on Android. Change-Id: I03a821aeec7b3b0524b02b432d2cea196b7a1f83 Reviewed-on: https://chromium-review.googlesource.com/1117634Reviewed-by:
-
Antonio Gomes authored
URLFetcher et al will stop working in the browser process with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. CL migrates SendProtocolRequest to the new API. Major remarks: * URLRequestPostInterceptor is replaced by URLLoaderPostInterceptor although the public APIs of the former is kept (are almost the same) in the later. This allows the extensive set of unit tests to remain untouched. The replacement is needed because URLRequestPostInterceptor used to intercept requests instantiated by URLFetcher, precisely the class we are moving away to use. * URLLoaderPostInterceptor operates in two modes: it supports working both with TestURLLoaderFactory and EmbeddedTestServer. Two constructors are offered that control the 'mode' it operates on. This is needed because of the nature of the tests: some tests manipulate the TestConfigurator directly, hence the needed SharedURLLoaderFactory instance can be acquired directly from it, eg PingManagerTest, UpdateCheckerTest and RequestSenderTest. Some other tests, trigger the respective SimpleURLLoader machinery from upper layers, and then have no access to TestConfigurator instances. In such cases, URLLoaderPostInterceptor operates using EmbeddedTestServer in order to intercept URL loads. Note that this CL migrates components/update_client/utils.cc|h to SimpleURLLoader, but there some other classes on the same directory that still use URLFetcher (eg UrlFetcherDownloader), so we simply can not *yet* remove all the references to URLFetcher and URLRequestContextGetter. It will be done in a follow up CL. BUG=773295,844973 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3d8be368818ba77b559907c0217995f8c6a95b04 Reviewed-on: https://chromium-review.googlesource.com/1097337 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#571097}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/56b60a2e..d3714bb8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I93ec403a2c990e082e806b037f1293553b35ef13 Reviewed-on: https://chromium-review.googlesource.com/1118007Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571096}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/64b17c2aca96..77cc8182aef6 git log 64b17c2aca96..77cc8182aef6 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 mbonadei@webrtc.org Pull GN via CIPD package. 2018-06-28 alexnarest@webrtc.org Adding ABWENoTWCC field trial 2018-06-28 terelius@webrtc.org Add return after NOT_REACHED() in eventlog unittest. Created with: gclient setdep -r src/third_party/webrtc@77cc8182aef6 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib9844e6d7c25671ddbdb96fe1ba12a8846a3bf81 Reviewed-on: https://chromium-review.googlesource.com/1117944Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571095}
-
John Delaney authored
The DelayUnsafeAds field trial parameters should only be queried if the client has AdTagging enabled. Bug: 856271 Change-Id: Ie4c19bb735c8b20c2454da21f12c3c7ce7cd4e02 Reviewed-on: https://chromium-review.googlesource.com/1117326Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#571094}
-
Hajime Hoshi authored
There is no usage of the constructor. Change-Id: I23cfe086745d2d6b395ee4a6e29c64304504a1d4 Reviewed-on: https://chromium-review.googlesource.com/1118075Reviewed-by:
-
Elad Alon authored
When a tab is closed, if other tabs do not have active peer connections, remote event logs collected on the first tab become eligible for upload. Bug: 775415 Change-Id: Id14b880753d90e0a4693bd5f966e1d674d4d850a Reviewed-on: https://chromium-review.googlesource.com/1116548 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#571092}
-
Hans Wennborg authored
A new Clang version caught these two cases. (While fixing localized_error.cc, switch the bitfields to unsigned and tweak a comment.) TBR=edwardjung,khushalsagar Bug: 857393 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I88bf4bfb2f3cf7874c308c9b3453e9d01c7c16ee Reviewed-on: https://chromium-review.googlesource.com/1118165Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#571091}
-
Arthur Hemery authored
Prepares moving DocumentState creation outside of DidCreateDocumentLoader. It does a few things: - Separates the paths between using pending_navigation_params_ and not using them to build DocumentState. - Removes the dependencies on navigation_state in DidCreateDocumentLoader. Instead we use the pending_navigation_params_ directly. Also removes reliance on default constructed values of CommonNavigationParams and RequestNavigationParams members. - Moved as much things as possible out of the main class into utilities in the anonymous namespace. - Stripped UpdateNavigationState that is now only used to update same document navigation states. Bug: 789577 Change-Id: I18d12d24827c3289ef909d9253fe8bbf6ca5080f Reviewed-on: https://chromium-review.googlesource.com/1109831Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Florin Malita authored
[1] updated web_url_request_util.cc:GetRequestBodyForWebHTTPBody() to use a WebData chunk iterator and push data to network::ResourceRequestBody one segment at a time. This introduced an issue downstream, in WebRequest's form data parser, where data was assumed to be contiguous. The issue was addressed in [2], by adding a non-trivial buffering mechanism in ParsedDataPresenter. Unfortunately, the incremental buffering seems to be problematic with large data payloads (blamed in the linked bug). Circling back to the original change, I noticed ResourceRequestBody::AppendBytes() does not perform any internal data consolidation, but in turn allocates and copies one segment at a time. Since the data is being copied anyway, there is no benefit to preserving segmentation: we might as well make a consolidating copy on the spot, and pass that to ResourceRequestBody. I propose the following in this change: - update SharedBuffer::Copy (currently only used in tests) to support both WTF::Vector and std::vector specializations (in order to be usable outside Blink) - expose Copy on WebData - add std::vector-moving variants of ResourceRequestBody::AppendBytes() and DataElement::SetToBytes() - (*) change GetRequestBodyForWebHTTPBody() to make an upfront/consolidating copy, and pass (move) the data to ResourceRequestBody as a single chunk - revert the ParsedDataPresenter buffering workaround introduced in [2] Essentially, this reverts the ResourceRequestBody segmentation changes introduced in [1] & [2], by making the data copy explicit. (*) <- this is the gist of the change, everything else is supporting or revert. [1] https://chromium-review.googlesource.com/c/chromium/src/+/581748 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1011322 Bug: 853500 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_mojo;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5f8d4bbaf7cc4b6372e868b4e62f6077bdf7d5a1 Reviewed-on: https://chromium-review.googlesource.com/1114258Reviewed-by:Ken Rockot <rockot@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#571089}
-
Alexander Timin authored
Fix a crash when queue was readded to RemoveFromIncomingImmediateWorkList during unregistration process when a different thread tried to post a task to it, leaving a dangling pointer. R=alexclarke@chromium.org Change-Id: Iac8c207699e3a08a4f792f705841bdfa1839b30c Reviewed-on: https://chromium-review.googlesource.com/1112239 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 310b4ff4. With Chromium commits locally applied on WPT: ab4fb5ca "Update links to feature policy documentation." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20296 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes kpaulhamus@chromium.org: external/wpt/webauthn mkwst@chromium.org, jochen@chromium.org: external/wpt/subresource-integrity TBR=markdittmer No-Export: true Change-Id: Idbfe43f05f92b19ec150132cfd34d2f92996de61 Reviewed-on: https://chromium-review.googlesource.com/1118013 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#571087}
-
Adam Rice authored
Also remove the unsafe version of IsReadableStream(). Remove BooleanOperation() helper from readable_stream_operations.cc as it is no longer used. Modify the tests to pass an ExceptionState& argument to IsReadableStream() and IsReadableStreamDefaultReader(). Bug: 853189 Change-Id: I26393861760e3bdab6991e522565067aabae5fb4 Reviewed-on: https://chromium-review.googlesource.com/1118089Reviewed-by:
-
Henrik Grunell authored
virtual/outofblink-cors/external/wpt/service-workers/service-worker/about-blank-replacement.https.html http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-webaudio.js TBR=tkent@chromium.org Bug: 857410, 857414 Change-Id: I422301df885098ca66b440d01b0fc5bd54a4a8a9 Reviewed-on: https://chromium-review.googlesource.com/1118167Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#571085}
-
Michael van Ouwerkerk authored
Bug: 853732 Change-Id: I82029d1dd7067ab6d615b8cb77797f6edd5fe65a Reviewed-on: https://chromium-review.googlesource.com/1113752 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#571084}
-
Ned Nguyen authored
This reverts commit 71b865f4. Reason for revert: break many perf tests (see https://ci.chromium.org/buildbot/chromium.perf/linux-perf/307) Original change's description: > gtest perf tests: Output well formed test results json > > This CL changes the run_gtest_perf_test.py script to output well formed > test results json. > > Bug: 855234 > Change-Id: Ia5ce6e258865e34a2aa37635c014cd54efa62796 > Reviewed-on: https://chromium-review.googlesource.com/1112635 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570943} TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org Change-Id: Ia0aaff923014438005ebc0a8677c3bbbebb808ac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855234 Reviewed-on: https://chromium-review.googlesource.com/1118238Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#571083}
-
Henrik Grunell authored
TBR=fdoray@chromium.org Bug: 857418 Change-Id: I70afce6260e3510fda0707cf36c5c5c21e07bc7b Reviewed-on: https://chromium-review.googlesource.com/1118173Reviewed-by:
-
Max Morin authored
The callback thread thread check may trigger if the SilentSinkSuspender sets in. Drive-by update the other thread check of this class to use a macro and add missing includes. Bug: 854774 Change-Id: I79f7c56886acd7f1ad56c466eb0c2825d1d8ec16 Reviewed-on: https://chromium-review.googlesource.com/1114973Reviewed-by:
-
Aleks Totic authored
This bug occurs when painting NG child inside non-inline vertical-rl parent with scrollbars. Root cause is extra scrollbar offset that Paint applies to Legacy painting that is not needed for NG. The fix is hacky: NG applies reverse offset. This fix does not make any additional tests pass or fail. Bug: 852395 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7dda2cdbf682485ab30c048987ae683981731886 Reviewed-on: https://chromium-review.googlesource.com/1115863 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#571080}
-
