GitLab

This reverts commit df22b814.

Reason for revert: breaks generate_build_files (http://crbug.com/869231)

Original change's description:
> Use proguard version 6.0.3 for monochrome_public_apk.
> 
> MonochromePublic.apk release builds are very close to the main dex limit
> and updating proguard reduces the number of methods by about 3000.
> 
> 6.0.3 cannot be used for all APKs yet due to a bug which causes
> cronet_test_instrumentation_apk to fail.
> 
> The version mismatch should be temporary as we plan to switch to R8 in the
> future (https://crbug.com/868770).
> 
> Bug: 857572
> Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
> Change-Id: I3676a42908c5046dc3f3831e282150702038140d
> Reviewed-on: https://chromium-review.googlesource.com/1154366
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Commit-Queue: Eric Stevenson <estevenson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579250}

TBR=yfriedman@chromium.org,estevenson@chromium.org

Change-Id: I1d7e50cf720e9a128a62f06bb34a4c9f6d25c60d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 857572
Bug: 869231
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Reviewed-on: https://chromium-review.googlesource.com/1155502Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579262}

https://pdfium.googlesource.com/pdfium.git/+log/87c1fdcc9a56..b53ef1e52d40


git log 87c1fdcc9a56..b53ef1e52d40 --date=short --no-merges --format='%ad %ae %s'
2018-07-30 tsepez@chromium.org Replace m_bIsContentLayoutItem with proper enum for type.


Created with:
  gclient setdep -r src/third_party/pdfium@b53ef1e52d40

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I7cb0dd7ebf3def2a01c40482a2fa5fb655617d85
Reviewed-on: https://chromium-review.googlesource.com/1155885Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579261}

Per chromium style guide we should not be DCHECK'ing handled cases;
these cases must be handled in release builds and thus should not
have special handling in debug mode.

BUG=868695
TEST=none

Change-Id: I1c17d5c2aadeda43fcc4193746623edaadae45e6
Reviewed-on: https://chromium-review.googlesource.com/1155825Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579260}

This reverts commit 35be1bb5.

Reason for revert: Causing test flakes.

Bug: chromium:869225

Original change's description:
> Add MimeSniffingThrottle for navigation and requests from renderer
> 
> This CL adds MimeSniffingThrottle which can intercept the response in
> ThrottlingURLLoader. Typically mime sniffing happens in network::URLLoader and
> MimeSniffingThrottle is skipped in this case. If a request goes to a service
> worker or other interceptors, the MimeSniffngThrottle intercepts the response
> when a set of the mime type and the url is eligible to sniff the mime
> type. Sniffable mime types are defined in net::ShouldSniffMimeType(). When a
> mime type for performance sensitive components like "text/html",
> "text/javascript",or "text/css" is provided, it doesn't sniff.
> 
> Bug: 858975
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: Ib6e5b29867494fc0c0876952b4fec2a141288b36
> Reviewed-on: https://chromium-review.googlesource.com/1141744
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578971}

TBR=kinuko@chromium.org,shimazu@chromium.org

Change-Id: I88721b279e5f38685b96d2d6f2813e423ff49540
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 858975
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1155501Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579259}

This CL is fixing a flakiness caused by a random trigger.
A slow-report is triggered for a control population for every 1/3000 case.
Unfortunately, that will cause other tests to be flaky 1/3000 times.

This CL is fixing this by adding a virtual method to hide the random
behavior.

R=erikchen@chromium.org

Change-Id: I32190b4b8786c5b1b7b3d2684ba952928a043085
Reviewed-on: https://chromium-review.googlesource.com/1155736Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579258}

Previous CL assumed that if we were not using GL, we wouldn't need a
default_offscreen_surface(). While true, a SW Viz process tried to
query the format of this surface leading to a crash. Instead we should
allow this surface to be null.

R=piman

Bug: 868777
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I37377396c6e172eac17c3d6db00b600eb9896d15
Reviewed-on: https://chromium-review.googlesource.com/1155473
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579257}

Certain Cast-enabled devices also advertise via SSDP for the purpose of
improving discovey reliability. However, they also (incorrectly) claim
to support DIAL apps, only for the DIAL app launch to fail.

We currently prevent such cases of Cast devices showing up as a
duplicated (incorrect) DIAL sink by relying on a hardcoded list of
model names to determine whether a DIAL sink is "discovery only",
i.e., DIAL sink queries should not be performed on them.

Unfortunately the list is not exhaustive and it would be challenging
if not impossible to obtain and maintain an acccurate list, as seen
from the recent regression. This patch takes a different approach, by
noting that if a Cast sink can be derived from a DIAL sink (or if it
already exists), then the DIAL sink can be removed from
DialMediaSinkServiceImpl as it has no further use by the DIAL MRP.
This ensures that no further DIAL queries will be issued to that sink,
and that the sink will not show up on a sink query.

Change-Id: Icdd3fc35baf6e3898537d38e1b059fc5c2714007
Bug: 869112
Reviewed-on: https://chromium-review.googlesource.com/1155258
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579256}

This CL includes a concrete implementation for the abstract class
SystemClock defined in the Nearby library.

SystemClock currently contains a single method elapsedRealtime(),
which is expected to return time in milliseconds since boot, including
time spent in states such as suspension (closed lid). The
implementation in this CL, however, does not include time spent in
suspension due to a current limitation of the POSIX implementation of
base::TimeTicks::Now(). See https://crbug.com/166153 for info.

Because the actual Nearby library has yet to be merged into the CrOS
directory, this CL includes stand-in Nearby abstract classes under
the temporary directory //chromeos/components/nearby/library.
This directory will be removed after the Nearby library gets imported
to //third_party.

Bug: 861813
Change-Id: I194880c75c4a8ba3afa37b6b3c916485c065f20f
Reviewed-on: https://chromium-review.googlesource.com/1150822Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Qian <kyleqian@google.com>
Cr-Commit-Position: refs/heads/master@{#579255}

Some layers under --enable-bloink-gen-property-trees at least
have no element_id.  Don't unregister them since they were never
registered.

Bug: None
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1d9cf412e56ce088819157f7b43d5214fdcf39d7
Reviewed-on: https://chromium-review.googlesource.com/1155821Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579254}

Two behavior changes:
* Previously, DidReceiveRedirectTo() was called for almost all
  redirects (barring a few early-exits), but WillFollowRedirect()
  was only called for same-origin redirects. Now the single callback,
  WillFollowRedirect(), is called whenever DidReceiveRedirectTo()
  used to be called.
* Previously, due to a bug in
  https://chromium-review.googlesource.com/c/chromium/src/+/1147890,
  the return value of WillFollowRedirect() was ignored when
  out-of-blink CORS was enabled. That return value is now honored.

Change-Id: I9c1ebb30b23aea77114711e0ee1b5dd0409c7166
Reviewed-on: https://chromium-review.googlesource.com/1150695
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579253}

As following specification in url[1], return value was wrong in idl.
So I fixed the return value.

[1] https://immersive-web.github.io/webxr/#xrdevice-interface

Bug: None
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I87adbd6e3dfe73a6a7707c282fda625b233b4d3b
Reviewed-on: https://chromium-review.googlesource.com/1155027Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#579252}

ScopedTabbedBrowserDisplayer takes care of creation and showing if necessary.

BUG=none
TEST=none

Change-Id: Iba7055bddce6aa0cfe2b5d564ec3b653fd0ab9aa
Reviewed-on: https://chromium-review.googlesource.com/1155937Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579251}

MonochromePublic.apk release builds are very close to the main dex limit
and updating proguard reduces the number of methods by about 3000.

6.0.3 cannot be used for all APKs yet due to a bug which causes
cronet_test_instrumentation_apk to fail.

The version mismatch should be temporary as we plan to switch to R8 in the
future (https://crbug.com/868770).

Bug: 857572
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I3676a42908c5046dc3f3831e282150702038140d
Reviewed-on: https://chromium-review.googlesource.com/1154366Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579250}

Screenshots:
https://screenshot.googleplex.com/871EngQdhMQ.png
https://screenshot.googleplex.com/nUQPvKxaBiR.png

Bug: 851194
Change-Id: I97e8474bc79b18d579aaeb3c13e202dd1c7748b0
Reviewed-on: https://chromium-review.googlesource.com/1154196
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579249}

Change-Id: I31eebb83d523e906ba2752b26abf098f373a9ac2
Reviewed-on: https://chromium-review.googlesource.com/1155932Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579248}

This reverts commit b43fa6db.

Reason for revert:
Caused three bugs open for flaky tests:
https://bugs.chromium.org/p/chromium/issues/detail?id=869043
https://bugs.chromium.org/p/chromium/issues/detail?id=868769
https://bugs.chromium.org/p/chromium/issues/detail?id=868839

The speculation is that new calls to ScanDirForExternalWebApps() are not being done on the correct thread.

Original change's description:
> Allow (auto-installed) external web apps
> 
> These are the Web App analogs of external extensions, described at
> https://developer.chrome.com/apps/external_extensions
> 
> On start up, *.json files (often but not necessarily named
> external_extensions.json) are scanned in a number of directories. Prior
> to this CL, such .json files can install regular extensions (.crx files)
> or, on Chrome OS, Android apps. New in this CL is being able to install
> Web Apps (sometimes known as Progressive Web Apps or PWAs).
> 
> For example, the chrome::DIR_USER_EXTERNAL_EXTENSIONS path (defined in
> chrome/common/chrome_paths.h) can correspond to file system directory
> like "$HOME/.config/chromium/test-user/.config/chromium/External
> Extensions". Placing a foo_bar.json file containing:
> 
> {
>   "web_app_manifest_url": "https://www.chromestatus.com/static/manifest.json",
>   "web_app_start_url": "https://www.chromestatus.com/features"
> }
> 
> in that directory will install the Chrome Platform Status web app.
> 
> Bug: 855281
> Change-Id: I716fead81d407076a0dda32f5c0b3e8869351c83
> Reviewed-on: https://chromium-review.googlesource.com/1127214
> Commit-Queue: Nigel Tao <nigeltao@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Alexey Baskakov <loyso@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578944}

TBR=ortuno@chromium.org,loyso@chromium.org,dominickn@chromium.org,nigeltao@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 855281
Change-Id: I976928b151910bcc39ea372a6f80d9d833fc8253
Reviewed-on: https://chromium-review.googlesource.com/1155496Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579247}

We plan to make --site-per-process mode the default mode on ToT for
//content layer (//chrome layer will continue to be controlled by field
trials and disable --site-per-process on Android).  To make this switch
slightly easier, this CL inlines the test expectations from
//testing/buildbot/filters into the source code of the tests - this
should avoid having to keep passing the filter files to the default test
steps after making the switch.

Bug: 856734
Change-Id: Ic0983cb667d7904caeb18d46705f7721147a6354
Reviewed-on: https://chromium-review.googlesource.com/1153975Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579246}

crrev.com/1ffee348 changed these methods to
no longer be pure-virtual. This change is intended to make the code more
consistent (and delete a bunch of useless code).

BUG=None

Change-Id: I27c5ee5b58e94deeed380603e10f54ea316f30ef
Reviewed-on: https://chromium-review.googlesource.com/1152345Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579245}

Consider this code:
  const String& attribute_value = AtomicString(html_attribute.second);

It gets a String member, creates a temporaty AtomicString, and then
returns a reference to its String member. The AtomicString object is not
lifetime extended.

However, if we change the type of the variable to 'const AtomicString&',
then it will be lifetime extended, and there is no bug.

This is causing the Linux and Windows ASan ToT bots to time out, so I
will TBR this.

TBR=csharrison@chromium.org
BUG=869067

Change-Id: Ie90c7f07038c4d394b8cba5d03fec4569476ed91
Reviewed-on: https://chromium-review.googlesource.com/1155832Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579244}

When S13nServiceWorker is enabled these tests requre an instance
of URLLoaderFactory. Add a mock URLLoaderFactory and set them in
tests. This makes tests pass.

Bug: 860361
Change-Id: I2cfa371c1c1076d895398686b3df36340664e30b
Reviewed-on: https://chromium-review.googlesource.com/1152337Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579243}

Shell keeps a reference to the connector, so it shouldn't be needed on the
delegate.

BUG=none
TEST=none

Change-Id: I8e1342d4f887575f7b35d7a8a05233927743f222
Reviewed-on: https://chromium-review.googlesource.com/1155810
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579242}

Bug: 872199
Change-Id: I4e7a409ff20819d682e5f7e9415e126563e353ef
Reviewed-on: https://chromium-review.googlesource.com/1155922Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579241}

This doesn't do a roll, but updates the stamps from the recent
roll in r578749, and modifies the roller script to do this
automatically for future rolls.

Bug: None
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I2658e88be0020d554b08e843dc4dbb7b74fc9e9f
Reviewed-on: https://chromium-review.googlesource.com/1154615Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579240}

https://webrtc.googlesource.com/src.git/+log/f452e3e5882f..1899c1270f0c


git log f452e3e5882f..1899c1270f0c --date=short --no-merges --format='%ad %ae %s'
2018-07-30 buildbot@webrtc.org Roll chromium_revision 0e06bcbb..fdf31b15 (579047:579160)


Created with:
  gclient setdep -r src/third_party/webrtc@1899c1270f0c

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I2ad91d1c474e0405176d86777dcdd741c793e4c1
Reviewed-on: https://chromium-review.googlesource.com/1155615Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579239}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values.

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing "static final" values, enum
and some classes in one common @IntDef/@StringDef form:

1. with @IntDef/@StringDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with NUM_ENTRIES declaring number of entries if necessary
4. with comment about numbering from 0 without gaps when necessary
5. with @Retention(RetentionPolicy.SOURCE)
6. without "static final" in the @interface

Change-Id: I700514afca44a71999b6b316992cdcf37022b983
Reviewed-on: https://chromium-review.googlesource.com/1154223Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#579238}

This suggestion was provided by the UX team.

Bug: 824568
Change-Id: I2728b1e1de4b0d8c27c13f0f70eb5eed80f6029f
Reviewed-on: https://chromium-review.googlesource.com/1155904Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579237}

Change-Id: Ica9b8579796c6684f59eb8bfe3731f26285f880c
Reviewed-on: https://chromium-review.googlesource.com/1150823
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579236}

Bug: 850539
Change-Id: I24fe05cb8a909ceb181df643aeaf75c5007a4a3d
Reviewed-on: https://chromium-review.googlesource.com/1154999
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579235}

This is a reland of 453eba23

Removed the call to mojo::core::Init from the test startup. It
caused a memory leak because //chromeos/run_all_unittests.cc
already calls it.

Original change's description:
> Add basic ServiceConnection unit test
>
> The is just testing that ServiceConnection::BindModelProvider returns
> successfully. The Mojo invitation won't go anywhere beyond the no-op
> FakeMachineLearningClient D-Bus client.
>
> To make this test compile, I had to fix an #include from an
> overlooked file rename in an earlier CL ...
>
> Bug: 863794
>
> Change-Id: Ifd31fea950145561cd5954ae16e930b801bfe49b
> Reviewed-on: https://chromium-review.googlesource.com/1139942
> Commit-Queue: Andrew Moylan <amoylan@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Dan Erat <derat@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578329}

Tested by: manual detect_leaks=1 invocation of the test.

TBR=rockot@chromium.org,derat@chromium.org

Bug: 863794
Change-Id: I1258de74273551cebdc9dd1a76f86a35ffa50147
Reviewed-on: https://chromium-review.googlesource.com/1154647Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Commit-Queue: Andrew Moylan <amoylan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579234}

linux_optional_gpu_tests_tel doesn't run the WebGL 1.0 conformance
tests on Linux/Intel on the CQ (it should) so this was missed.

Bug: 820891, 867675
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I77b898b4ddd83cc1e1ec8fcdcc19918c203433d7
Tbr: kainino@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1155807Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579233}

We had a custom OverlayCandidateValidator for AndroidOutputSurface, but
this was missing from GLOutputSurfaceAndroid.

Bug: 868504
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I9a7b58575378d8c516b10dba04df8f80a2ccf77d
Reviewed-on: https://chromium-review.googlesource.com/1153604
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579232}

This reverts commit 4dd5af99.

Reason for revert: Browser crashes flakily with DCHECKs on

See
https://chromium-swarm.appspot.com/task?id=3f063cbec4a26e10
https://chromium-swarm.appspot.com/task?id=3f063760c6162910
https://chromium-swarm.appspot.com/task?id=3f063164005d9710

Example crashes
https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=e4fef843d0fef24b39d59d06bfddbe1569402f2b&as=chrome.PREVIOUS
https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=4d98a300e399d97b4b02cf89f01134050e2f985e&as=chrome_20180730-160158
https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=a4068c05476b786213ab26a80cf35e426fd54f44&as=chrome_20180730-155114

Original change's description:
> Enable DCHECKs on amd64-generic simplechrome CQ bot.
> 
> Bug: 867077
> Change-Id: Icad4a62735d3be6579b3c6476bbbb65ad1843ec8
> Reviewed-on: https://chromium-review.googlesource.com/1150939
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579118}

TBR=dpranke@chromium.org,dcastagna@chromium.org,bpastene@chromium.org,jbudorick@chromium.org

Change-Id: I42e28d289cd2c6604b829b9971abb0783fa5ee76
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 867077
Reviewed-on: https://chromium-review.googlesource.com/1155500Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579231}

https://pdfium.googlesource.com/pdfium.git/+log/d718d634b7aa..87c1fdcc9a56


git log d718d634b7aa..87c1fdcc9a56 --date=short --no-merges --format='%ad %ae %s'
2018-07-30 tsepez@chromium.org Don't static_cast<>(this) to subclass in CXFA_LayoutItem methods.
2018-07-30 tsepez@chromium.org Return unique_ptr from CXFA_FFNotify::OnCreate{Container,Content}LayoutItem()
2018-07-30 tsepez@chromium.org Convert some asserts to ifs in cxfa_ffnotify.cpp.


Created with:
  gclient setdep -r src/third_party/pdfium@87c1fdcc9a56

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib65f272f30b18482963afe5f468bdaff4fc40fe4
Reviewed-on: https://chromium-review.googlesource.com/1155613Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579230}

This reverts commit 8cc4e50c and relands
812abd15 with iOS tests disabled.

R=rch@chromium.org

Change-Id: I56fb4be93602fcaa9deccdf9a1837ebcd787af11
Reviewed-on: https://chromium-review.googlesource.com/1154361Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579229}

This reverts commit fa0ab3e4.

Add user button is not showing up correctly due to this CL, revert it now
and will investigate the cause.

TBR=tsepez@chromium.org,msw@chromium.org

Change-Id: I2ab8ccd357f2ef27d3f9d1d53733cad45e65b6c8
Reviewed-on: https://chromium-review.googlesource.com/1155757
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579228}

This has been flipped on in the recipe side.

Bug: 533481
Change-Id: Id0ef0dec5fefbbdcece8a485e65ca672e0982bc0
Reviewed-on: https://chromium-review.googlesource.com/1152035
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579227}

Get permission to start remoting when harmony cast dialog is enabled.

Bug: 849020
Change-Id: I98e306c7ffaa6f53dc825a418f2c0b48ea7a9ee2
Reviewed-on: https://chromium-review.googlesource.com/1139173Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579226}

Add find shortcut handling to sub-pages with search.

Bug: 862701
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I0db88c2712cac918f1be18068fe02df5d942e53d
Reviewed-on: https://chromium-review.googlesource.com/1141157
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579225}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d795ab891c15..b0e855a33353


git log d795ab891c15..b0e855a33353 --date=short --no-merges --format='%ad %ae %s'
2018-07-30 tandrii@chromium.org cq.cfg: remove cq_name.


Created with:
  gclient setdep -r src/third_party/depot_tools@b0e855a33353

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:866476
TBR=agable@chromium.org

Change-Id: Ie813a123c02f374125160a0cda33bd52577e0643
Reviewed-on: https://chromium-review.googlesource.com/1155610Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579224}

Previously, rect-based hit tests were assumed to be list-based as well.
However, that's not necessary for IO. It's sufficient to return the
first hit test result -- if it's the target element, then the target is
not occluded; otherwise, it is occluded.

Also add the kIgnoreZeroOpacityObjects flag, since zero opacity objects
are not considered occluding by IO.

With this change, the "deep layers" benchmark for IOV2 runs 6-7 times
slower with visibility checking enabled, which is a big improvement
over previous measurements (which were up to 50x slower).

BUG=831762,823748
R=chrishtr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7471221357de465e9e5c1673537e7f11ee287e6a
Reviewed-on: https://chromium-review.googlesource.com/1153547
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579223}