- 29 May, 2019 40 commits
-
-
Taylor Bergquist authored
Bug: 958173 Change-Id: Iff81fa8dd3ff57cb7121d628cd5e78e8e58c157f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633350 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#664067}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/86837544cd02..76ce2f554e7a Created with: gclient setdep -r src-internal@76ce2f554e7a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I668311010db0a96804fc4e9ee10883386fd64b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633228Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664066}
-
Anand K. Mistry authored
If the dropdown is opened when there are initially 0 items and new items are added while it is open, the dropdown doesn't expand to accomodate the new items. This manifests in the SMB share dialog where share discovery is happening in the background. If the user opens the dropdown while the discovery is in progress, the dropdown will not be expanded when share are discovered. The user needs to close and re-open the dropdown to see the discovered shares. BUG=None Change-Id: I71c85466145301fd25366138711c43e478457210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627849Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#664065}
-
Jeffrey Kardatzke authored
If you set the language to French (and likely many others), then the text describing the sys info/app/metrics checkbox can overlay on top of the screenshot image. This puts a margin on the right of that text to avoid that overlapping. Bug: 949722 Test: Manually verified on Chrome OS in French language Change-Id: I4ccb453e0f5071103058fa1025aacb426fd1f1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632535 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#664064}
-
Matthew Braithwaite authored
This is a followup to b5cccac5, and has the same motivation: to improve testability of Certificate Transparency enforcement. Injecting the time of evaluation allows a test to be written that shows that while a call may return |CT_POLICY_COMPLIES_VIA_SCTS| today, the same inputs may return |CT_POLICY_BUILD_NOT_TIMELY| tomorrow. Change-Id: If4a4519ccaf7b1470477fc4c1978de1d14e58aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626016 Commit-Queue: Matt Braithwaite <mab@google.com> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#664063}
-
Istiaque Ahmed authored
Add a flag to RunExtensionTest so that an existing event page based test extension can be loaded as SW based extension. This can be used to run extenision tests with Service Worker based extensions. This CL also converts runtime/open_options_page/ test extension to event page extension and demonstrates that the extension be loaded as SW extension and the corresponding test ExtensionApiTest.ChromeRuntimeOpenOptionsPage passes with the flag in ServiceWorkerBasedBackgroundTest.ChromeRuntimeOpenOptionsPage. Doc: https://docs.google.com/document/d/1PvXZ7VGRGdmd1s99SFByn9NCGj0GAiBhhPmfjj35ZeI/edit# Bug: 967899 Change-Id: I8821d1c9fa22795b8fe0f65f1bd073a034e24431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626455 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#664062}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ee244c772a41..ded5f903261a git log ee244c772a41..ded5f903261a --date=short --no-merges --format='%ad %ae %s' 2019-05-28 geofflang@chromium.org Vulkan: Make the Vulkan renderer thread safe. 2019-05-28 geofflang@chromium.org Vulkan: Use atomics in SerialFactory. 2019-05-28 jmadill@chromium.org D3D11: Suppress failing Texture test on AMD. Created with: gclient setdep -r src/third_party/angle@ded5f903261a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:967796 TBR=cwallez@google.com Change-Id: Ie0425a04fc08aeea66934d9fc31670c43a703a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633224Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664061}
-
Victor Costan authored
This addresses review comments on https://crrev.com/c/1630807 Change-Id: Iabb5c56b176a179fc7c40c1ba93f7bcdbad9daaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633318 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#664060}
-
BUG=762641 TBR=mukai@google.com Change-Id: I0fdd59f83a784c236193398146c6fb8f3181f921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632536Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664059}
-
Zhenyao Mo authored
Also, simply some of the unit tests. (This relanding removed the newly added YUY2SwapChain unit test since it doesn't pass on AMD. Will add it in a separate CL with proper support detection.) BUG=909827,967860 TEST=bots,gl_unittests TBR=sunnyps@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623030 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#662443} Change-Id: Ia85b82d177a455b8a3db1888ba3a3a9a924d6b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629726Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664058}
-
tby authored
The EnableAppListLaunchRecording feature flag is used to guard hashed logging (see /src/ash/public/cpp/app_list/app_list_features.cc). This CL adds a testing config for it. Bug: 951287 Change-Id: I7a7d62d2388170c921976009db256c822d2425b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631910Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#664057}
-
Tom Anderson authored
Design document: https://docs.google.com/document/d/1m5cbNLv4CgUTsBw0XaM8OaVgeq1-N1SD66Vu0VOqeb4/edit?usp=sharing Behavior when EnableDbusAndX11StatusIcons is disabled (same as old behavior): * If libappindicator is available, create an AppIndicatorIcon - libappindicator will asynchronously try to create the status icon with DBus, then with X11, then will give up. * Otherwise, create a GtkStatusIcon - GtkStatusIcon will asynchronously try to create a status icon with X11, then will give up. Otherwise, when EnableDbusAndX11StatusIcons is enabled (planned new behavior): * Try to create a StatusIconLinuxDbus. If that fails, try to create a StatusIconLinuxX11. If that fails, then give up. BUG=419673 R=thestig Change-Id: Id7ef4869f24caf726ba0e39d604a47b1e81815be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633230 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#664056}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/162eba28f207..ddde8daf5768 git log 162eba28f207..ddde8daf5768 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 jperaza@chromium.org Add crashpad_handler to chrome paths Created with: gclient setdep -r src/third_party/chromite@ddde8daf5768 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I56adb35d52cf68e97a72a844d159d9b9f48c6ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633220Reviewed-by:
-
Derek Schuff authored
This check currently only determines whether a page can load a NaCl module and doesn't consider PNaCl (previously there was also a flag to disable PNaCl). Also it does not modify the WebPluginParams. Bug: 918374 Change-Id: I90dfd18e98db26fb8db76192221004efd78341a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633233Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Derek Schuff <dschuff@chromium.org> Cr-Commit-Position: refs/heads/master@{#664054}
-
Jun Mukai authored
This reverts commit 3e8aceb1. Reason for revert: Failures of SessionRestoreTestChromeOS in linux-chromeos-rel. see crbug.com/967929 Original change's description: > mash cleanup: Remove wallpaper.mojom > > Move wallpaper.mojom to a virtual c++ interface. > Update impl and clients, make some methods sync. > Combine mojo and non-mojo observer types. > Add a static WallpaperController::Get(), cleanup. > > Bug: 958227 > Test: No Chrome OS wallpaper regressions. > Change-Id: I23de39efd3721f40ec423eed651f1cb8fed7edd4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626011 > Commit-Queue: Michael Wasserman <msw@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663937} TBR=sky@chromium.org,msw@chromium.org,dcheng@chromium.org Change-Id: I18b34e5ad58657c1d9d3e70baade46d340de1887 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958227, 967929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633549 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#664053}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1f02e8488551..66661df8e9f9 git log 1f02e8488551..66661df8e9f9 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@66661df8e9f9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I727a33950a1dba70ca9485fc56ab5cd707a205c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633219Reviewed-by:
-
John Chen authored
Disabling failing perf tests: * blink_perf.canvas/draw-video-to-hw-accelerated-canvas-2d_RAF.html?RAF * blink_perf.canvas/upload-video-to-sub-texture_RAF.html?RAF * blink_perf.canvas/upload-video-to-texture_RAF.html?RAF * rendering.mobile/microsoft_video_city NOTRY=true TBR=crouleau@chromium.org CC=aaronhk@chromium.org, fserb@chromium.org, sadrul@chromium.org, vmiura@chromium.org Bug: 967809 Change-Id: Idfae0a2e3adc5b4075a00a53f7b361fd61e9d276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633589Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#664051}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f7ea76c9. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" be76d09e "[ServiceWorker] Reject update() from within installing workers" abf2ac5e "webrtc wpt: avoid race conditions" 760a2c20 "Apply iframe referrerpolicy attribute to non-initial loads." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ic9237eb2a2e840fe792776e1a06093ebc3a8c648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633210Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664050}
-
Tsuyoshi Horo authored
Bug: 935267 Change-Id: I29bdd68d565442f13dd83940884aaedcbbebb99b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630380Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664049}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/10e57cf61851..4ce909c11c06 git log 10e57cf61851..4ce909c11c06 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-28 iannucci@chromium.org Revert "cipd: remove windows-386" 2019-05-28 maruel@chromium.org cipd: remove windows-386 Created with: gclient setdep -r src/third_party/depot_tools@4ce909c11c06 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Iea4ffdc5ed774dc7e2b773ba4c6be54d3b70791e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632948Reviewed-by:
-
Danan S authored
This functionality will instead be implemented on the server side. Bug: 937995 Change-Id: I4c862a5d90f02a541cff3293b83cfb8f981cd069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627924Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#664047}
-
Justin Cohen authored
ios/web quickly gets into a bad state when navigating while the currently committed url is a redirect URL. Similar to blocking navigation during session restoration, also block navigation during the redirect URL. This redirect happens very quickly, so don't update the UI -- rather ignore the tap. Not updating the UI prevents a flicker. Bug: 960326 Change-Id: Ibfe30f3341723bdc6cba122dccf21872ada2d072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630224 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#664046}
-
Giovanni Ortuño Urquidi authored
Change-Id: I814de4b2943e9d6890bae260fab3e561a5f2ab23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632925Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#664045}
-
Sean Kau authored
Metric was set to expire in June. Extending metric into next year. Activity has not stabilized yet. Bug: chromium:967466 Change-Id: Ide6d07391fc919617bddc908442b9a8507d1dccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632418 Auto-Submit: Sean Kau <skau@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
David Benjamin authored
Sadly, enterprise usage of buggy middleware is still on the high side. Extend the metrics so we can continue to monitor this. Bug: 967483 Change-Id: I7b571b284315c2b0223b97e405d2e355313aac9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632779 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Jonas Olsson authored
Media.Audio.Render.StreamBrokerDisconnectReason2 is still in use. This CL delays its expiry by another quarter. It also replaces me as owner of it. Bug: chromium:960094 Change-Id: Ic44d954b3fb156a12e5dd786d6cb06f7692a0da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631694 Auto-Submit: Jonas Olsson <jonasolsson@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Andrew Moylan authored
* Extend expiry on soon-to-be-expired histograms * Add expiry to all histograms per best practice * Add a second owner to all histograms per best practice The expiry date was chosen according to https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#how-to-choose-expiry-for-histograms where these histograms are "Actively in use now, useful for short [likely long] term". Bug: 967500 Test: none Change-Id: Idbfef38927d2856c99f2ad940b910695a7c4ab79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631852 Auto-Submit: Andrew Moylan <amoylan@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Jeffrey Cohen authored
This reverts commit 8d639cb7. Reason for revert: failing test on macos10: http/tests/devtools/elements/highlight/highlight-node-vertical-rl.js Original change's description: > More physical coordinates in LayoutText and LayoutInline > > This further reduces back-and-forth flipping for LayoutNG, and makes it > clear that inspector highlight always uses physical coordinates. > > Change-Id: Iecec0c03c2a1a14d8ad2aeb29f61f3a912d5d670 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625876 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663927} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: I1179b65f14a0e3f73454d1d271986e81acf7dbf2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633292Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#664040}
-
rbpotter authored
It is possible that by changing various settings the length of the previewed document can change, which may invalidate the custom page range. Reset the custom page range to the full set of pages in the following 2 cases: (1) The custom page range was set to the full page range in JS, due to the user blurring an empty custom input. Note: reset even if the length change would not invalidate the value, so that leaving a custom input blank matches the behavior of selecting "All" in the dropdown. (2) The custom page range is set to the full page range, so it is clear that the user intends to print all the content, and the length of the previewed document decreases. Bug: 938214, 940386 Change-Id: Icdee3970c041f2d269c16967cc07a58514bdf811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629045Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/698a4380c296..d524d32f3c7c git log 698a4380c296..d524d32f3c7c --date=short --no-merges --format='%ad %ae %s' 2019-05-28 tsepez@chromium.org Avoid circular includes between CPDF_Document and CPDF_LinkList Created with: gclient setdep -r src/third_party/pdfium@d524d32f3c7c The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: If7fe08992b68fbb9189d75c0a57eaa21f1f9ed2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633249Reviewed-by:
-
Eric Aleshire authored
Also adds them to a test to confirm they execute. There aren't enough methods landed to be able to check for correctness yet - those will come in a follow-up. Change-Id: Id1ccdaeebebbea2c7f6e299ef192244c75f209f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628273 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5a06fa466186..f051812343eb git log 5a06fa466186..f051812343eb --date=short --no-merges --format='%ad %ae %s' 2019-05-28 zoddicus@users.noreply.github.com Add WebGPU specific fuzzer for validation (#2628) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@f051812343eb The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Id9ecea0cb29444249634ca3a13783824f13d09bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632805Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/90cb260644cd..cee3dffa8f79 git log 90cb260644cd..cee3dffa8f79 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 bclayton@google.com LLVMReactor: Mutex calls to llvm::orc::IRCompileLayer. 2019-05-28 bclayton@google.com Reactor: Add UInt4 constructors taking UInt Created with: gclient setdep -r src/third_party/swiftshader@cee3dffa8f79 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/133127573 TBR=swiftshader-team+autoroll@google.com Change-Id: I7c91d395a1c9fefc80c8f9902f78a8cf2b70ad0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632946Reviewed-by:
-
Jeremy Chinsen authored
TabModalConfirmDialog takes ownership of the TabModalConfirmDialogDelegate* passed in, but its comment did not convey this. Changing the parameter to a unique_ptr expresses this explicitly. Bug: 961772 Change-Id: Id7f4242a0797d3d49237b833b0bd6af4c146dd98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626502Reviewed-by:
-
Charles Zhao authored
Currently, when a tab is discarded, it has 0 ukm_source_id in TabActivityWatcher; which eventually leads to no logging. Fix: assign the old ukm_source_id to the new WebContentsData when replace is called. Bug: 967558 Change-Id: Ic989baafc6850c47d8d53c14bc775a2475e1f12e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631914Reviewed-by:François Doray <fdoray@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#664033}
-
Kyle Horimoto authored
The issue was trigged by a JavaScript error in getDialogTitle_(). This function attempts to evaluate |this.managedProperties_.Name| without checking whether |this.managedProperties_| is set. I added an early return to prevent against this case. Bug: 967807 Change-Id: I14544a6185f255d73e405845446efb1fc07bf4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633213 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Steven Bennetts authored
This also eliminates a NetworkHandler dependency in ash/system/network. Bug: 919691 Change-Id: Ie315a3a6589cd3f68a980ec17db9db8c83dba859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626684Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#664031}
-
Min Qin authored
Currently for each download stream, the data read from the network was immediately written to the disk. This CL allows each SourceStream to read some data before the file write offset for content validation purpose. And data will only be written after all the initial validation data are consumed. A new field called starting_file_write_offset_ is added to SourceStream to identify this checkpoint for file validation. BUG=965215 Change-Id: Ia46de1a588bc0c2fb4e6eb19e62ef794d706ad1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625461 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#664030}
-
Torne (Richard Coles) authored
Convert more cases where C++ code iterates over Java object arrays to use range-based for with the new helper class introduced by https://chromium-review.googlesource.com/c/chromium/src/+/1283836 Also remove ConvertJStringArrayToString16Array from chrome_browser_provider.cc, as there is already a helper for this in jni_array.h. Change-Id: Ifb8ecf25dbde8d1fab6549df22153b9bf398b4d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588961 Auto-Submit: Richard Coles <torne@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#664029}
-
Istiaque Ahmed authored
We can do this without any string copy, so use StringPiece variant from GURL. This is interesting because every extension resource fetch goes through this method. Bug: None Change-Id: Ief332c09295b1087f64721e44f026eccc4a49497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631938Reviewed-by:
-
